[GitHub] [maven-surefire] andpab commented on a diff in pull request #584: [SUREFIRE-2135] Use native.encoding for parsing ps

2022-12-18 Thread GitBox
andpab commented on code in PR #584: URL: https://github.com/apache/maven-surefire/pull/584#discussion_r1051892390 ## surefire-booter/src/main/java/org/apache/maven/surefire/booter/PpidChecker.java: ## @@ -170,7 +169,7 @@ private void checkProcessInfo() // http://hg.openjd

[jira] [Commented] (SUREFIRE-2136) UmlautDirIT: Revert special paths with colon in it to regular ones after test

2022-12-18 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649190#comment-17649190 ] Michael Osipov commented on SUREFIRE-2136: -- Let me guess. GHA nodes don't use

[jira] [Comment Edited] (SUREFIRE-2136) UmlautDirIT: Revert special paths with colon in it to regular ones after test

2022-12-18 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649190#comment-17649190 ] Michael Osipov edited comment on SUREFIRE-2136 at 12/19/22 7:36 AM:

[GitHub] [maven-surefire] michael-o commented on a diff in pull request #584: [SUREFIRE-2135] Use native.encoding for parsing ps

2022-12-18 Thread GitBox
michael-o commented on code in PR #584: URL: https://github.com/apache/maven-surefire/pull/584#discussion_r1051886715 ## surefire-booter/src/main/java/org/apache/maven/surefire/booter/PpidChecker.java: ## @@ -170,7 +169,7 @@ private void checkProcessInfo() // http://hg.ope

[jira] [Commented] (DOXIA-617) doxia-module-markdown: Add support for --- header section marks

2022-12-18 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649189#comment-17649189 ] Herve Boutemy commented on DOXIA-617: - one stupid question: i did not even know that w

[jira] [Updated] (MSHARED-1174) Don't wrap elements in anchors

2022-12-18 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MSHARED-1174: --- Description: In the last improvement MSHARED-1106 of the {{AbstractMavenReportRenderer}} e

[jira] [Updated] (MSHARED-1174) Don't wrap elements in anchors

2022-12-18 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MSHARED-1174: --- Description: In the last improvement of the {{AbstractMavenReportRenderer}} elements were

[GitHub] [maven-surefire] andpab opened a new pull request, #585: [SUREFIRE-2136] Rename test dir that contains colon

2022-12-18 Thread GitBox
andpab opened a new pull request, #585: URL: https://github.com/apache/maven-surefire/pull/585 In the UmlautDirIT two special directories are created that have a colon character in the name. This causes problems with the artifact upload of the Github actions, so we rename those directories

[jira] [Created] (SUREFIRE-2136) UmlautDirIT: Revert special paths with colon in it to regular ones after test

2022-12-18 Thread Andreas Pabst (Jira)
Andreas Pabst created SUREFIRE-2136: --- Summary: UmlautDirIT: Revert special paths with colon in it to regular ones after test Key: SUREFIRE-2136 URL: https://issues.apache.org/jira/browse/SUREFIRE-2136

[GitHub] [maven-invoker-plugin] olamy merged pull request #159: merge back branch release-3.4.0

2022-12-18 Thread GitBox
olamy merged PR #159: URL: https://github.com/apache/maven-invoker-plugin/pull/159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ma

[GitHub] [maven-enforcer] ajarmoniuk commented on a diff in pull request #198: [MENFORCER-435] Replacing maven-compat and maven-dependency-tree usage with Resolver

2022-12-18 Thread GitBox
ajarmoniuk commented on code in PR #198: URL: https://github.com/apache/maven-enforcer/pull/198#discussion_r1051782468 ## enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/BanTransitiveDependencies.java: ## @@ -127,55 +130,27 @@ private static boolean searchTree(Dep

[GitHub] [maven-archetype] dependabot[bot] closed pull request #102: Bump maven-script-interpreter from 1.2 to 1.3

2022-12-18 Thread GitBox
dependabot[bot] closed pull request #102: Bump maven-script-interpreter from 1.2 to 1.3 URL: https://github.com/apache/maven-archetype/pull/102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [maven-archetype] dependabot[bot] closed pull request #108: Bump maven-invoker-plugin from 3.2.1 to 3.3.0

2022-12-18 Thread GitBox
dependabot[bot] closed pull request #108: Bump maven-invoker-plugin from 3.2.1 to 3.3.0 URL: https://github.com/apache/maven-archetype/pull/108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [maven-archetype] dependabot[bot] commented on pull request #102: Bump maven-script-interpreter from 1.2 to 1.3

2022-12-18 Thread GitBox
dependabot[bot] commented on PR #102: URL: https://github.com/apache/maven-archetype/pull/102#issuecomment-1357069969 Superseded by #123. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [maven-archetype] dependabot[bot] opened a new pull request, #123: Bump maven-script-interpreter from 1.2 to 1.4

2022-12-18 Thread GitBox
dependabot[bot] opened a new pull request, #123: URL: https://github.com/apache/maven-archetype/pull/123 Bumps [maven-script-interpreter](https://github.com/apache/maven-script-interpreter) from 1.2 to 1.4. Release notes Sourced from https://github.com/apache/maven-script-interpre

[GitHub] [maven-archetype] dependabot[bot] commented on pull request #108: Bump maven-invoker-plugin from 3.2.1 to 3.3.0

2022-12-18 Thread GitBox
dependabot[bot] commented on PR #108: URL: https://github.com/apache/maven-archetype/pull/108#issuecomment-1357069732 Superseded by #122. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [maven-archetype] dependabot[bot] opened a new pull request, #122: Bump maven-invoker-plugin from 3.2.1 to 3.4.0

2022-12-18 Thread GitBox
dependabot[bot] opened a new pull request, #122: URL: https://github.com/apache/maven-archetype/pull/122 Bumps [maven-invoker-plugin](https://github.com/apache/maven-invoker-plugin) from 3.2.1 to 3.4.0. Release notes Sourced from https://github.com/apache/maven-invoker-plugin/relea

[GitHub] [maven-invoker-plugin] dependabot[bot] opened a new pull request, #160: Bump maven-script-interpreter from 1.4-SNAPSHOT to 1.4

2022-12-18 Thread GitBox
dependabot[bot] opened a new pull request, #160: URL: https://github.com/apache/maven-invoker-plugin/pull/160 Bumps [maven-script-interpreter](https://github.com/apache/maven-script-interpreter) from 1.4-SNAPSHOT to 1.4. Commits See full diff in https://github.com/apache/maven

[GitHub] [maven-apache-parent] dependabot[bot] opened a new pull request, #122: Bump maven-invoker-plugin from 3.3.0 to 3.4.0

2022-12-18 Thread GitBox
dependabot[bot] opened a new pull request, #122: URL: https://github.com/apache/maven-apache-parent/pull/122 Bumps [maven-invoker-plugin](https://github.com/apache/maven-invoker-plugin) from 3.3.0 to 3.4.0. Commits https://github.com/apache/maven-invoker-plugin/commit/2de13f627

[GitHub] [maven-invoker-plugin] olamy opened a new pull request, #159: merge back branch release-3.4.0

2022-12-18 Thread GitBox
olamy opened a new pull request, #159: URL: https://github.com/apache/maven-invoker-plugin/pull/159 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MINVOKER) filed

[GitHub] [maven-enforcer] slawekjaranowski closed pull request #190: [SECURITY] Fix Temporary File Information Disclosure Vulnerability

2022-12-18 Thread GitBox
slawekjaranowski closed pull request #190: [SECURITY] Fix Temporary File Information Disclosure Vulnerability URL: https://github.com/apache/maven-enforcer/pull/190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [maven-enforcer] slawekjaranowski commented on pull request #190: [SECURITY] Fix Temporary File Information Disclosure Vulnerability

2022-12-18 Thread GitBox
slawekjaranowski commented on PR #190: URL: https://github.com/apache/maven-enforcer/pull/190#issuecomment-1356893592 Not a security issue, all change are in unit tests ... PR created by boot without human investigate. Not meet our requirements for reporting and so on ... -- This i

[GitHub] [maven-enforcer] slawekjaranowski commented on a diff in pull request #198: [MENFORCER-435] Replacing maven-compat and maven-dependency-tree usage with Resolver

2022-12-18 Thread GitBox
slawekjaranowski commented on code in PR #198: URL: https://github.com/apache/maven-enforcer/pull/198#discussion_r1051677093 ## enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/BanTransitiveDependencies.java: ## @@ -127,55 +130,27 @@ private static boolean searchTr

[jira] [Commented] (MNG-7425) Maven artifact downloads sometimes result in empty zip files in local repository

2022-12-18 Thread Nils Breunese (Jira)
[ https://issues.apache.org/jira/browse/MNG-7425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649101#comment-17649101 ] Nils Breunese commented on MNG-7425: [~michael-o] I'm afraid I can't use that at work,

[GitHub] [maven-enforcer] slawekjaranowski commented on pull request #189: Bump plexus-utils from 3.4.2 to 3.5.0

2022-12-18 Thread GitBox
slawekjaranowski commented on PR #189: URL: https://github.com/apache/maven-enforcer/pull/189#issuecomment-1356889639 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[jira] [Closed] (MENFORCER-443) Bump junit-bom from 5.9.0 to 5.9.1

2022-12-18 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MENFORCER-443. - Resolution: Fixed > Bump junit-bom from 5.9.0 to 5.9.1 > -

[GitHub] [maven-enforcer] slawekjaranowski merged pull request #186: [MENFORCER-443] Bump junit-bom from 5.9.0 to 5.9.1

2022-12-18 Thread GitBox
slawekjaranowski merged PR #186: URL: https://github.com/apache/maven-enforcer/pull/186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Created] (MENFORCER-443) Bump junit-bom from 5.9.0 to 5.9.1

2022-12-18 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MENFORCER-443: - Summary: Bump junit-bom from 5.9.0 to 5.9.1 Key: MENFORCER-443 URL: https://issues.apache.org/jira/browse/MENFORCER-443 Project: Maven Enforcer Plugi

[jira] [Commented] (MNG-7590) Allow configure resolver by properties in settings.xml

2022-12-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649099#comment-17649099 ] ASF GitHub Bot commented on MNG-7590: - slawekjaranowski opened a new pull request, #927

[GitHub] [maven] slawekjaranowski opened a new pull request, #927: [MNG-7590] Allow to configure resolver by properties in settings.xml

2022-12-18 Thread GitBox
slawekjaranowski opened a new pull request, #927: URL: https://github.com/apache/maven/pull/927 Cherry-pick from fa15fcf1536a6a5e92355ac8c91ecfa0301f016e --- Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is

[GitHub] [maven-surefire] andpab opened a new pull request, #584: [SUREFIRE-2135] Use native.encoding for parsing ps

2022-12-18 Thread GitBox
andpab opened a new pull request, #584: URL: https://github.com/apache/maven-surefire/pull/584 - Use the value of the system property native.encoding as charset for parsing the output of the ps command that ForkedBooter issues on Unix-like OSes when checking if the forked process is still a

[jira] [Commented] (MNG-7600) LocalRepositoryManager is created too early

2022-12-18 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649097#comment-17649097 ] Michael Osipov commented on MNG-7600: - Fixed with [8fd8a05aad65df05587cfed2b0a870ece2e

[jira] [Updated] (MNG-7600) LocalRepositoryManager is created too early

2022-12-18 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MNG-7600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MNG-7600: - Fix Version/s: 3.8.7 (was: 3.8.x-candidate) > LocalRepositoryManager

[jira] [Commented] (MNG-7600) LocalRepositoryManager is created too early

2022-12-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649096#comment-17649096 ] ASF GitHub Bot commented on MNG-7600: - slawekjaranowski merged PR #926: URL: https://gi

[GitHub] [maven] slawekjaranowski merged pull request #926: [MNG-7600] LocalRepositoryManager is created too early

2022-12-18 Thread GitBox
slawekjaranowski merged PR #926: URL: https://github.com/apache/maven/pull/926 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.

[jira] [Created] (SUREFIRE-2135) On Unix-like OS and JDK 18+ Surefire kills the forked JVM if PpidChecker is active and argLine is set to -Dfile.encoding=UTF-16

2022-12-18 Thread Andreas Pabst (Jira)
Andreas Pabst created SUREFIRE-2135: --- Summary: On Unix-like OS and JDK 18+ Surefire kills the forked JVM if PpidChecker is active and argLine is set to -Dfile.encoding=UTF-16 Key: SUREFIRE-2135 URL: https://issu

[jira] [Closed] (WAGON-631) Upgrade and clean up dependencies

2022-12-18 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/WAGON-631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed WAGON-631. Resolution: Fixed Fixed with [baac9242909c26057797d040b2d5bdfa6db426ef|https://gitbox.apache.org/re

[GitHub] [maven-wagon] asfgit merged pull request #88: [WAGON-631] Upgrade and clean up dependencies

2022-12-18 Thread GitBox
asfgit merged PR #88: URL: https://github.com/apache/maven-wagon/pull/88 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache

[jira] [Created] (MNG-7639) Prepare a unit test for DefaultRepositorySystemSessionFactory#newRepositorySession

2022-12-18 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MNG-7639: Summary: Prepare a unit test for DefaultRepositorySystemSessionFactory#newRepositorySession Key: MNG-7639 URL: https://issues.apache.org/jira/browse/MNG-7639

[jira] [Closed] (MENFORCER-442) Bump Mockito from 4.7.0 to 4.10.0

2022-12-18 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MENFORCER-442. - Resolution: Fixed > Bump Mockito from 4.7.0 to 4.10.0 > --

[jira] [Commented] (MNG-7600) LocalRepositoryManager is created too early

2022-12-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649089#comment-17649089 ] ASF GitHub Bot commented on MNG-7600: - michael-o commented on PR #926: URL: https://git

[GitHub] [maven] michael-o commented on pull request #926: [MNG-7600] LocalRepositoryManager is created too early

2022-12-18 Thread GitBox
michael-o commented on PR #926: URL: https://github.com/apache/maven/pull/926#issuecomment-1356870696 > Ok, we can merge as is, with agree for missing IT tests - what do you think? > > I think that better idea will be write a unit tests for `DefaultRepositorySystemSessionFactory#newR

[jira] [Commented] (MNG-7600) LocalRepositoryManager is created too early

2022-12-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649087#comment-17649087 ] ASF GitHub Bot commented on MNG-7600: - slawekjaranowski commented on PR #926: URL: http

[GitHub] [maven] slawekjaranowski commented on pull request #926: [MNG-7600] LocalRepositoryManager is created too early

2022-12-18 Thread GitBox
slawekjaranowski commented on PR #926: URL: https://github.com/apache/maven/pull/926#issuecomment-1356869913 Ok, we can merge as is, with agree for missing IT tests - what do you think? I think that better idea will be write a unit tests for `DefaultRepositorySystemSessionFactory#newR

[jira] [Commented] (MNG-7629) Revert MNG-6118 and provide a better solution for it

2022-12-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649086#comment-17649086 ] ASF GitHub Bot commented on MNG-7629: - mthmulders commented on code in PR #912: URL: ht

[GitHub] [maven] mthmulders commented on a diff in pull request #912: [MNG-7629] Fix resolution of reactor dependencies

2022-12-18 Thread GitBox
mthmulders commented on code in PR #912: URL: https://github.com/apache/maven/pull/912#discussion_r1051659869 ## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ## @@ -139,187 +132,75 @@ private File find(MavenProject project, Artifact artifact) { ret

[jira] [Created] (WAGON-631) Upgrade and clean up dependencies

2022-12-18 Thread Michael Osipov (Jira)
Michael Osipov created WAGON-631: Summary: Upgrade and clean up dependencies Key: WAGON-631 URL: https://issues.apache.org/jira/browse/WAGON-631 Project: Maven Wagon Issue Type: Dependency up

[jira] [Commented] (MNG-7629) Revert MNG-6118 and provide a better solution for it

2022-12-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649084#comment-17649084 ] ASF GitHub Bot commented on MNG-7629: - gnodet commented on code in PR #912: URL: https:

[GitHub] [maven] gnodet commented on a diff in pull request #912: [MNG-7629] Fix resolution of reactor dependencies

2022-12-18 Thread GitBox
gnodet commented on code in PR #912: URL: https://github.com/apache/maven/pull/912#discussion_r1051658567 ## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ## @@ -139,187 +132,75 @@ private File find(MavenProject project, Artifact artifact) { return

[jira] [Commented] (MNG-7629) Revert MNG-6118 and provide a better solution for it

2022-12-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649082#comment-17649082 ] ASF GitHub Bot commented on MNG-7629: - gnodet commented on code in PR #912: URL: https:

[GitHub] [maven] gnodet commented on a diff in pull request #912: [MNG-7629] Fix resolution of reactor dependencies

2022-12-18 Thread GitBox
gnodet commented on code in PR #912: URL: https://github.com/apache/maven/pull/912#discussion_r1051658332 ## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ## @@ -64,28 +63,21 @@ class ReactorReader implements MavenWorkspaceReader { public static final Strin

[jira] [Commented] (MNG-7600) LocalRepositoryManager is created too early

2022-12-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649081#comment-17649081 ] ASF GitHub Bot commented on MNG-7600: - michael-o commented on PR #926: URL: https://git

[GitHub] [maven] michael-o commented on pull request #926: [MNG-7600] LocalRepositoryManager is created too early

2022-12-18 Thread GitBox
michael-o commented on PR #926: URL: https://github.com/apache/maven/pull/926#issuecomment-1356866186 > Looking again resolver 1.6.3 has a less configuration options, so maybe such ports are not required for 3.8.x Less != none. I also maintain a fork of 3.8.x with Resolver 1.8.x until

[jira] [Commented] (MNG-7629) Revert MNG-6118 and provide a better solution for it

2022-12-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649080#comment-17649080 ] ASF GitHub Bot commented on MNG-7629: - gnodet commented on code in PR #912: URL: https:

[GitHub] [maven] gnodet commented on a diff in pull request #912: [MNG-7629] Fix resolution of reactor dependencies

2022-12-18 Thread GitBox
gnodet commented on code in PR #912: URL: https://github.com/apache/maven/pull/912#discussion_r1051657680 ## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ## @@ -139,187 +132,75 @@ private File find(MavenProject project, Artifact artifact) { return

[jira] [Commented] (MNG-7600) LocalRepositoryManager is created too early

2022-12-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649079#comment-17649079 ] ASF GitHub Bot commented on MNG-7600: - slawekjaranowski commented on PR #926: URL: http

[GitHub] [maven] slawekjaranowski commented on pull request #926: [MNG-7600] LocalRepositoryManager is created too early

2022-12-18 Thread GitBox
slawekjaranowski commented on PR #926: URL: https://github.com/apache/maven/pull/926#issuecomment-1356865487 Looking again resolver 1.6.3 has a less configuration options, so maybe such ports are not required for 3.8.x -- This is an automated message from the Apache Git Service. To re

[jira] [Commented] (MNG-7600) LocalRepositoryManager is created too early

2022-12-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649078#comment-17649078 ] ASF GitHub Bot commented on MNG-7600: - slawekjaranowski commented on PR #926: URL: http

[GitHub] [maven] slawekjaranowski commented on pull request #926: [MNG-7600] LocalRepositoryManager is created too early

2022-12-18 Thread GitBox
slawekjaranowski commented on PR #926: URL: https://github.com/apache/maven/pull/926#issuecomment-1356864582 > LGTM, any ITs to port? As far as I understand [MNG-7590](https://issues.apache.org/jira/browse/MNG-7590) needs to go first? MNG-7590 is independent of this. In 3.8.x w

[jira] [Commented] (MNG-7629) Revert MNG-6118 and provide a better solution for it

2022-12-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649075#comment-17649075 ] ASF GitHub Bot commented on MNG-7629: - mthmulders commented on code in PR #912: URL: ht

[GitHub] [maven] mthmulders commented on a diff in pull request #912: [MNG-7629] Fix resolution of reactor dependencies

2022-12-18 Thread GitBox
mthmulders commented on code in PR #912: URL: https://github.com/apache/maven/pull/912#discussion_r1051655836 ## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ## @@ -64,28 +63,21 @@ class ReactorReader implements MavenWorkspaceReader { public static final S

[jira] [Updated] (MNG-7506) Upgrade Maven Wagon to 3.5.2

2022-12-18 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-7506: Fix Version/s: 3.8.7 > Upgrade Maven Wagon to 3.5.2 > > >

[jira] [Commented] (MNG-7506) Upgrade Maven Wagon to 3.5.2

2022-12-18 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649074#comment-17649074 ] Michael Osipov commented on MNG-7506: - Fixed with [ed8493332c9aab7b970e525a3353090e68f

[jira] [Updated] (MNG-7019) Notify also at start when profile is missing

2022-12-18 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-7019: Fix Version/s: 3.8.7 > Notify also at start when profile is missing > ---

[jira] [Commented] (MNG-7019) Notify also at start when profile is missing

2022-12-18 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649073#comment-17649073 ] Michael Osipov commented on MNG-7019: - Fixed with [398a4341450d7ae780a8ec95d0b2cc98249

[jira] [Closed] (MNG-7533) jar v2.6 has medium (CVE-2021-29425) Prisma vulnerability associated with maven v3.8.6

2022-12-18 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNG-7533. --- Fix Version/s: (was: waiting-for-feedback) (was: wontfix-candidate) Re

[jira] [Commented] (MNG-7545) Multi building can create bad files for downloaded artifacts in local repository

2022-12-18 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649072#comment-17649072 ] Michael Osipov commented on MNG-7545: - [~cstamas], I believe we can close this with 3.9

[jira] [Updated] (MNG-7545) Multi building can create bad files for downloaded artifacts in local repository

2022-12-18 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-7545: Fix Version/s: 3.9.0-candidate > Multi building can create bad files for downloaded artifacts in loca

[GitHub] [maven] sultan commented on pull request #901: fix version comparison

2022-12-18 Thread GitBox
sultan commented on PR #901: URL: https://github.com/apache/maven/pull/901#issuecomment-1356858811 i also think the specs lacks this PR new cases and that they need to be discussed and the expectation decided before continuing this draft -- This is an automated message from the Apache Git

[GitHub] [maven] sultan commented on pull request #901: fix version comparison

2022-12-18 Thread GitBox
sultan commented on PR #901: URL: https://github.com/apache/maven/pull/901#issuecomment-1356857958 > > > Is this a followup to [97e8bf6](https://github.com/apache/maven/commit/97e8bf67113a9697ff8940b0b65b3e4d7bd3c28a)? > > > > > > different test cases, i consider opening a JIRA be

[jira] [Commented] (MNG-7600) LocalRepositoryManager is created too early

2022-12-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649070#comment-17649070 ] ASF GitHub Bot commented on MNG-7600: - slawekjaranowski opened a new pull request, #926

[GitHub] [maven] slawekjaranowski opened a new pull request, #926: [MNG-7600] LocalRepositoryManager is created too early

2022-12-18 Thread GitBox
slawekjaranowski opened a new pull request, #926: URL: https://github.com/apache/maven/pull/926 LocalRepositoryManager needs configurations from RepositorySystemSession so must be created after session configuration is finished. (cherry picked from commit b1c1f7556d6b66d984c4ed2c0eb72

[GitHub] [maven] michael-o commented on pull request #901: fix version comparison

2022-12-18 Thread GitBox
michael-o commented on PR #901: URL: https://github.com/apache/maven/pull/901#issuecomment-1356855453 > > Is this a followup to [97e8bf6](https://github.com/apache/maven/commit/97e8bf67113a9697ff8940b0b65b3e4d7bd3c28a)? > > different test cases, i consider opening a JIRA before making

[GitHub] [maven] sultan commented on pull request #901: fix version comparison

2022-12-18 Thread GitBox
sultan commented on PR #901: URL: https://github.com/apache/maven/pull/901#issuecomment-1356855240 > Is this a followup to [97e8bf6](https://github.com/apache/maven/commit/97e8bf67113a9697ff8940b0b65b3e4d7bd3c28a)? different test cases, i consider opening a JIRA before making this rea

[GitHub] [maven] michael-o commented on pull request #901: fix version comparison

2022-12-18 Thread GitBox
michael-o commented on PR #901: URL: https://github.com/apache/maven/pull/901#issuecomment-1356852893 Is this a followup to https://github.com/apache/maven/commit/97e8bf67113a9697ff8940b0b65b3e4d7bd3c28a? -- This is an automated message from the Apache Git Service. To respond to the messa

[jira] [Commented] (MNG-7106) VersionRange.toString() produces a string that cannot be parsed with VersionRange.createFromVersionSpec() for same lower and upper bounds

2022-12-18 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649069#comment-17649069 ] Michael Osipov commented on MNG-7106: - Fixed with [13d82830eed4d8a7ff1215fe559b041eb26

[jira] [Updated] (MNG-7106) VersionRange.toString() produces a string that cannot be parsed with VersionRange.createFromVersionSpec() for same lower and upper bounds

2022-12-18 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-7106: Fix Version/s: 3.8.7 (was: 3.8.x-candidate) > VersionRange.toString() produces

[jira] [Commented] (MNG-7106) VersionRange.toString() produces a string that cannot be parsed with VersionRange.createFromVersionSpec() for same lower and upper bounds

2022-12-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649068#comment-17649068 ] ASF GitHub Bot commented on MNG-7106: - asfgit merged PR #922: URL: https://github.com/a

[GitHub] [maven] asfgit merged pull request #922: [MNG-7106] Accept same lower and upper bound in version spec string (…

2022-12-18 Thread GitBox
asfgit merged PR #922: URL: https://github.com/apache/maven/pull/922 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

[jira] [Created] (MNG-7638) Leverage Build Cache Extension for Maven itself

2022-12-18 Thread Konrad Windszus (Jira)
Konrad Windszus created MNG-7638: Summary: Leverage Build Cache Extension for Maven itself Key: MNG-7638 URL: https://issues.apache.org/jira/browse/MNG-7638 Project: Maven Issue Type: New Fea

[GitHub] [maven] michael-o commented on pull request #923: Implement some #toString() methods (3.9.x)

2022-12-18 Thread GitBox
michael-o commented on PR #923: URL: https://github.com/apache/maven/pull/923#issuecomment-1356838638 The failures in the Core ITs aren't related to this PR. All is good, different topic to fix them. -- This is an automated message from the Apache Git Service. To respond to the message, p

[jira] [Commented] (MNG-7559) ComparableVersion vs versions with custom qualifiers

2022-12-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649058#comment-17649058 ] ASF GitHub Bot commented on MNG-7559: - sultan opened a new pull request, #925: URL: htt

[GitHub] [maven] sultan opened a new pull request, #925: [MNG-7559] Fix versions comparison, backport to 3.8.x

2022-12-18 Thread GitBox
sultan opened a new pull request, #925: URL: https://github.com/apache/maven/pull/925 This PR can be merged, If wanted to port (to 3.8.x) the fix for https://issues.apache.org/jira/browse/MNG-7559 intention is: * 1.0.0.RC1 < 1.0.0-RC2 * ( edr, pfd, etc.) < final, ga, release * 9.

[GitHub] [maven] michael-o closed pull request #923: Implement some #toString() methods (3.9.x)

2022-12-18 Thread GitBox
michael-o closed pull request #923: Implement some #toString() methods (3.9.x) URL: https://github.com/apache/maven/pull/923 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [maven] michael-o commented on pull request #923: Implement some #toString() methods (3.9.x)

2022-12-18 Thread GitBox
michael-o commented on PR #923: URL: https://github.com/apache/maven/pull/923#issuecomment-1356836298 Merge with 4adaf2abca4e3018b92c0c03e07c50a6b1a8ddab. Looking at ITs. If they rely on `#toString()` then they are flawed :-( -- This is an automated message from the Apache Git Service. To

[jira] [Updated] (MNG-7590) Allow configure resolver by properties in settings.xml

2022-12-18 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-7590: Fix Version/s: 3.8.x-candidate > Allow configure resolver by properties in settings.xml > ---

[jira] [Commented] (MNG-7559) ComparableVersion vs versions with custom qualifiers

2022-12-18 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649057#comment-17649057 ] Michael Osipov commented on MNG-7559: - What am I supposed to say: {noformat} D:\Entwick

[jira] [Commented] (MNG-7559) ComparableVersion vs versions with custom qualifiers

2022-12-18 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649056#comment-17649056 ] Michael Osipov commented on MNG-7559: - [~garretwilson], I agree with you that it should

[GitHub] [maven] pzygielo commented on pull request #923: Implement some #toString() methods (3.9.x)

2022-12-18 Thread GitBox
pzygielo commented on PR #923: URL: https://github.com/apache/maven/pull/923#issuecomment-1356833048 Seems that ITs fail since c0c752baefac68bdedf106265337df82545a6944 on that branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [maven] michael-o opened a new pull request, #924: Mng 7590+mng 7600

2022-12-18 Thread GitBox
michael-o opened a new pull request, #924: URL: https://github.com/apache/maven/pull/924 @slawekjaranowski Here it is, just requires Java 7 conversion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Commented] (MNG-7559) ComparableVersion vs versions with custom qualifiers

2022-12-18 Thread Garret Wilson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649055#comment-17649055 ] Garret Wilson commented on MNG-7559: {quote} indeed not a bug, but the spec could be im

[jira] [Commented] (MNG-7600) LocalRepositoryManager is created too early

2022-12-18 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649054#comment-17649054 ] Michael Osipov commented on MNG-7600: - Let's do so, then we also need a Java 7 version

[jira] [Commented] (MNG-7578) Building Linux image on Windows impossible (patch incuded)

2022-12-18 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649053#comment-17649053 ] Michael Osipov commented on MNG-7578: - Fixed with [a020540c5f5d5b3a01b08b1014465b3999f

[jira] [Updated] (MNG-7578) Building Linux image on Windows impossible (patch incuded)

2022-12-18 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-7578: Fix Version/s: 3.8.7 > Building Linux image on Windows impossible (patch incuded) > -

[jira] [Updated] (MNG-7578) Building Linux image on Windows impossible (patch incuded)

2022-12-18 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-7578: Fix Version/s: 3.9.0 > Building Linux image on Windows impossible (patch incuded) > -

[jira] [Commented] (MNG-7578) Building Linux image on Windows impossible (patch incuded)

2022-12-18 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649052#comment-17649052 ] Michael Osipov commented on MNG-7578: - Fixed with [a6b8a9e9fb3ca1f742883abd8cafe9eb6bf

[GitHub] [maven] pzygielo opened a new pull request, #923: Implement some #toString() methods (3.9.x)

2022-12-18 Thread GitBox
pzygielo opened a new pull request, #923: URL: https://github.com/apache/maven/pull/923 - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - - Picked from #914 and spotles

[jira] [Commented] (MNG-7352) org.apache.maven.toolchain.java.JavaToolchainImpl should be public

2022-12-18 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649048#comment-17649048 ] Michael Osipov commented on MNG-7352: - Look at 61f1d01ba86e0765e0a78eb0b18571ee503055f6

[jira] [Updated] (MNG-7352) org.apache.maven.toolchain.java.JavaToolchainImpl should be public

2022-12-18 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-7352: Fix Version/s: waiting-for-feedback > org.apache.maven.toolchain.java.JavaToolchainImpl should be pub

[jira] [Assigned] (MNG-7352) org.apache.maven.toolchain.java.JavaToolchainImpl should be public

2022-12-18 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MNG-7352: --- Assignee: Michael Osipov > org.apache.maven.toolchain.java.JavaToolchainImpl should be public

  1   2   >