[GitHub] [maven-integration-testing] MartinKanters commented on a diff in pull request #131: [MNG-7310] Add a test for MNG-7310

2022-09-11 Thread GitBox
MartinKanters commented on code in PR #131: URL: https://github.com/apache/maven-integration-testing/pull/131#discussion_r968045644 ## core-it-suite/src/test/resources/mng-7310-lifecycle-activated-in-specified-module/extension/pom.xml: ## @@ -0,0 +1,105 @@ + + + + +http://maven

[jira] [Commented] (MNG-7310) Maven loads extension from another submodule

2022-09-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602962#comment-17602962 ] ASF GitHub Bot commented on MNG-7310: - MartinKanters commented on code in PR #639: URL:

[GitHub] [maven] MartinKanters commented on a diff in pull request #639: [MNG-7310] Using the plexusContainer to prevent loading lifecycle defined by extensions from other submodules.

2022-09-11 Thread GitBox
MartinKanters commented on code in PR #639: URL: https://github.com/apache/maven/pull/639#discussion_r968044971 ## maven-core/src/test/java/org/apache/maven/lifecycle/internal/LifecycleExecutionPlanCalculatorTest.java: ## @@ -63,6 +64,7 @@ public void testCalculateExecutionPlanW

[GitHub] [maven-release] edwardUL99 commented on a diff in pull request #149: [MRELEASE-839]: Unable to supply tag to release for release:perform

2022-09-11 Thread GitBox
edwardUL99 commented on code in PR #149: URL: https://github.com/apache/maven-release/pull/149#discussion_r968034602 ## maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PerformReleaseMojo.java: ## @@ -46,7 +46,7 @@ */ @Mojo( name = "perform", aggregator = t

[jira] [Commented] (MNGSITE-491) Update commit policy related documents to avoid any misunderstanding

2022-09-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602959#comment-17602959 ] ASF GitHub Bot commented on MNGSITE-491: olamy commented on PR #321: URL: https:

[GitHub] [maven-site] olamy commented on pull request #321: [MNGSITE-491] Update commit policy related document

2022-09-11 Thread GitBox
olamy commented on PR #321: URL: https://github.com/apache/maven-site/pull/321#issuecomment-1243273891 > > > Our agreement (informal) was that changes to Corw go through PRs. > > > > > > yup but PRs mandatory != RTC vs CTR. > > The technical fact of make it mandatory to provide

[jira] [Commented] (MNGSITE-491) Update commit policy related documents to avoid any misunderstanding

2022-09-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602957#comment-17602957 ] ASF GitHub Bot commented on MNGSITE-491: michael-o commented on PR #321: URL: ht

[GitHub] [maven-site] michael-o commented on pull request #321: [MNGSITE-491] Update commit policy related document

2022-09-11 Thread GitBox
michael-o commented on PR #321: URL: https://github.com/apache/maven-site/pull/321#issuecomment-1243268809 > > Our agreement (informal) was that changes to Corw go through PRs. > > yup but PRs mandatory != RTC vs CTR. > > The technical fact of make it mandatory to provide a PR h

[jira] [Commented] (MNGSITE-491) Update commit policy related documents to avoid any misunderstanding

2022-09-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602956#comment-17602956 ] ASF GitHub Bot commented on MNGSITE-491: michael-o commented on code in PR #321:

[GitHub] [maven-site] michael-o commented on a diff in pull request #321: [MNGSITE-491] Update commit policy related document

2022-09-11 Thread GitBox
michael-o commented on code in PR #321: URL: https://github.com/apache/maven-site/pull/321#discussion_r967685008 ## content/apt/developers/conventions/git.apt: ## @@ -64,8 +64,14 @@ Maven Git Convention ** For committers Committers may, of course, commit directly to the AS

[GitHub] [maven-script-interpreter] dependabot[bot] closed pull request #72: Bump groovy from 4.0.2 to 4.0.4

2022-09-11 Thread GitBox
dependabot[bot] closed pull request #72: Bump groovy from 4.0.2 to 4.0.4 URL: https://github.com/apache/maven-script-interpreter/pull/72 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [maven-script-interpreter] dependabot[bot] commented on pull request #72: Bump groovy from 4.0.2 to 4.0.4

2022-09-11 Thread GitBox
dependabot[bot] commented on PR #72: URL: https://github.com/apache/maven-script-interpreter/pull/72#issuecomment-1243189726 Superseded by #76. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [maven-script-interpreter] dependabot[bot] opened a new pull request, #76: Bump groovy from 4.0.2 to 4.0.5

2022-09-11 Thread GitBox
dependabot[bot] opened a new pull request, #76: URL: https://github.com/apache/maven-script-interpreter/pull/76 Bumps [groovy](https://github.com/apache/groovy) from 4.0.2 to 4.0.5. Commits See full diff in https://github.com/apache/groovy/commits";>compare view

[GitHub] [maven-release] kwin commented on a diff in pull request #149: [MRELEASE-839]: Unable to supply tag to release for release:perform

2022-09-11 Thread GitBox
kwin commented on code in PR #149: URL: https://github.com/apache/maven-release/pull/149#discussion_r967967581 ## maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PerformReleaseMojo.java: ## @@ -46,7 +46,7 @@ */ @Mojo( name = "perform", aggregator = true, r

[jira] [Commented] (MSHARED-1133) Switch to JUnit 5 and drop junit-addons

2022-09-11 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602916#comment-17602916 ] Hudson commented on MSHARED-1133: - Build succeeded in Jenkins: Maven » Maven TLP » mave

[jira] [Closed] (MSHARED-1133) Switch to JUnit 5 and drop junit-addons

2022-09-11 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MSHARED-1133. - Resolution: Fixed > Switch to JUnit 5 and drop junit-addons > -

[jira] [Commented] (MSHARED-1133) Switch to JUnit 5 and drop junit-addons

2022-09-11 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602915#comment-17602915 ] Sylwester Lachiewicz commented on MSHARED-1133: --- Done in [4bcb9be15f6662

[GitHub] [maven-reporting-impl] slachiewicz merged pull request #11: [MSHARED-1133] Switch to JUnit 5 and drop junit-addons

2022-09-11 Thread GitBox
slachiewicz merged PR #11: URL: https://github.com/apache/maven-reporting-impl/pull/11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[jira] [Assigned] (MNG-7531) Upgrade to SLF4J 2.0.0

2022-09-11 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned MNG-7531: - Assignee: (was: Sylwester Lachiewicz) > Upgrade to SLF4J 2.0.0 > -

[jira] [Updated] (MNG-7531) Upgrade to SLF4J 2.0.0

2022-09-11 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MNG-7531: -- Fix Version/s: (was: 3.9.0-candidate) > Upgrade to SLF4J 2.0.0 >

[jira] [Commented] (MNGSITE-491) Update commit policy related documents to avoid any misunderstanding

2022-09-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602913#comment-17602913 ] ASF GitHub Bot commented on MNGSITE-491: olamy commented on PR #321: URL: https:

[GitHub] [maven-site] olamy commented on pull request #321: [MNGSITE-491] Update commit policy related document

2022-09-11 Thread GitBox
olamy commented on PR #321: URL: https://github.com/apache/maven-site/pull/321#issuecomment-1243048738 > Our agreement (informal) was that changes to Corw go through PRs. yup but PRs mandatory != RTC vs CTR. The technical fact of make it mandatory to provide a PR has nothing to

[jira] [Assigned] (MSHARED-1128) Deprecate all executeGoal(s) methods

2022-09-11 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned MSHARED-1128: Assignee: Slawomir Jaranowski > Deprecate all executeGoal(s) methods > -

[GitHub] [maven-verifier] slawekjaranowski commented on a diff in pull request #43: [MSHARED-1128] Introduce execute method and deprecate executeGoal(s)

2022-09-11 Thread GitBox
slawekjaranowski commented on code in PR #43: URL: https://github.com/apache/maven-verifier/pull/43#discussion_r967890214 ## src/main/java/org/apache/maven/shared/verifier/Verifier.java: ## @@ -1263,12 +1301,25 @@ public void executeGoals( List goals, Map envVars )

[jira] [Commented] (MSHARED-1134) Remove debug mode in Verifier

2022-09-11 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602911#comment-17602911 ] Slawomir Jaranowski commented on MSHARED-1134: -- - error prone - method res

[jira] [Commented] (MSHARED-1134) Remove debug mode in Verifier

2022-09-11 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602909#comment-17602909 ] Michael Osipov commented on MSHARED-1134: - I am trying to understand why this s

[GitHub] [maven-verifier] slawekjaranowski commented on a diff in pull request #42: [MSHARED-1129] Prepare for replace CLI options with CLI args

2022-09-11 Thread GitBox
slawekjaranowski commented on code in PR #42: URL: https://github.com/apache/maven-verifier/pull/42#discussion_r967872317 ## src/main/java/org/apache/maven/shared/verifier/Verifier.java: ## @@ -1566,38 +1567,77 @@ public void reset() } } +/** + * @depreca

[GitHub] [maven-verifier] gnodet commented on a diff in pull request #42: [MSHARED-1129] Prepare for replace CLI options with CLI args

2022-09-11 Thread GitBox
gnodet commented on code in PR #42: URL: https://github.com/apache/maven-verifier/pull/42#discussion_r967869428 ## src/main/java/org/apache/maven/shared/verifier/Verifier.java: ## @@ -1566,38 +1567,77 @@ public void reset() } } +/** + * @deprecated will b

[GitHub] [maven-verifier] michael-o commented on a diff in pull request #43: [MSHARED-1128] Introduce execute method and deprecate executeGoal(s)

2022-09-11 Thread GitBox
michael-o commented on code in PR #43: URL: https://github.com/apache/maven-verifier/pull/43#discussion_r967866316 ## src/main/java/org/apache/maven/shared/verifier/Verifier.java: ## @@ -1284,8 +1335,6 @@ public void executeGoals( List goals, Map envVars ) if ( ret >

[jira] [Created] (MSHARED-1134) Remove debug mode in Verifier

2022-09-11 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MSHARED-1134: Summary: Remove debug mode in Verifier Key: MSHARED-1134 URL: https://issues.apache.org/jira/browse/MSHARED-1134 Project: Maven Shared Components

[jira] [Updated] (MSHARED-1134) Remove debug mode in Verifier

2022-09-11 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MSHARED-1134: - Fix Version/s: maven-verifier-2.0.0 > Remove debug mode in Verifier > -

[jira] [Commented] (MDEP-716) TestListClassesMojo logs too much

2022-09-11 Thread Jira
[ https://issues.apache.org/jira/browse/MDEP-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602891#comment-17602891 ] Björn Raupach commented on MDEP-716: Hi there, please review the [PR|https://github.

[GitHub] [maven-dependency-plugin] raupachz opened a new pull request, #245: [MDEP-716] - TestListClassesMojo logs too much

2022-09-11 Thread GitBox
raupachz opened a new pull request, #245: URL: https://github.com/apache/maven-dependency-plugin/pull/245 Hello there, attached is a PR for [MDEP-716](https://issues.apache.org/jira/browse/MDEP-716). This is an `up-for-grabs` issue. This code uses Mockito and creates a mock o

[jira] [Updated] (MSHARED-1133) Switch to JUnit 5 and drop junit-addons

2022-09-11 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSHARED-1133: Summary: Switch to JUnit 5 and drop junit-addons (was: Switch to Junit5 and drop junit-a

[jira] [Updated] (MSHARED-1133) Switch to Junit5 and drop junit-addons

2022-09-11 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSHARED-1133: Fix Version/s: maven-reporting-impl-4.0.0-M3 > Switch to Junit5 and drop junit-addons > -

[GitHub] [maven-dist-tool] dependabot[bot] opened a new pull request, #22: Bump animal-sniffer-maven-plugin from 1.21 to 1.22

2022-09-11 Thread GitBox
dependabot[bot] opened a new pull request, #22: URL: https://github.com/apache/maven-dist-tool/pull/22 Bumps [animal-sniffer-maven-plugin](https://github.com/mojohaus/animal-sniffer) from 1.21 to 1.22. Release notes Sourced from https://github.com/mojohaus/animal-sniffer/releases"

[GitHub] [maven-dist-tool] dependabot[bot] opened a new pull request, #21: Bump maven-reporting-exec from 2.0.0-M1 to 2.0.0-M2

2022-09-11 Thread GitBox
dependabot[bot] opened a new pull request, #21: URL: https://github.com/apache/maven-dist-tool/pull/21 Bumps [maven-reporting-exec](https://github.com/apache/maven-reporting-exec) from 2.0.0-M1 to 2.0.0-M2. Commits https://github.com/apache/maven-reporting-exec/commit/d9582052e

[GitHub] [maven-doxia-sitetools] dependabot[bot] commented on pull request #55: Bump maven-surefire-plugin from 3.0.0-M5 to 3.0.0-M7

2022-09-11 Thread GitBox
dependabot[bot] commented on PR #55: URL: https://github.com/apache/maven-doxia-sitetools/pull/55#issuecomment-1242996111 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor v

[GitHub] [maven-doxia-sitetools] asfgit closed pull request #55: Bump maven-surefire-plugin from 3.0.0-M5 to 3.0.0-M7

2022-09-11 Thread GitBox
asfgit closed pull request #55: Bump maven-surefire-plugin from 3.0.0-M5 to 3.0.0-M7 URL: https://github.com/apache/maven-doxia-sitetools/pull/55 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven-doxia-sitetools] asfgit closed pull request #33: Bump aetherVersion from 1.0.0.v20140518 to 1.1.0

2022-09-11 Thread GitBox
asfgit closed pull request #33: Bump aetherVersion from 1.0.0.v20140518 to 1.1.0 URL: https://github.com/apache/maven-doxia-sitetools/pull/33 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [maven-doxia-sitetools] dependabot[bot] commented on pull request #33: Bump aetherVersion from 1.0.0.v20140518 to 1.1.0

2022-09-11 Thread GitBox
dependabot[bot] commented on PR #33: URL: https://github.com/apache/maven-doxia-sitetools/pull/33#issuecomment-1242995721 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a de

[GitHub] [maven-doxia-sitetools] dependabot[bot] commented on pull request #56: Bump wagon-http from 2.8 to 3.5.2

2022-09-11 Thread GitBox
dependabot[bot] commented on PR #56: URL: https://github.com/apache/maven-doxia-sitetools/pull/56#issuecomment-1242993764 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor v

[GitHub] [maven-doxia-sitetools] asfgit closed pull request #56: Bump wagon-http from 2.8 to 3.5.2

2022-09-11 Thread GitBox
asfgit closed pull request #56: Bump wagon-http from 2.8 to 3.5.2 URL: https://github.com/apache/maven-doxia-sitetools/pull/56 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[jira] [Assigned] (MSHARED-1133) Switch to Junit5 and drop junit-addons

2022-09-11 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned MSHARED-1133: - Assignee: Sylwester Lachiewicz > Switch to Junit5 and drop junit-addon

[jira] [Updated] (MSHARED-1133) Switch to Junit5 and drop junit-addons

2022-09-11 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MSHARED-1133: -- Summary: Switch to Junit5 and drop junit-addons (was: Drop dependency to jun

[jira] [Updated] (MSHARED-1133) Drop dependency to junit-addons

2022-09-11 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MSHARED-1133: -- Description: fixes bellow reported issues in tests Provides transitive vulne

[jira] [Created] (MSHARED-1133) Drop dependency to junit-addons

2022-09-11 Thread Sylwester Lachiewicz (Jira)
Sylwester Lachiewicz created MSHARED-1133: - Summary: Drop dependency to junit-addons Key: MSHARED-1133 URL: https://issues.apache.org/jira/browse/MSHARED-1133 Project: Maven Shared Components

[jira] [Commented] (MNGSITE-491) Update commit policy related documents to avoid any misunderstanding

2022-09-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602881#comment-17602881 ] ASF GitHub Bot commented on MNGSITE-491: michael-o commented on PR #321: URL: ht

[GitHub] [maven-site] michael-o commented on pull request #321: [MNGSITE-491] Update commit policy related document

2022-09-11 Thread GitBox
michael-o commented on PR #321: URL: https://github.com/apache/maven-site/pull/321#issuecomment-1242990180 Our agreement (informal) was that changes to Corw go through PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[jira] [Commented] (MNGSITE-491) Update commit policy related documents to avoid any misunderstanding

2022-09-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602870#comment-17602870 ] ASF GitHub Bot commented on MNGSITE-491: stephenc commented on PR #321: URL: htt

[GitHub] [maven-site] stephenc commented on pull request #321: [MNGSITE-491] Update commit policy related document

2022-09-11 Thread GitBox
stephenc commented on PR #321: URL: https://github.com/apache/maven-site/pull/321#issuecomment-1242979519 > @cstamas after the Maven 3.4.0 debacle we switched to RTC for good reasons @stephenc remembers. I remember 3.4.0 but I don't remember us switching to RTC. What happened i

[jira] [Updated] (MENFORCER-432) requireUpperBoundDeps support for checking dependencyManagement

2022-09-11 Thread Marcono1234 (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcono1234 updated MENFORCER-432: -- Description: For projects which are either used as parent by other projects, or which are u

[jira] [Created] (MENFORCER-432) requireUpperBoundDeps support for checking dependencyManagement

2022-09-11 Thread Marcono1234 (Jira)
Marcono1234 created MENFORCER-432: - Summary: requireUpperBoundDeps support for checking dependencyManagement Key: MENFORCER-432 URL: https://issues.apache.org/jira/browse/MENFORCER-432 Project: Maven

[jira] [Commented] (MNGSITE-491) Update commit policy related documents to avoid any misunderstanding

2022-09-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602865#comment-17602865 ] ASF GitHub Bot commented on MNGSITE-491: michael-o commented on PR #321: URL: ht

[GitHub] [maven-site] michael-o commented on pull request #321: [MNGSITE-491] Update commit policy related document

2022-09-11 Thread GitBox
michael-o commented on PR #321: URL: https://github.com/apache/maven-site/pull/321#issuecomment-1242960484 @cstamas after the Maven 3.4.0 debacle we switched to RTC for good reasons @stephenc remembers. -- This is an automated message from the Apache Git Service. To respond to the message

[jira] [Commented] (MNGSITE-491) Update commit policy related documents to avoid any misunderstanding

2022-09-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602862#comment-17602862 ] ASF GitHub Bot commented on MNGSITE-491: cstamas commented on PR #321: URL: http

[GitHub] [maven-site] cstamas commented on pull request #321: [MNGSITE-491] Update commit policy related document

2022-09-11 Thread GitBox
cstamas commented on PR #321: URL: https://github.com/apache/maven-site/pull/321#issuecomment-1242957974 Folks, I thought I was precise enough with this PR, but seems I was not, so let me reiterate: * this PR is NOT changing project policy, what it tries to do instead is to **align doco

[jira] [Closed] (MSHARED-1129) Replace CLI options with CLI args

2022-09-11 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MSHARED-1129. Resolution: Fixed > Replace CLI options with CLI args > -

[jira] [Commented] (MSHARED-1129) Replace CLI options with CLI args

2022-09-11 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602859#comment-17602859 ] Hudson commented on MSHARED-1129: - Build succeeded in Jenkins: Maven » Maven TLP » mave

[GitHub] [maven-verifier] slawekjaranowski merged pull request #42: [MSHARED-1129] Prepare for replace CLI options with CLI args

2022-09-11 Thread GitBox
slawekjaranowski merged PR #42: URL: https://github.com/apache/maven-verifier/pull/42 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[jira] [Commented] (MNGSITE-491) Update commit policy related documents to avoid any misunderstanding

2022-09-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602855#comment-17602855 ] ASF GitHub Bot commented on MNGSITE-491: olamy commented on PR #321: URL: https:

[GitHub] [maven-site] olamy commented on pull request #321: [MNGSITE-491] Update commit policy related document

2022-09-11 Thread GitBox
olamy commented on PR #321: URL: https://github.com/apache/maven-site/pull/321#issuecomment-1242948176 regarding this change some vote might be needed or some discussion on a mailing list not sure if it's mandatory per ASF rule but might need to be checked. because you can definite

[GitHub] [maven-verifier] slawekjaranowski commented on a diff in pull request #42: [MSHARED-1129] Prepare for replace CLI options with CLI args

2022-09-11 Thread GitBox
slawekjaranowski commented on code in PR #42: URL: https://github.com/apache/maven-verifier/pull/42#discussion_r967810976 ## src/main/java/org/apache/maven/shared/verifier/Verifier.java: ## @@ -1566,38 +1567,76 @@ public void reset() } } +/** + * @depreca

[jira] [Commented] (MENFORCER-430) Allow one of many files in RequireFiles rules to pass

2022-09-11 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602853#comment-17602853 ] Hudson commented on MENFORCER-430: -- Build succeeded in Jenkins: Maven » Maven TLP » m

[jira] [Updated] (MENFORCER-397) allow no rules

2022-09-11 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MENFORCER-397: -- Issue Type: New Feature (was: Improvement) > allow no rules > -

[jira] [Closed] (MENFORCER-430) Allow one of many files in RequireFiles rules to pass

2022-09-11 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MENFORCER-430. - Fix Version/s: next-release Assignee: Slawomir Jaranowski Resol

[GitHub] [maven-enforcer] slawekjaranowski commented on pull request #183: [MENFORCER-430] Allow one of many files in RequireFiles rules to pass

2022-09-11 Thread GitBox
slawekjaranowski commented on PR #183: URL: https://github.com/apache/maven-enforcer/pull/183#issuecomment-1242941027 @raupachz thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [maven-enforcer] slawekjaranowski merged pull request #183: [MENFORCER-430] Allow one of many files in RequireFiles rules to pass

2022-09-11 Thread GitBox
slawekjaranowski merged PR #183: URL: https://github.com/apache/maven-enforcer/pull/183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [maven-verifier] michael-o commented on a diff in pull request #42: [MSHARED-1129] Prepare for replace CLI options with CLI args

2022-09-11 Thread GitBox
michael-o commented on code in PR #42: URL: https://github.com/apache/maven-verifier/pull/42#discussion_r967804699 ## src/main/java/org/apache/maven/shared/verifier/Verifier.java: ## @@ -1566,38 +1567,76 @@ public void reset() } } +/** + * @deprecated wil

[GitHub] [maven-verifier] michael-o commented on a diff in pull request #42: [MSHARED-1129] Prepare for replace CLI options with CLI args

2022-09-11 Thread GitBox
michael-o commented on code in PR #42: URL: https://github.com/apache/maven-verifier/pull/42#discussion_r967804480 ## src/main/java/org/apache/maven/shared/verifier/Verifier.java: ## @@ -1566,38 +1567,76 @@ public void reset() } } +/** + * @deprecated wil

[jira] [Comment Edited] (MNG-6434) Cannot specify empty string for configuration value

2022-09-11 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/MNG-6434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602843#comment-17602843 ] Konrad Windszus edited comment on MNG-6434 at 9/11/22 10:39 AM: -

[jira] [Commented] (MNG-6434) Cannot specify empty string for configuration value

2022-09-11 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/MNG-6434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602847#comment-17602847 ] Konrad Windszus commented on MNG-6434: -- I raised https://github.com/codehaus-plexus/pl

[GitHub] [maven-verifier] slawekjaranowski commented on a diff in pull request #42: [MSHARED-1129] Prepare for replace CLI options with CLI args

2022-09-11 Thread GitBox
slawekjaranowski commented on code in PR #42: URL: https://github.com/apache/maven-verifier/pull/42#discussion_r967801977 ## src/main/java/org/apache/maven/shared/verifier/Verifier.java: ## @@ -1566,38 +1567,76 @@ public void reset() } } +/** + * @depreca

[jira] [Comment Edited] (MNG-6434) Cannot specify empty string for configuration value

2022-09-11 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/MNG-6434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602843#comment-17602843 ] Konrad Windszus edited comment on MNG-6434 at 9/11/22 10:26 AM: -

[jira] [Comment Edited] (MNG-6434) Cannot specify empty string for configuration value

2022-09-11 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/MNG-6434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602843#comment-17602843 ] Konrad Windszus edited comment on MNG-6434 at 9/11/22 10:23 AM: -

[jira] [Comment Edited] (MNG-6434) Cannot specify empty string for configuration value

2022-09-11 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/MNG-6434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602843#comment-17602843 ] Konrad Windszus edited comment on MNG-6434 at 9/11/22 10:19 AM: -

[GitHub] [maven-verifier] slawekjaranowski commented on a diff in pull request #42: [MSHARED-1129] Prepare for replace CLI options with CLI args

2022-09-11 Thread GitBox
slawekjaranowski commented on code in PR #42: URL: https://github.com/apache/maven-verifier/pull/42#discussion_r967800114 ## src/main/java/org/apache/maven/shared/verifier/Verifier.java: ## @@ -210,7 +211,7 @@ private Verifier( String basedir, String settingsFile, boolean debug

[GitHub] [maven-enforcer] raupachz commented on pull request #183: [MENFORCER-430] Allow one of many files in RequireFiles rules to pass

2022-09-11 Thread GitBox
raupachz commented on PR #183: URL: https://github.com/apache/maven-enforcer/pull/183#issuecomment-1242929156 @slawekjaranowski Thank you for reviewing. PR is updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[jira] [Comment Edited] (MNG-6434) Cannot specify empty string for configuration value

2022-09-11 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/MNG-6434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602843#comment-17602843 ] Konrad Windszus edited comment on MNG-6434 at 9/11/22 9:49 AM: --

[jira] [Commented] (MNG-6434) Cannot specify empty string for configuration value

2022-09-11 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/MNG-6434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602843#comment-17602843 ] Konrad Windszus commented on MNG-6434: -- The problem is that the {{Xpp3DomBuilder}} tri

[GitHub] [maven-dist-tool] dependabot[bot] commented on pull request #10: Bump aether-util from 0.9.0.M2 to 1.1.0

2022-09-11 Thread GitBox
dependabot[bot] commented on PR #10: URL: https://github.com/apache/maven-dist-tool/pull/10#issuecomment-1242919195 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version,

[GitHub] [maven-dist-tool] slachiewicz closed pull request #10: Bump aether-util from 0.9.0.M2 to 1.1.0

2022-09-11 Thread GitBox
slachiewicz closed pull request #10: Bump aether-util from 0.9.0.M2 to 1.1.0 URL: https://github.com/apache/maven-dist-tool/pull/10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [maven-dist-tool] dependabot[bot] commented on pull request #12: Bump aether-api from 0.9.0.M2 to 1.1.0

2022-09-11 Thread GitBox
dependabot[bot] commented on PR #12: URL: https://github.com/apache/maven-dist-tool/pull/12#issuecomment-1242919179 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version,

[GitHub] [maven-dist-tool] slachiewicz closed pull request #12: Bump aether-api from 0.9.0.M2 to 1.1.0

2022-09-11 Thread GitBox
slachiewicz closed pull request #12: Bump aether-api from 0.9.0.M2 to 1.1.0 URL: https://github.com/apache/maven-dist-tool/pull/12 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[jira] [Commented] (MNG-7502) Upgrade Guice to 5.1.0

2022-09-11 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602835#comment-17602835 ] Hudson commented on MNG-7502: - Build unstable in Jenkins: Maven » Maven TLP » maven » maven-3.9

[jira] [Commented] (MNG-7537) Create a branch for pre 3.9.x integration testing and remove old tests in master

2022-09-11 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602836#comment-17602836 ] Hudson commented on MNG-7537: - Build unstable in Jenkins: Maven » Maven TLP » maven » maven-3.9

[jira] [Commented] (MNG-7502) Upgrade Guice to 5.1.0

2022-09-11 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-7502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602833#comment-17602833 ] Sylwester Lachiewicz commented on MNG-7502: --- Done for 3.9.0 in [2f7dfcfe82c07829

[jira] [Closed] (MNG-7502) Upgrade Guice to 5.1.0

2022-09-11 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-7502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MNG-7502. - Resolution: Fixed > Upgrade Guice to 5.1.0 > -- > > Key

[jira] [Updated] (MNG-7502) Upgrade Guice to 5.1.0

2022-09-11 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-7502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MNG-7502: -- Fix Version/s: 3.9.0 (was: 3.9.0-candidate) > Upgrade Guice to 5.1

[jira] [Commented] (MNG-7502) Upgrade Guice to 5.1.0

2022-09-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602832#comment-17602832 ] ASF GitHub Bot commented on MNG-7502: - slachiewicz merged PR #800: URL: https://github.

[GitHub] [maven] slachiewicz merged pull request #800: [MNG-7502] Upgrade to Guice 5.1.0

2022-09-11 Thread GitBox
slachiewicz merged PR #800: URL: https://github.com/apache/maven/pull/800 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apach