[GitHub] [maven-jar-plugin] olamy commented on a diff in pull request #47: Code simplifications in AbstractMojo

2022-08-11 Thread GitBox
olamy commented on code in PR #47: URL: https://github.com/apache/maven-jar-plugin/pull/47#discussion_r944120213 ## src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java: ## @@ -196,16 +196,17 @@ protected File getJarFile( File basedir, String resultFinalName, String

[GitHub] [maven-enforcer] gastaldi commented on a diff in pull request #180: [MENFORCER-422] Added externalRules rule

2022-08-11 Thread GitBox
gastaldi commented on code in PR #180: URL: https://github.com/apache/maven-enforcer/pull/180#discussion_r944013362 ## enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/Descriptors.java: ## @@ -0,0 +1,148 @@ +package org.apache.maven.plugins.enforcer; + +/* + * Lice

[GitHub] [maven-enforcer] gastaldi commented on a diff in pull request #180: [MENFORCER-422] Added descriptors rule

2022-08-11 Thread GitBox
gastaldi commented on code in PR #180: URL: https://github.com/apache/maven-enforcer/pull/180#discussion_r943933810 ## enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/Descriptors.java: ## @@ -0,0 +1,148 @@ +package org.apache.maven.plugins.enforcer; + +/* + * Lice

[GitHub] [maven-enforcer] gastaldi commented on a diff in pull request #180: [MENFORCER-422] Added descriptors rule

2022-08-11 Thread GitBox
gastaldi commented on code in PR #180: URL: https://github.com/apache/maven-enforcer/pull/180#discussion_r943933035 ## enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/Descriptors.java: ## @@ -0,0 +1,148 @@ +package org.apache.maven.plugins.enforcer; + +/* + * Lice

[GitHub] [maven-enforcer] ppalaga commented on pull request #180: [MENFORCER-422] Added descriptors rule

2022-08-11 Thread GitBox
ppalaga commented on PR #180: URL: https://github.com/apache/maven-enforcer/pull/180#issuecomment-1212467432 > you could use the Maven dependency plugin to unpack the original rule XML, transform and include the transformed file in another dependency with another GAV), but we can discuss ab

[GitHub] [maven-enforcer] ppalaga commented on a diff in pull request #180: [MENFORCER-422] Added descriptors rule

2022-08-11 Thread GitBox
ppalaga commented on code in PR #180: URL: https://github.com/apache/maven-enforcer/pull/180#discussion_r943916426 ## enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/Descriptors.java: ## @@ -0,0 +1,148 @@ +package org.apache.maven.plugins.enforcer; + +/* + * Licen

[jira] [Commented] (MCOMPILER-395) annotationProcessorPaths should accept exclusions

2022-08-11 Thread Stephan Schroevers (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17578653#comment-17578653 ] Stephan Schroevers commented on MCOMPILER-395: -- Linked to MCOMPILER-503,

[jira] [Commented] (MCOMPILER-503) Unexpected dependency resolution of `annotationProcessorPaths`

2022-08-11 Thread Stephan Schroevers (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17578650#comment-17578650 ] Stephan Schroevers commented on MCOMPILER-503: -- Additionally, contrary to

[GitHub] [maven-enforcer] ppalaga commented on a diff in pull request #180: [MENFORCER-422] Added descriptors rule

2022-08-11 Thread GitBox
ppalaga commented on code in PR #180: URL: https://github.com/apache/maven-enforcer/pull/180#discussion_r943905739 ## enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/Descriptors.java: ## @@ -0,0 +1,148 @@ +package org.apache.maven.plugins.enforcer; + +/* + * Licen

[GitHub] [maven-enforcer] gastaldi commented on a diff in pull request #180: [MENFORCER-422] Added descriptors rule

2022-08-11 Thread GitBox
gastaldi commented on code in PR #180: URL: https://github.com/apache/maven-enforcer/pull/180#discussion_r943902433 ## enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/Descriptors.java: ## @@ -0,0 +1,148 @@ +package org.apache.maven.plugins.enforcer; + +/* + * Lice

[GitHub] [maven-enforcer] gastaldi commented on pull request #180: [MENFORCER-422] Added descriptors rule

2022-08-11 Thread GitBox
gastaldi commented on PR #180: URL: https://github.com/apache/maven-enforcer/pull/180#issuecomment-1212443930 > Another important feature for the future: be able to customize the descriptor before processing, ideally through an XSLT. Motivation: some artifacts that are banned in Quarkus mig

[GitHub] [maven-enforcer] gastaldi commented on a diff in pull request #180: [MENFORCER-422] Added descriptors rule

2022-08-11 Thread GitBox
gastaldi commented on code in PR #180: URL: https://github.com/apache/maven-enforcer/pull/180#discussion_r943894987 ## enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/Descriptors.java: ## @@ -0,0 +1,148 @@ +package org.apache.maven.plugins.enforcer; + +/* + * Lice

[GitHub] [maven-enforcer] gastaldi commented on a diff in pull request #180: [MENFORCER-422] Added descriptors rule

2022-08-11 Thread GitBox
gastaldi commented on code in PR #180: URL: https://github.com/apache/maven-enforcer/pull/180#discussion_r943892982 ## maven-enforcer-plugin/src/it/projects/descriptors-local-always-pass/pom.xml: ## @@ -0,0 +1,56 @@ + + + + + + 4.0.0 + + org.apache.maven.its.enforcer + test +

[GitHub] [maven-enforcer] ppalaga commented on a diff in pull request #180: [MENFORCER-422] Added descriptors rule

2022-08-11 Thread GitBox
ppalaga commented on code in PR #180: URL: https://github.com/apache/maven-enforcer/pull/180#discussion_r943874201 ## enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/Descriptors.java: ## @@ -0,0 +1,148 @@ +package org.apache.maven.plugins.enforcer; + +/* + * Licen

[GitHub] [maven-enforcer] ppalaga commented on a diff in pull request #180: [MENFORCER-422] Added descriptors rule

2022-08-11 Thread GitBox
ppalaga commented on code in PR #180: URL: https://github.com/apache/maven-enforcer/pull/180#discussion_r943862140 ## maven-enforcer-plugin/src/it/projects/descriptors-local-always-pass/pom.xml: ## @@ -0,0 +1,56 @@ + + + + + + 4.0.0 + + org.apache.maven.its.enforcer + test +

[jira] [Commented] (MENFORCER-422) Support declaring external banned dependencies in an external file/URL

2022-08-11 Thread George Gastaldi (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17578571#comment-17578571 ] George Gastaldi commented on MENFORCER-422: --- Based on the ideas in this issu

[GitHub] [maven-enforcer] gastaldi opened a new pull request, #180: [MENFORCER-422] Added descriptors rule

2022-08-11 Thread GitBox
gastaldi opened a new pull request, #180: URL: https://github.com/apache/maven-enforcer/pull/180 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MENFORCER) filed

[jira] [Updated] (MJAVADOC-724) Maven Java Doc Plug-in v3.4.0 downloads Log4j-1.2.12 dependency transitively

2022-08-11 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MJAVADOC-724: Fix Version/s: wontfix-candidate > Maven Java Doc Plug-in v3.4.0 downloads Log4j-1.2.12 d