[GitHub] [maven-checkstyle-plugin] dependabot[bot] closed pull request #72: Bump checkstyle from 9.3 to 10.1

2022-05-01 Thread GitBox
dependabot[bot] closed pull request #72: Bump checkstyle from 9.3 to 10.1 URL: https://github.com/apache/maven-checkstyle-plugin/pull/72 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [maven-checkstyle-plugin] dependabot[bot] commented on pull request #72: Bump checkstyle from 9.3 to 10.1

2022-05-01 Thread GitBox
dependabot[bot] commented on PR #72: URL: https://github.com/apache/maven-checkstyle-plugin/pull/72#issuecomment-1114517856 Superseded by #73. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven-checkstyle-plugin] dependabot[bot] opened a new pull request, #73: Bump checkstyle from 9.3 to 10.2

2022-05-01 Thread GitBox
dependabot[bot] opened a new pull request, #73: URL: https://github.com/apache/maven-checkstyle-plugin/pull/73 Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 9.3 to 10.2. Release notes Sourced from https://github.com/checkstyle/checkstyle/releases";>checkstyle's

[GitHub] [maven-fluido-skin] olamy commented on a diff in pull request #23: [MSKINS-169] Image height not effective

2022-05-01 Thread GitBox
olamy commented on code in PR #23: URL: https://github.com/apache/maven-fluido-skin/pull/23#discussion_r862553037 ## pom.xml: ## @@ -253,7 +253,6 @@ under the License. site - true Review Comment: fair enough but t

[GitHub] [maven-mvnd] hboutemy opened a new pull request, #629: don't skip build/ in source archive

2022-05-01 Thread GitBox
hboutemy opened a new pull request, #629: URL: https://github.com/apache/maven-mvnd/pull/629 fixes issue found during 0.8.0 vote -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[jira] [Commented] (MSKINS-170) Allow to show name as headline in addition to bannerLeft

2022-05-01 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/MSKINS-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530564#comment-17530564 ] Konrad Windszus commented on MSKINS-170: This probably requires a new version of

[jira] [Commented] (MSKINS-170) Allow to show name as headline in addition to bannerLeft

2022-05-01 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/MSKINS-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530563#comment-17530563 ] Konrad Windszus commented on MSKINS-170: Just compare https://sling.apache.org/c

[jira] [Commented] (MNG-7429) The classloader containing build extensions should be used throughout the build

2022-05-01 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530560#comment-17530560 ] Michael Osipov commented on MNG-7429: - [~gnodet], is this still valid? > The classloa

[GitHub] [maven-deploy-plugin] michael-o commented on a diff in pull request #22: [MDEPLOY-291] Update POM parent and Maven

2022-05-01 Thread GitBox
michael-o commented on code in PR #22: URL: https://github.com/apache/maven-deploy-plugin/pull/22#discussion_r862515576 ## pom.xml: ## @@ -126,33 +138,45 @@ under the License. test - org.mockito - mockito-core - 2.28.2 + org.apache.maven +

[GitHub] [maven] michael-o commented on a diff in pull request #731: [MNG-7464] Warn about using read-only parameters for Mojo in configuration

2022-05-01 Thread GitBox
michael-o commented on code in PR #731: URL: https://github.com/apache/maven/pull/731#discussion_r862515080 ## maven-core/src/main/java/org/apache/maven/plugin/internal/ReadOnlyPluginParametersValidator.java: ## @@ -0,0 +1,80 @@ +package org.apache.maven.plugin.internal; + +/* +

[GitHub] [maven-surefire] dejan2609 commented on pull request #233: [SUREFIRE-1494] default provider for JUnit4 integration tests is changed (from 'surefire-junit4' to 'surefire-junit47')

2022-05-01 Thread GitBox
dejan2609 commented on PR #233: URL: https://github.com/apache/maven-surefire/pull/233#issuecomment-1114306994 Sure @Tibor17, will do that (I'm currently almost off the grid, but will be back soon). -- This is an automated message from the Apache Git Service. To respond to the message, pl

[jira] [Commented] (MDEP-804) Allow auto-ignore of all non-test scoped dependencies used only in test scope

2022-05-01 Thread Henning Schmiedehausen (Jira)
[ https://issues.apache.org/jira/browse/MDEP-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530551#comment-17530551 ] Henning Schmiedehausen commented on MDEP-804: - Very much agreed. That is why I

[jira] [Commented] (MDEP-804) Allow auto-ignore of all non-test scoped dependencies used only in test scope

2022-05-01 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MDEP-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530543#comment-17530543 ] Slawomir Jaranowski commented on MDEP-804: -- Nevermind if you are or not committed

[jira] [Commented] (MDEP-804) Allow auto-ignore of all non-test scoped dependencies used only in test scope

2022-05-01 Thread Henning Schmiedehausen (Jira)
[ https://issues.apache.org/jira/browse/MDEP-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530539#comment-17530539 ] Henning Schmiedehausen commented on MDEP-804: - Yeah, according to https://peopl

[jira] [Comment Edited] (MDEP-804) Allow auto-ignore of all non-test scoped dependencies used only in test scope

2022-05-01 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MDEP-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530533#comment-17530533 ] Slawomir Jaranowski edited comment on MDEP-804 at 5/1/22 5:07 PM: ---

[jira] [Commented] (MDEP-804) Allow auto-ignore of all non-test scoped dependencies used only in test scope

2022-05-01 Thread Henning Schmiedehausen (Jira)
[ https://issues.apache.org/jira/browse/MDEP-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530538#comment-17530538 ] Henning Schmiedehausen commented on MDEP-804: - You are correct, this would be e

[jira] [Commented] (MDEP-777) String index out of range when using FlattenFileMapper

2022-05-01 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MDEP-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530537#comment-17530537 ] Slawomir Jaranowski commented on MDEP-777: -- please provide simple minimal project

[GitHub] [maven-dependency-plugin] slawekjaranowski commented on pull request #211: [MDEP-804] - Allow auto-ignore of all non-test scoped dependencies used only in test scope

2022-05-01 Thread GitBox
slawekjaranowski commented on PR #211: URL: https://github.com/apache/maven-dependency-plugin/pull/211#issuecomment-1114284099 Explanation in issue - why I close it. https://issues.apache.org/jira/browse/MDEP-804 -- This is an automated message from the Apache Git Service. To respo

[GitHub] [maven-dependency-plugin] slawekjaranowski closed pull request #211: [MDEP-804] - Allow auto-ignore of all non-test scoped dependencies used only in test scope

2022-05-01 Thread GitBox
slawekjaranowski closed pull request #211: [MDEP-804] - Allow auto-ignore of all non-test scoped dependencies used only in test scope URL: https://github.com/apache/maven-dependency-plugin/pull/211 -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (MDEP-804) Allow auto-ignore of all non-test scoped dependencies used only in test scope

2022-05-01 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MDEP-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530533#comment-17530533 ] Slawomir Jaranowski commented on MDEP-804: -- Why not use: {code} < ignoredNonTes

[jira] [Updated] (MDEP-804) Allow auto-ignore of all non-test scoped dependencies used only in test scope

2022-05-01 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MDEP-804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MDEP-804: - Fix Version/s: wontfix-candidate > Allow auto-ignore of all non-test scoped dependencies us

[GitHub] [maven-fluido-skin] michael-o commented on a diff in pull request #23: [MSKINS-169] Image height not effective

2022-05-01 Thread GitBox
michael-o commented on code in PR #23: URL: https://github.com/apache/maven-fluido-skin/pull/23#discussion_r862476253 ## pom.xml: ## @@ -253,7 +253,6 @@ under the License. site - true Review Comment: It spills the

[GitHub] [maven-fluido-skin] olamy commented on a diff in pull request #23: [MSKINS-169] Image height not effective

2022-05-01 Thread GitBox
olamy commented on code in PR #23: URL: https://github.com/apache/maven-fluido-skin/pull/23#discussion_r862469166 ## pom.xml: ## @@ -253,7 +253,6 @@ under the License. site - true Review Comment: Why? -- This

[jira] [Commented] (MSKINS-170) Allow to show name as headline in addition to bannerLeft

2022-05-01 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSKINS-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530508#comment-17530508 ] Michael Osipov commented on MSKINS-170: --- Can you explain where you see the benefit?

[jira] [Commented] (MSKINS-169) Image height not effective

2022-05-01 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSKINS-169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530505#comment-17530505 ] Michael Osipov commented on MSKINS-169: --- [~kwin], PR created. Please review/test.

[GitHub] [maven-fluido-skin] michael-o commented on pull request #23: [MSKINS-169] Image height not effective

2022-05-01 Thread GitBox
michael-o commented on PR #23: URL: https://github.com/apache/maven-fluido-skin/pull/23#issuecomment-1114195235 @kwin Please review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [maven-fluido-skin] michael-o opened a new pull request, #23: [MSKINS-169] Image height not effective

2022-05-01 Thread GitBox
michael-o opened a new pull request, #23: URL: https://github.com/apache/maven-fluido-skin/pull/23 It is also imperative to provide units otherwise the browser will ignore them. Reason for the failure: https://stackoverflow.com/a/44010892/696632 This closes #23 -- This is

[jira] [Updated] (MSKINS-169) Image height not effective

2022-05-01 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSKINS-169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSKINS-169: -- Summary: Image height not effective (was: image height not effective) > Image height not effec

[GitHub] [maven-mvnd] hboutemy commented on pull request #626: prepare Reproducible Builds

2022-05-01 Thread GitBox
hboutemy commented on PR #626: URL: https://github.com/apache/maven-mvnd/pull/626#issuecomment-1114191846 removing platform-dependant data from daemon common breaks tests... I'm convinced that such things should not be at that place: perhaps only in client, because client is the only aspe

[GitHub] [maven-mvnd] hboutemy opened a new issue, #628: make libmvndnative.* builds reproducible

2022-05-01 Thread GitBox
hboutemy opened a new issue, #628: URL: https://github.com/apache/maven-mvnd/issues/628 currently, when doing `cd native ; make native-all`, we see that on the 14 native libs built and stored in `src/main/resources/org/mvndaemon/mvnd/nativ/`, 11 are not reproducible = each run gives a diffe

[jira] [Commented] (MNG-7468) Unsupported plugins parameters in configuration should be verified

2022-05-01 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MNG-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530497#comment-17530497 ] Slawomir Jaranowski commented on MNG-7468: -- We can only check root parameters prov

[GitHub] [maven-mvnd] hboutemy commented on issue #627: building libmvndnative.* creates root files in target directory

2022-05-01 Thread GitBox
hboutemy commented on issue #627: URL: https://github.com/apache/maven-mvnd/issues/627#issuecomment-1114173216 first research results: the 4 cases respecting user are in fact those having a script that does proper job for user detection: https://github.com/apache/maven-mvnd/tree/master/na

[GitHub] [maven-mvnd] hboutemy opened a new issue, #627: building libmvndnative.* creates root files in target directory

2022-05-01 Thread GitBox
hboutemy opened a new issue, #627: URL: https://github.com/apache/maven-mvnd/issues/627 ``` $ cd native $ make native-all ... $ ls -l target/native-* target/native-FreeBSD-x86: total 12 -rwxr-xr-x 1 root root 4803 mai1 10:13 libmvndnative.so -rw-r--r-- 1 root root

[GitHub] [maven-mvnd] hboutemy opened a new pull request, #626: prepare Reproducible Builds

2022-05-01 Thread GitBox
hboutemy opened a new pull request, #626: URL: https://github.com/apache/maven-mvnd/pull/626 not sure this is sufficient, but at least this is required for Reproducible Builds... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[jira] [Commented] (MSKINS-117) Improve lisibility and user-friendliness in the left menu

2022-05-01 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MSKINS-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530489#comment-17530489 ] Herve Boutemy commented on MSKINS-117: -- UX and visual improvement request still seem