[GitHub] [maven] michael-o commented on a change in pull request #598: MNG-7129 switch from JAXB to Modello

2021-10-17 Thread GitBox
michael-o commented on a change in pull request #598: URL: https://github.com/apache/maven/pull/598#discussion_r730594544 ## File path: maven-core/src/main/mdo/cache-domain.mdo ## @@ -0,0 +1,296 @@ +

[GitHub] [maven] mthmulders commented on a change in pull request #598: MMG-7129 switch from JAXB to Modello

2021-10-17 Thread GitBox
mthmulders commented on a change in pull request #598: URL: https://github.com/apache/maven/pull/598#discussion_r730578718 ## File path: maven-core/src/main/mdo/cache-domain.mdo ## @@ -0,0 +1,296 @@ +

[GitHub] [maven-invoker] dependabot[bot] opened a new pull request #24: Bump actions/checkout from 2.3.4 to 2.3.5

2021-10-17 Thread GitBox
dependabot[bot] opened a new pull request #24: URL: https://github.com/apache/maven-invoker/pull/24 Bumps [actions/checkout](https://github.com/actions/checkout) from 2.3.4 to 2.3.5. Release notes Sourced from https://github.com/actions/checkout/releases";>actions/checkout's rele

[GitHub] [maven-script-interpreter] dependabot[bot] opened a new pull request #52: Bump actions/checkout from 2.3.4 to 2.3.5

2021-10-17 Thread GitBox
dependabot[bot] opened a new pull request #52: URL: https://github.com/apache/maven-script-interpreter/pull/52 Bumps [actions/checkout](https://github.com/actions/checkout) from 2.3.4 to 2.3.5. Release notes Sourced from https://github.com/actions/checkout/releases";>actions/check

[GitHub] [maven-javadoc-plugin] dependabot[bot] opened a new pull request #102: Bump actions/checkout from 2.3.4 to 2.3.5

2021-10-17 Thread GitBox
dependabot[bot] opened a new pull request #102: URL: https://github.com/apache/maven-javadoc-plugin/pull/102 Bumps [actions/checkout](https://github.com/actions/checkout) from 2.3.4 to 2.3.5. Release notes Sourced from https://github.com/actions/checkout/releases";>actions/checkou

[GitHub] [maven-scm] michael-o commented on pull request #128: [SCM-969] Remove all deprecated providers

2021-10-17 Thread GitBox
michael-o commented on pull request #128: URL: https://github.com/apache/maven-scm/pull/128#issuecomment-945188301 `grep` tells me some changes is till missing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [maven] hboutemy commented on pull request #597: [MNG-7129] Incremental build and shared cache feature

2021-10-17 Thread GitBox
hboutemy commented on pull request #597: URL: https://github.com/apache/maven/pull/597#issuecomment-945163562 without PR, no review: I had to create a PR to create life :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[jira] [Commented] (MNG-7231) Fix Javadoc errors

2021-10-17 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429736#comment-17429736 ] Hudson commented on MNG-7231: - Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-7129

[jira] [Commented] (MNG-6914) Align mvn and mvnw scripts

2021-10-17 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-6914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429738#comment-17429738 ] Hudson commented on MNG-6914: - Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-7129

[jira] [Commented] (MNG-7230) Replace assert by simpler but equivalent calls

2021-10-17 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429735#comment-17429735 ] Hudson commented on MNG-7230: - Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-7129

[GitHub] [maven] michael-o commented on pull request #597: [MNG-7129] Incremental build and shared cache feature

2021-10-17 Thread GitBox
michael-o commented on pull request #597: URL: https://github.com/apache/maven/pull/597#issuecomment-945160691 I thought that incremental changes would happen in the branch only. So a branch from branch. This diff looks huge to me. -- This is an automated message from the Apache Git Serv

[GitHub] [maven] hboutemy commented on pull request #597: [MNG-7129] Incremental build and shared cache feature

2021-10-17 Thread GitBox
hboutemy commented on pull request #597: URL: https://github.com/apache/maven/pull/597#issuecomment-945160225 step by step -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [maven] michael-o commented on pull request #597: [MNG-7129] Incremental build and shared cache feature

2021-10-17 Thread GitBox
michael-o commented on pull request #597: URL: https://github.com/apache/maven/pull/597#issuecomment-945160128 Why into 3.8.x? Shouldn't this be Maven 4 for now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Assigned] (SCM-969) Remove all deprecated providers

2021-10-17 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/SCM-969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned SCM-969: -- Assignee: Michael Osipov > Remove all deprecated providers > --- > >

[GitHub] [maven] hboutemy opened a new pull request #597: [MNG-7129] Incremental build and shared cache feature

2021-10-17 Thread GitBox
hboutemy opened a new pull request #597: URL: https://github.com/apache/maven/pull/597 after initial merge of Deutsche Bank donation to MNG-7129 branch #526, let's rework the code to better match Maven codebase For example switching from jaxb2 to Modello -- This is an automated me

[GitHub] [maven] rmannibucau commented on pull request #521: prefer use of InheritableThreadLocal to fix possible issue when mojo start a thread and try to access some artifacts

2021-10-17 Thread GitBox
rmannibucau commented on pull request #521: URL: https://github.com/apache/maven/pull/521#issuecomment-945140574 I would agree with #476 but didn't get much time to test but if you are confident it is better than any thread local solution anyway so happy to go with it too. -- This is an

[jira] [Commented] (MDEP-753) Non-test dependency reported as Non-test scoped test only dependency

2021-10-17 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MDEP-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429693#comment-17429693 ] Elliotte Rusty Harold commented on MDEP-753: Oops, confused 2020 and 2021 The f

[jira] [Reopened] (MDEP-753) Non-test dependency reported as Non-test scoped test only dependency

2021-10-17 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MDEP-753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold reopened MDEP-753: My mistake. I fixed the root of the problem in https://github.com/apache/maven-dependenc

[jira] [Resolved] (MDEP-773) Getting Warning : Non-test scoped test only dependencies found

2021-10-17 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MDEP-773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold resolved MDEP-773. Resolution: Duplicate dupe of MDEP-753 > Getting Warning : Non-test scoped test only

[jira] [Closed] (MDEP-773) Getting Warning : Non-test scoped test only dependencies found

2021-10-17 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MDEP-773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold closed MDEP-773. -- > Getting Warning : Non-test scoped test only dependencies found > --

[GitHub] [maven] michael-o edited a comment on pull request #521: prefer use of InheritableThreadLocal to fix possible issue when mojo start a thread and try to access some artifacts

2021-10-17 Thread GitBox
michael-o edited a comment on pull request #521: URL: https://github.com/apache/maven/pull/521#issuecomment-945107348 > > > I personally would prefer #476 over my PR #578 because it seems to be more efficient and catches more cases. But I guess that #476 is a bit much of a global c

[GitHub] [maven] michael-o edited a comment on pull request #521: prefer use of InheritableThreadLocal to fix possible issue when mojo start a thread and try to access some artifacts

2021-10-17 Thread GitBox
michael-o edited a comment on pull request #521: URL: https://github.com/apache/maven/pull/521#issuecomment-945107348 > > > I personally would prefer #476 over my PR #578 because it seems to be more efficient and catches more cases. But I guess that #476 is a bit much of a global c

[GitHub] [maven] michael-o commented on pull request #521: prefer use of InheritableThreadLocal to fix possible issue when mojo start a thread and try to access some artifacts

2021-10-17 Thread GitBox
michael-o commented on pull request #521: URL: https://github.com/apache/maven/pull/521#issuecomment-945107348 > > > I personally would prefer #476 over my PR #578 because it seems to be more efficient and catches more cases. But I guess that #476 is a bit much of a global change f

[GitHub] [maven] famod commented on pull request #521: prefer use of InheritableThreadLocal to fix possible issue when mojo start a thread and try to access some artifacts

2021-10-17 Thread GitBox
famod commented on pull request #521: URL: https://github.com/apache/maven/pull/521#issuecomment-945106390 I personally would prefer #476 over my PR #578 because it seems to be more efficient and catches more cases. But I guess that #476 is a bit much of a global change for a 3.8.x? Ther

[GitHub] [maven] rmannibucau commented on pull request #521: prefer use of InheritableThreadLocal to fix possible issue when mojo start a thread and try to access some artifacts

2021-10-17 Thread GitBox
rmannibucau commented on pull request #521: URL: https://github.com/apache/maven/pull/521#issuecomment-945103277 Yes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [maven] michael-o commented on pull request #521: prefer use of InheritableThreadLocal to fix possible issue when mojo start a thread and try to access some artifacts

2021-10-17 Thread GitBox
michael-o commented on pull request #521: URL: https://github.com/apache/maven/pull/521#issuecomment-945100645 > > > 578 gets backs to an usable state for most case with a fully functional one with 1 thread so i would merge it yes. And that superseded this PR for you? -- T

[GitHub] [maven] rmannibucau commented on pull request #521: prefer use of InheritableThreadLocal to fix possible issue when mojo start a thread and try to access some artifacts

2021-10-17 Thread GitBox
rmannibucau commented on pull request #521: URL: https://github.com/apache/maven/pull/521#issuecomment-945100099 578 gets backs to an usable state for most case with a fully functional one with 1 thread so i would merge it yes. -- This is an automated message from the Apache Git Service.

[GitHub] [maven-integration-testing] michael-o merged pull request #121: Update ITs for simplify args help

2021-10-17 Thread GitBox
michael-o merged pull request #121: URL: https://github.com/apache/maven-integration-testing/pull/121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[GitHub] [maven] michael-o merged pull request #596: Simplify args help

2021-10-17 Thread GitBox
michael-o merged pull request #596: URL: https://github.com/apache/maven/pull/596 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [maven] michael-o commented on pull request #521: prefer use of InheritableThreadLocal to fix possible issue when mojo start a thread and try to access some artifacts

2021-10-17 Thread GitBox
michael-o commented on pull request #521: URL: https://github.com/apache/maven/pull/521#issuecomment-945088039 > > > InheritableThreadLocal works only when subclassloader tree is controlled and can accept its value leakage. It is the case for jetty but not for all mojo so iy is not

[GitHub] [maven] rmannibucau commented on pull request #521: prefer use of InheritableThreadLocal to fix possible issue when mojo start a thread and try to access some artifacts

2021-10-17 Thread GitBox
rmannibucau commented on pull request #521: URL: https://github.com/apache/maven/pull/521#issuecomment-945087278 InheritableThreadLocal works only when subclassloader tree is controlled and can accept its value leakage. It is the case for jetty but not for all mojo so iy is not a good solu

[GitHub] [maven-integration-testing] michael-o commented on a change in pull request #121: Update ITs for simplify args help

2021-10-17 Thread GitBox
michael-o commented on a change in pull request #121: URL: https://github.com/apache/maven-integration-testing/pull/121#discussion_r730387504 ## File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5760ResumeFeatureTest.java ## @@ -72,8 +72,8 @@ public void te

[GitHub] [maven-plugin-tools] slawekjaranowski commented on pull request #44: use shared gh action

2021-10-17 Thread GitBox
slawekjaranowski commented on pull request #44: URL: https://github.com/apache/maven-plugin-tools/pull/44#issuecomment-945081349 @olamy, @cstamas, @gnodet -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [maven-integration-testing] michael-o opened a new pull request #121: Update ITs for simplify args help

2021-10-17 Thread GitBox
michael-o opened a new pull request #121: URL: https://github.com/apache/maven-integration-testing/pull/121 As discussed some months ago. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [maven] michael-o opened a new pull request #596: Simplify args help

2021-10-17 Thread GitBox
michael-o opened a new pull request #596: URL: https://github.com/apache/maven/pull/596 As discussed some months ago. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [maven-plugin-tools] slawekjaranowski commented on pull request #43: [MPLUGIN-375] deprecate unsupported Mojo descriptor items

2021-10-17 Thread GitBox
slawekjaranowski commented on pull request #43: URL: https://github.com/apache/maven-plugin-tools/pull/43#issuecomment-945080554 Please look: @cstamas , @rfscholte @aheritier @khmarbaise -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [maven-dependency-plugin] slawekjaranowski commented on pull request #170: [MDEP-768] use shared gh action

2021-10-17 Thread GitBox
slawekjaranowski commented on pull request #170: URL: https://github.com/apache/maven-dependency-plugin/pull/170#issuecomment-945069504 @olamy please look ... is it time to propagate to another repos ... this issue `MDEP-768` was be at the beginning of trip -- This is an automated messa

[GitHub] [maven] michael-o commented on pull request #521: prefer use of InheritableThreadLocal to fix possible issue when mojo start a thread and try to access some artifacts

2021-10-17 Thread GitBox
michael-o commented on pull request #521: URL: https://github.com/apache/maven/pull/521#issuecomment-945068707 > > > @michael-o yup sure do it. #578 just introduce a very high level (unmaintainable? really needed?) complexity. There is still no real proof this simple change is bad.

[GitHub] [maven-dependency-plugin] slawekjaranowski opened a new pull request #170: [MDEP-768] use shared gh action

2021-10-17 Thread GitBox
slawekjaranowski opened a new pull request #170: URL: https://github.com/apache/maven-dependency-plugin/pull/170 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MD

[jira] [Commented] (MDEP-752) skip dependency analyze in ear packaging

2021-10-17 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MDEP-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429659#comment-17429659 ] Slawomir Jaranowski commented on MDEP-752: -- PR recreated > skip dependency analyz

[GitHub] [maven-dependency-plugin] slawekjaranowski opened a new pull request #169: [MDEP-752] Add ignoredPackagings options for analyze

2021-10-17 Thread GitBox
slawekjaranowski opened a new pull request #169: URL: https://github.com/apache/maven-dependency-plugin/pull/169 By default pom and ear packaging are ignored from analyzing. Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make su