[GitHub] [maven] cstamas commented on pull request #565: Mojo API update proposal

2021-10-16 Thread GitBox
cstamas commented on pull request #565: URL: https://github.com/apache/maven/pull/565#issuecomment-944256505 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [maven] arturobernalg opened a new pull request #593: [MNG-7311] - Use Collections.singletonList

2021-10-16 Thread GitBox
arturobernalg opened a new pull request #593: URL: https://github.com/apache/maven/pull/593 Following this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed f

[GitHub] [maven] michael-o commented on pull request #521: prefer use of InheritableThreadLocal to fix possible issue when mojo start a thread and try to access some artifacts

2021-10-16 Thread GitBox
michael-o commented on pull request #521: URL: https://github.com/apache/maven/pull/521#issuecomment-944906151 @olamy Can this be closed in favor of #578 since the thread local solution will be reverted? -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [maven] olamy commented on pull request #521: prefer use of InheritableThreadLocal to fix possible issue when mojo start a thread and try to access some artifacts

2021-10-16 Thread GitBox
olamy commented on pull request #521: URL: https://github.com/apache/maven/pull/521#issuecomment-945023117 @michael-o yup sure do it. #578 just introduce a very high level (unmaintainable? really needed?) complexity. There is still no real proof this simple change is bad. but yeah (no

[GitHub] [maven-release] mthmulders commented on pull request #82: [MRELEASE-1069] - typo: it's

2021-10-16 Thread GitBox
mthmulders commented on pull request #82: URL: https://github.com/apache/maven-release/pull/82#issuecomment-944476239 Thanks for your contribution, @prasad-gowda. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [maven] arturobernalg commented on pull request #593: [MNG-7311] - Use Collections.singletonList

2021-10-16 Thread GitBox
arturobernalg commented on pull request #593: URL: https://github.com/apache/maven/pull/593#issuecomment-944860029 > are we sure we really want immutable lists in those places? > it's not really a so easy change as it is not backward compatible... HI @olamy AFAIK There is no need t

[GitHub] [maven] michael-o opened a new pull request #594: [MNG-7312] Revert ThreadLocal approach from MNG-6843 and MNG-7251

2021-10-16 Thread GitBox
michael-o opened a new pull request #594: URL: https://github.com/apache/maven/pull/594 Revert "[MNG-7251] Fix threadLocalArtifactsHolder leaking into cloned project" This reverts commit a6e462b53a4b6c87ef43f6cfe7fbde0b0939e3d6. Revert "[MNG-6843] Parallel build fails due to m

[GitHub] [maven] michael-o commented on pull request #594: [MNG-7312] Revert ThreadLocal approach from MNG-6843 and MNG-7251

2021-10-16 Thread GitBox
michael-o commented on pull request #594: URL: https://github.com/apache/maven/pull/594#issuecomment-944913844 @famod Initial work. 3.8.x is up next. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [maven] hboutemy merged pull request #580: simplify, reorganise and document apache-maven-wrapper distribution

2021-10-16 Thread GitBox
hboutemy merged pull request #580: URL: https://github.com/apache/maven/pull/580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[GitHub] [maven] michael-o opened a new pull request #595: [MNG-7312] Revert ThreadLocal approach from MNG-6843 and MNG-7251

2021-10-16 Thread GitBox
michael-o opened a new pull request #595: URL: https://github.com/apache/maven/pull/595 Revert "[MNG-7251] Fix threadLocalArtifactsHolder leaking into cloned project" This reverts commit 4e5b3d55545e5f03f05ac7b0cd1b56689df36201. Revert "[MNG-6843] Parallel build fails due to m

[GitHub] [maven-plugin-testing] cstamas merged pull request #19: Get rid of warnings, cleanup

2021-10-16 Thread GitBox
cstamas merged pull request #19: URL: https://github.com/apache/maven-plugin-testing/pull/19 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issue

[GitHub] [maven-release] mthmulders closed pull request #82: [MRELEASE-1069] - typo: it's

2021-10-16 Thread GitBox
mthmulders closed pull request #82: URL: https://github.com/apache/maven-release/pull/82 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [maven] hboutemy commented on pull request #580: simplify, reorganise and document apache-maven-wrapper distribution

2021-10-16 Thread GitBox
hboutemy commented on pull request #580: URL: https://github.com/apache/maven/pull/580#issuecomment-944873478 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[GitHub] [maven] michael-o commented on pull request #595: [MNG-7312] Revert ThreadLocal approach from MNG-6843 and MNG-7251

2021-10-16 Thread GitBox
michael-o commented on pull request #595: URL: https://github.com/apache/maven/pull/595#issuecomment-944916191 @famod Same for 3.8.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [maven] olamy commented on pull request #593: [MNG-7311] - Use Collections.singletonList

2021-10-16 Thread GitBox
olamy commented on pull request #593: URL: https://github.com/apache/maven/pull/593#issuecomment-944827876 are we sure we really want immutable lists in those places? it's not really a so easy change as it is not backward compatible... -- This is an automated message from the Apache Gi

[GitHub] [maven] cstamas commented on pull request #479: [MNG-7173] The maven-resolver-provider:MavenResolverModule is broken

2021-10-16 Thread GitBox
cstamas commented on pull request #479: URL: https://github.com/apache/maven/pull/479#issuecomment-944506272 Test will pass, but not done yet: module is getting huge, so probably needs some refactoring, maybe splitting them into several parts (and allow overrides). -- This is an automate

[GitHub] [maven] rmannibucau commented on pull request #565: Mojo API update proposal

2021-10-16 Thread GitBox
rmannibucau commented on pull request #565: URL: https://github.com/apache/maven/pull/565#issuecomment-944259010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[jira] [Commented] (MNG-6914) Align mvn and mvnw scripts

2021-10-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-6914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429603#comment-17429603 ] Hudson commented on MNG-6914: - Build unstable in Jenkins: Maven » Maven TLP » maven » master #2

[jira] [Commented] (MDEP-752) skip dependency analyze in ear packaging

2021-10-16 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MDEP-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429601#comment-17429601 ] Sylwester Lachiewicz commented on MDEP-752: --- Please re-create PR, now with GHA we

[jira] [Commented] (MDEP-752) skip dependency analyze in ear packaging

2021-10-16 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MDEP-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429592#comment-17429592 ] Slawomir Jaranowski commented on MDEP-752: -- Now ... I don't see any logs on Jenkin

[jira] [Assigned] (MDEP-752) skip dependency analyze in ear packaging

2021-10-16 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MDEP-752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned MDEP-752: - Assignee: (was: Sylwester Lachiewicz) > skip dependency analyze in ear packagi

[jira] [Commented] (MDEP-752) skip dependency analyze in ear packaging

2021-10-16 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MDEP-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429587#comment-17429587 ] Sylwester Lachiewicz commented on MDEP-752: --- I reverted it because build failed (

[jira] [Commented] (MDEP-752) skip dependency analyze in ear packaging

2021-10-16 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MDEP-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429586#comment-17429586 ] Slawomir Jaranowski commented on MDEP-752: -- First PR was merged ... next commit wa

[jira] [Updated] (MNG-7300) [Regression] Reloading web application (Enter) fails due to java.lang.ClassNotFoundException

2021-10-16 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-7300: Affects Version/s: 4.0.0-alpha-1 > [Regression] Reloading web application (Enter) fails due to > jav

[jira] [Created] (MNG-7312) Revert ThreadLocal approach from MNG-6843 and MNG-7251

2021-10-16 Thread Michael Osipov (Jira)
Michael Osipov created MNG-7312: --- Summary: Revert ThreadLocal approach from MNG-6843 and MNG-7251 Key: MNG-7312 URL: https://issues.apache.org/jira/browse/MNG-7312 Project: Maven Issue Type: Ta

[jira] [Updated] (MNG-7300) [Regression] Reloading web application (Enter) fails due to java.lang.ClassNotFoundException

2021-10-16 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-7300: Summary: [Regression] Reloading web application (Enter) fails due to java.lang.ClassNotFoundException

[jira] [Updated] (MRESOLVER-206) Upgrade Maven to 3.8.4

2021-10-16 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRESOLVER-206: - Summary: Upgrade Maven to 3.8.4 (was: Upgrade Maven to 3.8.3) > Upgrade Maven to 3.8.

[jira] [Commented] (MNG-7310) Maven loads plugin from another submodule

2021-10-16 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429548#comment-17429548 ] Michael Osipov commented on MNG-7310: - Finally clean commits pay out. Maybe this isn't