[GitHub] [maven-resolver] gnodet commented on pull request #88: [MRESOLVER-157] Drop ServiceLocator

2021-10-12 Thread GitBox
gnodet commented on pull request #88: URL: https://github.com/apache/maven-resolver/pull/88#issuecomment-941953408 @cstamas OSGi comes with a bunch of rules, similar to switching to JPMS if you investigated that bit. On this particular topic, if the packages do not depend directly on sisu

[GitHub] [maven-resolver] olamy commented on pull request #88: [MRESOLVER-157] Drop ServiceLocator

2021-10-12 Thread GitBox
olamy commented on pull request #88: URL: https://github.com/apache/maven-resolver/pull/88#issuecomment-941944509 how do you use now maven-resolver when not using sisu/guice just as a simple class instantiation? I bet few projects use it.. Such Jetty as here https://github.com/eclips

[jira] [Commented] (MDEP-775) Update velocity-tools from 2.0 to a newer version that doesn't depend on struts 1.3.8

2021-10-12 Thread Gazy Mahomar (Jira)
[ https://issues.apache.org/jira/browse/MDEP-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17428013#comment-17428013 ] Gazy Mahomar commented on MDEP-775: --- Heh. I already did. You try getting a large corporat

[GitHub] [maven-parent] dependabot[bot] opened a new pull request #31: Bump maven-shared-resources from 2 to 4

2021-10-12 Thread GitBox
dependabot[bot] opened a new pull request #31: URL: https://github.com/apache/maven-parent/pull/31 Bumps [maven-shared-resources](https://github.com/apache/maven-shared-resources) from 2 to 4. Commits See full diff in https://github.com/apache/maven-shared-resources/commits";

[GitHub] [maven] arturobernalg closed pull request #585: [MNG-7302] - Replace construction of FileInputStream and FileOutputStream objects with Files NIO APIs.

2021-10-12 Thread GitBox
arturobernalg closed pull request #585: URL: https://github.com/apache/maven/pull/585 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsub

[GitHub] [maven] arturobernalg opened a new pull request #585: [MNG-7302] - Replace construction of FileInputStream and FileOutputStream objects with Files NIO APIs.

2021-10-12 Thread GitBox
arturobernalg opened a new pull request #585: URL: https://github.com/apache/maven/pull/585 Following this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed

[jira] [Created] (MNG-7302) Replace construction of FileInputStream and FileOutputStream objects with Files NIO APIs.

2021-10-12 Thread Arturo Bernal (Jira)
Arturo Bernal created MNG-7302: -- Summary: Replace construction of FileInputStream and FileOutputStream objects with Files NIO APIs. Key: MNG-7302 URL: https://issues.apache.org/jira/browse/MNG-7302 Proje

[jira] [Created] (MNG-7301) Replace java.io Stream objects with Files NIO APIs.

2021-10-12 Thread Arturo Bernal (Jira)
Arturo Bernal created MNG-7301: -- Summary: Replace java.io Stream objects with Files NIO APIs. Key: MNG-7301 URL: https://issues.apache.org/jira/browse/MNG-7301 Project: Maven Issue Type: Improve

[GitHub] [maven-filtering] dependabot[bot] opened a new pull request #21: Bump commons-io from 2.6 to 2.11.0

2021-10-12 Thread GitBox
dependabot[bot] opened a new pull request #21: URL: https://github.com/apache/maven-filtering/pull/21 Bumps commons-io from 2.6 to 2.11.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=commons-io:commons-io&p

[GitHub] [maven-filtering] dependabot[bot] opened a new pull request #20: Bump org.eclipse.sisu.plexus from 0.0.0.M2a to 0.3.5

2021-10-12 Thread GitBox
dependabot[bot] opened a new pull request #20: URL: https://github.com/apache/maven-filtering/pull/20 Bumps org.eclipse.sisu.plexus from 0.0.0.M2a to 0.3.5. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.e

[jira] [Commented] (MDEP-775) Update velocity-tools from 2.0 to a newer version that doesn't depend on struts 1.3.8

2021-10-12 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MDEP-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427813#comment-17427813 ] Michael Osipov commented on MDEP-775: - Struts isn't used at all. There is no threat. Yo

[jira] [Commented] (MPLUGIN-375) Review Mojo descriptor params

2021-10-12 Thread Jira
[ https://issues.apache.org/jira/browse/MPLUGIN-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427803#comment-17427803 ] Tamás Cservenák commented on MPLUGIN-375: - I kinda vaguely remember something ab

[GitHub] [maven] rmannibucau edited a comment on pull request #565: Mojo API update proposal

2021-10-12 Thread GitBox
rmannibucau edited a comment on pull request #565: URL: https://github.com/apache/maven/pull/565#issuecomment-941099920 @michael-o yes and no, since the API has suppliers it is faster and more fluent to not use placeholders these days: > logger.info(() -> "I did " + that); -- This

[GitHub] [maven] rmannibucau commented on pull request #565: Mojo API update proposal

2021-10-12 Thread GitBox
rmannibucau commented on pull request #565: URL: https://github.com/apache/maven/pull/565#issuecomment-941099920 @michael-o yes and not, since the API has suppliers it is faster and more fluent to not use placeholders these days: > logger.info(() -> "I did " + that); -- This is an

[jira] [Created] (MDEP-775) Update velocity-tools from 2.0 to a newer version that doesn't depend on struts 1.3.8

2021-10-12 Thread Gazy Mahomar (Jira)
Gazy Mahomar created MDEP-775: - Summary: Update velocity-tools from 2.0 to a newer version that doesn't depend on struts 1.3.8 Key: MDEP-775 URL: https://issues.apache.org/jira/browse/MDEP-775 Project: Ma

[GitHub] [maven] michael-o commented on pull request #565: Mojo API update proposal

2021-10-12 Thread GitBox
michael-o commented on pull request #565: URL: https://github.com/apache/maven/pull/565#issuecomment-941068464 > > > @michael-o if you mean JULi I will not dig but if you mean JUL I think it is wrong. Technically JUL is 1-1 with slf4j without drawbacks SLF4J brings for a plugin sys

[jira] [Commented] (MPLUGIN-375) Review Mojo descriptor params

2021-10-12 Thread Simon (Jira)
[ https://issues.apache.org/jira/browse/MPLUGIN-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427707#comment-17427707 ] Simon commented on MPLUGIN-375: --- Thx a lot for this clarification. 🙏 I understand that th

[GitHub] [maven] rmannibucau commented on pull request #565: Mojo API update proposal

2021-10-12 Thread GitBox
rmannibucau commented on pull request #565: URL: https://github.com/apache/maven/pull/565#issuecomment-941062402 @michael-o if you mean JULi I will not dig but if you mean JUL I think it is wrong. Technically JUL is 1-1 with slf4j without drawbacks SLF4J brings for a plugin system like moj

[jira] [Comment Edited] (MPLUGIN-375) Review Mojo descriptor params

2021-10-12 Thread Jira
[ https://issues.apache.org/jira/browse/MPLUGIN-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427700#comment-17427700 ] Tamás Cservenák edited comment on MPLUGIN-375 at 10/12/21, 2:18 PM: --

[jira] [Commented] (MPLUGIN-375) Review Mojo descriptor params

2021-10-12 Thread Jira
[ https://issues.apache.org/jira/browse/MPLUGIN-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427700#comment-17427700 ] Tamás Cservenák commented on MPLUGIN-375: - Truth is, am unsure when was it added

[jira] [Commented] (MPLUGIN-375) Review Mojo descriptor params

2021-10-12 Thread Simon (Jira)
[ https://issues.apache.org/jira/browse/MPLUGIN-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427695#comment-17427695 ] Simon commented on MPLUGIN-375: --- Just to be sure I get you correctly, with recent version

[GitHub] [maven] michael-o commented on pull request #584: Fix MojoDescriptor

2021-10-12 Thread GitBox
michael-o commented on pull request #584: URL: https://github.com/apache/maven/pull/584#issuecomment-941045830 Ah ok, maybe this should be in one PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [maven] cstamas commented on pull request #584: Fix MojoDescriptor

2021-10-12 Thread GitBox
cstamas commented on pull request #584: URL: https://github.com/apache/maven/pull/584#issuecomment-941039127 Nope, just @slachiewicz throwed together a test, it all started there https://github.com/apache/maven/pull/291 -- This is an automated message from the Apache Git Service. To resp

[jira] [Commented] (MPLUGIN-375) Review Mojo descriptor params

2021-10-12 Thread Jira
[ https://issues.apache.org/jira/browse/MPLUGIN-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427689#comment-17427689 ] Tamás Cservenák commented on MPLUGIN-375: - Correct, these params are not used in

[GitHub] [maven] michael-o commented on pull request #584: Fix MojoDescriptor

2021-10-12 Thread GitBox
michael-o commented on pull request #584: URL: https://github.com/apache/maven/pull/584#issuecomment-941030223 Is there a JIRA issue for this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven] michael-o commented on pull request #565: Mojo API update proposal

2021-10-12 Thread GitBox
michael-o commented on pull request #565: URL: https://github.com/apache/maven/pull/565#issuecomment-941029226 > > > @cstamas the only agreement was for @apache/maven project. For the API there is no slf4j agreement but the agreement to get a logging API. Since JUL is the built-in

[jira] [Commented] (MPLUGIN-375) Review Mojo descriptor params

2021-10-12 Thread Simon (Jira)
[ https://issues.apache.org/jira/browse/MPLUGIN-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427676#comment-17427676 ] Simon commented on MPLUGIN-375: --- I have a mojo which is using `inheritByDefault=false` ann

[GitHub] [maven] rfscholte commented on pull request #580: simplify, reorganise and document apache-maven-wrapper distribution

2021-10-12 Thread GitBox
rfscholte commented on pull request #580: URL: https://github.com/apache/maven/pull/580#issuecomment-941006328 My feeling is that it would overcomplicate a release of Maven. I'm not convinced by the argument of a bug in the script. If that would be the case, the bug is also in the maven

[GitHub] [maven-resolver] cstamas commented on pull request #88: [MRESOLVER-157] Drop ServiceLocator

2021-10-12 Thread GitBox
cstamas commented on pull request #88: URL: https://github.com/apache/maven-resolver/pull/88#issuecomment-940972322 @gnodet ping ^ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[jira] [Commented] (MRELEASE-927) Releasing flat multi-module projects using git

2021-10-12 Thread Tobias Schellien (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427645#comment-17427645 ] Tobias Schellien commented on MRELEASE-927: --- when are  you planning to solve

[GitHub] [maven] rmannibucau commented on pull request #565: Mojo API update proposal

2021-10-12 Thread GitBox
rmannibucau commented on pull request #565: URL: https://github.com/apache/maven/pull/565#issuecomment-940951770 @cstamas the only agreement was for @apache/maven project. For the API there is no slf4j agreement but the agreement to get a logging API. Since JUL is the built-in and well kn

[GitHub] [maven-resolver] gnodet commented on a change in pull request #129: Update build plugins

2021-10-12 Thread GitBox
gnodet commented on a change in pull request #129: URL: https://github.com/apache/maven-resolver/pull/129#discussion_r727055549 ## File path: pom.xml ## @@ -433,7 +442,7 @@ biz.aQute.bnd bnd-maven-plugin - 5.1.2 + 6.0.0 Review

[jira] [Commented] (MNG-7300) Reloading web application (Enter) fails due to java.lang.ClassNotFoundException

2021-10-12 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427631#comment-17427631 ] Michael Osipov commented on MNG-7300: - [~malvarezdiaz], thanks. The confirmation for PR

[jira] [Commented] (MNG-7283) add dependency when maven exec

2021-10-12 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427632#comment-17427632 ] Michael Osipov commented on MNG-7283: - bq. There is another confusing question. Does *s

[GitHub] [maven] cstamas commented on pull request #291: [MNG-6776] Inconsistent list of parameters for MojoDescriptor (testcase)

2021-10-12 Thread GitBox
cstamas commented on pull request #291: URL: https://github.com/apache/maven/pull/291#issuecomment-940916163 Yup, this is wrong, but: these classes are NOT used/mutated at runtime, but are populated from sources (buildtime) and populated from XML (runtime). Still, this leaves a room for im

[GitHub] [maven] cstamas opened a new pull request #584: Fix MojoDescriptor

2021-10-12 Thread GitBox
cstamas opened a new pull request #584: URL: https://github.com/apache/maven/pull/584 It may lead to confusion as parameters (list) and parametersMap (map) may "fall apart" easily. Also, parametersMap did not honor parameter ordering while parameters list makes it look that o

[jira] [Commented] (MNG-7283) add dependency when maven exec

2021-10-12 Thread wangjie (Jira)
[ https://issues.apache.org/jira/browse/MNG-7283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427626#comment-17427626 ] wangjie commented on MNG-7283: -- you point seems right. i need to take deep look on SCM, Wagon

[jira] [Commented] (MNG-7300) Reloading web application (Enter) fails due to java.lang.ClassNotFoundException

2021-10-12 Thread Jira
[ https://issues.apache.org/jira/browse/MNG-7300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427625#comment-17427625 ] Manuel Álvarez Díaz commented on MNG-7300: -- I tried [https://github.com/apache/mav

[GitHub] [maven] cstamas edited a comment on pull request #580: simplify, reorganise and document apache-maven-wrapper distribution

2021-10-12 Thread GitBox
cstamas edited a comment on pull request #580: URL: https://github.com/apache/maven/pull/580#issuecomment-940898997 Just some thoughts popping out here: > they have exactly the same lifecycle, because they contain a (intended) hard version of Maven Why? I mean, isn't (some fut

[GitHub] [maven] cstamas commented on pull request #565: Mojo API update proposal

2021-10-12 Thread GitBox
cstamas commented on pull request #565: URL: https://github.com/apache/maven/pull/565#issuecomment-940901629 @rmannibucau please stop with "why not...". We had this (long) discussion, it was resolved, and this is where we are with it. All the enumerated things stand for slf4j as well, sans

[GitHub] [maven] cstamas commented on pull request #580: simplify, reorganise and document apache-maven-wrapper distribution

2021-10-12 Thread GitBox
cstamas commented on pull request #580: URL: https://github.com/apache/maven/pull/580#issuecomment-940898997 Just some thoughts popping out here: > they have exactly the same lifecycle, because they contain a (intended) hard version of Maven Why? I mean, isn't (some future) sc

[GitHub] [maven] rmannibucau commented on pull request #565: Mojo API update proposal

2021-10-12 Thread GitBox
rmannibucau commented on pull request #565: URL: https://github.com/apache/maven/pull/565#issuecomment-940897889 Maybe off topic: but why not using JUL API? it is lazy, standard, dep free and built-in. Can also be made working and wired to whatever maven picked as logger impl out of the bo

[GitHub] [maven-resolver] cstamas commented on a change in pull request #129: Update build plugins

2021-10-12 Thread GitBox
cstamas commented on a change in pull request #129: URL: https://github.com/apache/maven-resolver/pull/129#discussion_r726990108 ## File path: pom.xml ## @@ -433,7 +442,7 @@ biz.aQute.bnd bnd-maven-plugin - 5.1.2 + 6.0.0 Review

[GitHub] [maven] cstamas edited a comment on pull request #565: Mojo API update proposal

2021-10-12 Thread GitBox
cstamas edited a comment on pull request #565: URL: https://github.com/apache/maven/pull/565#issuecomment-940876114 > Hi, as you ping me there for the replacement of #437 and #438 here is what I can tell you. Thanks for reaching out! > When I created the PRs, I was looking for

[GitHub] [maven-resolver] slachiewicz commented on a change in pull request #129: Update build plugins

2021-10-12 Thread GitBox
slachiewicz commented on a change in pull request #129: URL: https://github.com/apache/maven-resolver/pull/129#discussion_r726987976 ## File path: pom.xml ## @@ -433,7 +442,7 @@ biz.aQute.bnd bnd-maven-plugin - 5.1.2 + 6.0.0 Re

[GitHub] [maven] cstamas edited a comment on pull request #565: Mojo API update proposal

2021-10-12 Thread GitBox
cstamas edited a comment on pull request #565: URL: https://github.com/apache/maven/pull/565#issuecomment-940876114 > Hi, as you ping me there for the replacement of #437 and #438 here is what I can tell you. Thanks for reaching out! > When I created the PRs, I was looking for

[GitHub] [maven] cstamas edited a comment on pull request #565: Mojo API update proposal

2021-10-12 Thread GitBox
cstamas edited a comment on pull request #565: URL: https://github.com/apache/maven/pull/565#issuecomment-940876114 > Hi, as you ping me there for the replacement of #437 and #438 here is what I can tell you. Thanks for reaching out! > When I created the PRs, I was looking for

[GitHub] [maven] cstamas edited a comment on pull request #565: Mojo API update proposal

2021-10-12 Thread GitBox
cstamas edited a comment on pull request #565: URL: https://github.com/apache/maven/pull/565#issuecomment-940876114 > Hi, as you ping me there for the replacement of #437 and #438 here is what I can tell you. Thanks for reaching out! > When I created the PRs, I was looking for

[GitHub] [maven] cstamas commented on pull request #565: Mojo API update proposal

2021-10-12 Thread GitBox
cstamas commented on pull request #565: URL: https://github.com/apache/maven/pull/565#issuecomment-940876114 > Hi, as you ping me there for the replacement of #437 and #438 here is what I can tell you. Thanks for reaching out! > When I created the PRs, I was looking for a stan

[GitHub] [maven-resolver] cstamas commented on pull request #129: Update build plugins

2021-10-12 Thread GitBox
cstamas commented on pull request #129: URL: https://github.com/apache/maven-resolver/pull/129#issuecomment-940869306 @michael-o ping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Comment Edited] (MCHECKSTYLE-406) Make plugin compatible with Checkstyle 8.44

2021-10-12 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427577#comment-17427577 ] Alexander Kriegisch edited comment on MCHECKSTYLE-406 at 10/12/21, 9:21 AM: --

[jira] [Commented] (MCHECKSTYLE-406) Make plugin compatible with Checkstyle 8.44

2021-10-12 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427577#comment-17427577 ] Alexander Kriegisch commented on MCHECKSTYLE-406: - Update: maven-sha

[jira] [Commented] (MNG-7300) Reloading web application (Enter) fails due to java.lang.ClassNotFoundException

2021-10-12 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427559#comment-17427559 ] Michael Osipov commented on MNG-7300: - [~malvarezdiaz], there is ongoing work: https://

[jira] [Assigned] (MNG-7300) Reloading web application (Enter) fails due to java.lang.ClassNotFoundException

2021-10-12 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MNG-7300: --- Assignee: Michael Osipov > Reloading web application (Enter) fails due to > java.lang.ClassNo

[jira] [Updated] (MNG-7300) Reloading web application (Enter) fails due to java.lang.ClassNotFoundException

2021-10-12 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-7300: Fix Version/s: 3.8.x-candidate 4.0.x-candidate > Reloading web application (Enter)

[jira] [Commented] (MNG-6914) Align mvn and mvnw scripts

2021-10-12 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-6914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427530#comment-17427530 ] Hudson commented on MNG-6914: - Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-6914_

[jira] [Commented] (MNG-7300) Reloading web application (Enter) fails due to java.lang.ClassNotFoundException

2021-10-12 Thread Jira
[ https://issues.apache.org/jira/browse/MNG-7300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427527#comment-17427527 ] Manuel Álvarez Díaz commented on MNG-7300: -- https://issues.apache.org/jira/browse/

[jira] [Commented] (MNG-7300) Reloading web application (Enter) fails due to java.lang.ClassNotFoundException

2021-10-12 Thread Olivier Lamy (Jira)
[ https://issues.apache.org/jira/browse/MNG-7300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427523#comment-17427523 ] Olivier Lamy commented on MNG-7300: --- definitely due to the thread local problem in collec

[jira] [Created] (MNG-7300) Reloading web application (Enter) fails due to java.lang.ClassNotFoundException

2021-10-12 Thread Jira
Manuel Álvarez Díaz created MNG-7300: Summary: Reloading web application (Enter) fails due to java.lang.ClassNotFoundException Key: MNG-7300 URL: https://issues.apache.org/jira/browse/MNG-7300 Pro