[GitHub] [maven-archetype] dependabot[bot] opened a new pull request #74: Bump maven-artifact-transfer from 0.12.0 to 0.13.1

2021-09-30 Thread GitBox
dependabot[bot] opened a new pull request #74: URL: https://github.com/apache/maven-archetype/pull/74 Bumps [maven-artifact-transfer](https://github.com/apache/maven-artifact-transfer) from 0.12.0 to 0.13.1. Commits https://github.com/apache/maven-artifact-transfer/commit/ee4

[jira] [Updated] (MNG-7253) Relocation message is never shown

2021-09-30 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MNG-7253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MNG-7253: --- Description: The {{relocation}} element as defined in  [https://maven.apache.org/ref/3.8.2/maven-model/

[jira] [Updated] (MNG-7253) Relocation message is never shown

2021-09-30 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MNG-7253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MNG-7253: --- Description: The {{relocation}} element as defined in  [https://maven.apache.org/ref/3.8.2/maven-model/

[jira] [Commented] (MINVOKER-282) Can't use mvnDebug since Maven 3.8.1

2021-09-30 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MINVOKER-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423079#comment-17423079 ] Herve Boutemy commented on MINVOKER-282: could it be related to MNG-7090 ? > C

[jira] [Commented] (MINVOKER-283) Change in behaviour with maven 3.8.2, invoker plugin is trying to install its parent

2021-09-30 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MINVOKER-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423077#comment-17423077 ] Herve Boutemy commented on MINVOKER-283: Maven 3.8.3 is currently being release

[GitHub] [maven] lujiefsi opened a new pull request #561: [MNG-7275] - fixing resource leak due to Files.list

2021-09-30 Thread GitBox
lujiefsi opened a new pull request #561: URL: https://github.com/apache/maven/pull/561 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for th

[jira] [Commented] (MSHARED-997) Failed / error test DefaultProjectDependencyAnalyzerTest in maven-dependency-analyzer

2021-09-30 Thread Piotr Zygielo (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423015#comment-17423015 ] Piotr Zygielo commented on MSHARED-997: --- For that reason (Unrecognised tag: 'block

[jira] [Commented] (MSHARED-997) Failed / error test DefaultProjectDependencyAnalyzerTest in maven-dependency-analyzer

2021-09-30 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423012#comment-17423012 ] Slawomir Jaranowski commented on MSHARED-997: - with commit {{a79910e73809f45

[GitHub] [maven] khmarbaise opened a new pull request #560: [MNG-7277] - Remove useless Test - testNonNumericVersionRepresentatio…

2021-09-30 Thread GitBox
khmarbaise opened a new pull request #560: URL: https://github.com/apache/maven/pull/560 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed

[jira] [Commented] (MSHARED-997) Failed / error test DefaultProjectDependencyAnalyzerTest in maven-dependency-analyzer

2021-09-30 Thread Piotr Zygielo (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422992#comment-17422992 ] Piotr Zygielo commented on MSHARED-997: --- 15150191f9309abfe06bff82680313c903532506

[jira] [Updated] (MNG-7277) Remove useless Test - testNonNumericVersionRepresentationReturnsANumberFormatException

2021-09-30 Thread Karl Heinz Marbaise (Jira)
[ https://issues.apache.org/jira/browse/MNG-7277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise updated MNG-7277: - Summary: Remove useless Test - testNonNumericVersionRepresentationReturnsANumberFormatExcep

[jira] [Updated] (MNG-7277) Remove Wrong or useless Tests

2021-09-30 Thread Karl Heinz Marbaise (Jira)
[ https://issues.apache.org/jira/browse/MNG-7277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise updated MNG-7277: - Description: Currently the following test: {code:java} public void testNonNumericVersi

[jira] [Updated] (MNG-7277) Remove Wrong or useless Tests

2021-09-30 Thread Karl Heinz Marbaise (Jira)
[ https://issues.apache.org/jira/browse/MNG-7277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise updated MNG-7277: - Description: Currently the following test: {code:java} public void testNonNumericVersi

[jira] [Updated] (MNG-7277) Remove Wrong or useless Tests

2021-09-30 Thread Karl Heinz Marbaise (Jira)
[ https://issues.apache.org/jira/browse/MNG-7277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise updated MNG-7277: - Description: Currently the following test: {code:java} public void testNonNumericVersi

[jira] [Updated] (MNG-7277) Remove Wrong or useless Tests

2021-09-30 Thread Karl Heinz Marbaise (Jira)
[ https://issues.apache.org/jira/browse/MNG-7277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise updated MNG-7277: - Description: Currently the following test: {code:java} public void testNonNumericVersi

[jira] [Updated] (MNG-7277) Remove Wrong or useless Tests

2021-09-30 Thread Karl Heinz Marbaise (Jira)
[ https://issues.apache.org/jira/browse/MNG-7277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise updated MNG-7277: - Summary: Remove Wrong or useless Tests (was: Wrong Test - testNonNumericVersionRepresentat

[jira] [Updated] (MNG-7277) Wrong Test - testNonNumericVersionRepresentationReturnsANumberFormatException

2021-09-30 Thread Karl Heinz Marbaise (Jira)
[ https://issues.apache.org/jira/browse/MNG-7277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise updated MNG-7277: - Description: Currently the following test: {code:java} public void testNonNumericVersi

[jira] [Updated] (MNG-7277) Wrong Test - testNonNumericVersionRepresentationReturnsANumberFormatException

2021-09-30 Thread Karl Heinz Marbaise (Jira)
[ https://issues.apache.org/jira/browse/MNG-7277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise updated MNG-7277: - Description: Currently the following test: {code:java} public void testNonNumericVersi

[jira] [Assigned] (MNG-7277) Wrong Test - testNonNumericVersionRepresentationReturnsANumberFormatException

2021-09-30 Thread Karl Heinz Marbaise (Jira)
[ https://issues.apache.org/jira/browse/MNG-7277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise reassigned MNG-7277: Assignee: Karl Heinz Marbaise > Wrong Test - testNonNumericVersionRepresentationRetu

[jira] [Commented] (MENFORCER-394) DependencyConvergence in 3.0.0 fails on provided scoped dependencies

2021-09-30 Thread Adam Gent (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422978#comment-17422978 ] Adam Gent commented on MENFORCER-394: - Same here. Its a little shocking that going

[jira] [Created] (MNG-7277) Wrong Test - testNonNumericVersionRepresentationReturnsANumberFormatException

2021-09-30 Thread Karl Heinz Marbaise (Jira)
Karl Heinz Marbaise created MNG-7277: Summary: Wrong Test - testNonNumericVersionRepresentationReturnsANumberFormatException Key: MNG-7277 URL: https://issues.apache.org/jira/browse/MNG-7277 Proje

[jira] [Commented] (MNG-7274) JUnit Jupiter via BOM

2021-09-30 Thread Karl Heinz Marbaise (Jira)
[ https://issues.apache.org/jira/browse/MNG-7274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422925#comment-17422925 ] Karl Heinz Marbaise commented on MNG-7274: -- Done in [038201e31423f329afdc5695a417

[jira] [Closed] (MNG-7274) JUnit Jupiter via BOM

2021-09-30 Thread Karl Heinz Marbaise (Jira)
[ https://issues.apache.org/jira/browse/MNG-7274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise closed MNG-7274. Resolution: Done > JUnit Jupiter via BOM > - > > Key: MNG

[GitHub] [maven] asfgit merged pull request #559: [MNG-7274] - JUnit Jupiter via BOM

2021-09-30 Thread GitBox
asfgit merged pull request #559: URL: https://github.com/apache/maven/pull/559 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[jira] [Created] (MNG-7276) Refactoring - Umbrella

2021-09-30 Thread Karl Heinz Marbaise (Jira)
Karl Heinz Marbaise created MNG-7276: Summary: Refactoring - Umbrella Key: MNG-7276 URL: https://issues.apache.org/jira/browse/MNG-7276 Project: Maven Issue Type: Improvement Affects

[jira] [Updated] (MNG-7275) Resource leak due to Files.list()

2021-09-30 Thread Karl Heinz Marbaise (Jira)
[ https://issues.apache.org/jira/browse/MNG-7275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise updated MNG-7275: - Priority: Minor (was: Major) > Resource leak due to Files.list() > ---

[jira] [Updated] (MNG-7275) Resource leak due to Files.list()

2021-09-30 Thread Karl Heinz Marbaise (Jira)
[ https://issues.apache.org/jira/browse/MNG-7275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise updated MNG-7275: - Issue Type: Improvement (was: Bug) > Resource leak due to Files.list() > -

[jira] [Commented] (MNG-7275) Resource leak due to Files.list()

2021-09-30 Thread Karl Heinz Marbaise (Jira)
[ https://issues.apache.org/jira/browse/MNG-7275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422918#comment-17422918 ] Karl Heinz Marbaise commented on MNG-7275: -- Would you like to offer a patch for th

[jira] [Created] (MSHARED-997) Failed / error test DefaultProjectDependencyAnalyzerTest in maven-dependency-analyzer

2021-09-30 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MSHARED-997: --- Summary: Failed / error test DefaultProjectDependencyAnalyzerTest in maven-dependency-analyzer Key: MSHARED-997 URL: https://issues.apache.org/jira/browse/MSHARED-99

[GitHub] [maven] gnodet edited a comment on pull request #552: [MNG-7260] [MNG-7266] Remove maven-compat module

2021-09-30 Thread GitBox
gnodet edited a comment on pull request #552: URL: https://github.com/apache/maven/pull/552#issuecomment-931428987 The `ArtifactDeployer` and `ArtifactInstaller`, `ArtifactCollector`, `ArtifactResolver` interfaces contains various methods used in https://github.com/apache/maven-integration

[GitHub] [maven] gnodet edited a comment on pull request #552: [MNG-7260] [MNG-7266] Remove maven-compat module

2021-09-30 Thread GitBox
gnodet edited a comment on pull request #552: URL: https://github.com/apache/maven/pull/552#issuecomment-931428987 The `ArtifactDeployer` and `ArtifactInstaller`, `ArtifactCollector` interfaces contains various methods used in https://github.com/apache/maven-integration-testing/blob/master

[GitHub] [maven] gnodet commented on pull request #552: [MNG-7260] [MNG-7266] Remove maven-compat module

2021-09-30 Thread GitBox
gnodet commented on pull request #552: URL: https://github.com/apache/maven/pull/552#issuecomment-931428987 The `ArtifactDeployer` and `ArtifactInstaller` interfaces contains two methods for installing / deploying artifacts. The `ArtifactInstaller` at least is used in https://github.com/

[GitHub] [maven-enforcer] dependabot[bot] opened a new pull request #112: Bump extra-enforcer-rules from 1.3 to 1.4

2021-09-30 Thread GitBox
dependabot[bot] opened a new pull request #112: URL: https://github.com/apache/maven-enforcer/pull/112 Bumps [extra-enforcer-rules](https://github.com/mojohaus/extra-enforcer-rules) from 1.3 to 1.4. Release notes Sourced from https://github.com/mojohaus/extra-enforcer-rules/relea

[GitHub] [maven] cstamas commented on pull request #554: [MNG-6898] Drop plexus-component-metadata plugin from maven-core

2021-09-30 Thread GitBox
cstamas commented on pull request #554: URL: https://github.com/apache/maven/pull/554#issuecomment-931375327 > I suppose fixing sisu so that `@Inject` would take care of plexus visibility rules has been considered and discarded ? Yes, as SISU does not have a notion on ClassRealm (and

[GitHub] [maven] gnodet commented on pull request #554: [MNG-6898] Drop plexus-component-metadata plugin from maven-core

2021-09-30 Thread GitBox
gnodet commented on pull request #554: URL: https://github.com/apache/maven/pull/554#issuecomment-931370896 > > Looks good to me. I would only check impact on performance, because previously everything was stored in singleton/map and here we have calls for every component lookup. >

[GitHub] [maven] cstamas commented on pull request #554: [MNG-6898] Drop plexus-component-metadata plugin from maven-core

2021-09-30 Thread GitBox
cstamas commented on pull request #554: URL: https://github.com/apache/maven/pull/554#issuecomment-931343189 Opps -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [maven] cstamas edited a comment on pull request #554: [MNG-6898] Drop plexus-component-metadata plugin from maven-core

2021-09-30 Thread GitBox
cstamas edited a comment on pull request #554: URL: https://github.com/apache/maven/pull/554#issuecomment-931341771 > Looks good to me. I would only check impact on performance, because previously everything was stored in singleton/map and here we have calls for every component lookup.

[GitHub] [maven] cstamas closed pull request #554: [MNG-6898] Drop plexus-component-metadata plugin from maven-core

2021-09-30 Thread GitBox
cstamas closed pull request #554: URL: https://github.com/apache/maven/pull/554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[GitHub] [maven] cstamas commented on pull request #554: [MNG-6898] Drop plexus-component-metadata plugin from maven-core

2021-09-30 Thread GitBox
cstamas commented on pull request #554: URL: https://github.com/apache/maven/pull/554#issuecomment-931341771 > Looks good to me. I would only check impact on performance, because previously everything was stored in singleton/map and here we have calls for every component lookup. Sis

[GitHub] [maven] slachiewicz commented on pull request #554: [MNG-6898] Drop plexus-component-metadata plugin from maven-core

2021-09-30 Thread GitBox
slachiewicz commented on pull request #554: URL: https://github.com/apache/maven/pull/554#issuecomment-931340300 Looks good to me. I would only check impact on performance, because previously everything was stored in singleton/map and here we have calls for every component lookup. -- Th

[jira] [Resolved] (MPMD-327) Upgrade to PMD 6.39.0

2021-09-30 Thread Andreas Dangel (Jira)
[ https://issues.apache.org/jira/browse/MPMD-327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Dangel resolved MPMD-327. - Resolution: Fixed > Upgrade to PMD 6.39.0 > - > > Key: MPMD-327

[jira] [Comment Edited] (MPMD-327) Upgrade to PMD 6.39.0

2021-09-30 Thread Andreas Dangel (Jira)
[ https://issues.apache.org/jira/browse/MPMD-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422796#comment-17422796 ] Andreas Dangel edited comment on MPMD-327 at 9/30/21, 1:43 PM: --

[jira] [Commented] (MPMD-327) Upgrade to PMD 6.39.0

2021-09-30 Thread Andreas Dangel (Jira)
[ https://issues.apache.org/jira/browse/MPMD-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422796#comment-17422796 ] Andreas Dangel commented on MPMD-327: - Update to PMD 6.39.0: https://gitbox.apache.org

[jira] [Closed] (MPMD-325) Could not find class due to IncompatibleClassChangeError warning

2021-09-30 Thread Andreas Dangel (Jira)
[ https://issues.apache.org/jira/browse/MPMD-325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Dangel closed MPMD-325. --- Resolution: Fixed > Could not find class due to IncompatibleClassChangeError warning >

[jira] [Commented] (MPMD-326) Set Maven 3.1.1 as minimum version

2021-09-30 Thread Andreas Dangel (Jira)
[ https://issues.apache.org/jira/browse/MPMD-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422794#comment-17422794 ] Andreas Dangel commented on MPMD-326: - Fixed with https://gitbox.apache.org/repos/asf?

[jira] [Closed] (MPMD-326) Set Maven 3.1.1 as minimum version

2021-09-30 Thread Andreas Dangel (Jira)
[ https://issues.apache.org/jira/browse/MPMD-326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Dangel closed MPMD-326. --- Resolution: Fixed > Set Maven 3.1.1 as minimum version > -- > >

[jira] [Commented] (MPMD-325) Could not find class due to IncompatibleClassChangeError warning

2021-09-30 Thread Andreas Dangel (Jira)
[ https://issues.apache.org/jira/browse/MPMD-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422795#comment-17422795 ] Andreas Dangel commented on MPMD-325: - Fixed by MPMD-326, verified by additional tests

[GitHub] [maven-pmd-plugin] adangel merged pull request #47: [MPMD-325] Could not find class due to IncompatibleClassChangeError warning

2021-09-30 Thread GitBox
adangel merged pull request #47: URL: https://github.com/apache/maven-pmd-plugin/pull/47 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [maven] khmarbaise opened a new pull request #559: [MNG-7274] - JUnit Jupiter via BOM

2021-09-30 Thread GitBox
khmarbaise opened a new pull request #559: URL: https://github.com/apache/maven/pull/559 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for

[GitHub] [maven] cstamas commented on a change in pull request #554: [MNG-6898] Drop plexus-component-metadata plugin from maven-core

2021-09-30 Thread GitBox
cstamas commented on a change in pull request #554: URL: https://github.com/apache/maven/pull/554#discussion_r719404588 ## File path: maven-core/src/test/resources/META-INF/plexus/components.xml ## @@ -1,107 +0,0 @@ - Review comment: Yes, but frankly, this XML was unuse

[GitHub] [maven] cstamas commented on pull request #555: [MNG-7055] Fix G level metadata handling

2021-09-30 Thread GitBox
cstamas commented on pull request #555: URL: https://github.com/apache/maven/pull/555#issuecomment-931320282 > Does this mean that the `AddPluginArtifactMetadataMojo` from maven-plugin-plugin is completely useless ? This is actually one of the pain point because it depends on the `GroupRep

[GitHub] [maven] gnodet commented on a change in pull request #554: [MNG-6898] Drop plexus-component-metadata plugin from maven-core

2021-09-30 Thread GitBox
gnodet commented on a change in pull request #554: URL: https://github.com/apache/maven/pull/554#discussion_r719401108 ## File path: maven-core/src/test/resources/META-INF/plexus/components.xml ## @@ -1,107 +0,0 @@ - Review comment: That's unrelated right ? It's just a

[GitHub] [maven] gnodet commented on pull request #555: [MNG-7055] Fix G level metadata handling

2021-09-30 Thread GitBox
gnodet commented on pull request #555: URL: https://github.com/apache/maven/pull/555#issuecomment-931316580 Does this mean that the `AddPluginArtifactMetadataMojo` from maven-plugin-plugin is completely useless ? This is actually one of the pain point because it depends on the `GroupRepos

[GitHub] [maven] jmtd commented on pull request #556: [MNG-7270] Switch to shell alternative to "which"

2021-09-30 Thread GitBox
jmtd commented on pull request #556: URL: https://github.com/apache/maven/pull/556#issuecomment-931290865 I'm not sure whether this level of complication is warranted in the patch itself (and I'd love your input on that), but, via [1](https://unix.stackexchange.com/a/188365), the following

[GitHub] [maven-integration-testing] cstamas closed pull request #114: Fix IT0138: the m-plugin-p mojo is removed from maven-plugin lifecycle

2021-09-30 Thread GitBox
cstamas closed pull request #114: URL: https://github.com/apache/maven-integration-testing/pull/114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [maven-integration-testing] cstamas commented on pull request #114: Fix IT0138: the m-plugin-p mojo is removed from maven-plugin lifecycle

2021-09-30 Thread GitBox
cstamas commented on pull request #114: URL: https://github.com/apache/maven-integration-testing/pull/114#issuecomment-931266787 Lifecycle in related PR went back to "no change" so this PR is obsolete, dropping it -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [maven] khmarbaise commented on a change in pull request #558: [MNG-7272] - Code Improvement - II

2021-09-30 Thread GitBox
khmarbaise commented on a change in pull request #558: URL: https://github.com/apache/maven/pull/558#discussion_r719314728 ## File path: maven-core/src/main/java/org/apache/maven/graph/DefaultProjectDependencyGraph.java ## @@ -61,39 +61,25 @@ * @throws DuplicateProjectEx

[GitHub] [maven] khmarbaise commented on a change in pull request #558: [MNG-7272] - Code Improvement - II

2021-09-30 Thread GitBox
khmarbaise commented on a change in pull request #558: URL: https://github.com/apache/maven/pull/558#discussion_r719314728 ## File path: maven-core/src/main/java/org/apache/maven/graph/DefaultProjectDependencyGraph.java ## @@ -61,39 +61,25 @@ * @throws DuplicateProjectEx

[GitHub] [maven] khmarbaise commented on a change in pull request #558: [MNG-7272] - Code Improvement - II

2021-09-30 Thread GitBox
khmarbaise commented on a change in pull request #558: URL: https://github.com/apache/maven/pull/558#discussion_r719306831 ## File path: maven-core/src/main/java/org/apache/maven/graph/DefaultProjectDependencyGraph.java ## @@ -61,39 +61,25 @@ * @throws DuplicateProjectEx

[GitHub] [maven] rfscholte commented on a change in pull request #558: [MNG-7272] - Code Improvement - II

2021-09-30 Thread GitBox
rfscholte commented on a change in pull request #558: URL: https://github.com/apache/maven/pull/558#discussion_r719305664 ## File path: maven-core/src/main/java/org/apache/maven/graph/DefaultProjectDependencyGraph.java ## @@ -61,39 +61,25 @@ * @throws DuplicateProjectExc

[GitHub] [maven] michael-o commented on a change in pull request #558: [MNG-7272] - Code Improvement - II

2021-09-30 Thread GitBox
michael-o commented on a change in pull request #558: URL: https://github.com/apache/maven/pull/558#discussion_r719304708 ## File path: maven-core/src/main/java/org/apache/maven/graph/DefaultProjectDependencyGraph.java ## @@ -61,39 +61,25 @@ * @throws DuplicateProjectExc

[GitHub] [maven] khmarbaise commented on a change in pull request #558: [MNG-7272] - Code Improvement - II

2021-09-30 Thread GitBox
khmarbaise commented on a change in pull request #558: URL: https://github.com/apache/maven/pull/558#discussion_r719301712 ## File path: maven-core/src/main/java/org/apache/maven/graph/DefaultProjectDependencyGraph.java ## @@ -61,39 +61,25 @@ * @throws DuplicateProjectEx

[GitHub] [maven] rfscholte commented on a change in pull request #558: [MNG-7272] - Code Improvement - II

2021-09-30 Thread GitBox
rfscholte commented on a change in pull request #558: URL: https://github.com/apache/maven/pull/558#discussion_r719298137 ## File path: maven-core/src/main/java/org/apache/maven/graph/DefaultProjectDependencyGraph.java ## @@ -61,39 +61,25 @@ * @throws DuplicateProjectExc

[GitHub] [maven] jmtd commented on pull request #556: [MNG-7270] Switch to shell alternative to "which"

2021-09-30 Thread GitBox
jmtd commented on pull request #556: URL: https://github.com/apache/maven/pull/556#issuecomment-931219516 > I tried your script on the POSIX shell on HP-UX, the result is quite surpring: Thanks! I no longer have (easy) access to the less common UNIXes. (My go-to- awkward shell for t

[GitHub] [maven] michael-o commented on a change in pull request #558: [MNG-7272] - Code Improvement - II

2021-09-30 Thread GitBox
michael-o commented on a change in pull request #558: URL: https://github.com/apache/maven/pull/558#discussion_r719294804 ## File path: maven-core/src/main/java/org/apache/maven/graph/DefaultProjectDependencyGraph.java ## @@ -61,39 +61,25 @@ * @throws DuplicateProjectExc

[GitHub] [maven] michael-o edited a comment on pull request #556: [MNG-7270] Switch to shell alternative to "which"

2021-09-30 Thread GitBox
michael-o edited a comment on pull request #556: URL: https://github.com/apache/maven/pull/556#issuecomment-931216010 I tried your script on the POSIX shell on HP-UX, the result is quite surpring: ``` $ LC_ALL=C.utf8 ./script ./script[3]: restricted: command is a shell builtin /

[GitHub] [maven] michael-o commented on pull request #556: [MNG-7270] Switch to shell alternative to "which"

2021-09-30 Thread GitBox
michael-o commented on pull request #556: URL: https://github.com/apache/maven/pull/556#issuecomment-931216010 I tried your script on the POSIX shell on HP-UX, the result is quite surpring: ``` $ LC_ALL=C.utf8 ./script ./script[3]: restricted: command is a shell builtin /opt/jav

[jira] [Commented] (MNG-7270) Maven startup script (init) calls which(1) which is an external command

2021-09-30 Thread Jonathan Dowland (Jira)
[ https://issues.apache.org/jira/browse/MNG-7270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422682#comment-17422682 ] Jonathan Dowland commented on MNG-7270: --- The binary itself is tiny, yes; but the savi

[jira] [Comment Edited] (MNG-7270) Maven startup script (init) calls which(1) which is an external command

2021-09-30 Thread Jonathan Dowland (Jira)
[ https://issues.apache.org/jira/browse/MNG-7270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422682#comment-17422682 ] Jonathan Dowland edited comment on MNG-7270 at 9/30/21, 10:24 AM: ---

[GitHub] [maven] jmtd commented on pull request #556: [MNG-7270] Switch to shell alternative to "which"

2021-09-30 Thread GitBox
jmtd commented on pull request #556: URL: https://github.com/apache/maven/pull/556#issuecomment-931189840 Hi @michael-o thanks for your comments. The approach I used was lifted straight from the opengroup.org URI in the PR body/commit. However, I realised last night that I'd made a mistake

[jira] [Updated] (MNG-7275) Resource leak due to Files.list()

2021-09-30 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-7275: Description: Leak happends at [https://github.com/apache/maven/blob/c3cf29438e3d65d6ee5c5726f8611af9

[jira] [Updated] (MNG-7275) Resouce leak due to Files.list()

2021-09-30 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-7275: Summary: Resouce leak due to Files.list() (was: RedouceLeak due to Files.list) > Resouce leak due t

[jira] [Updated] (MNG-7275) Resource leak due to Files.list()

2021-09-30 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-7275: Summary: Resource leak due to Files.list() (was: Resouce leak due to Files.list()) > Resource leak

[GitHub] [maven-pmd-plugin] adangel commented on a change in pull request #47: [MPMD-325] Could not find class due to IncompatibleClassChangeError warning

2021-09-30 Thread GitBox
adangel commented on a change in pull request #47: URL: https://github.com/apache/maven-pmd-plugin/pull/47#discussion_r719240429 ## File path: pom.xml ## @@ -102,6 +102,13 @@ under the License. org.apache.maven maven-core ${mavenVersion} + Review com

[GitHub] [maven-pmd-plugin] adangel commented on a change in pull request #47: [MPMD-325] Could not find class due to IncompatibleClassChangeError warning

2021-09-30 Thread GitBox
adangel commented on a change in pull request #47: URL: https://github.com/apache/maven-pmd-plugin/pull/47#discussion_r719233445 ## File path: src/it/MPMD-280-JDK12/invoker.properties ## @@ -16,4 +16,5 @@ # under the License. invoker.java.version = 12+ Review comment:

[jira] [Created] (MPMD-327) Upgrade to PMD 6.39.0

2021-09-30 Thread Andreas Dangel (Jira)
Andreas Dangel created MPMD-327: --- Summary: Upgrade to PMD 6.39.0 Key: MPMD-327 URL: https://issues.apache.org/jira/browse/MPMD-327 Project: Maven PMD Plugin Issue Type: Dependency upgrade

[jira] [Created] (MNG-7275) RedouceLeak due to Files.list

2021-09-30 Thread lujie (Jira)
lujie created MNG-7275: -- Summary: RedouceLeak due to Files.list Key: MNG-7275 URL: https://issues.apache.org/jira/browse/MNG-7275 Project: Maven Issue Type: Bug Reporter: lujie Leak happen

[GitHub] [maven] khmarbaise commented on a change in pull request #558: [MNG-7272] - Code Improvement - II

2021-09-30 Thread GitBox
khmarbaise commented on a change in pull request #558: URL: https://github.com/apache/maven/pull/558#discussion_r719162777 ## File path: maven-core/src/main/java/org/apache/maven/graph/DefaultProjectDependencyGraph.java ## @@ -62,38 +62,30 @@ * @throws CycleDetectedExcep

[GitHub] [maven] khmarbaise commented on a change in pull request #558: [MNG-7272] - Code Improvement - II

2021-09-30 Thread GitBox
khmarbaise commented on a change in pull request #558: URL: https://github.com/apache/maven/pull/558#discussion_r719160720 ## File path: maven-core/src/main/java/org/apache/maven/project/ProjectSorter.java ## @@ -126,43 +123,29 @@ public ProjectSorter( Collection projects )

[GitHub] [maven] michael-o commented on a change in pull request #558: [MNG-7272] - Code Improvement - II

2021-09-30 Thread GitBox
michael-o commented on a change in pull request #558: URL: https://github.com/apache/maven/pull/558#discussion_r719159185 ## File path: maven-core/src/main/java/org/apache/maven/graph/DefaultProjectDependencyGraph.java ## @@ -62,38 +62,30 @@ * @throws CycleDetectedExcept

[jira] [Created] (MINVOKER-289) Support for shared invoker's Update-Snapshots Flag

2021-09-30 Thread Tuomas Kiviaho (Jira)
Tuomas Kiviaho created MINVOKER-289: --- Summary: Support for shared invoker's Update-Snapshots Flag Key: MINVOKER-289 URL: https://issues.apache.org/jira/browse/MINVOKER-289 Project: Maven Invoker Plug

[jira] [Assigned] (MNG-7270) Maven startup script (init) calls which(1) which is an external command

2021-09-30 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MNG-7270: --- Assignee: (was: Michael Osipov) > Maven startup script (init) calls which(1) which is an e

[GitHub] [maven] pzygielo commented on a change in pull request #558: [MNG-7272] - Code Improvement - II

2021-09-30 Thread GitBox
pzygielo commented on a change in pull request #558: URL: https://github.com/apache/maven/pull/558#discussion_r719133718 ## File path: maven-core/src/main/java/org/apache/maven/graph/DefaultProjectDependencyGraph.java ## @@ -62,38 +62,30 @@ * @throws CycleDetectedExcepti

[GitHub] [maven] pzygielo commented on a change in pull request #558: [MNG-7272] - Code Improvement - II

2021-09-30 Thread GitBox
pzygielo commented on a change in pull request #558: URL: https://github.com/apache/maven/pull/558#discussion_r719132710 ## File path: maven-core/src/main/java/org/apache/maven/graph/DefaultProjectDependencyGraph.java ## @@ -43,16 +43,16 @@ * @author Benjamin Bentmann */

[GitHub] [maven] pzygielo commented on a change in pull request #558: [MNG-7272] - Code Improvement - II

2021-09-30 Thread GitBox
pzygielo commented on a change in pull request #558: URL: https://github.com/apache/maven/pull/558#discussion_r719125588 ## File path: maven-core/src/main/java/org/apache/maven/project/ProjectSorter.java ## @@ -126,43 +123,29 @@ public ProjectSorter( Collection projects )