[GitHub] [maven-shade-plugin] Tibor17 commented on pull request #95: [MSHADE-391] Do not write modified class files for no-op relocations

2021-07-18 Thread GitBox
Tibor17 commented on pull request #95: URL: https://github.com/apache/maven-shade-plugin/pull/95#issuecomment-882133546 @eolivelli @rmannibucau It looks like you have approved all commits. Are there any objections to push this? -- This is an automated message from the Apache Gi

[GitHub] [maven-shade-plugin] Tibor17 commented on pull request #90: [MSHADE-382] - Add property to skip execution

2021-07-18 Thread GitBox
Tibor17 commented on pull request #90: URL: https://github.com/apache/maven-shade-plugin/pull/90#issuecomment-882132625 If there are no objections, we can close this PR with push. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [maven-shade-plugin] Tibor17 commented on pull request #90: [MSHADE-382] - Add property to skip execution

2021-07-18 Thread GitBox
Tibor17 commented on pull request #90: URL: https://github.com/apache/maven-shade-plugin/pull/90#issuecomment-882132478 @aalmiray Pls squash these commits in one. Thx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[jira] [Commented] (MJAVADOC-683) Reimplement failOnWarning

2021-07-18 Thread Robert Scholte (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382913#comment-17382913 ] Robert Scholte commented on MJAVADOC-683: - bq. ... leaving stdout to be used fo

[jira] [Commented] (MJAVADOC-683) Reimplement failOnWarning

2021-07-18 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382910#comment-17382910 ] Michael Osipov commented on MJAVADOC-683: - If diagnostics are written to stderr

[jira] [Commented] (MJAVADOC-683) Reimplement failOnWarning

2021-07-18 Thread Robert Scholte (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382906#comment-17382906 ] Robert Scholte commented on MJAVADOC-683: - Their argument is that we should hav

[jira] [Commented] (MNG-6603) XDG Base Directory Specification support

2021-07-18 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382884#comment-17382884 ] Michael Osipov commented on MNG-6603: - There isn't any. First of all one need to create

[GitHub] [maven-shade-plugin] aalmiray commented on a change in pull request #90: [MSHADE-382] - Add property to skip execution

2021-07-18 Thread GitBox
aalmiray commented on a change in pull request #90: URL: https://github.com/apache/maven-shade-plugin/pull/90#discussion_r671859020 ## File path: src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java ## @@ -385,12 +385,23 @@ @Inject private Map shaders; +

[jira] [Comment Edited] (MNG-6603) XDG Base Directory Specification support

2021-07-18 Thread Ignacio Taranto (Jira)
[ https://issues.apache.org/jira/browse/MNG-6603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382850#comment-17382850 ] Ignacio Taranto edited comment on MNG-6603 at 7/18/21, 3:11 PM: -

[jira] [Comment Edited] (MNG-6603) XDG Base Directory Specification support

2021-07-18 Thread Ignacio Taranto (Jira)
[ https://issues.apache.org/jira/browse/MNG-6603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382850#comment-17382850 ] Ignacio Taranto edited comment on MNG-6603 at 7/18/21, 3:10 PM: -

[jira] [Comment Edited] (MNG-6603) XDG Base Directory Specification support

2021-07-18 Thread Ignacio Taranto (Jira)
[ https://issues.apache.org/jira/browse/MNG-6603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382850#comment-17382850 ] Ignacio Taranto edited comment on MNG-6603 at 7/18/21, 3:10 PM: -

[jira] [Comment Edited] (MNG-6603) XDG Base Directory Specification support

2021-07-18 Thread Ignacio Taranto (Jira)
[ https://issues.apache.org/jira/browse/MNG-6603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382850#comment-17382850 ] Ignacio Taranto edited comment on MNG-6603 at 7/18/21, 3:09 PM: -

[jira] [Comment Edited] (MNG-6603) XDG Base Directory Specification support

2021-07-18 Thread Ignacio Taranto (Jira)
[ https://issues.apache.org/jira/browse/MNG-6603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382850#comment-17382850 ] Ignacio Taranto edited comment on MNG-6603 at 7/18/21, 3:09 PM: -

[jira] [Comment Edited] (MNG-6603) XDG Base Directory Specification support

2021-07-18 Thread Ignacio Taranto (Jira)
[ https://issues.apache.org/jira/browse/MNG-6603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382850#comment-17382850 ] Ignacio Taranto edited comment on MNG-6603 at 7/18/21, 3:07 PM: -

[jira] [Commented] (MNG-6603) XDG Base Directory Specification support

2021-07-18 Thread Ignacio Taranto (Jira)
[ https://issues.apache.org/jira/browse/MNG-6603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382850#comment-17382850 ] Ignacio Taranto commented on MNG-6603: -- Any news about this? If you think that splitt

[jira] [Commented] (MJAVADOC-683) Reimplement failOnWarning

2021-07-18 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382811#comment-17382811 ] Michael Osipov commented on MJAVADOC-683: - That's really depressing, constant c