kriegaex edited a comment on pull request #100:
URL:
https://github.com/apache/maven-shade-plugin/pull/100#issuecomment-876058443
Sorry for the late feedback. I just checked out this PR and ran it against
my shading configuration in AspectJ, then diffed the shaded source archives
before a
kriegaex commented on pull request #100:
URL:
https://github.com/apache/maven-shade-plugin/pull/100#issuecomment-876058443
Sorry for the late feedback. I just checked out this PR and ran it against
my shading configuration is AspectJ, then diffed the shaded source archives
before and afte
elharo commented on pull request #65:
URL: https://github.com/apache/maven-archetype/pull/65#issuecomment-876005412
I'm trying to understand what's going on here, and how it fails. This is
easier to do one change at a time. This test isn't very well factored to start
with, and might need s
[
https://issues.apache.org/jira/browse/MRESOLVER-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376868#comment-17376868
]
Jacques-Etienne Beaudet commented on MRESOLVER-189:
---
Good hunch, I'l
[
https://issues.apache.org/jira/browse/MRESOLVER-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376866#comment-17376866
]
Michael Osipov commented on MRESOLVER-189:
--
Has this been resolved with MRESO
[
https://issues.apache.org/jira/browse/MRESOLVER-189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques-Etienne Beaudet updated MRESOLVER-189:
--
Description:
While testing performance for in
[https://github.com/a
[
https://issues.apache.org/jira/browse/MRESOLVER-189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques-Etienne Beaudet updated MRESOLVER-189:
--
Description:
While testing performance for in
[https://github.com/a
[
https://issues.apache.org/jira/browse/MRESOLVER-189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques-Etienne Beaudet updated MRESOLVER-189:
--
Summary: Using semaphore-redisson followed by rwlock-redisson on many
jebeaudet commented on pull request #68:
URL: https://github.com/apache/maven-resolver/pull/68#issuecomment-875962106
with semaphores : 19.795s
without : 17.418s
This is using my custom build mvn with redisson 3.15.6 and
maven-resolver-named-locks-redisson-1.7.1. Again, negligible
Jacques-Etienne Beaudet created MRESOLVER-189:
-
Summary: Using semaphore followed by rwlock-redisson on many
parallel build of the same project triggers redisson error
Key: MRESOLVER-189
URL: https://i
[
https://issues.apache.org/jira/browse/SUREFIRE-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376843#comment-17376843
]
Tibor Digana commented on SUREFIRE-1926:
[~michael-o]
Let's switch to Slack, b
michael-o edited a comment on pull request #68:
URL: https://github.com/apache/maven-resolver/pull/68#issuecomment-875908357
>
>
> @michael-o Yup that's correct, reusing the same m2 repo for different
builds cut the build time dramatically, that's exactly why I ended up using
your
[
https://issues.apache.org/jira/browse/SUREFIRE-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376826#comment-17376826
]
Michael Osipov commented on SUREFIRE-1926:
--
Shit, it is threadsafe internally
[
https://issues.apache.org/jira/browse/SUREFIRE-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376823#comment-17376823
]
Michael Osipov commented on SUREFIRE-1926:
--
See: https://stackoverflow.com/a/
jebeaudet commented on pull request #68:
URL: https://github.com/apache/maven-resolver/pull/68#issuecomment-875909859
I'll test it out tomorrow and come back to you. Thanks again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
[
https://issues.apache.org/jira/browse/MRESOLVER-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376821#comment-17376821
]
Michael Osipov commented on MRESOLVER-188:
--
Will add https://github.com/jebea
michael-o commented on pull request #68:
URL: https://github.com/apache/maven-resolver/pull/68#issuecomment-875908357
>
>
> @michael-o Yup that's correct, reusing the same m2 repo for different
builds cut the build time dramatically, that's exactly why I ended up using
your plugin
[
https://issues.apache.org/jira/browse/MRESOLVER-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov reassigned MRESOLVER-188:
Assignee: Michael Osipov
> Improve documentation on using the named locks with
[
https://issues.apache.org/jira/browse/SUREFIRE-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376819#comment-17376819
]
Michael Osipov commented on SUREFIRE-1926:
--
I read your comment therefore the
jebeaudet commented on pull request #68:
URL: https://github.com/apache/maven-resolver/pull/68#issuecomment-875906048
@michael-o Yup that's correct, reusing the same m2 repo for different builds
cut the build time dramatically, that's exactly why I ended up using your
plugin for secure mul
Jacques-Etienne Beaudet created MRESOLVER-188:
-
Summary: Improve documentation on using the named locks with
redis/hazelcast
Key: MRESOLVER-188
URL: https://issues.apache.org/jira/browse/MRESOLVER-188
[
https://issues.apache.org/jira/browse/MRESOLVER-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques-Etienne Beaudet updated MRESOLVER-188:
--
Priority: Minor (was: Major)
> Improve documentation on using the n
michael-o commented on pull request #68:
URL: https://github.com/apache/maven-resolver/pull/68#issuecomment-875894045
I have already noticed that documentation is weak. We were more focused on
proper functionality. I also have founds bugs in Redisson with this new module.
Please file an is
jebeaudet commented on pull request #68:
URL: https://github.com/apache/maven-resolver/pull/68#issuecomment-875884653
I figured I'd educate myself so I built maven 3.8.1 with maven-resolver set
to 1.7.0 and run the tests with `mvn compile
-Daether.syncContext.named.factory=rwlock-redisson`
jebeaudet commented on pull request #68:
URL: https://github.com/apache/maven-resolver/pull/68#issuecomment-875841033
Yea ok it finally makes sense. If I can suggest something, this should be in
the documentation to warn others. Since the 1.7.x version is the current
version, it's the docu
newur edited a comment on pull request #65:
URL: https://github.com/apache/maven-archetype/pull/65#issuecomment-875833742
@elharo
I don't see what you try to achieve or what your reasoning is here. However,
the call to `.normalizeWhitespace()` is rather new and I assume it was added
newur commented on pull request #65:
URL: https://github.com/apache/maven-archetype/pull/65#issuecomment-875833742
@elharo
I don't see what you try to achieve or what your reasoning is here. However,
the call to `.normalizeWhitespace()` is rather new and I assume it was added to
'g
[
https://issues.apache.org/jira/browse/SUREFIRE-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376763#comment-17376763
]
Tibor Digana commented on SUREFIRE-1926:
[~michael-o]
Michael, you did not rea
[
https://issues.apache.org/jira/browse/ARCHETYPE-562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliotte Rusty Harold updated ARCHETYPE-562:
Fix Version/s: 3.2.1
> Error ordering Default Properties
> -
[
https://issues.apache.org/jira/browse/ARCHETYPE-562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliotte Rusty Harold resolved ARCHETYPE-562.
-
Resolution: Fixed
> Error ordering Default Properties
> --
[
https://issues.apache.org/jira/browse/ARCHETYPE-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliotte Rusty Harold updated ARCHETYPE-558:
Fix Version/s: 3.2.1
> Allow transitive requiredProperty from non defaul
michael-o commented on pull request #68:
URL: https://github.com/apache/maven-resolver/pull/68#issuecomment-875820934
I would recomment to compare the `tree` output of 3.8.x and 4.0.x and
replace Resolver JARs.
--
This is an automated message from the Apache Git Service.
To respond to th
[
https://issues.apache.org/jira/browse/ARCHETYPE-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliotte Rusty Harold resolved ARCHETYPE-558.
-
Resolution: Fixed
> Allow transitive requiredProperty from non default
michael-o commented on pull request #68:
URL: https://github.com/apache/maven-resolver/pull/68#issuecomment-875820164
Maven 3.8.x comes with Resolver 1.6.x because Resolver 1.7 requires Java 8
which Maven 3.8.x cannot offer. You can create a custom Maven distro to upgrade
Resolver. See
ht
elharo merged pull request #64:
URL: https://github.com/apache/maven-archetype/pull/64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsu
jebeaudet commented on pull request #68:
URL: https://github.com/apache/maven-resolver/pull/68#issuecomment-875803262
@michael-o Oh OK good to know between 1.6.x and 1.7.x. I have it running
with 1.6.x and it works great for our use case(thx for that!), I was just
trying to upgrade and ran
elharo commented on pull request #64:
URL: https://github.com/apache/maven-archetype/pull/64#issuecomment-875786039
one more time:
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-archetype/job/test4/
if this passes and there are no more commits, I'll merge
--
This i
elharo commented on pull request #64:
URL: https://github.com/apache/maven-archetype/pull/64#issuecomment-875746655
I should the final PR in jenkins and merge it if it passs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
mbenson commented on pull request #64:
URL: https://github.com/apache/maven-archetype/pull/64#issuecomment-875738621
Thanks @elharo ! What's next?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
michael-o commented on pull request #68:
URL: https://github.com/apache/maven-resolver/pull/68#issuecomment-875735162
The Redisson-based approach between 1.6 and 1.7 is, unfortunately, not
compatible. It has been competely moved to the named lock approach. I highly
recommend to replace 1.6
jebeaudet commented on pull request #68:
URL: https://github.com/apache/maven-resolver/pull/68#issuecomment-875702776
@michael-o Actually, I'm trying to upgrade from an old version of our custom
maven jenkins image that was working and I'm running into this issue. [The
previous configurati
elharo commented on pull request #65:
URL: https://github.com/apache/maven-archetype/pull/65#issuecomment-875699923
It might make sense to create a new Java 11 test rather than changing this
one.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
mbenson commented on a change in pull request #64:
URL: https://github.com/apache/maven-archetype/pull/64#discussion_r665437580
##
File path:
maven-archetype-plugin/src/main/java/org/apache/maven/archetype/ui/generation/DefaultArchetypeGenerationConfigurator.java
##
@@ -313,46
mbenson commented on a change in pull request #64:
URL: https://github.com/apache/maven-archetype/pull/64#discussion_r665436637
##
File path:
maven-archetype-plugin/src/main/java/org/apache/maven/archetype/ui/generation/DefaultArchetypeGenerationConfigurator.java
##
@@ -313,46
mbenson commented on a change in pull request #64:
URL: https://github.com/apache/maven-archetype/pull/64#discussion_r665435676
##
File path:
maven-archetype-plugin/src/main/java/org/apache/maven/archetype/ui/generation/DefaultArchetypeGenerationConfigurator.java
##
@@ -368,71
elharo commented on pull request #65:
URL: https://github.com/apache/maven-archetype/pull/65#issuecomment-875650892
Yep:
```
Expected: Expected text value '
' but was '
' - comparing
at /project[1]/text()[1] to
at /project[1]/text()[1]:
newur commented on pull request #65:
URL: https://github.com/apache/maven-archetype/pull/65#issuecomment-875650552
Looks like it fails on JDK 11+
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-archetype/job/linebreak/1/testReport/
--
This is an automated message f
elharo commented on a change in pull request #64:
URL: https://github.com/apache/maven-archetype/pull/64#discussion_r665417765
##
File path:
maven-archetype-plugin/src/main/java/org/apache/maven/archetype/ui/generation/DefaultArchetypeGenerationConfigurator.java
##
@@ -313,46
elharo commented on pull request #64:
URL: https://github.com/apache/maven-archetype/pull/64#issuecomment-875643202
checking again
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-archetype/job/test3/
--
This is an automated message from the Apache Git Service.
To respond t
mbenson commented on pull request #64:
URL: https://github.com/apache/maven-archetype/pull/64#issuecomment-875635447
Addressed latest comments... unfortunately I seem to lack permission to
re-trigger the CI build.
--
This is an automated message from the Apache Git Service.
To respond to
elharo opened a new pull request #65:
URL: https://github.com/apache/maven-archetype/pull/65
@newur @Tibor17
Passes in Java 8. I want to see if this fails in Java 11.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
[
https://issues.apache.org/jira/browse/SUREFIRE-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376579#comment-17376579
]
Michael Osipov commented on SUREFIRE-1926:
--
Why do you think that this issue
[
https://issues.apache.org/jira/browse/MNG-7161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376533#comment-17376533
]
Guy Brand commented on MNG-7161:
Also see [https://github.com/fusesource/jansi/issues/214]
guylabs commented on a change in pull request #93:
URL: https://github.com/apache/maven-shared-utils/pull/93#discussion_r665333009
##
File path: src/main/java/org/apache/maven/shared/utils/logging/MessageUtils.java
##
@@ -98,7 +98,14 @@ private static void doSystemUninstall()
rfscholte commented on a change in pull request #93:
URL: https://github.com/apache/maven-shared-utils/pull/93#discussion_r665316955
##
File path: src/main/java/org/apache/maven/shared/utils/logging/MessageUtils.java
##
@@ -98,7 +98,14 @@ private static void doSystemUninstall()
[
https://issues.apache.org/jira/browse/MSHARED-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376518#comment-17376518
]
Guy Brand commented on MSHARED-993:
---
The respective pull request https://github.com/ap
[
https://issues.apache.org/jira/browse/MNG-7161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376519#comment-17376519
]
Guy Brand commented on MNG-7161:
I've opened https://issues.apache.org/jira/browse/MSHARED-
guylabs opened a new pull request #93:
URL: https://github.com/apache/maven-shared-utils/pull/93
See https://issues.apache.org/jira/browse/MSHARED-993 for details.
There is no unit/integration test for this as it would require to use
Powermock or similar to mock Jansi. If requested,
[
https://issues.apache.org/jira/browse/SUREFIRE-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376517#comment-17376517
]
Tibor Digana commented on SUREFIRE-1926:
[~michael-o]
Pls have a look at the l
Guy Brand created MSHARED-993:
-
Summary: Make MessageUtils resilient to failures during uninstall
Key: MSHARED-993
URL: https://issues.apache.org/jira/browse/MSHARED-993
Project: Maven Shared Components
[
https://issues.apache.org/jira/browse/SUREFIRE-1927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376507#comment-17376507
]
satellite15 edited comment on SUREFIRE-1927 at 7/7/21, 11:51 AM:
---
[
https://issues.apache.org/jira/browse/SUREFIRE-1927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376507#comment-17376507
]
satellite15 commented on SUREFIRE-1927:
---
{code:java}
${surefireArgLine}
${unit.t
[
https://issues.apache.org/jira/browse/MINDEXER-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376499#comment-17376499
]
Victor Rubezhny commented on MINDEXER-127:
--
Hello [~slachiewicz],
Still have
[
https://issues.apache.org/jira/browse/SUREFIRE-1927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376494#comment-17376494
]
Tibor Digana commented on SUREFIRE-1927:
[~satellite15] I would like to see th
[
https://issues.apache.org/jira/browse/SUREFIRE-1927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376489#comment-17376489
]
satellite15 commented on SUREFIRE-1927:
---
[~tibordigana]
Thanks for that.
I'm
[
https://issues.apache.org/jira/browse/SUREFIRE-1927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376478#comment-17376478
]
Tibor Digana commented on SUREFIRE-1927:
Hi [~satellite15],
You can debug the
[
https://issues.apache.org/jira/browse/SUREFIRE-1927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376476#comment-17376476
]
satellite15 commented on SUREFIRE-1927:
---
[~tibordigana] we haven't the enablePro
[
https://issues.apache.org/jira/browse/WAGON-611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376353#comment-17376353
]
Michael Osipov edited comment on WAGON-611 at 7/7/21, 7:11 AM:
-
[
https://issues.apache.org/jira/browse/WAGON-611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376353#comment-17376353
]
Michael Osipov commented on WAGON-611:
--
You build suffers from two fundamental proble
69 matches
Mail list logo
