[GitHub] [maven-shade-plugin] rmannibucau commented on pull request #90: [MSHADE-382] - Add property to skip execution

2021-04-27 Thread GitBox
rmannibucau commented on pull request #90: URL: https://github.com/apache/maven-shade-plugin/pull/90#issuecomment-828131563 > removing the @Parameter annotation is the compromise that will let this PR be merged. Just the property value (you can keep it to get it configurable in the p

[GitHub] [maven-shade-plugin] aalmiray commented on pull request #90: [MSHADE-382] - Add property to skip execution

2021-04-27 Thread GitBox
aalmiray commented on pull request #90: URL: https://github.com/apache/maven-shade-plugin/pull/90#issuecomment-827953865 Alright. If I understood correctly, removing the `@Parameter` annotation is the compromise that will let this PR be merged. However, what we accomplish with that i

[jira] [Commented] (SUREFIRE-1910) Missleading error message when using -Dtest=....

2021-04-27 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17333559#comment-17333559 ] Tibor Digana commented on SUREFIRE-1910: yes, there is a bug even in the code.

[GitHub] [maven-scm] cquoss commented on a change in pull request #109: [SCM-947]

2021-04-27 Thread GitBox
cquoss commented on a change in pull request #109: URL: https://github.com/apache/maven-scm/pull/109#discussion_r621593564 ## File path: maven-scm-plugin/src/main/java/org/apache/maven/scm/plugin/ChangeLogMojo.java ## @@ -125,24 +145,58 @@ public void execute()

[GitHub] [maven-scm] cquoss commented on a change in pull request #109: [SCM-947]

2021-04-27 Thread GitBox
cquoss commented on a change in pull request #109: URL: https://github.com/apache/maven-scm/pull/109#discussion_r621593222 ## File path: maven-scm-plugin/src/main/java/org/apache/maven/scm/plugin/ChangeLogMojo.java ## @@ -125,24 +145,58 @@ public void execute()

[GitHub] [maven-resolver] michael-o commented on a change in pull request #101: [MRESOLVER-153] Make TrackingFileManager use NamedLocks

2021-04-27 Thread GitBox
michael-o commented on a change in pull request #101: URL: https://github.com/apache/maven-resolver/pull/101#discussion_r621489660 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultTrackingFileManager.java ## @@ -228,7 +205,7 @@ public Pro

[GitHub] [maven-resolver] michael-o commented on a change in pull request #101: [MRESOLVER-153] Make TrackingFileManager use NamedLocks

2021-04-27 Thread GitBox
michael-o commented on a change in pull request #101: URL: https://github.com/apache/maven-resolver/pull/101#discussion_r621490505 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultTrackingFileManager.java ## @@ -41,100 +52,189 @@ @Single

[GitHub] [maven-resolver] michael-o commented on a change in pull request #101: [MRESOLVER-153] Make TrackingFileManager use NamedLocks

2021-04-27 Thread GitBox
michael-o commented on a change in pull request #101: URL: https://github.com/apache/maven-resolver/pull/101#discussion_r621489660 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultTrackingFileManager.java ## @@ -228,7 +205,7 @@ public Pro

[jira] [Closed] (MNGSITE-449) Document profile deactivation syntax using hyphens

2021-04-27 Thread Martin Kanters (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Kanters closed MNGSITE-449. -- Resolution: Fixed > Document profile deactivation syntax using hyphens > -

[jira] [Assigned] (MNGSITE-449) Document profile deactivation syntax using hyphens

2021-04-27 Thread Martin Kanters (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Kanters reassigned MNGSITE-449: -- Assignee: Elliotte Rusty Harold > Document profile deactivation syntax using hyphens

[GitHub] [maven-resolver] cstamas commented on a change in pull request #101: [MRESOLVER-153] Make TrackingFileManager use NamedLocks

2021-04-27 Thread GitBox
cstamas commented on a change in pull request #101: URL: https://github.com/apache/maven-resolver/pull/101#discussion_r621435220 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultTrackingFileManager.java ## @@ -41,100 +52,189 @@ @Singleto

[GitHub] [maven-resolver] michael-o commented on a change in pull request #101: [MRESOLVER-153] Make TrackingFileManager use NamedLocks

2021-04-27 Thread GitBox
michael-o commented on a change in pull request #101: URL: https://github.com/apache/maven-resolver/pull/101#discussion_r621312209 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultTrackingFileManager.java ## @@ -41,100 +52,189 @@ @Single

[jira] [Commented] (MNGSITE-246) Documentation of mavenrc_pre / .mavenrc

2021-04-27 Thread Jira
[ https://issues.apache.org/jira/browse/MNGSITE-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1735#comment-1735 ] André Zmuda commented on MNGSITE-246: - [~michael-o], this feature is helpful, when c

[jira] [Commented] (MJAVADOC-675) Require Java 8

2021-04-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1730#comment-1730 ] Hudson commented on MJAVADOC-675: - Build failed in Jenkins: Maven » Maven TLP » maven-j

[jira] [Closed] (MJAVADOC-675) Require Java 8

2021-04-27 Thread Robert Scholte (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MJAVADOC-675. --- Fix Version/s: 3.3.0 Resolution: Fixed Fixed in [6c25863d1bac6eab0b30fceb04c39a22f0

[jira] [Created] (MJAVADOC-675) Require Java 8

2021-04-27 Thread Robert Scholte (Jira)
Robert Scholte created MJAVADOC-675: --- Summary: Require Java 8 Key: MJAVADOC-675 URL: https://issues.apache.org/jira/browse/MJAVADOC-675 Project: Maven Javadoc Plugin Issue Type: Improvement

[jira] [Commented] (SUREFIRE-1910) Missleading error message when using -Dtest=....

2021-04-27 Thread Jira
[ https://issues.apache.org/jira/browse/SUREFIRE-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17333239#comment-17333239 ] Christoph Läubrich commented on SUREFIRE-1910: -- btw this should be reprod

[jira] [Commented] (SUREFIRE-1910) Missleading error message when using -Dtest=....

2021-04-27 Thread Jira
[ https://issues.apache.org/jira/browse/SUREFIRE-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17333235#comment-17333235 ] Christoph Läubrich commented on SUREFIRE-1910: -- {noformat} [INFO] --- mav

[jira] [Commented] (SUREFIRE-1910) Missleading error message when using -Dtest=....

2021-04-27 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17333231#comment-17333231 ] Tibor Digana commented on SUREFIRE-1910: [~laeubi] Attach a complete log. Thx

[GitHub] [maven-resolver] cstamas opened a new pull request #101: [MRESOLVER-153] Make TrackingFileManager use NamedLocks

2021-04-27 Thread GitBox
cstamas opened a new pull request #101: URL: https://github.com/apache/maven-resolver/pull/101 Now that TrackingFileManager is shared singleton, let's make it use NamedLockFactory. Commits: Step1: drop all SyncContextFactory implementations and indirections, redo the same functio

[jira] [Commented] (MRESOLVER-174) Use all bindings in UTs and tests

2021-04-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17333198#comment-17333198 ] Hudson commented on MRESOLVER-174: -- Build succeeded in Jenkins: Maven » Maven TLP » m

[jira] [Commented] (MRESOLVER-173) Drop deprecated AetherModule

2021-04-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17333191#comment-17333191 ] Hudson commented on MRESOLVER-173: -- Build succeeded in Jenkins: Maven » Maven TLP » m

[jira] [Commented] (MNGSITE-449) Document profile deactivation syntax using hyphens

2021-04-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17333177#comment-17333177 ] Hudson commented on MNGSITE-449: Build succeeded in Jenkins: Maven » Maven TLP » maven-s

[jira] [Commented] (MJAVADOC-643) make build Reproducible for secondary artifacts

2021-04-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17333163#comment-17333163 ] Hudson commented on MJAVADOC-643: - Build failed in Jenkins: Maven » Maven TLP » maven-j

[jira] [Closed] (MRESOLVER-174) Use all bindings in UTs and tests

2021-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MRESOLVER-174. Resolution: Fixed Fixed with [95ad3ca4b6f2380999ca6b7e312f4f31aff45c83|https://gitbox.a

[GitHub] [maven-resolver] asfgit closed pull request #99: Fix bindings and do test them

2021-04-27 Thread GitBox
asfgit closed pull request #99: URL: https://github.com/apache/maven-resolver/pull/99 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[jira] [Created] (MRESOLVER-174) Use all bindings in UTs and tests

2021-04-27 Thread Michael Osipov (Jira)
Michael Osipov created MRESOLVER-174: Summary: Use all bindings in UTs and tests Key: MRESOLVER-174 URL: https://issues.apache.org/jira/browse/MRESOLVER-174 Project: Maven Resolver Issue

[jira] [Closed] (MJAVADOC-643) make build Reproducible for secondary artifacts

2021-04-27 Thread Robert Scholte (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MJAVADOC-643. --- Assignee: Robert Scholte Resolution: Fixed Fixed in [00fad576c995cad4360b2db413f250d

[jira] [Closed] (MRESOLVER-173) Drop deprecated AetherModule

2021-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MRESOLVER-173. Resolution: Fixed Fixed with [5a0b6c8aef74b0366bab3204ba03faf27ec348d9|https://gitbox.a

[GitHub] [maven-resolver] asfgit closed pull request #100: Drop deprecated module

2021-04-27 Thread GitBox
asfgit closed pull request #100: URL: https://github.com/apache/maven-resolver/pull/100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pl

[jira] [Created] (MRESOLVER-173) Drop deprecated AetherModule

2021-04-27 Thread Michael Osipov (Jira)
Michael Osipov created MRESOLVER-173: Summary: Drop deprecated AetherModule Key: MRESOLVER-173 URL: https://issues.apache.org/jira/browse/MRESOLVER-173 Project: Maven Resolver Issue Type:

[GitHub] [maven-resolver] cstamas opened a new pull request #100: Drop deprecated module

2021-04-27 Thread GitBox
cstamas opened a new pull request #100: URL: https://github.com/apache/maven-resolver/pull/100 This module was deprecated while project was hosted on Eclipse, well before moved to ASF. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Closed] (MJAVADOC-602) "Aggregating Javadocs For Multi-Projects" code snippet is garbled and tag example is missing

2021-04-27 Thread Robert Scholte (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MJAVADOC-602. --- Assignee: Robert Scholte Resolution: Done Code snippet fixed with [2440a51b5e732fcef

[GitHub] [maven-resolver] michael-o commented on a change in pull request #99: Fix bindings and do test them

2021-04-27 Thread GitBox
michael-o commented on a change in pull request #99: URL: https://github.com/apache/maven-resolver/pull/99#discussion_r621071001 ## File path: maven-resolver-demos/maven-resolver-demo-snippets/src/main/java/org/apache/maven/resolver/examples/util/Booter.java ## @@ -35,12 +35,4

[jira] [Closed] (MJAVADOC-583) javadoc: error - The code being documented uses modules but the packages defined in {URL} are in the unnamed module

2021-04-27 Thread Robert Scholte (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MJAVADOC-583. --- Assignee: Robert Scholte Resolution: Cannot Reproduce > javadoc: error - The code bei

[GitHub] [maven-resolver] cstamas opened a new pull request #99: Fix bindings and do test them

2021-04-27 Thread GitBox
cstamas opened a new pull request #99: URL: https://github.com/apache/maven-resolver/pull/99 So far with c17902add6435d228038c6ed5d117604dc66bd41 we did run "demo snippets" (can be understood as some sort of "integration testing", but as backward compatibility testing, as it used Maven Res

[GitHub] [maven] michael-o commented on pull request #469: [MNG-7090] mvnDebug socket binds on 0.0.0.0

2021-04-27 Thread GitBox
michael-o commented on pull request #469: URL: https://github.com/apache/maven/pull/469#issuecomment-827484126 > > > Is POSIX default value always supported? IIRC I had issues with this mechanism on some OSes. Maybe @hboutemy can refresh my memory. Old Solaris default shell i

[jira] [Commented] (MSHADE-386) Update JDependency to 2.6.0

2021-04-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17333076#comment-17333076 ] Hudson commented on MSHADE-386: --- Build succeeded in Jenkins: Maven » Maven TLP » maven-shad

[GitHub] [maven] rfscholte commented on pull request #469: [MNG-7090] mvnDebug socket binds on 0.0.0.0

2021-04-27 Thread GitBox
rfscholte commented on pull request #469: URL: https://github.com/apache/maven/pull/469#issuecomment-827470159 Is POSIX default value always supported? IIRC I had issues with this mechanism on some OSes. Maybe @hboutemy can refresh my memory. -- This is an automated message from the Apac

[jira] [Closed] (MSHADE-386) Update JDependency to 2.6.0

2021-04-27 Thread Robert Scholte (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MSHADE-386. - Fix Version/s: 3.3.0 Resolution: Fixed Fixed in [e11ebcbb2e803c40a5298667a4ceea6400b75be8

[jira] [Created] (MSHADE-386) Update JDependency to 2.6.0

2021-04-27 Thread Robert Scholte (Jira)
Robert Scholte created MSHADE-386: - Summary: Update JDependency to 2.6.0 Key: MSHADE-386 URL: https://issues.apache.org/jira/browse/MSHADE-386 Project: Maven Shade Plugin Issue Type: Dependen

[jira] [Commented] (MRESOLVER-172) Make TrackingFileManager shared singleton component

2021-04-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17333023#comment-17333023 ] Hudson commented on MRESOLVER-172: -- Build succeeded in Jenkins: Maven » Maven TLP » m

[jira] [Closed] (MRESOLVER-172) Make TrackingFileManager shared singleton component

2021-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MRESOLVER-172. Resolution: Fixed Fixed with [693403ec9a55eeff87776cd4f39218c8e0b8af81|https://gitbox.a

[GitHub] [maven-resolver] asfgit closed pull request #98: [MRESOLVER-153] Make TrackingFileManager shared singleton

2021-04-27 Thread GitBox
asfgit closed pull request #98: URL: https://github.com/apache/maven-resolver/pull/98 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[jira] [Commented] (MRESOLVER-172) Make TrackingFileManager shared singleton component

2021-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17333015#comment-17333015 ] Michael Osipov commented on MRESOLVER-172: -- To properly inject synchronizatio

[jira] [Created] (MRESOLVER-172) Make TrackingFileManager shared singleton component

2021-04-27 Thread Michael Osipov (Jira)
Michael Osipov created MRESOLVER-172: Summary: Make TrackingFileManager shared singleton component Key: MRESOLVER-172 URL: https://issues.apache.org/jira/browse/MRESOLVER-172 Project: Maven Resolve

[GitHub] [maven-resolver] cstamas opened a new pull request #98: [MRESOLVER-153] Make TrackingFileManager shared singleton

2021-04-27 Thread GitBox
cstamas opened a new pull request #98: URL: https://github.com/apache/maven-resolver/pull/98 Step one is to make TrackingFileManager a shared component, also, using iface+defaultClass patter to add indirection possibilities here as well. -- This is an automated message from the Apac