[GitHub] [maven] hboutemy commented on pull request #451: [MNG-7107] relax profile id validation, different from coordinate id

2021-02-26 Thread GitBox
hboutemy commented on pull request #451: URL: https://github.com/apache/maven/pull/451#issuecomment-787015632 @Tibor17 don't hesitate to implement, I'm eager to see the relationship between maven-model-builder and maven-embedder @michael-o sorry, I had already much feedback, and my i

[GitHub] [maven] michael-o commented on pull request #451: [MNG-7107] relax profile id validation, different from coordinate id

2021-02-26 Thread GitBox
michael-o commented on pull request #451: URL: https://github.com/apache/maven/pull/451#issuecomment-786923709 There likely more chars which would be forbidded, e.g., <, >, |, ~, ;, $, %, ", ', [, ], *, \. They all have some meaning either in POSIX shell, bash, PowerShell or Windows cmd. L

[GitHub] [maven] michael-o edited a comment on pull request #451: [MNG-7107] relax profile id validation, different from coordinate id

2021-02-26 Thread GitBox
michael-o edited a comment on pull request #451: URL: https://github.com/apache/maven/pull/451#issuecomment-786917698 @hboutemy Why didn't you wait for me to test? This one is incomplete. It misses a handling for these: ``` diff --git a/maven-model-builder/src/main/java/org/apache/ma

[GitHub] [maven] michael-o commented on pull request #451: [MNG-7107] relax profile id validation, different from coordinate id

2021-02-26 Thread GitBox
michael-o commented on pull request #451: URL: https://github.com/apache/maven/pull/451#issuecomment-786917698 @hboutemy Why didn't you wait for me to test? This one is incomplete. It misses a handling for these: ``` diff --git a/maven-model-builder/src/test/resources/poms/validation

[GitHub] [maven] michael-o commented on a change in pull request #451: [MNG-7107] relax profile id validation, different from coordinate id

2021-02-26 Thread GitBox
michael-o commented on a change in pull request #451: URL: https://github.com/apache/maven/pull/451#discussion_r583942707 ## File path: maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java ## @@ -850,36 +853,75 @@ private boolean valid

[GitHub] [maven-gpg-plugin] Syquel commented on a change in pull request #12: [MGPG-80] implement GpgVersion equality in adherence to comparibility

2021-02-26 Thread GitBox
Syquel commented on a change in pull request #12: URL: https://github.com/apache/maven-gpg-plugin/pull/12#discussion_r583937880 ## File path: src/test/java/org/apache/maven/plugins/gpg/GpgVersionTest.java ## @@ -48,4 +50,22 @@ public void testOpposite() assertFalse( Gp

[GitHub] [maven-jdeprscan-plugin] bmarwell opened a new pull request #3: [MDEPSCAN-4] add github actions.

2021-02-26 Thread GitBox
bmarwell opened a new pull request #3: URL: https://github.com/apache/maven-jdeprscan-plugin/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Created] (MJDEPRSCAN-4) Add GH Actions

2021-02-26 Thread Benjamin Marwell (Jira)
Benjamin Marwell created MJDEPRSCAN-4: - Summary: Add GH Actions Key: MJDEPRSCAN-4 URL: https://issues.apache.org/jira/browse/MJDEPRSCAN-4 Project: Maven JDeprScan Plugin Issue Type: Task

[jira] [Commented] (MNG-7107) relax recently introduced profile id validation

2021-02-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291857#comment-17291857 ] Hudson commented on MNG-7107: - Build succeeded in Jenkins: Maven » Maven TLP » maven » master #

[GitHub] [maven-gpg-plugin] elharo commented on a change in pull request #12: [MGPG-80] implement GpgVersion equality in adherence to comparibility

2021-02-26 Thread GitBox
elharo commented on a change in pull request #12: URL: https://github.com/apache/maven-gpg-plugin/pull/12#discussion_r583832637 ## File path: src/test/java/org/apache/maven/plugins/gpg/GpgVersionTest.java ## @@ -48,4 +50,22 @@ public void testOpposite() assertFalse( Gp

[GitHub] [maven-gpg-plugin] Syquel commented on a change in pull request #12: [MGPG-80] implement GpgVersion equality in adherence to comparibility

2021-02-26 Thread GitBox
Syquel commented on a change in pull request #12: URL: https://github.com/apache/maven-gpg-plugin/pull/12#discussion_r583828058 ## File path: src/test/java/org/apache/maven/plugins/gpg/GpgVersionTest.java ## @@ -48,4 +50,22 @@ public void testOpposite() assertFalse( Gp

[jira] [Comment Edited] (MGPG-80) GPGVersion compareTo is not consistent with equals

2021-02-26 Thread Frederik Boster (Jira)
[ https://issues.apache.org/jira/browse/MGPG-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291604#comment-17291604 ] Frederik Boster edited comment on MGPG-80 at 2/26/21, 5:47 PM: ---

[GitHub] [maven-gpg-plugin] elharo commented on a change in pull request #12: [MGPG-80] implement GpgVersion equality in adherence to comparibility

2021-02-26 Thread GitBox
elharo commented on a change in pull request #12: URL: https://github.com/apache/maven-gpg-plugin/pull/12#discussion_r583810993 ## File path: src/test/java/org/apache/maven/plugins/gpg/GpgVersionTest.java ## @@ -48,4 +50,22 @@ public void testOpposite() assertFalse( Gp

[GitHub] [maven-gpg-plugin] Syquel commented on pull request #11: [MGPG-81] check format in constructor

2021-02-26 Thread GitBox
Syquel commented on pull request #11: URL: https://github.com/apache/maven-gpg-plugin/pull/11#issuecomment-786793029 Thanks for merging. As promised I submitted PR #12 for MGPG-80. This is an automated message from the

[GitHub] [maven] Tibor17 edited a comment on pull request #451: [MNG-7107] relax profile id validation, different from coordinate id

2021-02-26 Thread GitBox
Tibor17 edited a comment on pull request #451: URL: https://github.com/apache/maven/pull/451#issuecomment-786791885 There does not need to be an abstraction. Two methods in one class which means that the developer is not able to skip the first method if modifying another one. ---

[GitHub] [maven-gpg-plugin] Syquel opened a new pull request #12: [MGPG-80] implement GpgVersion equality in adherence to comparibility

2021-02-26 Thread GitBox
Syquel opened a new pull request #12: URL: https://github.com/apache/maven-gpg-plugin/pull/12 Provides an implementation of GpgVersion#equals andGpgVersion#hashCode to address [MGPG-80](https://issues.apache.org/jira/projects/MGPG/issues/MGPG-80). "GpgVersion#equals" is implemented by ut

[GitHub] [maven] Tibor17 commented on pull request #451: [MNG-7107] relax profile id validation, different from coordinate id

2021-02-26 Thread GitBox
Tibor17 commented on pull request #451: URL: https://github.com/apache/maven/pull/451#issuecomment-786791885 There does not need to be an abstraction. Two methods in one class which means that the developer is not able to change the first method if modifying another one.

[jira] [Closed] (MNG-7107) relax recently introduced profile id validation

2021-02-26 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MNG-7107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy closed MNG-7107. -- Assignee: Herve Boutemy Resolution: Fixed done in https://github.com/apache/maven/commit/d74020081

[GitHub] [maven] asfgit merged pull request #451: [MNG-7107] relax profile id validation, different from coordinate id

2021-02-26 Thread GitBox
asfgit merged pull request #451: URL: https://github.com/apache/maven/pull/451 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [maven-compiler-plugin] elharo commented on pull request #34: [MCOMPILER-428] improve incremental compilation documentation

2021-02-26 Thread GitBox
elharo commented on pull request #34: URL: https://github.com/apache/maven-compiler-plugin/pull/34#issuecomment-786787076 four errors on JDK 16 build [ERROR] The following builds failed: [ERROR] * MCOMPILER-349_dependencyChanged/pom.xml [ERROR] * mcompiler-182/pom.xml [ERR

[GitHub] [maven] hboutemy edited a comment on pull request #451: [MNG-7107] relax profile id validation, different from coordinate id

2021-02-26 Thread GitBox
hboutemy edited a comment on pull request #451: URL: https://github.com/apache/maven/pull/451#issuecomment-786778197 > It would be worth for future maintenance to create a new class checking these characters in profile id because both classes DefaultModelValidator and MavenCli are chceckin

[GitHub] [maven] hboutemy commented on pull request #451: [MNG-7107] relax profile id validation, different from coordinate id

2021-02-26 Thread GitBox
hboutemy commented on pull request #451: URL: https://github.com/apache/maven/pull/451#issuecomment-786778197 bq. It would be worth for future maintenance to create a new class checking these characters in profile id because both classes DefaultModelValidator and MavenCli are chcecking the

[GitHub] [maven-surefire] eolivelli commented on pull request #336: Add more documentation and verification for failOnFlakeCount

2021-02-26 Thread GitBox
eolivelli commented on pull request #336: URL: https://github.com/apache/maven-surefire/pull/336#issuecomment-786777141 @Tibor17 if you are now happy with this patch. I am going to merge it This is an automated message fro

[jira] [Commented] (MNG-7051) Optionally skip non-existing profiles

2021-02-26 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MNG-7051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291781#comment-17291781 ] Herve Boutemy commented on MNG-7051: thank you for the explanations: I think something

[GitHub] [maven-surefire] oehme commented on pull request #336: Add more documentation and verification for failOnFlakeCount

2021-02-26 Thread GitBox
oehme commented on pull request #336: URL: https://github.com/apache/maven-surefire/pull/336#issuecomment-786773519 Ping :) This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [maven] hboutemy commented on a change in pull request #451: [MNG-7107] relax profile id validation, different from coordinate id

2021-02-26 Thread GitBox
hboutemy commented on a change in pull request #451: URL: https://github.com/apache/maven/pull/451#discussion_r583783212 ## File path: maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java ## @@ -916,7 +958,7 @@ private boolean isValidI

[GitHub] [maven] hboutemy commented on a change in pull request #451: [MNG-7107] relax profile id validation, different from coordinate id

2021-02-26 Thread GitBox
hboutemy commented on a change in pull request #451: URL: https://github.com/apache/maven/pull/451#discussion_r583782873 ## File path: maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java ## @@ -850,36 +853,75 @@ private boolean valida

[jira] [Commented] (MGPG-81) GPGVersion.compareTo misuses IllegalArgumentException

2021-02-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MGPG-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291764#comment-17291764 ] Hudson commented on MGPG-81: Build succeeded in Jenkins: Maven » Maven TLP » maven-gpg-plugin »

[GitHub] [maven-gpg-plugin] elharo merged pull request #11: [MGPG-81] check format in constructor

2021-02-26 Thread GitBox
elharo merged pull request #11: URL: https://github.com/apache/maven-gpg-plugin/pull/11 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [maven-compiler-plugin] elharo commented on pull request #34: [MCOMPILER-428] improve incremental compilation documentation

2021-02-26 Thread GitBox
elharo commented on pull request #34: URL: https://github.com/apache/maven-compiler-plugin/pull/34#issuecomment-786760461 runnign through jenkins https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-compiler-plugin/job/check/

[GitHub] [maven-compiler-plugin] sadraskol commented on pull request #34: [MCOMPILER-428] improve incremental compilation documentation

2021-02-26 Thread GitBox
sadraskol commented on pull request #34: URL: https://github.com/apache/maven-compiler-plugin/pull/34#issuecomment-786758617 Hello ! Any news regarding this modification? This is an automated message from the Apache Git Serv

[GitHub] [maven-gpg-plugin] elharo commented on pull request #11: [MGPG-81] check format in constructor

2021-02-26 Thread GitBox
elharo commented on pull request #11: URL: https://github.com/apache/maven-gpg-plugin/pull/11#issuecomment-786755426 https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-gpg-plugin/job/check/ This is an automated m

[GitHub] [maven-gpg-plugin] elharo commented on pull request #11: [MGPG-81] check format in constructor

2021-02-26 Thread GitBox
elharo commented on pull request #11: URL: https://github.com/apache/maven-gpg-plugin/pull/11#issuecomment-786754047 give me a minute to run this through jenkins This is an automated message from the Apache Git Service. To re

[GitHub] [maven-install-plugin] elharo opened a new pull request #10: docs: grammar

2021-02-26 Thread GitBox
elharo opened a new pull request #10: URL: https://github.com/apache/maven-install-plugin/pull/10 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [maven-jdeprscan-plugin] bmarwell opened a new pull request #2: add PR template.

2021-02-26 Thread GitBox
bmarwell opened a new pull request #2: URL: https://github.com/apache/maven-jdeprscan-plugin/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [maven-jdeprscan-plugin] bmarwell opened a new pull request #1: Remove duplicate code snippet, extract into method.

2021-02-26 Thread GitBox
bmarwell opened a new pull request #1: URL: https://github.com/apache/maven-jdeprscan-plugin/pull/1 - Convert line breaks to unix - Removed code duplication, refactored into a method - made map field `final`. The convention says "Avoid using final modifier on all fields and argumen

[jira] [Commented] (MCLEAN-58) Maven Clean Plugin ignores followSymLinks parameter on Windows

2021-02-26 Thread Jira
[ https://issues.apache.org/jira/browse/MCLEAN-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291739#comment-17291739 ] Miłosz S commented on MCLEAN-58: Please also note that on Windows there are symlinks AND "

[GitHub] [maven-gpg-plugin] Syquel commented on a change in pull request #11: [MGPG-81] check format in constructor

2021-02-26 Thread GitBox
Syquel commented on a change in pull request #11: URL: https://github.com/apache/maven-gpg-plugin/pull/11#discussion_r583733147 ## File path: src/main/java/org/apache/maven/plugins/gpg/GpgVersion.java ## @@ -32,54 +32,46 @@ */ public class GpgVersion implements Comparable {

[GitHub] [maven-gpg-plugin] Syquel commented on a change in pull request #11: [MGPG-81] check format in constructor

2021-02-26 Thread GitBox
Syquel commented on a change in pull request #11: URL: https://github.com/apache/maven-gpg-plugin/pull/11#discussion_r583733147 ## File path: src/main/java/org/apache/maven/plugins/gpg/GpgVersion.java ## @@ -32,54 +32,46 @@ */ public class GpgVersion implements Comparable {

[GitHub] [maven-gpg-plugin] Syquel commented on a change in pull request #11: [MGPG-81] check format in constructor

2021-02-26 Thread GitBox
Syquel commented on a change in pull request #11: URL: https://github.com/apache/maven-gpg-plugin/pull/11#discussion_r583733147 ## File path: src/main/java/org/apache/maven/plugins/gpg/GpgVersion.java ## @@ -32,54 +32,46 @@ */ public class GpgVersion implements Comparable {

[GitHub] [maven-gpg-plugin] Syquel commented on a change in pull request #11: [MGPG-81] check format in constructor

2021-02-26 Thread GitBox
Syquel commented on a change in pull request #11: URL: https://github.com/apache/maven-gpg-plugin/pull/11#discussion_r583733147 ## File path: src/main/java/org/apache/maven/plugins/gpg/GpgVersion.java ## @@ -32,54 +32,46 @@ */ public class GpgVersion implements Comparable {

[GitHub] [maven-gpg-plugin] Syquel commented on a change in pull request #11: [MGPG-81] check format in constructor

2021-02-26 Thread GitBox
Syquel commented on a change in pull request #11: URL: https://github.com/apache/maven-gpg-plugin/pull/11#discussion_r583733147 ## File path: src/main/java/org/apache/maven/plugins/gpg/GpgVersion.java ## @@ -32,54 +32,46 @@ */ public class GpgVersion implements Comparable {

[GitHub] [maven-gpg-plugin] Syquel commented on a change in pull request #11: [MGPG-81] check format in constructor

2021-02-26 Thread GitBox
Syquel commented on a change in pull request #11: URL: https://github.com/apache/maven-gpg-plugin/pull/11#discussion_r583724425 ## File path: src/main/java/org/apache/maven/plugins/gpg/GpgVersion.java ## @@ -32,54 +32,46 @@ */ public class GpgVersion implements Comparable {

[GitHub] [maven] michael-o commented on a change in pull request #446: [MNG-6511] - Optional project selection

2021-02-26 Thread GitBox
michael-o commented on a change in pull request #446: URL: https://github.com/apache/maven/pull/446#discussion_r583723197 ## File path: maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java ## @@ -242,21 +274,17 @@ public DefaultGraphBuilder( BuildResumption

[GitHub] [maven] michael-o commented on a change in pull request #446: [MNG-6511] - Optional project selection

2021-02-26 Thread GitBox
michael-o commented on a change in pull request #446: URL: https://github.com/apache/maven/pull/446#discussion_r583711304 ## File path: maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java ## @@ -176,38 +177,69 @@ public DefaultGraphBuilder( BuildResumption

[GitHub] [maven-integration-testing] mthmulders commented on a change in pull request #100: [MNG-6511] - Optional project selection

2021-02-26 Thread GitBox
mthmulders commented on a change in pull request #100: URL: https://github.com/apache/maven-integration-testing/pull/100#discussion_r583691119 ## File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6511OptionalProjectSelectionTest.java ## @@ -0,0 +1,104 @@ +p

[jira] [Updated] (MNGSITE-444) Add documentation around project selection

2021-02-26 Thread Maarten Mulders (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maarten Mulders updated MNGSITE-444: Description: With Maven 4, a lot has changed in how a user can select which modules in a

[jira] [Created] (MNGSITE-444) Add documentation around project selection

2021-02-26 Thread Maarten Mulders (Jira)
Maarten Mulders created MNGSITE-444: --- Summary: Add documentation around project selection Key: MNGSITE-444 URL: https://issues.apache.org/jira/browse/MNGSITE-444 Project: Maven Project Web Site

[GitHub] [maven] mthmulders commented on a change in pull request #446: [MNG-6511] - Optional project selection

2021-02-26 Thread GitBox
mthmulders commented on a change in pull request #446: URL: https://github.com/apache/maven/pull/446#discussion_r583683653 ## File path: maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java ## @@ -242,21 +274,17 @@ public DefaultGraphBuilder( BuildResumptio

[GitHub] [maven-gpg-plugin] elharo commented on a change in pull request #11: [MGPG-81] check format in constructor

2021-02-26 Thread GitBox
elharo commented on a change in pull request #11: URL: https://github.com/apache/maven-gpg-plugin/pull/11#discussion_r583681815 ## File path: src/main/java/org/apache/maven/plugins/gpg/GpgVersion.java ## @@ -32,54 +32,46 @@ */ public class GpgVersion implements Comparable {

[GitHub] [maven] mthmulders commented on a change in pull request #446: [MNG-6511] - Optional project selection

2021-02-26 Thread GitBox
mthmulders commented on a change in pull request #446: URL: https://github.com/apache/maven/pull/446#discussion_r583681131 ## File path: maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java ## @@ -176,38 +177,69 @@ public DefaultGraphBuilder( BuildResumptio

[GitHub] [maven] michael-o commented on a change in pull request #446: [MNG-6511] - Optional project selection

2021-02-26 Thread GitBox
michael-o commented on a change in pull request #446: URL: https://github.com/apache/maven/pull/446#discussion_r583681045 ## File path: maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java ## @@ -242,21 +274,17 @@ public DefaultGraphBuilder( BuildResumption

[GitHub] [maven] mthmulders commented on a change in pull request #446: [MNG-6511] - Optional project selection

2021-02-26 Thread GitBox
mthmulders commented on a change in pull request #446: URL: https://github.com/apache/maven/pull/446#discussion_r583679349 ## File path: maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java ## @@ -242,21 +274,17 @@ public DefaultGraphBuilder( BuildResumptio

[GitHub] [maven] michael-o commented on a change in pull request #446: [MNG-6511] - Optional project selection

2021-02-26 Thread GitBox
michael-o commented on a change in pull request #446: URL: https://github.com/apache/maven/pull/446#discussion_r583678292 ## File path: maven-core/src/main/java/org/apache/maven/execution/ProjectActivation.java ## @@ -0,0 +1,173 @@ +package org.apache.maven.execution; + +/* +

[jira] [Commented] (MSHARED-979) maven-shared-components uses commons-io 2.6 which is vulnerable to sonatype-2018-0705

2021-02-26 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291677#comment-17291677 ] Elliotte Rusty Harold commented on MSHARED-979: --- do we use the vulnerable

[GitHub] [maven] mthmulders commented on a change in pull request #446: [MNG-6511] - Optional project selection

2021-02-26 Thread GitBox
mthmulders commented on a change in pull request #446: URL: https://github.com/apache/maven/pull/446#discussion_r583671079 ## File path: maven-core/src/main/java/org/apache/maven/execution/ProjectActivation.java ## @@ -0,0 +1,173 @@ +package org.apache.maven.execution; + +/* +

[jira] [Created] (MSHARED-980) Xpp3DomBuilder does not handle XML encoding per spec

2021-02-26 Thread Elliotte Rusty Harold (Jira)
Elliotte Rusty Harold created MSHARED-980: - Summary: Xpp3DomBuilder does not handle XML encoding per spec Key: MSHARED-980 URL: https://issues.apache.org/jira/browse/MSHARED-980 Project: Maven

[GitHub] [maven] mthmulders commented on a change in pull request #446: [MNG-6511] - Optional project selection

2021-02-26 Thread GitBox
mthmulders commented on a change in pull request #446: URL: https://github.com/apache/maven/pull/446#discussion_r583665464 ## File path: maven-core/src/main/java/org/apache/maven/execution/ProfileActivation.java ## @@ -74,7 +44,7 @@ static ActivationSettings of( final boolean

[GitHub] [maven] mthmulders commented on a change in pull request #446: [MNG-6511] - Optional project selection

2021-02-26 Thread GitBox
mthmulders commented on a change in pull request #446: URL: https://github.com/apache/maven/pull/446#discussion_r583665088 ## File path: maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java ## @@ -278,55 +290,61 @@ MavenExecutionRequest setProfil

[GitHub] [maven] mthmulders opened a new pull request #452: [MNG-7051] Update deprecated methods related to profile selection

2021-02-26 Thread GitBox
mthmulders opened a new pull request #452: URL: https://github.com/apache/maven/pull/452 In #429 we deprecated a few methods related to selecting a profile from the CLI. This pull request updates those deprecated methods, so its easier to find their replacements. Also, the deprecate

[GitHub] [maven-shared-utils] elharo merged pull request #80: Test, fix, and deprecate buggy copyDirectory methods

2021-02-26 Thread GitBox
elharo merged pull request #80: URL: https://github.com/apache/maven-shared-utils/pull/80 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [maven] rfscholte commented on a change in pull request #451: [MNG-7107] relax profile id validation, different from coordinate id

2021-02-26 Thread GitBox
rfscholte commented on a change in pull request #451: URL: https://github.com/apache/maven/pull/451#discussion_r583625188 ## File path: maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java ## @@ -850,36 +853,75 @@ private boolean valid

[GitHub] [maven] rfscholte commented on a change in pull request #451: [MNG-7107] relax profile id validation, different from coordinate id

2021-02-26 Thread GitBox
rfscholte commented on a change in pull request #451: URL: https://github.com/apache/maven/pull/451#discussion_r583625188 ## File path: maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java ## @@ -850,36 +853,75 @@ private boolean valid

[GitHub] [maven] rfscholte commented on a change in pull request #451: [MNG-7107] relax profile id validation, different from coordinate id

2021-02-26 Thread GitBox
rfscholte commented on a change in pull request #451: URL: https://github.com/apache/maven/pull/451#discussion_r583624081 ## File path: maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java ## @@ -916,7 +958,7 @@ private boolean isValid

[GitHub] [maven-gpg-plugin] Syquel commented on a change in pull request #11: [MGPG-80][MGPG-81] refactor GpgVersion

2021-02-26 Thread GitBox
Syquel commented on a change in pull request #11: URL: https://github.com/apache/maven-gpg-plugin/pull/11#discussion_r583617698 ## File path: src/main/java/org/apache/maven/plugins/gpg/GpgVersion.java ## @@ -32,54 +33,46 @@ */ public class GpgVersion implements Comparable {

[GitHub] [maven-gpg-plugin] Syquel commented on pull request #11: [MGPG-80][MGPG-81] refactor GpgVersion

2021-02-26 Thread GitBox
Syquel commented on pull request #11: URL: https://github.com/apache/maven-gpg-plugin/pull/11#issuecomment-786625342 > > > can you split this into individual PRs for each issue? That makes it much easier to review and track in Jira and release notes. I will reduce this PR to

[GitHub] [maven-gpg-plugin] elharo commented on a change in pull request #11: [MGPG-80][MGPG-81] refactor GpgVersion

2021-02-26 Thread GitBox
elharo commented on a change in pull request #11: URL: https://github.com/apache/maven-gpg-plugin/pull/11#discussion_r583608230 ## File path: src/main/java/org/apache/maven/plugins/gpg/GpgVersion.java ## @@ -32,54 +33,46 @@ */ public class GpgVersion implements Comparable {

[GitHub] [maven-gpg-plugin] elharo commented on a change in pull request #11: [MGPG-80][MGPG-81] refactor GpgVersion

2021-02-26 Thread GitBox
elharo commented on a change in pull request #11: URL: https://github.com/apache/maven-gpg-plugin/pull/11#discussion_r583605971 ## File path: src/test/java/org/apache/maven/plugins/gpg/GpgVersionTest.java ## @@ -48,4 +50,17 @@ public void testOpposite() assertFalse( Gp

[jira] [Commented] (MNG-7051) Optionally skip non-existing profiles

2021-02-26 Thread Maarten Mulders (Jira)
[ https://issues.apache.org/jira/browse/MNG-7051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291617#comment-17291617 ] Maarten Mulders commented on MNG-7051: -- {quote}I have a question on this feature: in t

[jira] [Commented] (MGPG-80) GPGVersion compareTo is not consistent with equals

2021-02-26 Thread Frederik Boster (Jira)
[ https://issues.apache.org/jira/browse/MGPG-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291604#comment-17291604 ] Frederik Boster commented on MGPG-80: - I submitted a proposal in [PR #11|https://github

[jira] [Commented] (MGPG-81) GPGVersion.compareTo misuses IllegalArgumentException

2021-02-26 Thread Frederik Boster (Jira)
[ https://issues.apache.org/jira/browse/MGPG-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291603#comment-17291603 ] Frederik Boster commented on MGPG-81: - I submitted a proposal in [PR #11|https://github

[GitHub] [maven-gpg-plugin] Syquel opened a new pull request #11: [MGPG-80][MGPG-81] refactor GpgVersion

2021-02-26 Thread GitBox
Syquel opened a new pull request #11: URL: https://github.com/apache/maven-gpg-plugin/pull/11 Provides an refactored implementation of GpgVersion to address [MGPG-80](https://issues.apache.org/jira/projects/MGPG/issues/MGPG-80) and [MGPG-81](https://issues.apache.org/jira/projects/MGPG/iss

[jira] [Commented] (MGPG-66) sign goal's "excludes" configuration ignored

2021-02-26 Thread Frederik Boster (Jira)
[ https://issues.apache.org/jira/browse/MGPG-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291596#comment-17291596 ] Frederik Boster commented on MGPG-66: - I submitted a similar patch via [PR #10|https://

[GitHub] [maven-gpg-plugin] Syquel opened a new pull request #10: [MGPG-66] fix handling of excluded files

2021-02-26 Thread GitBox
Syquel opened a new pull request #10: URL: https://github.com/apache/maven-gpg-plugin/pull/10 Fixes [MGPG-66](https://issues.apache.org/jira/projects/MGPG/issues/MGPG-66) by adding a check if files match the exclude patterns. ---

[jira] [Commented] (MGPG-79) plugin hangs on first run on Windows Git Bash with Kleopatra

2021-02-26 Thread Frederik Boster (Jira)
[ https://issues.apache.org/jira/browse/MGPG-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291588#comment-17291588 ] Frederik Boster commented on MGPG-79: - The root cause is that the [GpgSigner|https://gi

[GitHub] [maven-gpg-plugin] Syquel opened a new pull request #9: [MGPG-79] fix handling of external pinentry programs in case the passphrase is not given

2021-02-26 Thread GitBox
Syquel opened a new pull request #9: URL: https://github.com/apache/maven-gpg-plugin/pull/9 Fixes [MGPG-79](https://issues.apache.org/jira/projects/MGPG/issues/MGPG-79) by using the default "pinentry-mode" if no passphrase for the GPG key is given. Only in case a passphrase for the GPG k

[jira] [Commented] (MNG-7107) relax recently introduced profile id validation

2021-02-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291584#comment-17291584 ] Hudson commented on MNG-7107: - Build succeeded in Jenkins: Maven » Maven TLP » maven » MNG-7107

[GitHub] [maven] Tibor17 commented on pull request #451: [MNG-7107] relax profile id validation, different from coordinate id

2021-02-26 Thread GitBox
Tibor17 commented on pull request #451: URL: https://github.com/apache/maven/pull/451#issuecomment-786574176 It would be worth for future maintenance to create a new class checking these characters in profile id because both classes `DefaultModelValidator` and `MavenCli` are chcecking the

[GitHub] [maven] michael-o commented on pull request #451: [MNG-7107] relax profile id validation, different from coordinate id

2021-02-26 Thread GitBox
michael-o commented on pull request #451: URL: https://github.com/apache/maven/pull/451#issuecomment-786568088 I will test your change later this day... This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (MNG-7051) Optionally skip non-existing profiles

2021-02-26 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MNG-7051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291549#comment-17291549 ] Herve Boutemy commented on MNG-7051: I have a question on this feature: in the case of

[GitHub] [maven] hboutemy commented on pull request #451: [MNG-7107] relax profile id validation, different from coordinate id

2021-02-26 Thread GitBox
hboutemy commented on pull request #451: URL: https://github.com/apache/maven/pull/451#issuecomment-786552743 ok, I found "optional profile activation" https://github.com/apache/maven/blob/master/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java#L1515 IMHO, this will re

[GitHub] [maven] michael-o commented on pull request #451: [MNG-7107] relax profile id validation, different from coordinate id

2021-02-26 Thread GitBox
michael-o commented on pull request #451: URL: https://github.com/apache/maven/pull/451#issuecomment-786551240 A recent change make profile activatoins mandatory, unless it is prefixed with `?`. See https://github.com/apache/maven/commit/8defd169651db30fe0ac3ad3f318e471f0241d02.

[GitHub] [maven] hboutemy commented on pull request #451: [MNG-7107] relax profile id validation, different from coordinate id

2021-02-26 Thread GitBox
hboutemy commented on pull request #451: URL: https://github.com/apache/maven/pull/451#issuecomment-786549495 I coded the few cases I thought I knew about `-P` in `mvn` command line but it seems I don't know what `?` means: I don't see it in code https://github.com/apache/maven/blob/mast

[jira] [Commented] (MNGSITE-443) Add setFile to Mojo Cookbook (website)

2021-02-26 Thread Casper Roubos (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291492#comment-17291492 ] Casper Roubos commented on MNGSITE-443: --- Hi, Yes, this issue is in regard to the

[GitHub] [maven] michael-o commented on pull request #451: [MNG-7107] relax profile id validation, different from coordinate id

2021-02-26 Thread GitBox
michael-o commented on pull request #451: URL: https://github.com/apache/maven/pull/451#issuecomment-786508314 > > > @michael-o > You mean something like this? > `-P ?+my-profile` or `-P +my-profile`, is it an expression? If it is, what kind of meaning? Yes and both are

[GitHub] [maven] Tibor17 commented on pull request #451: [MNG-7107] relax profile id validation, different from coordinate id

2021-02-26 Thread GitBox
Tibor17 commented on pull request #451: URL: https://github.com/apache/maven/pull/451#issuecomment-786506325 @michael-o You mean something like this? `-P ?+my-profile` or `-P +my-profile`, is it an expression? If it is, what kind of meaning?

[GitHub] [maven] michael-o commented on pull request #451: [MNG-7107] relax profile id validation, different from coordinate id

2021-02-26 Thread GitBox
michael-o commented on pull request #451: URL: https://github.com/apache/maven/pull/451#issuecomment-786504825 I would still ike to have clarified for `?, `-`, `+`, and `!`. This is an automated message from the Apache Git Se

[GitHub] [maven] Tibor17 commented on pull request #451: [MNG-7107] relax profile id validation, different from coordinate id

2021-02-26 Thread GitBox
Tibor17 commented on pull request #451: URL: https://github.com/apache/maven/pull/451#issuecomment-786503191 I think this implementation covers my requirement mentioned in Jira. Go ahead with the commit. Feel free to add a test into it. ---

[GitHub] [maven] Tibor17 commented on pull request #451: [MNG-7107] relax profile id validation, different from coordinate id

2021-02-26 Thread GitBox
Tibor17 commented on pull request #451: URL: https://github.com/apache/maven/pull/451#issuecomment-786499982 As I have understood one old feature request that this pattern `-my-profile` would exclude the profile `my-profile`. So I understood that the minus is part of the expression. Simi

[jira] [Commented] (MNG-7095) Support for parallel builds when resuming

2021-02-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291463#comment-17291463 ] Hudson commented on MNG-7095: - Build unstable in Jenkins: Maven » Maven TLP » maven-studies » m

[jira] [Commented] (MNG-7029) Remove super POM release profile

2021-02-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291462#comment-17291462 ] Hudson commented on MNG-7029: - Build unstable in Jenkins: Maven » Maven TLP » maven-studies » m

[jira] [Commented] (MNG-7051) Optionally skip non-existing profiles

2021-02-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291461#comment-17291461 ] Hudson commented on MNG-7051: - Build unstable in Jenkins: Maven » Maven TLP » maven-studies » m