[GitHub] [maven-shared-utils] gnodet commented on pull request #67: [MNG-6380] Option -Dstyle.color=always doesn't force color output

2021-01-21 Thread GitBox
gnodet commented on pull request #67: URL: https://github.com/apache/maven-shared-utils/pull/67#issuecomment-765203066 > I saw that something have changed in relation to unpacking libs. What native lib version will be used if we unpack (for maven core) lib to dedicated directory and set en

[GitHub] [maven-wagon] medb closed pull request #75: [WAGON-575] Add high-level download retries

2021-01-21 Thread GitBox
medb closed pull request #75: URL: https://github.com/apache/maven-wagon/pull/75 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven-wagon] medb commented on pull request #75: [WAGON-575] Add high-level download retries

2021-01-21 Thread GitBox
medb commented on pull request #75: URL: https://github.com/apache/maven-wagon/pull/75#issuecomment-765148607 Closing this PR because root cause of the [WAGON-575](https://issues.apache.org/jira/browse/WAGON-575) is [JDK-8214339](https://bugs.openjdk.java.net/browse/JDK-8214339) bug (see

[GitHub] [maven-wagon] medb edited a comment on pull request #75: [WAGON-575] Add high-level download retries

2021-01-21 Thread GitBox
medb edited a comment on pull request #75: URL: https://github.com/apache/maven-wagon/pull/75#issuecomment-765148607 Closing this PR because root cause of the [WAGON-575](https://issues.apache.org/jira/browse/WAGON-575) is [JDK-8214339](https://bugs.openjdk.java.net/browse/JDK-8214339) bug

[GitHub] [maven] gnodet commented on pull request #435: [MNG-7032] Evaluate --help and --version after configuring the logging/color

2021-01-21 Thread GitBox
gnodet commented on pull request #435: URL: https://github.com/apache/maven/pull/435#issuecomment-764761651 Supersedes https://github.com/apache/maven/pull/415 with a simpler change that allows supporting `mvn -v -l file` too. --

[GitHub] [maven-surefire] Tibor17 commented on pull request #331: [SUREFIRE-1876] Added support for skipping unit test execution not affecting integration test execution

2021-01-21 Thread GitBox
Tibor17 commented on pull request #331: URL: https://github.com/apache/maven-surefire/pull/331#issuecomment-764556997 I meant splitting the plugin configurations, not spliting the projects. This is an automated message from t

[GitHub] [maven-surefire] tobiasstadler commented on pull request #331: [SUREFIRE-1876] Added support for skipping unit test execution not affecting integration test execution

2021-01-21 Thread GitBox
tobiasstadler commented on pull request #331: URL: https://github.com/apache/maven-surefire/pull/331#issuecomment-764537096 Splitting the plugin would also solve my problem. Do you know when this will happen? This is an auto

[GitHub] [maven-shared-utils] gnodet commented on pull request #67: [MNG-6380] Update the wrapped jansi streams

2021-01-21 Thread GitBox
gnodet commented on pull request #67: URL: https://github.com/apache/maven-shared-utils/pull/67#issuecomment-764529402 Rebased on top of #69 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [maven-resolver] cstamas commented on pull request #77: [MRESOLVER-145] SyncContext implementations

2021-01-21 Thread GitBox
cstamas commented on pull request #77: URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-764908120 @michael-o @rmannibucau My proposal is to merge this PR, we already know current master is broken (see MRESOLVER-153), and while in this PR I did "return" (well, copied to ne

[GitHub] [maven-resolver] michael-o commented on pull request #77: [MRESOLVER-145] SyncContext implementations

2021-01-21 Thread GitBox
michael-o commented on pull request #77: URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-764929160 I need to go through another iteration because I wasn't really happy with some things last time, plus I need test myself too. I am currently on a short leash, but will try

[GitHub] [maven-resolver] michael-o commented on pull request #88: [MRESOLVER-157] Drop ServiceLocator

2021-01-21 Thread GitBox
michael-o commented on pull request #88: URL: https://github.com/apache/maven-resolver/pull/88#issuecomment-764772183 Please note that Maven Core uses this stupid locator too: https://github.com/apache/maven/blob/39641ac803e17360df40288aaeb40ea0c5ccd77d/maven-resolver-provider/src/main/java

[GitHub] [maven-shared-utils] rfscholte commented on pull request #69: [MSHARED-973] Upgrade jansi to 2.2.0

2021-01-21 Thread GitBox
rfscholte commented on pull request #69: URL: https://github.com/apache/maven-shared-utils/pull/69#issuecomment-764899882 Merged with https://github.com/apache/maven-shared-utils/commit/c6ae1438bc08fe202fbd699af324ce1a81396dc9 --

[GitHub] [maven-scm] cquoss commented on a change in pull request #109: [SCM-947]

2021-01-21 Thread GitBox
cquoss commented on a change in pull request #109: URL: https://github.com/apache/maven-scm/pull/109#discussion_r561290337 ## File path: maven-scm-plugin/src/main/java/org/apache/maven/scm/plugin/ChangeLogMojo.java ## @@ -125,24 +145,58 @@ public void execute()

[jira] [Commented] (WAGON-575) Retry for connection issues

2021-01-21 Thread Igor Dvorzhak (Jira)
[ https://issues.apache.org/jira/browse/WAGON-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269843#comment-17269843 ] Igor Dvorzhak commented on WAGON-575: - After looking closer in the root cause of this

[GitHub] [maven-scm] cquoss commented on a change in pull request #110: [SCM-948] Make the limit parameter work for git and svn exe

2021-01-21 Thread GitBox
cquoss commented on a change in pull request #110: URL: https://github.com/apache/maven-scm/pull/110#discussion_r561282580 ## File path: maven-scm-api/src/main/java/org/apache/maven/scm/command/changelog/AbstractChangeLogCommand.java ## @@ -96,11 +122,25 @@ public ScmResult ex

[GitHub] [maven-shared-utils] rfscholte closed pull request #69: [MSHARED-973] Upgrade jansi to 2.2.0

2021-01-21 Thread GitBox
rfscholte closed pull request #69: URL: https://github.com/apache/maven-shared-utils/pull/69 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (MPLUGIN-358) Cannot build plugin embedding java 13 compiled code

2021-01-21 Thread Matthias Fuchs (Jira)
[ https://issues.apache.org/jira/browse/MPLUGIN-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269669#comment-17269669 ] Matthias Fuchs commented on MPLUGIN-358: What's the reason for not releasing the

[GitHub] [maven-resolver] michael-o commented on pull request #77: [MRESOLVER-145] SyncContext implementations

2021-01-21 Thread GitBox
michael-o commented on pull request #77: URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-764929160 I need to go through another iteration because I wasn't really happy with some things last time, plus I need test myself too. I am currently on a short leash, but will try

[GitHub] [maven-resolver] cstamas commented on pull request #77: [MRESOLVER-145] SyncContext implementations

2021-01-21 Thread GitBox
cstamas commented on pull request #77: URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-764908120 @michael-o @rmannibucau My proposal is to merge this PR, we already know current master is broken (see MRESOLVER-153), and while in this PR I did "return" (well, copied to ne

[jira] [Commented] (MSHARED-973) Upgrade Jansi to 2.2.0

2021-01-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269591#comment-17269591 ] Hudson commented on MSHARED-973: Build succeeded in Jenkins: Maven » Maven TLP » maven-s

[GitHub] [maven-shared-utils] rfscholte closed pull request #69: [MSHARED-973] Upgrade jansi to 2.2.0

2021-01-21 Thread GitBox
rfscholte closed pull request #69: URL: https://github.com/apache/maven-shared-utils/pull/69 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [maven-shared-utils] rfscholte commented on pull request #69: [MSHARED-973] Upgrade jansi to 2.2.0

2021-01-21 Thread GitBox
rfscholte commented on pull request #69: URL: https://github.com/apache/maven-shared-utils/pull/69#issuecomment-764899882 Merged with https://github.com/apache/maven-shared-utils/commit/c6ae1438bc08fe202fbd699af324ce1a81396dc9 --

[jira] [Closed] (MSHARED-973) Upgrade Jansi to 2.2.0

2021-01-21 Thread Robert Scholte (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MSHARED-973. -- Fix Version/s: maven-shared-utils-3.4.0 Assignee: Robert Scholte Resolution: Fi

[jira] [Updated] (MSHARED-973) Upgrade Jansi to 2.2.0

2021-01-21 Thread Robert Scholte (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte updated MSHARED-973: --- Issue Type: Dependency upgrade (was: Improvement) > Upgrade Jansi to 2.2.0 > --

[jira] [Commented] (MNG-7080) Add a --color argument

2021-01-21 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269577#comment-17269577 ] Michael Osipov commented on MNG-7080: - I strongly support this. > Add a --color argume

[GitHub] [maven] gnodet opened a new pull request #436: Add a --color option to simplify color support

2021-01-21 Thread GitBox
gnodet opened a new pull request #436: URL: https://github.com/apache/maven/pull/436 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the

[GitHub] [maven-resolver] michael-o commented on pull request #88: [MRESOLVER-157] Drop ServiceLocator

2021-01-21 Thread GitBox
michael-o commented on pull request #88: URL: https://github.com/apache/maven-resolver/pull/88#issuecomment-764772183 Please note that Maven Core uses this stupid locator too: https://github.com/apache/maven/blob/39641ac803e17360df40288aaeb40ea0c5ccd77d/maven-resolver-provider/src/main/java

[jira] [Created] (MNG-7080) Add a --color argument

2021-01-21 Thread Guillaume Nodet (Jira)
Guillaume Nodet created MNG-7080: Summary: Add a --color argument Key: MNG-7080 URL: https://issues.apache.org/jira/browse/MNG-7080 Project: Maven Issue Type: Improvement Reporter

[GitHub] [maven] gnodet commented on pull request #435: [MNG-7032] Evaluate --help and --version after configuring the logging/color

2021-01-21 Thread GitBox
gnodet commented on pull request #435: URL: https://github.com/apache/maven/pull/435#issuecomment-764761651 Supersedes https://github.com/apache/maven/pull/415 with a simpler change that allows supporting `mvn -v -l file` too. --

[GitHub] [maven] gnodet opened a new pull request #435: [MNG-7032] Evaluate --help and --version after configuring the logging/color

2021-01-21 Thread GitBox
gnodet opened a new pull request #435: URL: https://github.com/apache/maven/pull/435 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the

[jira] [Commented] (MNG-6755) Console remains colored on build failed

2021-01-21 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-6755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269393#comment-17269393 ] Guillaume Nodet commented on MNG-6755: -- Upgrading to Jansi 2.2.0 has a good chance to

[jira] [Commented] (MNG-6915) Maven console output could be wider

2021-01-21 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-6915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269381#comment-17269381 ] Guillaume Nodet commented on MNG-6915: -- Now that Jansi 2.2.0 has been released, I've p

[GitHub] [maven-shared-utils] gnodet opened a new pull request #70: [MNG-6915] Add a helper method to get the terminal width

2021-01-21 Thread GitBox
gnodet opened a new pull request #70: URL: https://github.com/apache/maven-shared-utils/pull/70 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[jira] [Comment Edited] (MRESOURCES-265) Resource copying not using specified encoding

2021-01-21 Thread Jira
[ https://issues.apache.org/jira/browse/MRESOURCES-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269378#comment-17269378 ] Søren Nielsen edited comment on MRESOURCES-265 at 1/21/21, 3:29 PM: ---

[jira] [Commented] (MRESOURCES-265) Resource copying not using specified encoding

2021-01-21 Thread Jira
[ https://issues.apache.org/jira/browse/MRESOURCES-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269378#comment-17269378 ] Søren Nielsen commented on MRESOURCES-265: -- I had the same issue and luckily

[GitHub] [maven] gnodet opened a new pull request #434: [MNG-6915] Format help according to the terminal width

2021-01-21 Thread GitBox
gnodet opened a new pull request #434: URL: https://github.com/apache/maven/pull/434 This PR is built on top of #433 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [maven] gnodet opened a new pull request #433: [MNG-7079] Upgrade to jansi 2.2.0

2021-01-21 Thread GitBox
gnodet opened a new pull request #433: URL: https://github.com/apache/maven/pull/433 This PR depends on https://github.com/apache/maven-shared-utils/pull/69 and the release of `maven-shared-utils`. This is an automated messa

[jira] [Commented] (MNG-6719) mvn color output escape keys w/ "| tee xxx.log" on Win with git/bash

2021-01-21 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-6719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269244#comment-17269244 ] Guillaume Nodet commented on MNG-6719: -- I confirm this issue is fixed with MNG-7079 /

[GitHub] [maven-surefire] Tibor17 commented on pull request #331: [SUREFIRE-1876] Added support for skipping unit test execution not affecting integration test execution

2021-01-21 Thread GitBox
Tibor17 commented on pull request #331: URL: https://github.com/apache/maven-surefire/pull/331#issuecomment-764556997 I meant splitting the plugin configurations, not spliting the projects. This is an automated message from t

[GitHub] [maven-surefire] tobiasstadler commented on pull request #331: [SUREFIRE-1876] Added support for skipping unit test execution not affecting integration test execution

2021-01-21 Thread GitBox
tobiasstadler commented on pull request #331: URL: https://github.com/apache/maven-surefire/pull/331#issuecomment-764537096 Splitting the plugin would also solve my problem. Do you know when this will happen? This is an auto

[jira] [Comment Edited] (MSHARED-822) MessageBuilder should support Paths

2021-01-21 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269196#comment-17269196 ] Guillaume Nodet edited comment on MSHARED-822 at 1/21/21, 10:27 AM: --

[jira] [Commented] (MSHARED-822) MessageBuilder should support Paths

2021-01-21 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269196#comment-17269196 ] Guillaume Nodet commented on MSHARED-822: - Hyperlinks are somewhat supported by

[GitHub] [maven-shared-utils] gnodet commented on pull request #67: [MNG-6380] Update the wrapped jansi streams

2021-01-21 Thread GitBox
gnodet commented on pull request #67: URL: https://github.com/apache/maven-shared-utils/pull/67#issuecomment-764529402 Rebased on top of #69 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [maven-shared-utils] gnodet opened a new pull request #69: [MSHARED-973] Upgrade jansi to 2.2.0

2021-01-21 Thread GitBox
gnodet opened a new pull request #69: URL: https://github.com/apache/maven-shared-utils/pull/69 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[jira] [Created] (SUREFIRE-1880) Run nested junit test from abstract class

2021-01-21 Thread jakob braun (Jira)
jakob braun created SUREFIRE-1880: - Summary: Run nested junit test from abstract class Key: SUREFIRE-1880 URL: https://issues.apache.org/jira/browse/SUREFIRE-1880 Project: Maven Surefire Issu