[jira] [Resolved] (MNG-7025) Classified dependencies not resolved in workspace

2020-11-19 Thread Maarten Mulders (Jira)
[ https://issues.apache.org/jira/browse/MNG-7025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maarten Mulders resolved MNG-7025. -- Resolution: Not A Problem Need to at least invoke {{test-compile}} before the *test-jar* is avail

[GitHub] [maven-integration-testing] mthmulders closed pull request #81: [MNG-7025] Verify classified artifacts can also be resolved in the workspace

2020-11-19 Thread GitBox
mthmulders closed pull request #81: URL: https://github.com/apache/maven-integration-testing/pull/81 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [maven-common-artifact-filters] gnodet commented on pull request #15: Big speed improvements for patterns that do not contain any wildcard

2020-11-19 Thread GitBox
gnodet commented on pull request #15: URL: https://github.com/apache/maven-common-artifact-filters/pull/15#issuecomment-730702391 @olamy @cstamas please have another look at the last commit, it fixes a bunch of corner cases, but most importantly, optimize the patterns in all use cases by

[GitHub] [maven-common-artifact-filters] gnodet commented on pull request #15: Big speed improvements for patterns that do not contain any wildcard

2020-11-19 Thread GitBox
gnodet commented on pull request #15: URL: https://github.com/apache/maven-common-artifact-filters/pull/15#issuecomment-730701680 I've quite rewritten the class to optimize if in all scenarii. The code of the [match method](https://github.com/gnodet/maven-common-artifact-filters/blob/83

[GitHub] [maven-enforcer] jglick commented on pull request #25: MENFORCER-276 - Support ignoring dependency scopes in RequireUpperBoundDeps

2020-11-19 Thread GitBox
jglick commented on pull request #25: URL: https://github.com/apache/maven-enforcer/pull/25#issuecomment-730679116 @uhafner the error message in your case looks legitimate. https://github.com/apache/maven-enforcer/pull/25#pullrequestreview-47866562

[jira] [Commented] (MJLINK-36) Use JLink via ToolProvider

2020-11-19 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MJLINK-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235729#comment-17235729 ] Hudson commented on MJLINK-36: -- Build succeeded in Jenkins: Maven » Maven TLP » maven-jlink-p

[jira] [Updated] (MCHANGES-409) allow to completely skip github report

2020-11-19 Thread Luc Maisonobe (Jira)
[ https://issues.apache.org/jira/browse/MCHANGES-409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luc Maisonobe updated MCHANGES-409: --- Description: When using changes plugin on a project hosted at GitHub, there is always an a

[jira] [Created] (MCHANGES-409) allow to completely skip github report

2020-11-19 Thread Luc Maisonobe (Jira)
Luc Maisonobe created MCHANGES-409: -- Summary: allow to completely skip github report Key: MCHANGES-409 URL: https://issues.apache.org/jira/browse/MCHANGES-409 Project: Maven Changes Plugin I

[jira] [Commented] (MCHANGES-400) Can't connect to GitHub using OAuth token

2020-11-19 Thread Luc Maisonobe (Jira)
[ https://issues.apache.org/jira/browse/MCHANGES-400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235688#comment-17235688 ] Luc Maisonobe commented on MCHANGES-400: I think this issue became more importa

[jira] [Updated] (MNG-7026) Ability to only build direct dependants

2020-11-19 Thread Chadi (Jira)
[ https://issues.apache.org/jira/browse/MNG-7026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chadi updated MNG-7026: --- Description: We are an organization with a large reactor. When we update a project X, we would like to have the possib

[jira] [Created] (MNG-7026) Ability to only build direct dependants

2020-11-19 Thread Chadi (Jira)
Chadi created MNG-7026: -- Summary: Ability to only build direct dependants Key: MNG-7026 URL: https://issues.apache.org/jira/browse/MNG-7026 Project: Maven Issue Type: New Feature Components: C

[jira] [Commented] (MPLUGIN-358) Cannot build plugin embedding java 13 compiled code

2020-11-19 Thread Matt Hias (Jira)
[ https://issues.apache.org/jira/browse/MPLUGIN-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235628#comment-17235628 ] Matt Hias commented on MPLUGIN-358: --- Are there plans to rollout the version 3.6.1 ? [

[jira] [Updated] (MJLINK-36) Use JLink via ToolProvider

2020-11-19 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MJLINK-36?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MJLINK-36: --- Fix Version/s: 3.0.1 > Use JLink via ToolProvider > -- > >

[jira] [Closed] (MJLINK-51) Update site with latest SCM info

2020-11-19 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MJLINK-51?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MJLINK-51. -- Resolution: Done > Update site with latest SCM info > >

[jira] [Commented] (MJLINK-51) Update site with latest SCM info

2020-11-19 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MJLINK-51?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235618#comment-17235618 ] Sylwester Lachiewicz commented on MJLINK-51: Vote on next release started, ple

[jira] [Updated] (MJLINK-57) Migrate to slf4j

2020-11-19 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MJLINK-57?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MJLINK-57: --- Fix Version/s: 3.0.1 > Migrate to slf4j > > > Key: MJ

[jira] [Updated] (MJLINK-58) Remove usage of plexus utils, use commons lang or native java instead.

2020-11-19 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MJLINK-58?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MJLINK-58: --- Fix Version/s: 3.0.1 > Remove usage of plexus utils, use commons lang or native java i

[jira] [Closed] (MJLINK-48) 3.0.0-alpha-2 Release

2020-11-19 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MJLINK-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MJLINK-48. -- Resolution: Done > 3.0.0-alpha-2 Release > - > > Key

[jira] [Commented] (MJLINK-48) 3.0.0-alpha-2 Release

2020-11-19 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MJLINK-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235617#comment-17235617 ] Sylwester Lachiewicz commented on MJLINK-48: Vote on version 3.0 started here:

[GitHub] [maven-enforcer] oleg-nenashev commented on pull request #25: MENFORCER-276 - Support ignoring dependency scopes in RequireUpperBoundDeps

2020-11-19 Thread GitBox
oleg-nenashev commented on pull request #25: URL: https://github.com/apache/maven-enforcer/pull/25#issuecomment-730523427 I am still around if any help is needed This is an automated message from the Apache Git Service. To re

[jira] [Commented] (MJLINK-36) Use JLink via ToolProvider

2020-11-19 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MJLINK-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235605#comment-17235605 ] Hudson commented on MJLINK-36: -- Build succeeded in Jenkins: Maven » Maven TLP » maven-jlink-p

[GitHub] [maven-jlink-plugin] slachiewicz closed pull request #13: remove unused JUnit 5

2020-11-19 Thread GitBox
slachiewicz closed pull request #13: URL: https://github.com/apache/maven-jlink-plugin/pull/13 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Commented] (MJLINK-56) Convert unit tests to Junit5

2020-11-19 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MJLINK-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235603#comment-17235603 ] Hudson commented on MJLINK-56: -- Build succeeded in Jenkins: Maven » Maven TLP » maven-jlink-p

[jira] [Closed] (MJLINK-56) Convert unit tests to Junit5

2020-11-19 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MJLINK-56?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MJLINK-56. -- Resolution: Fixed > Convert unit tests to Junit5 > > >

[GitHub] [maven-jlink-plugin] asfgit closed pull request #18: jdk8 with buildchain.

2020-11-19 Thread GitBox
asfgit closed pull request #18: URL: https://github.com/apache/maven-jlink-plugin/pull/18 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (MJLINK-56) Convert unit tests to Junit5

2020-11-19 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MJLINK-56?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MJLINK-56: --- Fix Version/s: 3.0.1 > Convert unit tests to Junit5 > > >

[GitHub] [maven-jlink-plugin] bmarwell commented on a change in pull request #16: [MJLINK-36] java9 ToolProvider via Multi-Release jar.

2020-11-19 Thread GitBox
bmarwell commented on a change in pull request #16: URL: https://github.com/apache/maven-jlink-plugin/pull/16#discussion_r527045754 ## File path: src/main/java9/org/apache/maven/plugins/jlink/JLinkExecutor.java ## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [maven-jlink-plugin] asfgit closed pull request #15: (no-issue) remove unused junit 4.

2020-11-19 Thread GitBox
asfgit closed pull request #15: URL: https://github.com/apache/maven-jlink-plugin/pull/15 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [maven-jlink-plugin] asfgit merged pull request #17: [MJLINK-56] Use Junit5 imports, add display name, remove commented code.

2020-11-19 Thread GitBox
asfgit merged pull request #17: URL: https://github.com/apache/maven-jlink-plugin/pull/17 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (MJLINK-56) Convert unit tests to Junit5

2020-11-19 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MJLINK-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235587#comment-17235587 ] Hudson commented on MJLINK-56: -- Build succeeded in Jenkins: Maven » Maven TLP » maven-jlink-p

[jira] [Created] (MJLINK-59) Replace Printwriter, eats IOExceptions

2020-11-19 Thread Benjamin Marwell (Jira)
Benjamin Marwell created MJLINK-59: -- Summary: Replace Printwriter, eats IOExceptions Key: MJLINK-59 URL: https://issues.apache.org/jira/browse/MJLINK-59 Project: Maven JLink Plugin Issue Typ

[jira] [Assigned] (MJLINK-56) Convert unit tests to Junit5

2020-11-19 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MJLINK-56?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned MJLINK-56: -- Assignee: Sylwester Lachiewicz > Convert unit tests to Junit5 > ---

[GitHub] [maven-jlink-plugin] bmarwell commented on a change in pull request #16: [MJLINK-36] java9 ToolProvider via Multi-Release jar.

2020-11-19 Thread GitBox
bmarwell commented on a change in pull request #16: URL: https://github.com/apache/maven-jlink-plugin/pull/16#discussion_r527045163 ## File path: src/main/java/org/apache/maven/plugins/jlink/AbstractJLinkToolchainExecutor.java ## @@ -0,0 +1,204 @@ +package org.apache.maven.plu

[GitHub] [maven-jlink-plugin] bmarwell commented on a change in pull request #16: [MJLINK-36] java9 ToolProvider via Multi-Release jar.

2020-11-19 Thread GitBox
bmarwell commented on a change in pull request #16: URL: https://github.com/apache/maven-jlink-plugin/pull/16#discussion_r527044004 ## File path: src/main/java/org/apache/maven/plugins/jlink/AbstractJLinkExecutor.java ## @@ -0,0 +1,63 @@ +package org.apache.maven.plugins.jlink

[jira] [Created] (MJLINK-58) Remove usage of plexus utils, use commons lang or native java instead.

2020-11-19 Thread Benjamin Marwell (Jira)
Benjamin Marwell created MJLINK-58: -- Summary: Remove usage of plexus utils, use commons lang or native java instead. Key: MJLINK-58 URL: https://issues.apache.org/jira/browse/MJLINK-58 Project: Maven

[jira] [Created] (MJLINK-57) Migrate to slf4j

2020-11-19 Thread Benjamin Marwell (Jira)
Benjamin Marwell created MJLINK-57: -- Summary: Migrate to slf4j Key: MJLINK-57 URL: https://issues.apache.org/jira/browse/MJLINK-57 Project: Maven JLink Plugin Issue Type: Improvement Aff

[GitHub] [maven-enforcer] aheritier commented on pull request #25: MENFORCER-276 - Support ignoring dependency scopes in RequireUpperBoundDeps

2020-11-19 Thread GitBox
aheritier commented on pull request #25: URL: https://github.com/apache/maven-enforcer/pull/25#issuecomment-730469248 I got exactly the same issue yesterday on a non-jerkins project too. I agree that we should try to have it fixed. -

[GitHub] [maven-jlink-plugin] bmarwell commented on pull request #16: [MJLINK-36] java9 ToolProvider via Multi-Release jar.

2020-11-19 Thread GitBox
bmarwell commented on pull request #16: URL: https://github.com/apache/maven-jlink-plugin/pull/16#issuecomment-730437952 @elharo I added links to all your comments. I hope this helps to understand why I think this is "out of scope of this PR" and keep talking about "existing code".

[GitHub] [maven-jlink-plugin] bmarwell commented on a change in pull request #16: [MJLINK-36] java9 ToolProvider via Multi-Release jar.

2020-11-19 Thread GitBox
bmarwell commented on a change in pull request #16: URL: https://github.com/apache/maven-jlink-plugin/pull/16#discussion_r526960377 ## File path: src/main/java/org/apache/maven/plugins/jlink/AbstractJLinkToolchainExecutor.java ## @@ -0,0 +1,204 @@ +package org.apache.maven.plu

[GitHub] [maven-jlink-plugin] bmarwell commented on a change in pull request #16: [MJLINK-36] java9 ToolProvider via Multi-Release jar.

2020-11-19 Thread GitBox
bmarwell commented on a change in pull request #16: URL: https://github.com/apache/maven-jlink-plugin/pull/16#discussion_r526959685 ## File path: src/main/java/org/apache/maven/plugins/jlink/AbstractJLinkExecutor.java ## @@ -0,0 +1,63 @@ +package org.apache.maven.plugins.jlink

[GitHub] [maven-jlink-plugin] bmarwell commented on a change in pull request #16: [MJLINK-36] java9 ToolProvider via Multi-Release jar.

2020-11-19 Thread GitBox
bmarwell commented on a change in pull request #16: URL: https://github.com/apache/maven-jlink-plugin/pull/16#discussion_r526959284 ## File path: src/main/java/org/apache/maven/plugins/jlink/AbstractJLinkToolchainExecutor.java ## @@ -0,0 +1,204 @@ +package org.apache.maven.plu

[GitHub] [maven-jlink-plugin] bmarwell commented on a change in pull request #16: [MJLINK-36] java9 ToolProvider via Multi-Release jar.

2020-11-19 Thread GitBox
bmarwell commented on a change in pull request #16: URL: https://github.com/apache/maven-jlink-plugin/pull/16#discussion_r526953349 ## File path: src/main/java9/org/apache/maven/plugins/jlink/JLinkExecutor.java ## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [maven-jlink-plugin] bmarwell commented on a change in pull request #16: [MJLINK-36] java9 ToolProvider via Multi-Release jar.

2020-11-19 Thread GitBox
bmarwell commented on a change in pull request #16: URL: https://github.com/apache/maven-jlink-plugin/pull/16#discussion_r526953935 ## File path: src/main/java/org/apache/maven/plugins/jlink/AbstractJLinkToolchainExecutor.java ## @@ -0,0 +1,204 @@ +package org.apache.maven.plu

[GitHub] [maven-jlink-plugin] bmarwell commented on a change in pull request #16: [MJLINK-36] java9 ToolProvider via Multi-Release jar.

2020-11-19 Thread GitBox
bmarwell commented on a change in pull request #16: URL: https://github.com/apache/maven-jlink-plugin/pull/16#discussion_r526953349 ## File path: src/main/java9/org/apache/maven/plugins/jlink/JLinkExecutor.java ## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [maven-jlink-plugin] bmarwell commented on a change in pull request #16: [MJLINK-36] java9 ToolProvider via Multi-Release jar.

2020-11-19 Thread GitBox
bmarwell commented on a change in pull request #16: URL: https://github.com/apache/maven-jlink-plugin/pull/16#discussion_r526930416 ## File path: src/main/java9/org/apache/maven/plugins/jlink/JLinkExecutor.java ## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [maven-enforcer] uhafner commented on pull request #25: MENFORCER-276 - Support ignoring dependency scopes in RequireUpperBoundDeps

2020-11-19 Thread GitBox
uhafner commented on pull request #25: URL: https://github.com/apache/maven-enforcer/pull/25#issuecomment-730351862 Example: ``` [WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireUpperBoundDeps failed with message: Failed while enforcing RequireUpperBoundDeps. The error(s

[GitHub] [maven-jlink-plugin] elharo commented on a change in pull request #16: [MJLINK-36] java9 ToolProvider via Multi-Release jar.

2020-11-19 Thread GitBox
elharo commented on a change in pull request #16: URL: https://github.com/apache/maven-jlink-plugin/pull/16#discussion_r526849731 ## File path: pom.xml ## @@ -65,7 +65,8 @@ -3.1.0 + Review comment: do --> due ## File path: src/main/java9/org/a

[GitHub] [maven-enforcer] uhafner commented on pull request #25: MENFORCER-276 - Support ignoring dependency scopes in RequireUpperBoundDeps

2020-11-19 Thread GitBox
uhafner commented on pull request #25: URL: https://github.com/apache/maven-enforcer/pull/25#issuecomment-730332790 @oleg-nenashev Don't we need this PR anymore in Jenkins? I am currently struggling with a lot of enforcer failures in my test dependencies so having such a feature would be n

[GitHub] [maven-ear-plugin] mabrarov edited a comment on pull request #24: [MEAR-153] skinnyModules option

2020-11-19 Thread GitBox
mabrarov edited a comment on pull request #24: URL: https://github.com/apache/maven-ear-plugin/pull/24#issuecomment-727590153 Proposal for the further work on design of shared libraries inclusion / exclusion (i.e. this comment is not directly related to this pull request). Backward compati

[GitHub] [maven-ear-plugin] mabrarov edited a comment on pull request #24: [MEAR-153] skinnyModules option

2020-11-19 Thread GitBox
mabrarov edited a comment on pull request #24: URL: https://github.com/apache/maven-ear-plugin/pull/24#issuecomment-730289313 @hboutemy, The ["Maven EAR Plugin 3.2.0 with skinnyModules option"](https://lists.apache.org/thread.html/rbcf8c12948893ff80483e2456fb6bdd78a20c94720746a94ad4

[GitHub] [maven-ear-plugin] mabrarov commented on pull request #24: [MEAR-153] skinnyModules option

2020-11-19 Thread GitBox
mabrarov commented on pull request #24: URL: https://github.com/apache/maven-ear-plugin/pull/24#issuecomment-730289313 @hboutemy, The ["Maven EAR Plugin 3.2.0 with skinnyModules option"](https://lists.apache.org/thread.html/rbcf8c12948893ff80483e2456fb6bdd78a20c94720746a94ad474741%4

[GitHub] [maven-wagon] michael-o commented on pull request #72: [MNG-6975] Wagon-HTTP, set content-type when determinable from file extension

2020-11-19 Thread GitBox
michael-o commented on pull request #72: URL: https://github.com/apache/maven-wagon/pull/72#issuecomment-730253846 Still interested in completing this? This is an automated message from the Apache Git Service. To respond to t

[jira] [Deleted] (MNGSITE-432) Situs Agen Bola Sbobet Casino

2020-11-19 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov deleted MNGSITE-432: --- > Situs Agen Bola Sbobet Casino > - > > Key: MNGSIT

[jira] [Deleted] (MNGSITE-433) Bola88

2020-11-19 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov deleted MNGSITE-433: --- > Bola88 > -- > > Key: MNGSITE-433 > URL: https://issues.ap

[GitHub] [maven-jlink-plugin] bmarwell commented on pull request #16: [MJLINK-36] java9 ToolProvider via Multi-Release jar.

2020-11-19 Thread GitBox
bmarwell commented on pull request #16: URL: https://github.com/apache/maven-jlink-plugin/pull/16#issuecomment-730223612 @elharo while agree with **everything** you wrote, I do not want to change any algorithms, methods etc. for this method. You had a chance to review these things earlier

[GitHub] [maven-jlink-plugin] bmarwell commented on a change in pull request #16: [MJLINK-36] java9 ToolProvider via Multi-Release jar.

2020-11-19 Thread GitBox
bmarwell commented on a change in pull request #16: URL: https://github.com/apache/maven-jlink-plugin/pull/16#discussion_r526681732 ## File path: src/main/java9/org/apache/maven/plugins/jlink/JLinkExecutor.java ## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [maven-jlink-plugin] bmarwell commented on a change in pull request #16: [MJLINK-36] java9 ToolProvider via Multi-Release jar.

2020-11-19 Thread GitBox
bmarwell commented on a change in pull request #16: URL: https://github.com/apache/maven-jlink-plugin/pull/16#discussion_r526681588 ## File path: src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java ## @@ -443,15 +416,14 @@ public void execute() return modulepat

[GitHub] [maven-jlink-plugin] bmarwell commented on a change in pull request #16: [MJLINK-36] java9 ToolProvider via Multi-Release jar.

2020-11-19 Thread GitBox
bmarwell commented on a change in pull request #16: URL: https://github.com/apache/maven-jlink-plugin/pull/16#discussion_r526679134 ## File path: src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java ## @@ -443,15 +416,14 @@ public void execute() return modulepat

[GitHub] [maven-jlink-plugin] bmarwell commented on a change in pull request #16: [MJLINK-36] java9 ToolProvider via Multi-Release jar.

2020-11-19 Thread GitBox
bmarwell commented on a change in pull request #16: URL: https://github.com/apache/maven-jlink-plugin/pull/16#discussion_r526677178 ## File path: src/main/java9/org/apache/maven/plugins/jlink/JLinkExecutor.java ## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Founda

[jira] [Commented] (MNG-6450) Allow importing a POM with a classifier

2020-11-19 Thread Arnoud Glimmerveen (Jira)
[ https://issues.apache.org/jira/browse/MNG-6450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235257#comment-17235257 ] Arnoud Glimmerveen commented on MNG-6450: - I stumbled on this issue as well, when t

[GitHub] [maven-jlink-plugin] bmarwell commented on a change in pull request #16: [MJLINK-36] java9 ToolProvider via Multi-Release jar.

2020-11-19 Thread GitBox
bmarwell commented on a change in pull request #16: URL: https://github.com/apache/maven-jlink-plugin/pull/16#discussion_r526671119 ## File path: src/main/java/org/apache/maven/plugins/jlink/AbstractJLinkToolchainExecutor.java ## @@ -0,0 +1,204 @@ +package org.apache.maven.plu