[GitHub] [maven-shade-plugin] dependabot[bot] closed pull request #62: Bump mockito-core from 2.28.2 to 3.4.2

2020-07-19 Thread GitBox
dependabot[bot] closed pull request #62: URL: https://github.com/apache/maven-shade-plugin/pull/62 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [maven-shade-plugin] dependabot[bot] commented on pull request #62: Bump mockito-core from 2.28.2 to 3.4.2

2020-07-19 Thread GitBox
dependabot[bot] commented on pull request #62: URL: https://github.com/apache/maven-shade-plugin/pull/62#issuecomment-660789932 Superseded by #63. This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [maven-shade-plugin] dependabot[bot] opened a new pull request #63: Bump mockito-core from 2.28.2 to 3.4.4

2020-07-19 Thread GitBox
dependabot[bot] opened a new pull request #63: URL: https://github.com/apache/maven-shade-plugin/pull/63 Bumps [mockito-core](https://github.com/mockito/mockito) from 2.28.2 to 3.4.4. Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-core's releases

[GitHub] [maven-dependency-plugin] dependabot[bot] opened a new pull request #85: Bump mockito-core from 2.28.2 to 3.4.4

2020-07-19 Thread GitBox
dependabot[bot] opened a new pull request #85: URL: https://github.com/apache/maven-dependency-plugin/pull/85 Bumps [mockito-core](https://github.com/mockito/mockito) from 2.28.2 to 3.4.4. Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-core's rel

[GitHub] [maven-surefire] rmannibucau commented on pull request #307: Change default debug options to not use legacy options

2020-07-19 Thread GitBox
rmannibucau commented on pull request #307: URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-660710293 @Thihup yep but 0.0.0.0:5005 is unsafe and not a good default anyway so guess it is better (if moving to current config as this issue is about) to fix that too properly

[jira] [Closed] (MNG-6902) not storing/getting artifacts in/from local repository

2020-07-19 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNG-6902. --- Fix Version/s: (was: wontfix-candidate) Resolution: Not A Problem Please move discussions to

[jira] [Commented] (MRESOURCES-132) Copying of files with permissions broken

2020-07-19 Thread Martin Todorov (Jira)
[ https://issues.apache.org/jira/browse/MRESOURCES-132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160739#comment-17160739 ] Martin Todorov commented on MRESOURCES-132: --- [~khmarbaise], [~olamy],   C

[GitHub] [maven-surefire] Tibor17 commented on pull request #307: Change default debug options to not use legacy options

2020-07-19 Thread GitBox
Tibor17 commented on pull request #307: URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-660673408 @Thihup thx This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [maven-surefire] Thihup commented on pull request #307: Change default debug options to not use legacy options

2020-07-19 Thread GitBox
Thihup commented on pull request #307: URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-660673180 @rmannibucau Sure. I didn't change to localhost:5005 because it changes the current behavior in JDK <= 8. I don't know if someone connects remotely during debug. If it OK to

[jira] [Commented] (MRESOURCES-132) Copying of files with permissions broken

2020-07-19 Thread Daniele Pirola (Jira)
[ https://issues.apache.org/jira/browse/MRESOURCES-132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160724#comment-17160724 ] Daniele Pirola commented on MRESOURCES-132: --- Issue still present with plugi

[GitHub] [maven-surefire] rmannibucau commented on pull request #307: Change default debug options to not use legacy options

2020-07-19 Thread GitBox
rmannibucau commented on pull request #307: URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-66026 Side note: for java 11, localhost:5005 is a saner default which works on java 8 (think 6 but didnt test), would be great to handle it too.

[GitHub] [maven-surefire] Tibor17 commented on pull request #307: Change default debug options to not use legacy options

2020-07-19 Thread GitBox
Tibor17 commented on pull request #307: URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-660665835 Yes, please check it out additionally with jacoco. This is an automated message from the Apache Git Service

[GitHub] [maven-surefire] Thihup commented on pull request #307: Change default debug options to not use legacy options

2020-07-19 Thread GitBox
Thihup commented on pull request #307: URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-660663266 @Tibor17 I don't think so. Unfortunately, I don't have an extensive collection of projects with JaCoCo to test, but where I tested it worked fine. The JaCoCo injects itsel

[GitHub] [maven-resolver] michael-o commented on a change in pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-19 Thread GitBox
michael-o commented on a change in pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#discussion_r456921858 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultSyncContextFactory.java ## @@ -28,31 +30,59 @@ import org.e

[GitHub] [maven-surefire] Tibor17 commented on pull request #307: Change default debug options to not use legacy options

2020-07-19 Thread GitBox
Tibor17 commented on pull request #307: URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-660658510 @Thihup Do you think this change would not be in a conflict with JaCoCo AGENT? This is an automated mes

[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #307: Change default debug options to not use legacy options

2020-07-19 Thread GitBox
Tibor17 edited a comment on pull request #307: URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-660652711 We have to make sure it is as you say, otherwise the Jenkins build would fail on old Java. Here the GitHub workflow uses only Java 14 and 3 OS. -

[GitHub] [maven-surefire] Tibor17 commented on pull request #307: Change default debug options to not use legacy options

2020-07-19 Thread GitBox
Tibor17 commented on pull request #307: URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-660652711 We have make sure it is as you say, otherwise the Jenkins build would fail on old Java. Here the GitHub workflow uses only Java 14 and 3 OS. ---

[jira] [Created] (SUREFIRE-1827) The console output is not flushed

2020-07-19 Thread Tibor Digana (Jira)
Tibor Digana created SUREFIRE-1827: -- Summary: The console output is not flushed Key: SUREFIRE-1827 URL: https://issues.apache.org/jira/browse/SUREFIRE-1827 Project: Maven Surefire Issue Type

[GitHub] [maven-surefire] Thihup edited a comment on pull request #307: Change default debug options to not use legacy options

2020-07-19 Thread GitBox
Thihup edited a comment on pull request #307: URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-660651391 I haven't tested it in Java 1.7 yet. However, as far as I remember, these options were introduced in Java 1.5. ---

[GitHub] [maven-surefire] Thihup commented on pull request #307: Change default debug options to not use legacy options

2020-07-19 Thread GitBox
Thihup commented on pull request #307: URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-660651391 I haven't tested it in Java 1.7. However, as far as I remember, these options were introduced in Java 1.5. --

[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #307: Change default debug options to not use legacy options

2020-07-19 Thread GitBox
Tibor17 edited a comment on pull request #307: URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-660650833 Have you checked this change on Java 1.7 projects too? We can always alter this feature upon Java version if necessary. --

[GitHub] [maven-surefire] Tibor17 commented on pull request #307: Change default debug options to not use legacy options

2020-07-19 Thread GitBox
Tibor17 commented on pull request #307: URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-660650833 Have checked this change on Java 1.7 projects too? We can always alter this feature upon Java version if necessary. -

[GitHub] [maven-surefire] Thihup opened a new pull request #307: Change default debug options to not use legacy options

2020-07-19 Thread GitBox
Thihup opened a new pull request #307: URL: https://github.com/apache/maven-surefire/pull/307 Using the -Xdebug -Xnoagent -Djava.compiler=NONE causes the OpenJ9 JVM to run the tests in interpreted mode, thus running them VERY slowly. In Hotspot JVM these options are ignored.

[GitHub] [maven-resolver] Tibor17 commented on pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-19 Thread GitBox
Tibor17 commented on pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#issuecomment-660647245 @eolivelli Can you please interpret every single line in this change? What they do? I would really like to see the sense.

[GitHub] [maven-surefire] Tibor17 closed pull request #306: Faster queue

2020-07-19 Thread GitBox
Tibor17 closed pull request #306: URL: https://github.com/apache/maven-surefire/pull/306 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [maven-resolver] Tibor17 commented on a change in pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-19 Thread GitBox
Tibor17 commented on a change in pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#discussion_r456902065 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultSyncContextFactory.java ## @@ -28,31 +30,59 @@ import org.ecl

[jira] [Closed] (SUREFIRE-1826) Improved performance of ThreadedStreamConsumer

2020-07-19 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana closed SUREFIRE-1826. -- Resolution: Fixed https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=686856

[jira] [Closed] (SUREFIRE-1825) Unable to zip the Cucumber TXT report file on Linux and MacOS

2020-07-19 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana closed SUREFIRE-1825. -- Resolution: Fixed https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=53ea3e

[jira] [Commented] (SUREFIRE-1821) Broken junit report when parallel and rerunFailingTestsCount configureation is used

2020-07-19 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160650#comment-17160650 ] Tibor Digana commented on SUREFIRE-1821: [~himos] Thx for investigating this.

[GitHub] [maven-resolver] michael-o commented on a change in pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-19 Thread GitBox
michael-o commented on a change in pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#discussion_r456887921 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultSyncContextFactory.java ## @@ -28,31 +30,59 @@ import org.e

[GitHub] [maven-resolver] michael-o commented on a change in pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-19 Thread GitBox
michael-o commented on a change in pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#discussion_r456887762 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultSyncContextFactory.java ## @@ -28,31 +30,59 @@ import org.e

[GitHub] [maven-resolver] Tibor17 commented on a change in pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-19 Thread GitBox
Tibor17 commented on a change in pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#discussion_r456887720 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultSyncContextFactory.java ## @@ -28,31 +30,59 @@ import org.ecl

[GitHub] [maven-resolver] Tibor17 commented on a change in pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-19 Thread GitBox
Tibor17 commented on a change in pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#discussion_r456887401 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultSyncContextFactory.java ## @@ -28,31 +30,59 @@ import org.ecl

[GitHub] [maven-resolver] Tibor17 commented on a change in pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-19 Thread GitBox
Tibor17 commented on a change in pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#discussion_r456886644 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultSyncContextFactory.java ## @@ -28,31 +30,59 @@ import org.ecl

[GitHub] [maven-resolver] michael-o commented on a change in pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-19 Thread GitBox
michael-o commented on a change in pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#discussion_r456886502 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultSyncContextFactory.java ## @@ -28,31 +30,59 @@ import org.e

[GitHub] [maven-resolver] michael-o commented on a change in pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-19 Thread GitBox
michael-o commented on a change in pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#discussion_r456886206 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultSyncContextFactory.java ## @@ -28,31 +30,59 @@ import org.e

[GitHub] [maven-resolver] Tibor17 commented on a change in pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-19 Thread GitBox
Tibor17 commented on a change in pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#discussion_r456886247 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultSyncContextFactory.java ## @@ -28,31 +30,59 @@ import org.ecl

[GitHub] [maven-resolver] Tibor17 commented on a change in pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-19 Thread GitBox
Tibor17 commented on a change in pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#discussion_r456885901 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultSyncContextFactory.java ## @@ -28,31 +30,59 @@ import org.ecl

[GitHub] [maven-resolver] Tibor17 commented on a change in pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-19 Thread GitBox
Tibor17 commented on a change in pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#discussion_r456885982 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultSyncContextFactory.java ## @@ -28,31 +30,59 @@ import org.ecl

[GitHub] [maven-resolver] michael-o commented on a change in pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-19 Thread GitBox
michael-o commented on a change in pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#discussion_r456885102 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultSyncContextFactory.java ## @@ -28,31 +30,59 @@ import org.e

[jira] [Commented] (MDEP-437) Create symbolic links instead of physical copies

2020-07-19 Thread Markus Karg (Jira)
[ https://issues.apache.org/jira/browse/MDEP-437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160622#comment-17160622 ] Markus Karg commented on MDEP-437: -- I am planning to provide a PR which adds a new "link"

[GitHub] [maven-wagon] pzygielo commented on pull request #69: Remove unused class

2020-07-19 Thread GitBox
pzygielo commented on pull request #69: URL: https://github.com/apache/maven-wagon/pull/69#issuecomment-660610082 @olamy - could you shed some light on WAGON-350 related changes, please? For me it looks like code removed in this PR is unused in both commits e248eeea and in next 1f6719c5

[GitHub] [maven-compiler-plugin] sormuras closed pull request #14: Use junit-platform-maven-plugin w/o isolating test runtime jars

2020-07-19 Thread GitBox
sormuras closed pull request #14: URL: https://github.com/apache/maven-compiler-plugin/pull/14 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov