[jira] [Commented] (MNG-6959) Add "maven.jar.skip" property

2020-07-10 Thread Rupert Madden-Abbott (Jira)
[ https://issues.apache.org/jira/browse/MNG-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17155713#comment-17155713 ] Rupert Madden-Abbott commented on MNG-6959: --- Thanks very much for the advice [~rf

[GitHub] [maven-dependency-plugin] ian-lavallee commented on pull request #80: [MDEP-708] [NEEDS Maven-dependency-analyzer RELEASE] dependency:analyze should recommend narrower scope where possible

2020-07-10 Thread GitBox
ian-lavallee commented on pull request #80: URL: https://github.com/apache/maven-dependency-plugin/pull/80#issuecomment-656877067 The test relies on the line count of the HTML file but I'm going to change that to verify the contents and just look for Junit in the NonTestScopedTestDependen

[GitHub] [maven-dependency-plugin] ian-lavallee opened a new pull request #80: [MDEP-708] [NEEDS Maven-dependency-analyzer RELEASE] dependency:analyze should recommend narrower scope where possible

2020-07-10 Thread GitBox
ian-lavallee opened a new pull request #80: URL: https://github.com/apache/maven-dependency-plugin/pull/80 This can't be merged until we have a new release and final version of maven-dependency-analyzer. For now it relies on a snapshot version.

[GitHub] [maven-dependency-plugin] ian-lavallee commented on pull request #80: [MDEP-708] [NEEDS Maven-dependency-analyzer RELEASE] dependency:analyze should recommend narrower scope where possible

2020-07-10 Thread GitBox
ian-lavallee commented on pull request #80: URL: https://github.com/apache/maven-dependency-plugin/pull/80#issuecomment-656876714 @elharo This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [maven-dependency-analyzer] ian-lavallee commented on pull request #14: [MDEP-708] - dependency:analyze recommends test scope for test-only artifacts that have non-test scope

2020-07-10 Thread GitBox
ian-lavallee commented on pull request #14: URL: https://github.com/apache/maven-dependency-analyzer/pull/14#issuecomment-656869975 Actually @elharo need you to trigger a build for me. This is an automated message from the A

[GitHub] [maven-dependency-analyzer] ian-lavallee commented on pull request #14: [MDEP-708] - dependency:analyze recommends test scope for test-only artifacts that have non-test scope

2020-07-10 Thread GitBox
ian-lavallee commented on pull request #14: URL: https://github.com/apache/maven-dependency-analyzer/pull/14#issuecomment-656869786 Thought we might run into this. The dependency identification fails on test dependencies when using Java 7. Last commit should fix the issue, I'll monitor th

[GitHub] [maven-dependency-analyzer] elharo commented on a change in pull request #14: [MDEP-708] - dependency:analyze recommends test scope for test-only artifacts that have non-test scope

2020-07-10 Thread GitBox
elharo commented on a change in pull request #14: URL: https://github.com/apache/maven-dependency-analyzer/pull/14#discussion_r453014364 ## File path: src/test/resources/jarWithNonTestScopedTestDependency/pom.xml ## @@ -0,0 +1,38 @@ + + + + +http://maven.apache.org/POM/4.0.0";

[GitHub] [maven-dependency-analyzer] ian-lavallee commented on a change in pull request #14: [MDEP-708] - dependency:analyze recommends test scope for test-only artifacts that have non-test scope

2020-07-10 Thread GitBox
ian-lavallee commented on a change in pull request #14: URL: https://github.com/apache/maven-dependency-analyzer/pull/14#discussion_r453013369 ## File path: src/test/resources/jarWithNonTestScopedTestDependency/pom.xml ## @@ -0,0 +1,38 @@ + + + + +http://maven.apache.org/POM/4

[GitHub] [maven-dependency-analyzer] elharo commented on a change in pull request #14: [MDEP-708] - dependency:analyze recommends test scope for test-only artifacts that have non-test scope

2020-07-10 Thread GitBox
elharo commented on a change in pull request #14: URL: https://github.com/apache/maven-dependency-analyzer/pull/14#discussion_r453006508 ## File path: src/main/java/org/apache/maven/shared/dependency/analyzer/DefaultProjectDependencyAnalyzer.java ## @@ -189,6 +210,29 @@ else

[GitHub] [maven-dependency-analyzer] ian-lavallee commented on a change in pull request #14: [MDEP-708] - dependency:analyze recommends test scope for test-only artifacts that have non-test scope

2020-07-10 Thread GitBox
ian-lavallee commented on a change in pull request #14: URL: https://github.com/apache/maven-dependency-analyzer/pull/14#discussion_r453001178 ## File path: src/main/java/org/apache/maven/shared/dependency/analyzer/DefaultProjectDependencyAnalyzer.java ## @@ -189,6 +210,29 @@

[jira] [Updated] (MPOM-254) Shade Plugin Does Not Support JDK11

2020-07-10 Thread David Mollitor (Jira)
[ https://issues.apache.org/jira/browse/MPOM-254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mollitor updated MPOM-254: Description: https://blogs.apache.org/maven/entry/apache-maven-shade-plugin-version2 Must be version

[jira] [Created] (MPOM-254) Shade Plugin Does Not Support JDK11

2020-07-10 Thread David Mollitor (Jira)
David Mollitor created MPOM-254: --- Summary: Shade Plugin Does Not Support JDK11 Key: MPOM-254 URL: https://issues.apache.org/jira/browse/MPOM-254 Project: Maven POMs Issue Type: Improvement

[jira] [Created] (MWAR-438) Make Maven 3.1.0 the minimum version

2020-07-10 Thread Elliotte Rusty Harold (Jira)
Elliotte Rusty Harold created MWAR-438: -- Summary: Make Maven 3.1.0 the minimum version Key: MWAR-438 URL: https://issues.apache.org/jira/browse/MWAR-438 Project: Maven WAR Plugin Issue T

[jira] [Commented] (MNG-6959) Add "maven.jar.skip" property

2020-07-10 Thread Robert Scholte (Jira)
[ https://issues.apache.org/jira/browse/MNG-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17155604#comment-17155604 ] Robert Scholte commented on MNG-6959: - In case 1: a project with only test-sources is w

[GitHub] [maven-dependency-analyzer] elharo commented on a change in pull request #14: [MDEP-708] - dependency:analyze recommends test scope for test-only artifacts that have non-test scope

2020-07-10 Thread GitBox
elharo commented on a change in pull request #14: URL: https://github.com/apache/maven-dependency-analyzer/pull/14#discussion_r45294 ## File path: src/main/java/org/apache/maven/shared/dependency/analyzer/DefaultProjectDependencyAnalyzer.java ## @@ -189,6 +210,29 @@ else

[GitHub] [maven-dependency-analyzer] ian-lavallee commented on pull request #14: [MDEP-708] - dependency:analyze recommends test scope for test-only artifacts that have non-test scope

2020-07-10 Thread GitBox
ian-lavallee commented on pull request #14: URL: https://github.com/apache/maven-dependency-analyzer/pull/14#issuecomment-656765102 @elharo This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [maven-dependency-analyzer] ian-lavallee opened a new pull request #14: [MDEP-708] - dependency:analyze recommends test scope for test-only artifacts that have non-test scope

2020-07-10 Thread GitBox
ian-lavallee opened a new pull request #14: URL: https://github.com/apache/maven-dependency-analyzer/pull/14 Works similarly to the current logic for getting unused dependencies and declared; looks in output src and test folders and compares what it finds. Tried to make the test less

[jira] [Comment Edited] (MNG-6959) Add "maven.jar.skip" property

2020-07-10 Thread Rupert Madden-Abbott (Jira)
[ https://issues.apache.org/jira/browse/MNG-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17155569#comment-17155569 ] Rupert Madden-Abbott edited comment on MNG-6959 at 7/10/20, 4:01 PM:

[jira] [Commented] (MNG-6959) Add "maven.jar.skip" property

2020-07-10 Thread Rupert Madden-Abbott (Jira)
[ https://issues.apache.org/jira/browse/MNG-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17155569#comment-17155569 ] Rupert Madden-Abbott commented on MNG-6959: --- [~rfscholte] I agree but those artif

[GitHub] [maven-war-plugin] slachiewicz commented on pull request #18: update minimum Maven version to 3.1.0

2020-07-10 Thread GitBox
slachiewicz commented on pull request #18: URL: https://github.com/apache/maven-war-plugin/pull/18#issuecomment-656715914 Please create jira for this change - so it can be put in release note automaticly This is an automated

[GitHub] [maven-war-plugin] rmannibucau commented on pull request #16: Avoid resource leak from class loader

2020-07-10 Thread GitBox
rmannibucau commented on pull request #16: URL: https://github.com/apache/maven-war-plugin/pull/16#issuecomment-656712557 try/with/resource should work - we did something close in tomee - but I think the classloader should be drop to quit fast the previous loop. Idea is to iterate over cla

[jira] [Closed] (MNG-6959) Add "maven.jar.skip" property

2020-07-10 Thread Robert Scholte (Jira)
[ https://issues.apache.org/jira/browse/MNG-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MNG-6959. --- Assignee: Robert Scholte Resolution: Won't Fix The ultimate goal of every build is the creation o

[GitHub] [maven-war-plugin] elharo commented on pull request #16: Avoid resource leak from class loader

2020-07-10 Thread GitBox
elharo commented on pull request #16: URL: https://github.com/apache/maven-war-plugin/pull/16#issuecomment-656709472 Let me try to be clearer; try with resources does not work here. I tried it. It did not work. This is an a

[jira] [Closed] (SUREFIRE-1817) SurefireForkException with JaCoCo on gitlab-ci

2020-07-10 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana closed SUREFIRE-1817. -- Resolution: Not A Bug [~gwehner] Don't worry about my statement. I am glad that your project

[jira] [Assigned] (SUREFIRE-1817) SurefireForkException with JaCoCo on gitlab-ci

2020-07-10 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana reassigned SUREFIRE-1817: -- Assignee: Tibor Digana > SurefireForkException with JaCoCo on gitlab-ci > -

[GitHub] [maven-war-plugin] elharo opened a new pull request #18: update minimum Maven version to 3.1.0

2020-07-10 Thread GitBox
elharo opened a new pull request #18: URL: https://github.com/apache/maven-war-plugin/pull/18 @hboutemy This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (SUREFIRE-1817) SurefireForkException with JaCoCo on gitlab-ci

2020-07-10 Thread Guido Wehner (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17155493#comment-17155493 ] Guido Wehner commented on SUREFIRE-1817: Hi Tibor, sorry for not answering fo

[GitHub] [maven-war-plugin] pzygielo commented on pull request #16: Avoid resource leak from class loader

2020-07-10 Thread GitBox
pzygielo commented on pull request #16: URL: https://github.com/apache/maven-war-plugin/pull/16#issuecomment-656688911 > There's something weird about this though: Unhandled exception type IOException thrown by automatic close() invocation on loader Not weirder than using try-with-re

[GitHub] [maven-war-plugin] elharo commented on pull request #16: Avoid resource leak from class loader

2020-07-10 Thread GitBox
elharo commented on pull request #16: URL: https://github.com/apache/maven-war-plugin/pull/16#issuecomment-656683736 There's something weird about this though: Unhandled exception type IOException thrown by automatic close() invocation on loader ---

[jira] [Commented] (MNG-6959) Add "maven.jar.skip" property

2020-07-10 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17155474#comment-17155474 ] Michael Osipov commented on MNG-6959: - [~rfscholte], this one is for you. > Add "maven

[GitHub] [maven-war-plugin] pzygielo commented on pull request #16: Avoid resource leak from class loader

2020-07-10 Thread GitBox
pzygielo commented on pull request #16: URL: https://github.com/apache/maven-war-plugin/pull/16#issuecomment-656675270 > ClassLoader does not implement AutoCloseable. I don't know why, but it doesn't. But URLClassLoader does.

[jira] [Created] (MWAR-437) WAR plugin erases files written by YUICompressor plugin

2020-07-10 Thread Simon Urli (Jira)
Simon Urli created MWAR-437: --- Summary: WAR plugin erases files written by YUICompressor plugin Key: MWAR-437 URL: https://issues.apache.org/jira/browse/MWAR-437 Project: Maven WAR Plugin Issue Type

[GitHub] [maven-war-plugin] elharo merged pull request #14: Explicitly declare dependencies

2020-07-10 Thread GitBox
elharo merged pull request #14: URL: https://github.com/apache/maven-war-plugin/pull/14 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [maven-war-plugin] elharo commented on pull request #16: Avoid resource leak from class loader

2020-07-10 Thread GitBox
elharo commented on pull request #16: URL: https://github.com/apache/maven-war-plugin/pull/16#issuecomment-656673244 ClassLoader does not implement AutoCloseable. I don't know why, but it doesn't. This is an automated messa

[GitHub] [maven-war-plugin] elharo merged pull request #15: remove unused method

2020-07-10 Thread GitBox
elharo merged pull request #15: URL: https://github.com/apache/maven-war-plugin/pull/15 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [maven-war-plugin] elharo commented on pull request #17: fix deprecation

2020-07-10 Thread GitBox
elharo commented on pull request #17: URL: https://github.com/apache/maven-war-plugin/pull/17#issuecomment-656672287 This is a weird one. addDirectory is deprecated in Archiver but not JarArchiver. This is an automated mess

[GitHub] [maven-war-plugin] michael-o commented on pull request #16: Avoid resource leak from class loader

2020-07-10 Thread GitBox
michael-o commented on pull request #16: URL: https://github.com/apache/maven-war-plugin/pull/16#issuecomment-656669571 What about try-with-resources? This is an automated message from the Apache Git Service. To respond to th

[GitHub] [maven-war-plugin] michael-o commented on pull request #17: fix deprecation

2020-07-10 Thread GitBox
michael-o commented on pull request #17: URL: https://github.com/apache/maven-war-plugin/pull/17#issuecomment-656669023 Where is the deperecation? Am I blind? This is an automated message from the Apache Git Service. To respo

[jira] [Assigned] (MNG-6957) cannot build Maven Archetype with versionless reactor atifacts

2020-07-10 Thread Robert Scholte (Jira)
[ https://issues.apache.org/jira/browse/MNG-6957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte reassigned MNG-6957: --- Assignee: Robert Scholte > cannot build Maven Archetype with versionless reactor atifacts > --

[jira] [Created] (MNG-6959) Add "maven.jar.skip" property

2020-07-10 Thread Rupert Madden-Abbott (Jira)
Rupert Madden-Abbott created MNG-6959: - Summary: Add "maven.jar.skip" property Key: MNG-6959 URL: https://issues.apache.org/jira/browse/MNG-6959 Project: Maven Issue Type: Improvement

[GitHub] [maven-war-plugin] elharo opened a new pull request #17: fix deprecation

2020-07-10 Thread GitBox
elharo opened a new pull request #17: URL: https://github.com/apache/maven-war-plugin/pull/17 @hboutemy Archiver.addDirectory is deprecated This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [maven-war-plugin] elharo opened a new pull request #16: Avoid resource leak from class loader

2020-07-10 Thread GitBox
elharo opened a new pull request #16: URL: https://github.com/apache/maven-war-plugin/pull/16 @hboutemy This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [maven-war-plugin] elharo opened a new pull request #15: remove unused method

2020-07-10 Thread GitBox
elharo opened a new pull request #15: URL: https://github.com/apache/maven-war-plugin/pull/15 @hboutemy cure one generic warning This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [maven-war-plugin] elharo opened a new pull request #14: Explicitly declare dependencies

2020-07-10 Thread GitBox
elharo opened a new pull request #14: URL: https://github.com/apache/maven-war-plugin/pull/14 @hboutemy This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [maven-surefire] Tibor17 commented on pull request #305: enable to flush regularly output of the forked process

2020-07-10 Thread GitBox
Tibor17 commented on pull request #305: URL: https://github.com/apache/maven-surefire/pull/305#issuecomment-656630572 The branch https://github.com/apache/maven-surefire/commits/flush should be tested with a real project. It has wrong order of commits. So it has to be refactored. Curr

[jira] [Updated] (MRESOLVER-123) Provide a global locking sync context by default

2020-07-10 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRESOLVER-123: - Attachment: (was: mvn-debug-1.4.3-123.txt) > Provide a global locking sync context

[jira] [Updated] (MRESOLVER-123) Provide a global locking sync context by default

2020-07-10 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRESOLVER-123: - Summary: Provide a global locking sync context by default (was: Provide a global lock

[GitHub] [maven-resolver] michael-o opened a new pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-10 Thread GitBox
michael-o opened a new pull request #65: URL: https://github.com/apache/maven-resolver/pull/65 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Updated] (MRESOLVER-123) Provide a global locking sync context by default

2020-07-10 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRESOLVER-123: - Fix Version/s: 1.4.3 > Provide a global locking sync context by default >