[GitHub] [maven-surefire] eolivelli commented on pull request #300: [SUREFIRE-1796] The session of TCP channel should be authenticated

eolivelli commented on pull request #300: URL: https://github.com/apache/maven-surefire/pull/300#issuecomment-640161374 Maybe it is more consistent to call this new parameter 'sessionId' and not 'auth' or 'hash' This way it won't be confused for some kind of real security mechanism

[GitHub] [maven-surefire] eolivelli commented on a change in pull request #300: [SUREFIRE-1796] The session of TCP channel should be authenticated

eolivelli commented on a change in pull request #300: URL: https://github.com/apache/maven-surefire/pull/300#discussion_r436327376 ## File path: surefire-booter/src/test/java/org/apache/maven/surefire/booter/ForkedBooterMockTest.java ## @@ -362,6 +372,83 @@ public void run() t

[jira] [Commented] (SUREFIRE-1733) Surefire and Failsafe JPMS additions for JUnit 5.x execution

[ https://issues.apache.org/jira/browse/SUREFIRE-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127485#comment-17127485 ] Christian Stein commented on SUREFIRE-1733: --- > There must be some bug in JUn

[GitHub] [maven-surefire] olamy commented on pull request #300: [SUREFIRE-1796] The session of TCP channel should be authenticated

olamy commented on pull request #300: URL: https://github.com/apache/maven-surefire/pull/300#issuecomment-640145950 I don't think 127.0.0.1 neither localhost will work when executing within docker images running with k8s. That's why tools such testcontainer provide this https://www.testco

[jira] [Resolved] (WAGON-597) AbstractHttpClientWagon.setPersistentPool has no effect due to parameter assigned to itself

[ https://issues.apache.org/jira/browse/WAGON-597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy resolved WAGON-597. Resolution: Fixed > AbstractHttpClientWagon.setPersistentPool has no effect due to parameter > assi

[GitHub] [maven-wagon] olamy merged pull request #68: WAGON-597 Fix self-assignment and set class field

olamy merged pull request #68: URL: https://github.com/apache/maven-wagon/pull/68 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #300: [SUREFIRE-1796] The session of TCP channel should be authenticated

Tibor17 commented on a change in pull request #300: URL: https://github.com/apache/maven-surefire/pull/300#discussion_r436306303 ## File path: maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/extensions/E2ETest.java ## @@ -184,4 +192,74 @@ public void close

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #300: [SUREFIRE-1796] The session of TCP channel should be authenticated

Tibor17 commented on a change in pull request #300: URL: https://github.com/apache/maven-surefire/pull/300#discussion_r436306303 ## File path: maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/extensions/E2ETest.java ## @@ -184,4 +192,74 @@ public void close

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #300: [SUREFIRE-1796] The session of TCP channel should be authenticated

Tibor17 commented on a change in pull request #300: URL: https://github.com/apache/maven-surefire/pull/300#discussion_r436304747 ## File path: surefire-booter/src/test/java/org/apache/maven/surefire/booter/ForkedBooterMockTest.java ## @@ -385,4 +472,26 @@ public Object answer(

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #300: [SUREFIRE-1796] The session of TCP channel should be authenticated

Tibor17 commented on a change in pull request #300: URL: https://github.com/apache/maven-surefire/pull/300#discussion_r436304663 ## File path: surefire-booter/src/test/java/org/apache/maven/surefire/booter/ForkedBooterMockTest.java ## @@ -385,4 +472,26 @@ public Object answer(

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #300: [SUREFIRE-1796] The session of TCP channel should be authenticated

Tibor17 commented on a change in pull request #300: URL: https://github.com/apache/maven-surefire/pull/300#discussion_r436304525 ## File path: maven-surefire-common/src/test/java/org/apache/maven/surefire/extensions/ForkChannelTest.java ## @@ -100,7 +109,8 @@ public ConsoleLog

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #300: [SUREFIRE-1796] The session of TCP channel should be authenticated

Tibor17 commented on a change in pull request #300: URL: https://github.com/apache/maven-surefire/pull/300#discussion_r436304538 ## File path: maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/extensions/E2ETest.java ## @@ -184,4 +192,74 @@ public void close

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #300: [SUREFIRE-1796] The session of TCP channel should be authenticated

Tibor17 commented on a change in pull request #300: URL: https://github.com/apache/maven-surefire/pull/300#discussion_r436304484 ## File path: maven-surefire-common/src/test/java/org/apache/maven/surefire/extensions/ForkChannelTest.java ## @@ -162,17 +172,20 @@ public void han

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #300: [SUREFIRE-1796] The session of TCP channel should be authenticated

Tibor17 commented on a change in pull request #300: URL: https://github.com/apache/maven-surefire/pull/300#discussion_r436304424 ## File path: surefire-booter/src/test/java/org/apache/maven/surefire/booter/ForkedBooterMockTest.java ## @@ -362,6 +372,83 @@ public void run() thr

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #300: [SUREFIRE-1796] The session of TCP channel should be authenticated

Tibor17 commented on a change in pull request #300: URL: https://github.com/apache/maven-surefire/pull/300#discussion_r436304161 ## File path: maven-surefire-common/src/test/java/org/apache/maven/surefire/extensions/ForkChannelTest.java ## @@ -100,7 +109,8 @@ public ConsoleLog

[jira] [Closed] (MNG-6933) mvn site (org.apache.maven.model.building.ModelBuildingException)

[ https://issues.apache.org/jira/browse/MNG-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNG-6933. --- Resolution: Not A Problem * Very little information * This has already been discussed in several MPIR t

[GitHub] [maven-surefire] michael-o commented on a change in pull request #300: [SUREFIRE-1796] The session of TCP channel should be authenticated

michael-o commented on a change in pull request #300: URL: https://github.com/apache/maven-surefire/pull/300#discussion_r436302150 ## File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/extensions/SurefireForkChannel.java ## @@ -113,6 +124,25 @@ pub

[GitHub] [maven-surefire] michael-o commented on a change in pull request #300: [SUREFIRE-1796] The session of TCP channel should be authenticated

michael-o commented on a change in pull request #300: URL: https://github.com/apache/maven-surefire/pull/300#discussion_r436266749 ## File path: surefire-booter/src/main/java/org/apache/maven/surefire/booter/spi/SurefireMasterProcessChannelProcessorFactory.java ## @@ -119,4 +1

[jira] [Commented] (SUREFIRE-1733) Surefire and Failsafe JPMS additions for JUnit 5.x execution

[ https://issues.apache.org/jira/browse/SUREFIRE-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127431#comment-17127431 ] Tibor Digana commented on SUREFIRE-1733: According to my experiences with the

[jira] [Commented] (SUREFIRE-1733) Surefire and Failsafe JPMS additions for JUnit 5.x execution

[ https://issues.apache.org/jira/browse/SUREFIRE-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127430#comment-17127430 ] Pavel_K commented on SUREFIRE-1733: --- [~tibordigana] So must we in src/main/java/modu

[jira] [Commented] (SUREFIRE-1733) Surefire and Failsafe JPMS additions for JUnit 5.x execution

[ https://issues.apache.org/jira/browse/SUREFIRE-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127427#comment-17127427 ] Tibor Digana commented on SUREFIRE-1733: In such case I expect them to be two

[GitHub] [maven-surefire] Tibor17 commented on pull request #300: [SUREFIRE-1796] The session of TCP channel should be authenticated

Tibor17 commented on pull request #300: URL: https://github.com/apache/maven-surefire/pull/300#issuecomment-640112264 @michael-o Done! The localhost is fixed in master. This is an automated message from the Apache Git Serv

[GitHub] [maven-javadoc-plugin] XenoAmess commented on a change in pull request #48: [MJAVADOC-653] fix javadoc; fix code smells; performance improvement; add travis-ci script.

XenoAmess commented on a change in pull request #48: URL: https://github.com/apache/maven-javadoc-plugin/pull/48#discussion_r436295692 ## File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractFixJavadocMojo.java ## @@ -808,20 +808,6 @@ private void parseClirrTextO

[GitHub] [maven-javadoc-plugin] XenoAmess commented on a change in pull request #48: [MJAVADOC-653] fix javadoc; fix code smells; performance improvement; add travis-ci script.

XenoAmess commented on a change in pull request #48: URL: https://github.com/apache/maven-javadoc-plugin/pull/48#discussion_r436295368 ## File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractFixJavadocMojo.java ## @@ -808,20 +808,6 @@ private void parseClirrTextO

[GitHub] [maven-javadoc-plugin] XenoAmess commented on pull request #48: [MJAVADOC-653] fix javadoc; fix code smells; performance improvement; add travis-ci script.

XenoAmess commented on pull request #48: URL: https://github.com/apache/maven-javadoc-plugin/pull/48#issuecomment-640108640 > The Travis CI should be pulled out to a separate issue and PR. @elharo done. commits about travis-ci has been rebased out. -

[GitHub] [maven-javadoc-plugin] XenoAmess commented on a change in pull request #48: [MJAVADOC-653] fix javadoc; fix code smells; performance improvement; add travis-ci script.

XenoAmess commented on a change in pull request #48: URL: https://github.com/apache/maven-javadoc-plugin/pull/48#discussion_r436295088 ## File path: src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java ## @@ -629,35 +650,34 @@ protected static String parseJavadocMem

[GitHub] [maven-javadoc-plugin] elharo commented on a change in pull request #48: [MJAVADOC-653] fix javadoc; fix code smells; performance improvement; add travis-ci script.

elharo commented on a change in pull request #48: URL: https://github.com/apache/maven-javadoc-plugin/pull/48#discussion_r436294565 ## File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractFixJavadocMojo.java ## @@ -808,20 +808,6 @@ private void parseClirrTextOutp

[jira] [Commented] (MINVOKER-254) Upgrade Groovy

[ https://issues.apache.org/jira/browse/MINVOKER-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127419#comment-17127419 ] Hudson commented on MINVOKER-254: - Build failed in Jenkins: Maven TLP » maven-invoker-p

[GitHub] [maven-war-plugin] michael-o merged pull request #10: docs: 3.0 has been out for long enough to be the default

michael-o merged pull request #10: URL: https://github.com/apache/maven-war-plugin/pull/10 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Created] (MSHARED-919) Deprecate StringUtils.defaultString

Elliotte Rusty Harold created MSHARED-919: - Summary: Deprecate StringUtils.defaultString Key: MSHARED-919 URL: https://issues.apache.org/jira/browse/MSHARED-919 Project: Maven Shared Components

[jira] [Created] (MSHARED-918) Deprecate StringUtils.equals

Elliotte Rusty Harold created MSHARED-918: - Summary: Deprecate StringUtils.equals Key: MSHARED-918 URL: https://issues.apache.org/jira/browse/MSHARED-918 Project: Maven Shared Components

[jira] [Updated] (MSHARED-913) Missing component annotations for maven3 and maven31 dependency collectors

[ https://issues.apache.org/jira/browse/MSHARED-913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold updated MSHARED-913: -- Component/s: maven-artifact-transfer > Missing component annotations for maven

[GitHub] [maven-war-plugin] elharo opened a new pull request #13: clear up deprecations, resource leaks, and unused imports

elharo opened a new pull request #13: URL: https://github.com/apache/maven-war-plugin/pull/13 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [maven-war-plugin] michael-o merged pull request #11: ignore backup versions file

michael-o merged pull request #11: URL: https://github.com/apache/maven-war-plugin/pull/11 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [maven-war-plugin] elharo opened a new pull request #12: update dependencies: commons-io, plexus-interpolation, and plexus-archiver

elharo opened a new pull request #12: URL: https://github.com/apache/maven-war-plugin/pull/12 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [maven-war-plugin] elharo closed pull request #1: [MWAR-371] - Overlays break first-win rule for web resource with target path ending with '/'

elharo closed pull request #1: URL: https://github.com/apache/maven-war-plugin/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [maven-war-plugin] elharo opened a new pull request #11: ignore backup versions file

elharo opened a new pull request #11: URL: https://github.com/apache/maven-war-plugin/pull/11 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (MNG-5868) Adding serval times the same artifact via MavenProjectHelper (attachArtifact) keep adding to the List duplicate artifacts

[ https://issues.apache.org/jira/browse/MNG-5868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127394#comment-17127394 ] Hudson commented on MNG-5868: - Build failed in Jenkins: Maven TLP » maven » MNG-6169/MNG-6556 #

[jira] [Commented] (MNG-6919) maven-wrapper on windows

[ https://issues.apache.org/jira/browse/MNG-6919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127393#comment-17127393 ] Hudson commented on MNG-6919: - Build failed in Jenkins: Maven TLP » maven » MNG-6169/MNG-6556 #

[jira] [Closed] (MPLUGIN-361) make build Reproducible

[ https://issues.apache.org/jira/browse/MPLUGIN-361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy closed MPLUGIN-361. - Resolution: Fixed finished in https://github.com/apache/maven-plugin-tools/commit/b2f7e990c1b80

[GitHub] [maven] MartinKanters commented on pull request #360: [MNG-6891] Delete the useless codes which won't be executed

MartinKanters commented on pull request #360: URL: https://github.com/apache/maven/pull/360#issuecomment-640080533 I don't see any problems with this PR. It looks like dead code indeed, now that `LogLevelRecorder` has a static `ACCEPTED_LEVELS` Map. Nice find @2997ms . ---

[jira] [Updated] (MWAR-430) support JakartaEE namespace: remove or adapt hardcoded reference to javax.servlet package

[ https://issues.apache.org/jira/browse/MWAR-430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MWAR-430: --- Issue Type: Improvement (was: Bug) > support JakartaEE namespace: remove or adapt hardcoded reference

[jira] [Commented] (MNG-6446) @Parameters Annotation does not function

[ https://issues.apache.org/jira/browse/MNG-6446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127189#comment-17127189 ] Michael Osipov commented on MNG-6446: - Please provide a sample project. > @Parameters

[jira] [Commented] (MWAR-430) support JakartaEE namespace: remove or adapt hardcoded reference to javax.servlet package

[ https://issues.apache.org/jira/browse/MWAR-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127247#comment-17127247 ] Herve Boutemy commented on MWAR-430: merged in https://github.com/apache/maven-war-plu

[jira] [Updated] (MNG-6446) @Parameters Annotation does not function

[ https://issues.apache.org/jira/browse/MNG-6446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-6446: Fix Version/s: waiting-for-feedback > @Parameters Annotation does not function >

[jira] [Closed] (MNG-6610) pomless builds fail on jenkins with windows agents

[ https://issues.apache.org/jira/browse/MNG-6610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNG-6610. --- Resolution: Cannot Reproduce As per comment. > pomless builds fail on jenkins with windows agents > --

[jira] [Commented] (MINVOKER-264) Errors during maven site build

[ https://issues.apache.org/jira/browse/MINVOKER-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127295#comment-17127295 ] Hudson commented on MINVOKER-264: - Build failed in Jenkins: Maven TLP » maven-invoker-p

[jira] [Commented] (SUREFIRE-1733) Surefire and Failsafe JPMS additions for JUnit 5.x execution

[ https://issues.apache.org/jira/browse/SUREFIRE-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127382#comment-17127382 ] Gili commented on SUREFIRE-1733: Tibor, But to Pavel's point, what is the expected be

[jira] [Closed] (MNG-5180) Versioning's snapshot version list is not included in metadata merge

[ https://issues.apache.org/jira/browse/MNG-5180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNG-5180. --- Fix Version/s: (was: wontfix-candidate) (was: waiting-for-feedback) Re

[jira] [Commented] (SUREFIRE-1733) Surefire and Failsafe JPMS additions for JUnit 5.x execution

[ https://issues.apache.org/jira/browse/SUREFIRE-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127117#comment-17127117 ] Tibor Digana commented on SUREFIRE-1733: The Release Vote would start tomorrow

[jira] [Closed] (MNG-5843) Inappropriate version resolution for version range with relocation

[ https://issues.apache.org/jira/browse/MNG-5843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNG-5843. --- Fix Version/s: (was: wontfix-candidate) (was: waiting-for-feedback) Re

[jira] [Comment Edited] (MNG-6276) Support Reproducible Builds (https://reproducible-builds.org)

[ https://issues.apache.org/jira/browse/MNG-6276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127378#comment-17127378 ] Herve Boutemy edited comment on MNG-6276 at 6/6/20, 3:35 PM: - i

[jira] [Commented] (MNG-6276) Support Reproducible Builds (https://reproducible-builds.org)

[ https://issues.apache.org/jira/browse/MNG-6276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127378#comment-17127378 ] Herve Boutemy commented on MNG-6276: in fact, implementation fully happens at plugins l

[jira] [Created] (MNG-6933) mvn site (org.apache.maven.model.building.ModelBuildingException)

alex romanov created MNG-6933: - Summary: mvn site (org.apache.maven.model.building.ModelBuildingException) Key: MNG-6933 URL: https://issues.apache.org/jira/browse/MNG-6933 Project: Maven Issue

[jira] [Commented] (MSKINS-167) add deep anchors to headers

[ https://issues.apache.org/jira/browse/MSKINS-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127255#comment-17127255 ] Hudson commented on MSKINS-167: --- Build succeeded in Jenkins: Maven TLP » maven-fluido-skin

[jira] [Commented] (MNG-6276) Support Reproducible Builds (https://reproducible-builds.org)

[ https://issues.apache.org/jira/browse/MNG-6276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127180#comment-17127180 ] Michael Osipov commented on MNG-6276: - [~hboutemy], it this completed with Maven 3.7.0?

[jira] [Closed] (MINVOKER-264) Errors during maven site build

[ https://issues.apache.org/jira/browse/MINVOKER-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MINVOKER-264. - Resolution: Fixed > Errors during maven site build > --

[jira] [Closed] (MSKINS-167) add deep anchors to headers

[ https://issues.apache.org/jira/browse/MSKINS-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy closed MSKINS-167. Fix Version/s: fluido-2.0 Assignee: Herve Boutemy Resolution: Fixed first pass in

[jira] [Commented] (MPLUGIN-359) upgrade Doxia Sitetools to 1.9.2 to remove dependency on Struts

[ https://issues.apache.org/jira/browse/MPLUGIN-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127273#comment-17127273 ] Hudson commented on MPLUGIN-359: Build failed in Jenkins: Maven TLP » maven-plugin-tools

[jira] [Commented] (MNG-5868) Adding serval times the same artifact via MavenProjectHelper (attachArtifact) keep adding to the List duplicate artifacts

[ https://issues.apache.org/jira/browse/MNG-5868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127335#comment-17127335 ] Hudson commented on MNG-5868: - Build failed in Jenkins: Maven TLP » maven » MNG-6656 #66 See h

[jira] [Commented] (MWAR-430) support JakartaEE namespace: remove or adapt hardcoded reference to javax.servlet package

[ https://issues.apache.org/jira/browse/MWAR-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127194#comment-17127194 ] Hudson commented on MWAR-430: - Build failed in Jenkins: Maven TLP » maven-war-plugin » master #

[jira] [Updated] (MPLUGIN-346) plugin:descriptor sometimes fails with java.util.NoSuchElementException

[ https://issues.apache.org/jira/browse/MPLUGIN-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MPLUGIN-346: -- Description: Sometimes the maven-plugin-plugin fails to write the plugin descriptor and exits

[jira] [Closed] (MWAR-430) support JakartaEE namespace: remove or adapt hardcoded reference to javax.servlet package

[ https://issues.apache.org/jira/browse/MWAR-430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy closed MWAR-430. - Resolution: Fixed > support JakartaEE namespace: remove or adapt hardcoded reference to > javax.servlet pa

[jira] [Closed] (MPLUGIN-359) upgrade Doxia Sitetools to 1.9.2 to remove dependency on Struts

[ https://issues.apache.org/jira/browse/MPLUGIN-359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy closed MPLUGIN-359. - Resolution: Fixed fixed in https://github.com/apache/maven-plugin-tools/commit/acac609ed63f30d7

[GitHub] [maven-surefire] Tibor17 commented on pull request #300: [SUREFIRE-1796] The session of TCP channel should be authenticated

Tibor17 commented on pull request #300: URL: https://github.com/apache/maven-surefire/pull/300#issuecomment-640064404 The next optimization should be done in `ThreadedStreamConsumer` to implement lock-free queue. I have several shelfs in IDEA witht the impl using the locks on the border of

[GitHub] [maven-surefire] Tibor17 commented on pull request #300: [SUREFIRE-1796] The session of TCP channel should be authenticated

Tibor17 commented on pull request #300: URL: https://github.com/apache/maven-surefire/pull/300#issuecomment-640063766 @michael-o We agreed with @eolivelli to avoid Base64 and transfer the raw stream with bytes counter in the frame. This way we would be totally fast (below 1 microsecond) be

[GitHub] [maven-surefire] Tibor17 commented on pull request #300: [SUREFIRE-1796] The session of TCP channel should be authenticated

Tibor17 commented on pull request #300: URL: https://github.com/apache/maven-surefire/pull/300#issuecomment-640062050 @michael-o Using the native sockets for the performance reasons is useless because here the Base64 is slower than the data transmission. We are talking about 50 microsecond

[GitHub] [maven-surefire] eolivelli commented on pull request #300: [SUREFIRE-1796] The session of TCP channel should be authenticated

eolivelli commented on pull request #300: URL: https://github.com/apache/maven-surefire/pull/300#issuecomment-640057210 We could add new implementations in the future This is an automated message from the Apache Git Service.

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #300: [SUREFIRE-1796] The session of TCP channel should be authenticated

Tibor17 commented on a change in pull request #300: URL: https://github.com/apache/maven-surefire/pull/300#discussion_r436267032 ## File path: surefire-booter/src/test/java/org/apache/maven/surefire/booter/ForkedBooterMockTest.java ## @@ -362,6 +372,83 @@ public void run() thr

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #300: [SUREFIRE-1796] The session of TCP channel should be authenticated

Tibor17 commented on a change in pull request #300: URL: https://github.com/apache/maven-surefire/pull/300#discussion_r436266939 ## File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/extensions/SurefireForkChannel.java ## @@ -113,6 +124,25 @@ publi

[GitHub] [maven-surefire] michael-o commented on pull request #300: [SUREFIRE-1796] The session of TCP channel should be authenticated

michael-o commented on pull request #300: URL: https://github.com/apache/maven-surefire/pull/300#issuecomment-640056533 If this is abstracted enough, we could also consider using Unix domain sockets in the future which will be availabe in Java soon and already also available in Windows. Th

[GitHub] [maven-surefire] michael-o commented on a change in pull request #300: [SUREFIRE-1796] The session of TCP channel should be authenticated

michael-o commented on a change in pull request #300: URL: https://github.com/apache/maven-surefire/pull/300#discussion_r436266749 ## File path: surefire-booter/src/main/java/org/apache/maven/surefire/booter/spi/SurefireMasterProcessChannelProcessorFactory.java ## @@ -119,4 +1

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #300: [SUREFIRE-1796] The session of TCP channel should be authenticated

Tibor17 commented on a change in pull request #300: URL: https://github.com/apache/maven-surefire/pull/300#discussion_r436266600 ## File path: surefire-booter/src/main/java/org/apache/maven/surefire/booter/spi/SurefireMasterProcessChannelProcessorFactory.java ## @@ -119,4 +129

[GitHub] [maven-surefire] eolivelli commented on pull request #300: [SUREFIRE-1796] The session of TCP channel should be authenticated

eolivelli commented on pull request #300: URL: https://github.com/apache/maven-surefire/pull/300#issuecomment-640040229 @michael-o This is an initial attempt to make it sure that the client is only the expected one. We are always on localhost and IMO there is no need to do something m

[GitHub] [maven-surefire] eolivelli commented on a change in pull request #300: [SUREFIRE-1796] The session of TCP channel should be authenticated

eolivelli commented on a change in pull request #300: URL: https://github.com/apache/maven-surefire/pull/300#discussion_r436259355 ## File path: surefire-booter/src/main/java/org/apache/maven/surefire/booter/spi/SurefireMasterProcessChannelProcessorFactory.java ## @@ -119,4 +1

[GitHub] [maven-war-plugin] elharo opened a new pull request #10: docs: 3.0 has been out for long enough to be the default

elharo opened a new pull request #10: URL: https://github.com/apache/maven-war-plugin/pull/10 @hboutemy This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [maven-surefire] Tibor17 commented on pull request #300: [SUREFIRE-1796] The session of TCP channel should be authenticated

Tibor17 commented on pull request #300: URL: https://github.com/apache/maven-surefire/pull/300#issuecomment-640026011 @michael-o Thx, I will turn this to localhost. This is an automated message from the Apache Git Service

[GitHub] [maven-surefire] michael-o commented on pull request #300: [SUREFIRE-1796] The session of TCP channel should be authenticated

michael-o commented on pull request #300: URL: https://github.com/apache/maven-surefire/pull/300#issuecomment-640022711 @Tibor17 OK. Don't use `127.0.0.1`, but always use `localhost`. There is no guarantee that `localhost` == `127.0.0.1`. -

[GitHub] [maven-surefire] Tibor17 commented on pull request #300: [SUREFIRE-1796] The session of TCP channel should be authenticated

Tibor17 commented on pull request #300: URL: https://github.com/apache/maven-surefire/pull/300#issuecomment-640016939 @eolivelli Pls answer @michael-o 's questions. @michael-o Yes, it is on `127.0.0.1`. The stream cannot use SSL, otherwise we slowdown the tests. Instead we use the to

[GitHub] [maven] MartinKanters commented on a change in pull request #342: [MNG-5760] Add --resume / -r switch

MartinKanters commented on a change in pull request #342: URL: https://github.com/apache/maven/pull/342#discussion_r436252389 ## File path: maven-core/src/main/java/org/apache/maven/execution/BuildResumptionManager.java ## @@ -0,0 +1,74 @@ +package org.apache.maven.execution;

[GitHub] [maven] rfscholte commented on pull request #360: [MNG-6891] Delete the useless codes which won't be executed

rfscholte commented on pull request #360: URL: https://github.com/apache/maven/pull/360#issuecomment-640014966 I'll ask @mthmulders @MartinKanters to review as well. This is an automated message from the Apache Git Service.

[GitHub] [maven-fluido-skin] hboutemy commented on pull request #19: [MSKINS-167] Add deep anchors to headers

hboutemy commented on pull request #19: URL: https://github.com/apache/maven-fluido-skin/pull/19#issuecomment-639998801 nice work done, thank you @dialaya This is an automated message from the Apache Git Service. To respond

[GitHub] [maven-fluido-skin] hboutemy merged pull request #19: [MSKINS-167] Add deep anchors to headers

hboutemy merged pull request #19: URL: https://github.com/apache/maven-fluido-skin/pull/19 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to