[jira] [Commented] (SUREFIRE-1755) Put dependencies from module-info in test sources on module path

2020-04-28 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17095106#comment-17095106 ] Tibor Digana commented on SUREFIRE-1755: Hi [~cowwoc], makes sense to me. We h

[jira] [Comment Edited] (SUREFIRE-1755) Put dependencies from module-info in test sources on module path

2020-04-28 Thread Gili (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094996#comment-17094996 ] Gili edited comment on SUREFIRE-1755 at 4/29/20, 3:07 AM: -- [~

[jira] [Commented] (SUREFIRE-1755) Put dependencies from module-info in test sources on module path

2020-04-28 Thread Gili (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094996#comment-17094996 ] Gili commented on SUREFIRE-1755: [~tibordigana] I would like to get your feedback on a

[jira] [Created] (MNGSITE-406) Dead link on deploy plugin page

2020-04-28 Thread Kurt Greaves (Jira)
Kurt Greaves created MNGSITE-406: Summary: Dead link on deploy plugin page Key: MNGSITE-406 URL: https://issues.apache.org/jira/browse/MNGSITE-406 Project: Maven Project Web Site Issue Type:

[GitHub] [maven-fluido-skin] dialaya opened a new pull request #17: [MSKINS-167] Add deep anchors to headers

2020-04-28 Thread GitBox
dialaya opened a new pull request #17: URL: https://github.com/apache/maven-fluido-skin/pull/17 Add anchors to sections header using AnchorJS utility as the site resources instead of loading from the Internet. This change leads to a little change in anchor-4.2.2.js. Use of brack

[jira] [Closed] (SUREFIRE-1694) Surefire silently skips tests in presence of transitive dependency

2020-04-28 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana closed SUREFIRE-1694. -- Assignee: Tibor Digana Resolution: Invalid No reproducible project and no reply from t

[jira] [Closed] (SUREFIRE-1255) Surefire 2.19.1 hangs before starting test execution

2020-04-28 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana closed SUREFIRE-1255. -- Resolution: Delivered Already delivered in SUREFIRE-1658. Release version 3.0.0-M5. You have

[GitHub] [maven-invoker-plugin] slawekjaranowski commented on pull request #19: [MINVOKER-262] GitHub Action confirm build on multiple jdk

2020-04-28 Thread GitBox
slawekjaranowski commented on pull request #19: URL: https://github.com/apache/maven-invoker-plugin/pull/19#issuecomment-620871462 PR was rebased with current master branch. This is an automated message from the Apache Git S

[GitHub] [maven-invoker-plugin] slawekjaranowski commented on pull request #20: [MINVOKER-250] streamLogsOnFailures

2020-04-28 Thread GitBox
slawekjaranowski commented on pull request #20: URL: https://github.com/apache/maven-invoker-plugin/pull/20#issuecomment-620870560 PR was rebased with current master branch. Code was corrected according to comments from review. --

[jira] [Closed] (SUREFIRE-1766) Surefire does not display TestNG data provider values on command line

2020-04-28 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana closed SUREFIRE-1766. -- Resolution: Fixed https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=1c20db

[jira] [Closed] (SUREFIRE-1784) Fork JVM defined by jvm parameter should not inherit JAVA_HOME from Maven process

2020-04-28 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana closed SUREFIRE-1784. -- Resolution: Fixed https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=d8fe77

[GitHub] [maven-surefire] Tibor17 commented on pull request #289: SUREFIRE-1784 Fork JVM defined by jvm param should not inherit JAVA_HOME from Maven process

2020-04-28 Thread GitBox
Tibor17 commented on pull request #289: URL: https://github.com/apache/maven-surefire/pull/289#issuecomment-620847707 @akomakom I could not find your email but mine is available in public. Can you contact me? I want to speak with you. Thx --

[GitHub] [maven-surefire] Tibor17 commented on pull request #289: SUREFIRE-1784 Fork JVM defined by jvm param should not inherit JAVA_HOME from Maven process

2020-04-28 Thread GitBox
Tibor17 commented on pull request #289: URL: https://github.com/apache/maven-surefire/pull/289#issuecomment-620847124 Thx for contributing! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [maven-surefire] Tibor17 commented on pull request #289: SUREFIRE-1784 Fork JVM defined by jvm param should not inherit JAVA_HOME from Maven process

2020-04-28 Thread GitBox
Tibor17 commented on pull request #289: URL: https://github.com/apache/maven-surefire/pull/289#issuecomment-620841393 Thx, we are ready to go. This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [maven-surefire] akomakom commented on a change in pull request #289: SUREFIRE-1784 Fork JVM defined by jvm param should not inherit JAVA_HOME from Maven process

2020-04-28 Thread GitBox
akomakom commented on a change in pull request #289: URL: https://github.com/apache/maven-surefire/pull/289#discussion_r416898348 ## File path: maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/AbstractSurefireMojoTest.java ## @@ -2183,6 +2183,13 @@ public v

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #289: SUREFIRE-1784 Fork JVM defined by jvm param should not inherit JAVA_HOME from Maven process

2020-04-28 Thread GitBox
Tibor17 commented on a change in pull request #289: URL: https://github.com/apache/maven-surefire/pull/289#discussion_r416880320 ## File path: maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/AbstractSurefireMojoTest.java ## @@ -2183,6 +2183,13 @@ public vo

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #289: SUREFIRE-1784 Fork JVM defined by jvm param should not inherit JAVA_HOME from Maven process

2020-04-28 Thread GitBox
Tibor17 commented on a change in pull request #289: URL: https://github.com/apache/maven-surefire/pull/289#discussion_r416879210 ## File path: maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/AbstractSurefireMojoTest.java ## @@ -2183,6 +2183,13 @@ public vo

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #289: SUREFIRE-1784 Fork JVM defined by jvm param should not inherit JAVA_HOME from Maven process

2020-04-28 Thread GitBox
Tibor17 commented on a change in pull request #289: URL: https://github.com/apache/maven-surefire/pull/289#discussion_r416878759 ## File path: maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/AbstractSurefireMojoTest.java ## @@ -2183,6 +2183,13 @@ public vo

[jira] [Commented] (WAGON-590) Maven 3.5.0+ don't seem to send credentials after 301/302 http redirect

2020-04-28 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/WAGON-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094530#comment-17094530 ] Michael Osipov commented on WAGON-590: -- Something is fishy with the logs. This cannot

[jira] [Commented] (SUREFIRE-1779) Spock Tests Fail to Run

2020-04-28 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094470#comment-17094470 ] Tibor Digana commented on SUREFIRE-1779: [~alzimmer] Every user should see the

[GitHub] [maven-surefire] akomakom commented on a change in pull request #289: SUREFIRE-1784 Fork JVM defined by jvm param should not inherit JAVA_HOME from Maven process

2020-04-28 Thread GitBox
akomakom commented on a change in pull request #289: URL: https://github.com/apache/maven-surefire/pull/289#discussion_r416565840 ## File path: maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/AbstractSurefireMojoToolchainsTest.java ## @@ -154,6 +157,36 @@

[GitHub] [maven-surefire] akomakom commented on a change in pull request #289: SUREFIRE-1784 Fork JVM defined by jvm param should not inherit JAVA_HOME from Maven process

2020-04-28 Thread GitBox
akomakom commented on a change in pull request #289: URL: https://github.com/apache/maven-surefire/pull/289#discussion_r416565218 ## File path: maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/AbstractSurefireMojoToolchainsTest.java ## @@ -154,6 +157,36 @@

[jira] [Commented] (SUREFIRE-1779) Spock Tests Fail to Run

2020-04-28 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094443#comment-17094443 ] Tibor Digana commented on SUREFIRE-1779: [~alzimmer] The [example setup|https:

[jira] [Issue Comment Deleted] (SUREFIRE-1779) Spock Tests Fail to Run

2020-04-28 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1779: --- Comment: was deleted (was: Pls attach a reproducible project with zip file here in Jira. T

[jira] [Updated] (SUREFIRE-1784) Fork JVM defined by jvm parameter should not inherit JAVA_HOME from Maven process

2020-04-28 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1784: --- Fix Version/s: 3.0.0-M5 > Fork JVM defined by jvm parameter should not inherit JAVA_HOME f

[jira] [Assigned] (SUREFIRE-1784) Fork JVM defined by jvm parameter should not inherit JAVA_HOME from Maven process

2020-04-28 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana reassigned SUREFIRE-1784: -- Assignee: Tibor Digana > Fork JVM defined by jvm parameter should not inherit JAVA_

[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #281: [SUREFIRE-1766] Surefire does not display TestNG data provider values on command line

2020-04-28 Thread GitBox
Tibor17 edited a comment on pull request #281: URL: https://github.com/apache/maven-surefire/pull/281#issuecomment-620558872 Resolved in [branch](https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=shortlog;h=refs/heads/SUREFIRE-1766). Assigned to the release 3.0.0-M5. Thx for co

[GitHub] [maven-surefire] Tibor17 commented on pull request #281: [SUREFIRE-1766] Surefire does not display TestNG data provider values on command line

2020-04-28 Thread GitBox
Tibor17 commented on pull request #281: URL: https://github.com/apache/maven-surefire/pull/281#issuecomment-620558872 Resolved in [branch](https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=shortlog;h=refs/heads/SUREFIRE-1766). Assigned in the release 3.0.0-M5. Thx for contribut

[jira] [Commented] (SUREFIRE-1766) Surefire does not display TestNG data provider values on command line

2020-04-28 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094427#comment-17094427 ] Tibor Digana commented on SUREFIRE-1766: Resolved in the branch [SUREFIRE-176

[jira] [Updated] (SUREFIRE-1766) Surefire does not display TestNG data provider values on command line

2020-04-28 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1766: --- Issue Type: New Feature (was: Improvement) > Surefire does not display TestNG data provid

[jira] [Updated] (SUREFIRE-1766) Surefire does not display TestNG data provider values on command line

2020-04-28 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1766: --- Priority: Major (was: Minor) > Surefire does not display TestNG data provider values on c

[jira] [Commented] (WAGON-590) Maven 3.5.0+ don't seem to send credentials after 301/302 http redirect

2020-04-28 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/WAGON-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094364#comment-17094364 ] Michael Osipov commented on WAGON-590: -- I will look at the facts and get back to you.

[jira] [Updated] (WAGON-590) Maven 3.5.0+ don't seem to send credentials after 301/302 http redirect

2020-04-28 Thread Cintia DR (Jira)
[ https://issues.apache.org/jira/browse/WAGON-590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cintia DR updated WAGON-590: Attachment: maven_x.log > Maven 3.5.0+ don't seem to send credentials after 301/302 http redirect >

[jira] [Commented] (WAGON-590) Maven 3.5.0+ don't seem to send credentials after 301/302 http redirect

2020-04-28 Thread Cintia DR (Jira)
[ https://issues.apache.org/jira/browse/WAGON-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094348#comment-17094348 ] Cintia DR commented on WAGON-590: - Even without having any proof in the code (or changelog

[jira] [Commented] (WAGON-590) Maven 3.5.0+ don't seem to send credentials after 301/302 http redirect

2020-04-28 Thread Cintia DR (Jira)
[ https://issues.apache.org/jira/browse/WAGON-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094346#comment-17094346 ] Cintia DR commented on WAGON-590: - I suppose it's fair, similar to how cookies work in bro

[jira] [Updated] (WAGON-590) Maven 3.5.0+ don't seem to send credentials after 301/302 http redirect

2020-04-28 Thread Cintia DR (Jira)
[ https://issues.apache.org/jira/browse/WAGON-590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cintia DR updated WAGON-590: Attachment: Screen Shot 2020-04-28 at 7.45.33 pm.png > Maven 3.5.0+ don't seem to send credentials after 301

[GitHub] [maven-surefire] Tibor17 commented on pull request #248: SUREFIRE-1695 Support multiple inheritance of @Categories

2020-04-28 Thread GitBox
Tibor17 commented on pull request #248: URL: https://github.com/apache/maven-surefire/pull/248#issuecomment-620484170 @YiannisDermitzakis No problem. Offtopic, I want to ask you if you have any practical experiences with JPMS and Java Modularity. We have to fix JPMS related issues. ---

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #289: SUREFIRE-1784 Fork JVM defined by jvm param should not inherit JAVA_HOME from Maven process

2020-04-28 Thread GitBox
Tibor17 commented on a change in pull request #289: URL: https://github.com/apache/maven-surefire/pull/289#discussion_r416448777 ## File path: maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/AbstractSurefireMojoToolchainsTest.java ## @@ -154,6 +157,36 @@ p

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #289: SUREFIRE-1784 Fork JVM defined by jvm param should not inherit JAVA_HOME from Maven process

2020-04-28 Thread GitBox
Tibor17 commented on a change in pull request #289: URL: https://github.com/apache/maven-surefire/pull/289#discussion_r416446480 ## File path: maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/AbstractSurefireMojoToolchainsTest.java ## @@ -154,6 +157,36 @@ p

[GitHub] [maven-surefire] IoannisDermitzakis commented on pull request #248: SUREFIRE-1695 Support multiple inheritance of @Categories

2020-04-28 Thread GitBox
IoannisDermitzakis commented on pull request #248: URL: https://github.com/apache/maven-surefire/pull/248#issuecomment-620447285 Thank you @Tibor17 for stepping in, I had forgotten this was still open. This is an automated m