[GitHub] [maven-shade-plugin] rfscholte commented on issue #39: [MSHADE-353] adding a generic relocation friendly transformer

2020-04-22 Thread GitBox
rfscholte commented on issue #39: URL: https://github.com/apache/maven-shade-plugin/pull/39#issuecomment-618215508 AFAICS your current integration test doesn't cover handle dynamic content, so I'm not not convinced that it should be part of this ticket. How would you handle a dynamic resou

[GitHub] [maven-shade-plugin] rmannibucau commented on issue #39: [MSHADE-353] adding a generic relocation friendly transformer

2020-04-22 Thread GitBox
rmannibucau commented on issue #39: URL: https://github.com/apache/maven-shade-plugin/pull/39#issuecomment-618190383 @rfscholte a chain does not enable to inherit from dynamic resources so I don't see how you aim at making it work, did I miss sthg?

[jira] [Comment Edited] (SUREFIRE-1262) Add modulepath support

2020-04-22 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090097#comment-17090097 ] Tibor Digana edited comment on SUREFIRE-1262 at 4/23/20, 12:17 AM: -

[jira] [Commented] (SUREFIRE-1262) Add modulepath support

2020-04-22 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090097#comment-17090097 ] Tibor Digana commented on SUREFIRE-1262: [~Pavel_K] e.g. {{javax.persistence-a

[jira] [Commented] (SUREFIRE-1262) Add modulepath support

2020-04-22 Thread Pavel_K (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090076#comment-17090076 ] Pavel_K commented on SUREFIRE-1262: --- [~tibordigana] I think that com.foo.plugin is t

[jira] [Commented] (SUREFIRE-1262) Add modulepath support

2020-04-22 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090072#comment-17090072 ] Tibor Digana commented on SUREFIRE-1262: [~Pavel_K] I need you to investigate

[jira] [Commented] (SUREFIRE-1262) Add modulepath support

2020-04-22 Thread Pavel_K (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090061#comment-17090061 ] Pavel_K commented on SUREFIRE-1262: --- [~tibordigana] What about your question - could

[jira] [Commented] (SUREFIRE-1262) Add modulepath support

2020-04-22 Thread Pavel_K (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090055#comment-17090055 ] Pavel_K commented on SUREFIRE-1262: --- [~tibordigana] I found out why I added forkCoun

[jira] [Commented] (SUREFIRE-1262) Add modulepath support

2020-04-22 Thread Pavel_K (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090028#comment-17090028 ] Pavel_K commented on SUREFIRE-1262: --- [~tibordigana] Wow it seems to work. But in rea

[jira] [Commented] (SUREFIRE-1262) Add modulepath support

2020-04-22 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1708#comment-1708 ] Tibor Digana commented on SUREFIRE-1262: [~Pavel_K] This is the problem {code

[jira] [Created] (MWRAPPER-1) Fails behind proxy 407

2020-04-22 Thread Benjamin Marwell (Jira)
Benjamin Marwell created MWRAPPER-1: --- Summary: Fails behind proxy 407 Key: MWRAPPER-1 URL: https://issues.apache.org/jira/browse/MWRAPPER-1 Project: Maven Wrapper Issue Type: Bug E

[GitHub] [maven-shade-plugin] rfscholte commented on issue #39: [MSHADE-353] adding a generic relocation friendly transformer

2020-04-22 Thread GitBox
rfscholte commented on issue #39: URL: https://github.com/apache/maven-shade-plugin/pull/39#issuecomment-618002706 Based on the example that is the problem you are trying to solve right now. This is an automated message from

[jira] [Updated] (SUREFIRE-1766) Surefire does not display TestNG data provider values on command line

2020-04-22 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1766: --- Fix Version/s: 3.0.0-M5 > Surefire does not display TestNG data provider values on command

[jira] [Assigned] (SUREFIRE-1766) Surefire does not display TestNG data provider values on command line

2020-04-22 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana reassigned SUREFIRE-1766: -- Assignee: Tibor Digana > Surefire does not display TestNG data provider values on c

[jira] [Commented] (SUREFIRE-1262) Add modulepath support

2020-04-22 Thread Pavel_K (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089979#comment-17089979 ] Pavel_K commented on SUREFIRE-1262: --- [~tibordigana] Thank you for your answer. Run m

[jira] [Closed] (SUREFIRE-1767) maven-failsafe-plugin 2.22.2 causes coverage percentage drop in jacoco result

2020-04-22 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana closed SUREFIRE-1767. -- Resolution: Not A Bug Feel free to reopen this Jira issue if it is a real bug. > maven-fail

[jira] [Assigned] (SUREFIRE-1767) maven-failsafe-plugin 2.22.2 causes coverage percentage drop in jacoco result

2020-04-22 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana reassigned SUREFIRE-1767: -- Assignee: Tibor Digana > maven-failsafe-plugin 2.22.2 causes coverage percentage dr

[GitHub] [maven-shade-plugin] rmannibucau commented on issue #39: [MSHADE-353] adding a generic relocation friendly transformer

2020-04-22 Thread GitBox
rmannibucau commented on issue #39: URL: https://github.com/apache/maven-shade-plugin/pull/39#issuecomment-617981739 @rfscholte hmm, what about the comment that a chain does not work compared to a wrapper? This is an automat

[GitHub] [maven-shade-plugin] rfscholte commented on issue #39: [MSHADE-353] adding a generic relocation friendly transformer

2020-04-22 Thread GitBox
rfscholte commented on issue #39: URL: https://github.com/apache/maven-shade-plugin/pull/39#issuecomment-617976914 This proposal is too specific. What you're asking for is the ability to chain any transformers, it is not just about relocation. By limiting this we will have issues future re

[jira] [Comment Edited] (SUREFIRE-1570) Maven-fail-safe doesn't put testing JPMS module on module path

2020-04-22 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089950#comment-17089950 ] Tibor Digana edited comment on SUREFIRE-1570 at 4/22/20, 7:02 PM: --

[jira] [Comment Edited] (SUREFIRE-1570) Maven-fail-safe doesn't put testing JPMS module on module path

2020-04-22 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089950#comment-17089950 ] Tibor Digana edited comment on SUREFIRE-1570 at 4/22/20, 7:01 PM: --

[jira] [Commented] (SUREFIRE-1570) Maven-fail-safe doesn't put testing JPMS module on module path

2020-04-22 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089950#comment-17089950 ] Tibor Digana commented on SUREFIRE-1570: Both, MP and CP, are discovered. You

[jira] [Commented] (SUREFIRE-1262) Add modulepath support

2020-04-22 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089900#comment-17089900 ] Tibor Digana commented on SUREFIRE-1262: [~Pavel_K] Yes it works but some limi

[jira] [Commented] (SUREFIRE-1570) Maven-fail-safe doesn't put testing JPMS module on module path

2020-04-22 Thread Pavel_K (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089789#comment-17089789 ] Pavel_K commented on SUREFIRE-1570: --- [~tibordigana] I am trying to understand how fa

[jira] [Comment Edited] (SUREFIRE-1262) Add modulepath support

2020-04-22 Thread Pavel_K (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089769#comment-17089769 ] Pavel_K edited comment on SUREFIRE-1262 at 4/22/20, 3:19 PM: ---

[jira] [Commented] (SUREFIRE-1262) Add modulepath support

2020-04-22 Thread Pavel_K (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089769#comment-17089769 ] Pavel_K commented on SUREFIRE-1262: --- When maven-compiler-plugin:3.6.2:testCompile co

[jira] [Issue Comment Deleted] (SUREFIRE-1262) Add modulepath support

2020-04-22 Thread Pavel_K (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pavel_K updated SUREFIRE-1262: -- Comment: was deleted (was: [~rfscholte] Thank you very much for your help. However, moving in that

[jira] [Commented] (SUREFIRE-1262) Add modulepath support

2020-04-22 Thread Pavel_K (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089751#comment-17089751 ] Pavel_K commented on SUREFIRE-1262: --- [~rfscholte] Thank you very much for your help.

[GitHub] [maven] fkalinski commented on issue #310: [MNG-6843] - Parallel build fails due to missing JAR artifacts in compilePath

2020-04-22 Thread GitBox
fkalinski commented on issue #310: URL: https://github.com/apache/maven/pull/310#issuecomment-617783528 As I have checked, the havoc is caused by ensureDependenciesAreResolved setting the artifactFilter to null on all the projects when executing "effective-pom" aggregate mojo. All the

[GitHub] [maven-wagon] elharo commented on issue #35: new feature: support stream read interface

2020-04-22 Thread GitBox
elharo commented on issue #35: URL: https://github.com/apache/maven-wagon/pull/35#issuecomment-617753263 This would need to be discussed on the dev mailing list and in JIRA first. This is an automated message from the Apache

[GitHub] [maven-wagon] elharo opened a new pull request #65: deps: update JUnit and surefire

2020-04-22 Thread GitBox
elharo opened a new pull request #65: URL: https://github.com/apache/maven-wagon/pull/65 @olamy This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [maven] belingueres commented on issue #285: [MNG-5222] - Maven 3 no longer logs warnings about deprecated plugin

2020-04-22 Thread GitBox
belingueres commented on issue #285: URL: https://github.com/apache/maven/pull/285#issuecomment-617743826 @hboutemy please see maven-compiler-plugin. It has deprecated and properties. This is an automated message from the

[GitHub] [maven] belingueres edited a comment on issue #285: [MNG-5222] - Maven 3 no longer logs warnings about deprecated plugin

2020-04-22 Thread GitBox
belingueres edited a comment on issue #285: URL: https://github.com/apache/maven/pull/285#issuecomment-617743826 @hboutemy please see maven-compiler-plugin. It has deprecated `compilerArguments` and `optimize` properties. Th

[GitHub] [maven-shade-plugin] melloware commented on issue #39: [MSHADE-353] adding a generic relocation friendly transformer

2020-04-22 Thread GitBox
melloware commented on issue #39: URL: https://github.com/apache/maven-shade-plugin/pull/39#issuecomment-617701654 +1 this is needed This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [maven-shade-plugin] rmannibucau commented on issue #39: [MSHADE-353] adding a generic relocation friendly transformer

2020-04-22 Thread GitBox
rmannibucau commented on issue #39: URL: https://github.com/apache/maven-shade-plugin/pull/39#issuecomment-617666969 @rfscholte do you still think we shouldn't have this kind of transformer wrapper or are we ok to merge? Thi

[GitHub] [maven-shade-plugin] tandraschko commented on issue #39: [MSHADE-353] adding a generic relocation friendly transformer

2020-04-22 Thread GitBox
tandraschko commented on issue #39: URL: https://github.com/apache/maven-shade-plugin/pull/39#issuecomment-617662430 any news? This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Commented] (MNG-5001) @readonly Mojo parameter annotation doesn't work any more

2020-04-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-5001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089404#comment-17089404 ] Hudson commented on MNG-5001: - Build unstable in Jenkins: Maven TLP » maven » MNG-5001-t #6 Se

[GitHub] [maven] hboutemy commented on issue #285: [MNG-5222] - Maven 3 no longer logs warnings about deprecated plugin

2020-04-22 Thread GitBox
hboutemy commented on issue #285: URL: https://github.com/apache/maven/pull/285#issuecomment-617598581 while working on MNG-5001 (failure on read-only parameters), I imagine I'll work on this one also question: do you have an example of deprecated parameter on a plugin available in

[jira] [Updated] (MNG-5001) @readonly Mojo parameter annotation doesn't work

2020-04-22 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MNG-5001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MNG-5001: --- Affects Version/s: 3.0-alpha-1 > @readonly Mojo parameter annotation doesn't work > ---

[jira] [Updated] (MNG-5001) @readonly Mojo parameter annotation doesn't work any more

2020-04-22 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MNG-5001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MNG-5001: --- Summary: @readonly Mojo parameter annotation doesn't work any more (was: @readonly Mojo parameter anno