olamy commented on issue #13: [MINVOKER-257] Test code should meet checkstyle
requirements
URL:
https://github.com/apache/maven-invoker-plugin/pull/13#issuecomment-586780396
@hboutemy @rfscholte maybe a rule for all of our code?? (checkstyle even for
test).
honestly I'm really 0 with t
[
https://issues.apache.org/jira/browse/MSKINS-112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz closed MSKINS-112.
---
Resolution: Auto Closed
> Embed "social bar"
> --
>
>
rfscholte commented on a change in pull request #329: Mng 5760 resume from
without args
URL: https://github.com/apache/maven/pull/329#discussion_r379941499
##
File path:
maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java
##
@@ -118,6 +11
rfscholte commented on issue #8: [MPLUGINTESTING-62] target maven 3.6.0 and
Plexus 2.0.0
URL:
https://github.com/apache/maven-plugin-testing/pull/8#issuecomment-586764617
Almost all our plugins are still compatible with Maven 3.0, pushing the
Maven dependency to 3.6.0 will make it very ha
Arne Lewinski created MNG-6866:
--
Summary: PluginDescriptorBuilder build method very long
Key: MNG-6866
URL: https://issues.apache.org/jira/browse/MNG-6866
Project: Maven
Issue Type: Improvement
michael-o commented on a change in pull request #327: [MNG-6865] "copy" in
object scope rather in class scope
URL: https://github.com/apache/maven/pull/327#discussion_r379939322
##
File path:
maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java
##
Arne Lewinski created MNG-6865:
--
Summary: copy in object scope rather in class scope
Key: MNG-6865
URL: https://issues.apache.org/jira/browse/MNG-6865
Project: Maven
Issue Type: Improvement
oopexpert commented on a change in pull request #327: [Refactoring] "copy" in
object scope rather in class scope
URL: https://github.com/apache/maven/pull/327#discussion_r379939039
##
File path:
maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java
###
michael-o commented on a change in pull request #327: [Refactoring] "copy" in
object scope rather in class scope
URL: https://github.com/apache/maven/pull/327#discussion_r379938654
##
File path:
maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java
###
oopexpert commented on a change in pull request #327: [Refactoring] "copy" in
object scope rather in class scope
URL: https://github.com/apache/maven/pull/327#discussion_r379938222
##
File path:
maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java
###
KroArtem commented on issue #2: [MVERIFIER-38] Define encoding for FileReader
URL:
https://github.com/apache/maven-verifier-plugin/pull/2#issuecomment-586759961
@michael-o , I've missed your comment back then :(
I've also defined encoding in pom.xml but we also discussed FileReader h
[
https://issues.apache.org/jira/browse/MINVOKER-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17037978#comment-17037978
]
Slawomir Jaranowski commented on MINVOKER-255:
--
I'm working on it.
> supp
MartinKanters commented on issue #329: Mng 5760 resume from without args
URL: https://github.com/apache/maven/pull/329#issuecomment-586756340
I'm interested in knowing your opinions on what the behavior should be when
someone tries to run `-rf` (without args) on a project which does not hav
MartinKanters edited a comment on issue #329: Mng 5760 resume from without args
URL: https://github.com/apache/maven/pull/329#issuecomment-586756340
I'm interested in knowing your opinions on what the behavior should be when
someone tries to run `-rf` (without args) on a project which does
MartinKanters opened a new pull request #329: Mng 5760 resume from without args
URL: https://github.com/apache/maven/pull/329
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x ] Make sure there is a [JIRA
issue](https://issues.apache.org/
[
https://issues.apache.org/jira/browse/MINVOKER-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17037975#comment-17037975
]
Hudson commented on MINVOKER-256:
-
Build succeeded in Jenkins: Maven TLP » maven-invoke
hboutemy closed pull request #37: [SECURITY] Use HTTPS to resolve dependencies
in Maven Build
URL: https://github.com/apache/maven-archetype/pull/37
This is an automated message from the Apache Git Service.
To respond to the
hboutemy commented on issue #4: Remove trailing spaces in generated App.java
and AppTest.java
URL: https://github.com/apache/maven-archetypes/pull/4#issuecomment-586752235
thank you John
This is an automated message from the
hboutemy merged pull request #4: Remove trailing spaces in generated App.java
and AppTest.java
URL: https://github.com/apache/maven-archetypes/pull/4
This is an automated message from the Apache Git Service.
To respond to th
olamy merged pull request #12: [MINVOKER-256] upgrade parent pom to latest
version - 34
URL: https://github.com/apache/maven-invoker-plugin/pull/12
This is an automated message from the Apache Git Service.
To respond to the
oopexpert commented on issue #327: [Refactoring] "copy" in object scope rather
in class scope
URL: https://github.com/apache/maven/pull/327#issuecomment-586751478
>
>
> Please create a JIRA issue for this.
And which project in JIRA?
--
[
https://issues.apache.org/jira/browse/WAGON-570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov reassigned WAGON-570:
Assignee: Michael Osipov
> Use RedirectStrategy from HttpClient rather than our custom code
[
https://issues.apache.org/jira/browse/WAGON-570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated WAGON-570:
-
Fix Version/s: 3.4.0
> Use RedirectStrategy from HttpClient rather than our custom code
>
michael-o commented on a change in pull request #327: [Refactoring] "copy" in
object scope rather in class scope
URL: https://github.com/apache/maven/pull/327#discussion_r379929701
##
File path:
maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java
###
oopexpert commented on a change in pull request #327: [Refactoring] "copy" in
object scope rather in class scope
URL: https://github.com/apache/maven/pull/327#discussion_r379929355
##
File path:
maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java
###
Michael Osipov created WAGON-579:
Summary: Make AbstractHttpClientWagon.put(int, Resource, File,
HttpEntity, String) react on SC_UNAUTHORIZED and
SC_PROXY_AUTHENTICATION_REQUIRED
Key: WAGON-579
URL: https://issue
oopexpert opened a new pull request #328: [Refactoring] extract methods, apply
SLA in PluginDescriptorBuilder
URL: https://github.com/apache/maven/pull/328
The build method of the class ""PluginDescriptorBuilder" was very long.
I extracted several methods and harmonized the methodolg
[
https://issues.apache.org/jira/browse/WAGON-578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17037945#comment-17037945
]
Michael Osipov commented on WAGON-578:
--
Fixed with
[2bcfebb7bbcd5b97512ed589c59c99df
[
https://issues.apache.org/jira/browse/WAGON-578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated WAGON-578:
-
Comment: was deleted
(was: Fixed with
[1e19350708bf50ba7160155bba4dadad09d3c629|https://gitbox.ap
[
https://issues.apache.org/jira/browse/WAGON-577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed WAGON-577.
Resolution: Fixed
Fixed with
[1e19350708bf50ba7160155bba4dadad09d3c629|https://gitbox.apache.org/re
[
https://issues.apache.org/jira/browse/WAGON-578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed WAGON-578.
Resolution: Fixed
Fixed with
[1e19350708bf50ba7160155bba4dadad09d3c629|https://gitbox.apache.org/re
Michael Osipov created WAGON-578:
Summary: Upgrade HttpClient to 4.5.11
Key: WAGON-578
URL: https://issues.apache.org/jira/browse/WAGON-578
Project: Maven Wagon
Issue Type: Dependency upgrade
Michael Osipov created WAGON-577:
Summary: Upgrade HttpCore to 4.4.13
Key: WAGON-577
URL: https://issues.apache.org/jira/browse/WAGON-577
Project: Maven Wagon
Issue Type: Dependency upgrade
michael-o commented on a change in pull request #327: [Refactoring] "copy" in
object scope rather in class scope
URL: https://github.com/apache/maven/pull/327#discussion_r379928208
##
File path:
maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java
###
oopexpert commented on a change in pull request #327: [Refactoring] "copy" in
object scope rather in class scope
URL: https://github.com/apache/maven/pull/327#discussion_r379928145
##
File path: maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
##
@@ -763,7 +
michael-o merged pull request #31: (doc) Fix broken link to developpers mailing
list
URL: https://github.com/apache/maven-dependency-plugin/pull/31
This is an automated message from the Apache Git Service.
To respond to the
michael-o commented on a change in pull request #327: [Refactoring] "copy" in
object scope rather in class scope
URL: https://github.com/apache/maven/pull/327#discussion_r379926893
##
File path: maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
##
@@ -763,7 +
[
https://issues.apache.org/jira/browse/MPOM-241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy deleted MPOM-241:
---
> Ok
> ---
>
> Key: MPOM-241
> URL: https://issues.apache.org/jira/browse
[
https://issues.apache.org/jira/browse/MPOM-241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy updated MPOM-241:
---
Summary: Ok (was: upgrade parent pom to latest version - 34)
> Ok
> ---
>
> Key: MPO
oopexpert opened a new pull request #327: [Refactoring] "copy" in object scope
rather in class scope
URL: https://github.com/apache/maven/pull/327
This refactoring refers to a more intuitive API approach.
The interface "MavenExecutionRequest" now provides an object scope method to
c
ledoyen opened a new pull request #31: (doc) Fix broken link to developpers
mailing list
URL: https://github.com/apache/maven-dependency-plugin/pull/31
The link to dev-list was broken on the `README.md`.
I took the liberty to also fix other occurences of this link.
- [x] I he
oopexpert commented on issue #326: [Refactoring] extract methods, apply SLA
URL: https://github.com/apache/maven/pull/326#issuecomment-586727285
adapted.
This is an automated message from the Apache Git Service.
To respond to
michael-o commented on issue #326: [Refactoring] extract methods, apply SLA
URL: https://github.com/apache/maven/pull/326#issuecomment-586719822
Please stick to the Maven code formatting convention.
This is an automated messag
johnlinp commented on issue #4: Remove trailing spaces in generated App.java
and AppTest.java
URL: https://github.com/apache/maven-archetypes/pull/4#issuecomment-586719411
Hi @hboutemy, can you please take a look? Thanks!
Thi
oopexpert opened a new pull request #326: extract methods, apply SLA
URL: https://github.com/apache/maven/pull/326
Apply "extract method" refactoring to make methods smaller. Considering
principle "single level of abstraction".
--
SingingBush commented on a change in pull request #10: Add Github Workflows CI
for JDK 7 - 13
URL:
https://github.com/apache/maven-plugin-testing/pull/10#discussion_r379903447
##
File path: .github/workflows/maven.yml
##
@@ -0,0 +1,43 @@
+#
+# Licensed to the Apache Softw
SingingBush commented on a change in pull request #10: Add Github Workflows CI
for JDK 7 - 13
URL:
https://github.com/apache/maven-plugin-testing/pull/10#discussion_r379903422
##
File path: .github/workflows/maven.yml
##
@@ -0,0 +1,43 @@
+#
+# Licensed to the Apache Softw
SingingBush commented on issue #8: [MPLUGINTESTING-62] target maven 3.6.0 and
Plexus 2.0.0
URL:
https://github.com/apache/maven-plugin-testing/pull/8#issuecomment-586705940
@Tibor17 @rfscholte I've rebased with master so that this PR is now simply
changes to target Maven 3.6.0
--
[
https://issues.apache.org/jira/browse/WAGON-572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed WAGON-572.
Resolution: Won't Fix
It seems to be a bad idea to sniff on input streams. They are, by definition
michael-o commented on a change in pull request #10: Add Github Workflows CI
for JDK 7 - 13
URL:
https://github.com/apache/maven-plugin-testing/pull/10#discussion_r379901519
##
File path: .github/workflows/maven.yml
##
@@ -0,0 +1,43 @@
+#
+# Licensed to the Apache Softwar
michael-o commented on a change in pull request #10: Add Github Workflows CI
for JDK 7 - 13
URL:
https://github.com/apache/maven-plugin-testing/pull/10#discussion_r379901473
##
File path: .github/workflows/maven.yml
##
@@ -0,0 +1,43 @@
+#
+# Licensed to the Apache Softwar
SingingBush opened a new pull request #10: Add Github Workflows CI for JDK 7 -
13
URL: https://github.com/apache/maven-plugin-testing/pull/10
Although the project already has Jenkins for CI it would be really helpful
to use the in built Github Actions CI for quick builds and visibility for
asfgit closed pull request #1: Bump httpclient from 4.2.5 to 4.3.6
URL: https://github.com/apache/maven-dist-tool/pull/1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
dependabot[bot] commented on issue #1: Bump httpclient from 4.2.5 to 4.3.6
URL: https://github.com/apache/maven-dist-tool/pull/1#issuecomment-586700839
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates un
slawekjaranowski opened a new pull request #13: [MINVOKER-257] Test code should
meet checkstyle requirements
URL: https://github.com/apache/maven-invoker-plugin/pull/13
This is an automated message from the Apache Git Servic
[
https://issues.apache.org/jira/browse/WAGON-572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated WAGON-572:
-
Description: There are cases where a request needs to be replayed. Input
streams aren't repeatable
[
https://issues.apache.org/jira/browse/WAGON-573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17037784#comment-17037784
]
Michael Osipov commented on WAGON-573:
--
Fixed with
[ae3b9c4136d9ca504a9acba266e0326b
[
https://issues.apache.org/jira/browse/WAGON-573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed WAGON-573.
Fix Version/s: 3.4.0
Resolution: Fixed
> EntityUtils.consumeQuietly() never called on non-2xx
asfgit closed pull request #59: [WAGON-573] EntityUtils.consumeQuietly() never
called on non-2xx stat…
URL: https://github.com/apache/maven-wagon/pull/59
This is an automated message from the Apache Git Service.
To respond t
[
https://issues.apache.org/jira/browse/MINVOKER-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski updated MINVOKER-172:
-
Comment: was deleted
(was: As I see we have three source of mavenOpts
- system
Slawomir Jaranowski created MINVOKER-257:
Summary: Test code should meet checkstyle requirements
Key: MINVOKER-257
URL: https://issues.apache.org/jira/browse/MINVOKER-257
Project: Maven Invoker
[
https://issues.apache.org/jira/browse/MINVOKER-256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski updated MINVOKER-256:
-
Issue Type: Dependency upgrade (was: New Feature)
> upgrade parent pom to late
slachiewicz commented on issue #323: [SECURITY] Use HTTPS to resolve
dependencies in Maven Build
URL: https://github.com/apache/maven/pull/323#issuecomment-586688251
We have some errors when running unit tests, can you check them?
https://builds.apache.org/view/M-R/view/Maven/job/maven-
slawekjaranowski opened a new pull request #12: [MINVOKER-256] upgrade parent
pom to latest version - 34
URL: https://github.com/apache/maven-invoker-plugin/pull/12
This is an automated message from the Apache Git Service.
T
Slawomir Jaranowski created MINVOKER-256:
Summary: upgrade parent pom to latest version - 34
Key: MINVOKER-256
URL: https://issues.apache.org/jira/browse/MINVOKER-256
Project: Maven Invoker Plu
[
https://issues.apache.org/jira/browse/MPOM-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17037759#comment-17037759
]
Slawomir Jaranowski commented on MPOM-241:
--
Please drop/close - wrong project
> u
Slawomir Jaranowski created MPOM-241:
Summary: upgrade parent pom to latest version - 34
Key: MPOM-241
URL: https://issues.apache.org/jira/browse/MPOM-241
Project: Maven POMs
Issue Type:
67 matches
Mail list logo