[GitHub] [maven-surefire] Tibor17 edited a comment on issue #261: SUREFIRE-1744 - enable system-out for successful tests as well

2020-01-10 Thread GitBox
Tibor17 edited a comment on issue #261: SUREFIRE-1744 - enable system-out for successful tests as well URL: https://github.com/apache/maven-surefire/pull/261#issuecomment-573275070 @klevis Pls run the build locally. The module `surefire-logger-api` failed and you have to see the root c

[GitHub] [maven-surefire] Tibor17 commented on issue #261: SUREFIRE-1744 - enable system-out for successful tests as well

2020-01-10 Thread GitBox
Tibor17 commented on issue #261: SUREFIRE-1744 - enable system-out for successful tests as well URL: https://github.com/apache/maven-surefire/pull/261#issuecomment-573275070 @klevis Pls run the build locally. The module `surefire-logger-api` failed and you have see the rootcause in the

[jira] [Created] (MINVOKER-253) Sub Modules do not respect localRepositoryPath

2020-01-10 Thread Andreas Schaefer (Jira)
Andreas Schaefer created MINVOKER-253: - Summary: Sub Modules do not respect localRepositoryPath Key: MINVOKER-253 URL: https://issues.apache.org/jira/browse/MINVOKER-253 Project: Maven Invoker Plug

[GitHub] [maven-pmd-plugin] christianhujer commented on issue #15: [MPMD-295] - Maven PMD Plugin fails on Java 13: Unsupported targetJdk value '13'

2020-01-10 Thread GitBox
christianhujer commented on issue #15: [MPMD-295] - Maven PMD Plugin fails on Java 13: Unsupported targetJdk value '13' URL: https://github.com/apache/maven-pmd-plugin/pull/15#issuecomment-573154605 I've bumped the version of PMD to 6.19.0 which passes `mvn -Prun-its verify` without regre

[GitHub] [maven-shade-plugin] famod commented on issue #33: [MSHADE-339] - Shaded test jar has wrong type "jar"

2020-01-10 Thread GitBox
famod commented on issue #33: [MSHADE-339] - Shaded test jar has wrong type "jar" URL: https://github.com/apache/maven-shade-plugin/pull/33#issuecomment-573151931 Since strong "opposition" against this approach [was voiced in MSHADE-339](https://issues.apache.org/jira/browse/MSHADE-339?foc

[GitHub] [maven-pmd-plugin] christianhujer commented on issue #15: [MPMD-295] - Maven PMD Plugin fails on Java 13: Unsupported targetJdk value '13'

2020-01-10 Thread GitBox
christianhujer commented on issue #15: [MPMD-295] - Maven PMD Plugin fails on Java 13: Unsupported targetJdk value '13' URL: https://github.com/apache/maven-pmd-plugin/pull/15#issuecomment-573149759 I've just tried upgrading PMD to 6.20.0. When doing that, there are test issues. I will lo

[GitHub] [maven-pmd-plugin] christianhujer commented on issue #15: [MPMD-295] - Maven PMD Plugin fails on Java 13: Unsupported targetJdk value '13'

2020-01-10 Thread GitBox
christianhujer commented on issue #15: [MPMD-295] - Maven PMD Plugin fails on Java 13: Unsupported targetJdk value '13' URL: https://github.com/apache/maven-pmd-plugin/pull/15#issuecomment-573147645 Yes, and it's not a good reason. Somehow my tools (IntelliJ IDEA version autocomplete) tol

[GitHub] [maven-verifier-plugin] slachiewicz commented on issue #1: Use new version of site and thoughts about new release

2020-01-10 Thread GitBox
slachiewicz commented on issue #1: Use new version of site and thoughts about new release URL: https://github.com/apache/maven-verifier-plugin/pull/1#issuecomment-573110199 The build was successful - code merged to master. Thx. Let's continue the discussion about the release on the mailin

[jira] [Closed] (MVERIFIER-36) Cleanup code, move to Java 7 syntax

2020-01-10 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MVERIFIER-36?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MVERIFIER-36. - Resolution: Fixed > Cleanup code, move to Java 7 syntax > -

[jira] [Commented] (MVERIFIER-36) Cleanup code, move to Java 7 syntax

2020-01-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MVERIFIER-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013047#comment-17013047 ] Hudson commented on MVERIFIER-36: - Build succeeded in Jenkins: Maven TLP » maven-verifi

[GitHub] [maven-verifier-plugin] asfgit closed pull request #1: Use new version of site and thoughts about new release

2020-01-10 Thread GitBox
asfgit closed pull request #1: Use new version of site and thoughts about new release URL: https://github.com/apache/maven-verifier-plugin/pull/1 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [maven-verifier-plugin] slachiewicz commented on issue #1: Use new version of site and thoughts about new release

2020-01-10 Thread GitBox
slachiewicz commented on issue #1: Use new version of site and thoughts about new release URL: https://github.com/apache/maven-verifier-plugin/pull/1#issuecomment-573101934 thx for contribution. I've created https://issues.apache.org/jira/browse/MVERIFIER-36 for that and selected only ch

[jira] [Created] (MVERIFIER-36) Cleanup code, move to Java 7 syntax

2020-01-10 Thread Sylwester Lachiewicz (Jira)
Sylwester Lachiewicz created MVERIFIER-36: - Summary: Cleanup code, move to Java 7 syntax Key: MVERIFIER-36 URL: https://issues.apache.org/jira/browse/MVERIFIER-36 Project: Maven Verifier Plugin

[jira] [Commented] (MNG-6616) Create public API for Projects Artifacts Cache where one project can be invalidated

2020-01-10 Thread Robert Scholte (Jira)
[ https://issues.apache.org/jira/browse/MNG-6616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17012920#comment-17012920 ] Robert Scholte commented on MNG-6616: - [~balazs.zsoldos] I want to solve MNG-5669 and y

[GitHub] [maven] rosti-il commented on a change in pull request #307: Simplify detection of the MAVEN_HOME and make it fully qualified

2020-01-10 Thread GitBox
rosti-il commented on a change in pull request #307: Simplify detection of the MAVEN_HOME and make it fully qualified URL: https://github.com/apache/maven/pull/307#discussion_r364997442 ## File path: apache-maven/src/bin/mvn.cmd ## @@ -60,15 +60,11 @@ echo NB: JAVA_HOME sh

[jira] [Assigned] (MNG-6819) NullPointerException for DefaultArtifactDescriptorReader.loadPom

2020-01-10 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MNG-6819: --- Assignee: (was: Michael Osipov) > NullPointerException for DefaultArtifactDescriptorReader

[GitHub] [maven] michael-o commented on issue #314: [fix]conditional overwrite version

2020-01-10 Thread GitBox
michael-o commented on issue #314: [fix]conditional overwrite version URL: https://github.com/apache/maven/pull/314#issuecomment-573044577 This will require a JIRA issue. This is an automated message from the Apache Git Servic

[jira] [Commented] (ARCHETYPE-573) Version 3.1.1 generates redundant newlines in POM files

2020-01-10 Thread Jira
[ https://issues.apache.org/jira/browse/ARCHETYPE-573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17012862#comment-17012862 ] Paweł Gadecki commented on ARCHETYPE-573: - I also confirm, that this issue is

[GitHub] [maven] zhaoyunxing92 opened a new pull request #314: [fix]conditional overwrite version

2020-01-10 Thread GitBox
zhaoyunxing92 opened a new pull request #314: [fix]conditional overwrite version URL: https://github.com/apache/maven/pull/314 Following this checklist to help us incorporate your contribution quickly and easily: - [ x ] Make sure there is a [JIRA issue](https://issues.apache.or

[GitHub] [maven] elharo commented on a change in pull request #277: [MNG-6732] - DefaultArtifactDescriptorReader.loadPom to check IGNORE_MISSING policy upon ArtifactTransferException

2020-01-10 Thread GitBox
elharo commented on a change in pull request #277: [MNG-6732] - DefaultArtifactDescriptorReader.loadPom to check IGNORE_MISSING policy upon ArtifactTransferException URL: https://github.com/apache/maven/pull/277#discussion_r365221044 ## File path: maven-resolver-provider/src/test/

[jira] [Created] (MNG-6846) conditional overwrite

2020-01-10 Thread zhaoyx (Jira)
zhaoyx created MNG-6846: --- Summary: conditional overwrite Key: MNG-6846 URL: https://issues.apache.org/jira/browse/MNG-6846 Project: Maven Issue Type: Bug Components: Bootstrap & Build Aff

[GitHub] [maven-verifier-plugin] elharo commented on a change in pull request #1: Use new version of site and thoughts about new release

2020-01-10 Thread GitBox
elharo commented on a change in pull request #1: Use new version of site and thoughts about new release URL: https://github.com/apache/maven-verifier-plugin/pull/1#discussion_r365216069 ## File path: src/main/java/org/apache/maven/plugins/verifier/VerifierMojo.java ## @@

[GitHub] [maven-verifier-plugin] elharo commented on a change in pull request #1: Use new version of site and thoughts about new release

2020-01-10 Thread GitBox
elharo commented on a change in pull request #1: Use new version of site and thoughts about new release URL: https://github.com/apache/maven-verifier-plugin/pull/1#discussion_r365217088 ## File path: pom.xml ## @@ -77,19 +77,20 @@ under the License. org.apach

[GitHub] [maven-surefire] klevis edited a comment on issue #261: SUREFIRE-1744 - enable system-out for successful tests as well

2020-01-10 Thread GitBox
klevis edited a comment on issue #261: SUREFIRE-1744 - enable system-out for successful tests as well URL: https://github.com/apache/maven-surefire/pull/261#issuecomment-573009579 @Tibor17 about serializeTestClassWithRerun is quite unclear the right place this might needed.. Anyway look

[GitHub] [maven-surefire] klevis commented on issue #261: SUREFIRE-1744 - enable system-out for successful tests as well

2020-01-10 Thread GitBox
klevis commented on issue #261: SUREFIRE-1744 - enable system-out for successful tests as well URL: https://github.com/apache/maven-surefire/pull/261#issuecomment-573009579 @Tibor17 about serializeTestClassWithRerun is quite unclear the right place this might needed.. Anyway looking at

[GitHub] [maven-surefire] Tibor17 commented on issue #261: SUREFIRE-1744 - enable system-out for successful tests as well

2020-01-10 Thread GitBox
Tibor17 commented on issue #261: SUREFIRE-1744 - enable system-out for successful tests as well URL: https://github.com/apache/maven-surefire/pull/261#issuecomment-572983344 @klevis The CI for PRs is not executed. Can you make an extra commit rollbacking the https://github.com/apache/m

[GitHub] [maven-surefire] Tibor17 commented on issue #261: SUREFIRE-1744 - enable system-out for successful tests as well

2020-01-10 Thread GitBox
Tibor17 commented on issue #261: SUREFIRE-1744 - enable system-out for successful tests as well URL: https://github.com/apache/maven-surefire/pull/261#issuecomment-572982205 How is it with rerun in the method `serializeTestClassWithRerun`? Do we need to do the same there and can we cover t

[jira] [Created] (MJAVADOC-633) Javadoc fails with JDK13+: invalid flag: --no-module-directories

2020-01-10 Thread Emond Papegaaij (Jira)
Emond Papegaaij created MJAVADOC-633: Summary: Javadoc fails with JDK13+: invalid flag: --no-module-directories Key: MJAVADOC-633 URL: https://issues.apache.org/jira/browse/MJAVADOC-633 Project: M

[GitHub] [maven-surefire] klevis commented on issue #261: SUREFIRE-1744 - enable system-out for successful tests as well

2020-01-10 Thread GitBox
klevis commented on issue #261: SUREFIRE-1744 - enable system-out for successful tests as well URL: https://github.com/apache/maven-surefire/pull/261#issuecomment-572977125 @Tibor17 commits are squashed now, the change is really tiny... -

[GitHub] [maven-surefire] Tibor17 commented on issue #261: SUREFIRE-1744 - enable system-out for successful tests as well

2020-01-10 Thread GitBox
Tibor17 commented on issue #261: SUREFIRE-1744 - enable system-out for successful tests as well URL: https://github.com/apache/maven-surefire/pull/261#issuecomment-572974894 @klevis So what is the change in real? Would you squash the commits to one in order to see the diff better? -

[jira] [Commented] (MNG-6844) Use StandardCharsets and remove outdated @SuppressWarnings

2020-01-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-6844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17012657#comment-17012657 ] Hudson commented on MNG-6844: - Build succeeded in Jenkins: Maven TLP » maven » master #350 See

[jira] [Updated] (MPOM-234) Upgrade apache-rat-plugin to 0.13

2020-01-10 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MPOM-234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MPOM-234: -- Affects Version/s: ASF-22 > Upgrade apache-rat-plugin to 0.13 > -

[jira] [Updated] (MPOM-234) Upgrade apache-rat-plugin to 0.13

2020-01-10 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MPOM-234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MPOM-234: -- Fix Version/s: ASF-23 > Upgrade apache-rat-plugin to 0.13 > -

[jira] [Created] (MPOM-234) Upgrade apache-rat-plugin to 0.13

2020-01-10 Thread Sylwester Lachiewicz (Jira)
Sylwester Lachiewicz created MPOM-234: - Summary: Upgrade apache-rat-plugin to 0.13 Key: MPOM-234 URL: https://issues.apache.org/jira/browse/MPOM-234 Project: Maven POMs Issue Type: Depend

[GitHub] [maven] michael-o merged pull request #313: [MNG-6844] Remove outdated TODOs

2020-01-10 Thread GitBox
michael-o merged pull request #313: [MNG-6844] Remove outdated TODOs URL: https://github.com/apache/maven/pull/313 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[jira] [Created] (MNG-6845) Upgrade to apache-rat-plugin 0.13

2020-01-10 Thread Sylwester Lachiewicz (Jira)
Sylwester Lachiewicz created MNG-6845: - Summary: Upgrade to apache-rat-plugin 0.13 Key: MNG-6845 URL: https://issues.apache.org/jira/browse/MNG-6845 Project: Maven Issue Type: Dependency

[jira] [Commented] (SUREFIRE-1744) Enable system-out for successfuly passed tests as well

2020-01-10 Thread Klevis Ramo (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17012587#comment-17012587 ] Klevis Ramo commented on SUREFIRE-1744: --- [~tibordigana] I already created a PR

[GitHub] [maven-verifier-plugin] KroArtem commented on issue #1: Use new version of site and thoughts about new release

2020-01-10 Thread GitBox
KroArtem commented on issue #1: Use new version of site and thoughts about new release URL: https://github.com/apache/maven-verifier-plugin/pull/1#issuecomment-572928794 Let's wait for developer community replies then. This

[GitHub] [maven-surefire] klevis opened a new pull request #261: SUREFIRE-1744 - enable system-out for successful tests as well

2020-01-10 Thread GitBox
klevis opened a new pull request #261: SUREFIRE-1744 - enable system-out for successful tests as well URL: https://github.com/apache/maven-surefire/pull/261 Original Tickete at : https://issues.apache.org/jira/projects/SUREFIRE/issues/SUREFIRE-1744?filter=allopenissues ---