bmhm commented on issue #18: [MCHECKSTYLE-381] remove call to
checker.setClassLoader().
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/18#issuecomment-565334303
The method `private List getFilesToProcess( CheckstyleExecutorRequest
request )` also has a unused variable `String
bmhm commented on a change in pull request #18: [MCHECKSTYLE-381] remove call
to checker.setClassLoader().
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/18#discussion_r357512764
##
File path:
src/main/java/org/apache/maven/plugins/checkstyle/exec/DefaultCheckstyleExe
[
https://issues.apache.org/jira/browse/MRELEASE-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995281#comment-16995281
]
Hudson commented on MRELEASE-1035:
--
Build succeeded in Jenkins: Maven TLP » maven-rel
rnveach commented on a change in pull request #18: [MCHECKSTYLE-381] remove
call to checker.setClassLoader().
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/18#discussion_r357458054
##
File path:
src/main/java/org/apache/maven/plugins/checkstyle/exec/DefaultCheckstyle
rnveach commented on a change in pull request #18: [MCHECKSTYLE-381] remove
call to checker.setClassLoader().
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/18#discussion_r357458054
##
File path:
src/main/java/org/apache/maven/plugins/checkstyle/exec/DefaultCheckstyle
[
https://issues.apache.org/jira/browse/MPH-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995155#comment-16995155
]
Michael Osipov commented on MPH-162:
As far as I remember we add a similiar header with
Herve Boutemy created MRELEASE-1036:
---
Summary: fix javadoc for JDK 8
Key: MRELEASE-1036
URL: https://issues.apache.org/jira/browse/MRELEASE-1036
Project: Maven Release Plugin
Issue Type: Ta
[
https://issues.apache.org/jira/browse/MRELEASE-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy updated MRELEASE-1035:
Fix Version/s: 3.0.0
> make build reproducible
> ---
>
>
[
https://issues.apache.org/jira/browse/MRELEASE-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy reopened MRELEASE-1035:
-
as found during the vote, there are a few issues:
- sources.jar are all different, because
[
https://issues.apache.org/jira/browse/MRELEASE-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy updated MRELEASE-1035:
Fix Version/s: (was: 3.0.0-M1)
> make build reproducible
> ---
>
[
https://issues.apache.org/jira/browse/MPH-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995075#comment-16995075
]
Andy Wilkinson commented on MPH-162:
Yes, I should be able to do that. When you say "it"
[
https://issues.apache.org/jira/browse/ARCHETYPE-583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Scholte reassigned ARCHETYPE-583:
Assignee: Robert Scholte
> Skip parent non-archetype project when updating loca
[
https://issues.apache.org/jira/browse/MPH-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16994876#comment-16994876
]
Michael Osipov commented on MPH-162:
[~hboutemy], I think you will agree here.
> Allow
[
https://issues.apache.org/jira/browse/MPH-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16994859#comment-16994859
]
Michael Osipov commented on MPH-162:
I would completely drop it. Can you provide a PR fo
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16994824#comment-16994824
]
Lambert commented on MCHECKSTYLE-383:
-
Thanks for the answer.
I opened a github
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise closed MCHECKSTYLE-383.
---
Resolution: Not A Problem
> FallThrough module does not support the spel
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16994804#comment-16994804
]
Ben M. commented on MCHECKSTYLE-364:
There was not a lot of content:
[http://we
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16994797#comment-16994797
]
Ben M. commented on MCHECKSTYLE-264:
I forgot the Licence header in a new file a
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16994795#comment-16994795
]
Ben M. commented on MCHECKSTYLE-383:
I think this issue should be posted over he
Dietrich Schulten created SUREFIRE-1737:
---
Summary: Disabling the JUnit5Xml30StatelessReporter has no effect
Key: SUREFIRE-1737
URL: https://issues.apache.org/jira/browse/SUREFIRE-1737
Project: M
Dietrich Schulten created SUREFIRE-1736:
---
Summary: JUnit 5 runner does not evaluate display names of nested
tests
Key: SUREFIRE-1736
URL: https://issues.apache.org/jira/browse/SUREFIRE-1736
Proj
bmhm commented on issue #17: [MCHECKSTYLE-385] rework code to use a
Violation.java class.
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/17#issuecomment-565035024
Another alternative to the `null` Pattern is to use Java 8's `Optional`s
like so:
```patch
Index: src/m
bmhm opened a new pull request #18: [MCHECKSTYLE-381] remove call to
checker.setClassLoader().
URL: https://github.com/apache/maven-checkstyle-plugin/pull/18
- See also: https://github.com/checkstyle/checkstyle/issues/7190
Signed-off-by: Benjamin Marwell
- [X] I hereby dec
bmhm commented on a change in pull request #17: [MCHECKSTYLE-385] rework code
to use a Violation.java class.
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/17#discussion_r357159930
##
File path: src/main/java/org/apache/maven/plugins/checkstyle/Violation.java
bmhm commented on a change in pull request #17: [MCHECKSTYLE-385] rework code
to use a Violation.java class.
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/17#discussion_r357156917
##
File path:
src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleViolationChec
bmhm commented on a change in pull request #17: [MCHECKSTYLE-385] rework code
to use a Violation.java class.
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/17#discussion_r357155648
##
File path:
src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleViolationChec
eolivelli commented on a change in pull request #17: [MCHECKSTYLE-385] rework
code to use a Violation.java class.
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/17#discussion_r357139454
##
File path:
src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleViolatio
eolivelli commented on a change in pull request #17: [MCHECKSTYLE-385] rework
code to use a Violation.java class.
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/17#discussion_r357138678
##
File path:
src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleViolatio
eolivelli commented on a change in pull request #17: [MCHECKSTYLE-385] rework
code to use a Violation.java class.
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/17#discussion_r357139780
##
File path:
src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleViolatio
eolivelli commented on a change in pull request #17: [MCHECKSTYLE-385] rework
code to use a Violation.java class.
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/17#discussion_r357139125
##
File path:
src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleViolatio
eolivelli commented on issue #1: MANTRUN-221 Fails to pass maven properties set
in user properties only
URL: https://github.com/apache/maven-antrun-plugin/pull/1#issuecomment-564998684
let's wait for CI
https://builds.apache.org/job/maven-box/job/maven-antrun-plugin/job/MANTRUN-221/
--
elharo commented on a change in pull request #17: [MCHECKSTYLE-385] rework code
to use a Violation.java class.
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/17#discussion_r357128152
##
File path:
src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleViolationCh
elharo commented on a change in pull request #17: [MCHECKSTYLE-385] rework code
to use a Violation.java class.
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/17#discussion_r357126047
##
File path:
src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleViolationCh
elharo commented on a change in pull request #17: [MCHECKSTYLE-385] rework code
to use a Violation.java class.
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/17#discussion_r357126788
##
File path:
src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleViolationCh
elharo commented on a change in pull request #17: [MCHECKSTYLE-385] rework code
to use a Violation.java class.
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/17#discussion_r357130118
##
File path: src/main/java/org/apache/maven/plugins/checkstyle/Violation.java
##
bmhm commented on a change in pull request #17: [MCHECKSTYLE-385] rework code
to use a Violation.java class.
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/17#discussion_r357121349
##
File path: src/main/java/org/apache/maven/plugins/checkstyle/Violation.java
bmhm commented on a change in pull request #17: [MCHECKSTYLE-385] rework code
to use a Violation.java class.
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/17#discussion_r357118143
##
File path: src/main/java/org/apache/maven/plugins/checkstyle/Violation.java
bmhm commented on a change in pull request #17: [MCHECKSTYLE-385] rework code
to use a Violation.java class.
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/17#discussion_r357112470
##
File path: src/main/java/org/apache/maven/plugins/checkstyle/Violation.java
bmhm commented on a change in pull request #17: [MCHECKSTYLE-385] rework code
to use a Violation.java class.
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/17#discussion_r357112106
##
File path: src/main/java/org/apache/maven/plugins/checkstyle/Violation.java
bmhm commented on a change in pull request #17: [MCHECKSTYLE-385] rework code
to use a Violation.java class.
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/17#discussion_r357111728
##
File path:
src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleViolationChec
bmhm commented on a change in pull request #17: [MCHECKSTYLE-385] rework code
to use a Violation.java class.
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/17#discussion_r357110894
##
File path:
src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleViolationChec
bmhm commented on a change in pull request #17: [MCHECKSTYLE-385] rework code
to use a Violation.java class.
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/17#discussion_r357110483
##
File path:
src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleViolationChec
bmhm commented on a change in pull request #17: [MCHECKSTYLE-385] rework code
to use a Violation.java class.
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/17#discussion_r357109486
##
File path:
src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleViolationChec
bmhm commented on a change in pull request #17: [MCHECKSTYLE-385] rework code
to use a Violation.java class.
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/17#discussion_r357109387
##
File path:
src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleViolationChec
bmhm commented on a change in pull request #17: [MCHECKSTYLE-385] rework code
to use a Violation.java class.
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/17#discussion_r357109035
##
File path:
src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleViolationChec
elharo commented on a change in pull request #17: [MCHECKSTYLE-385] rework code
to use a Violation.java class.
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/17#discussion_r357099838
##
File path: src/main/java/org/apache/maven/plugins/checkstyle/Violation.java
##
elharo commented on a change in pull request #17: [MCHECKSTYLE-385] rework code
to use a Violation.java class.
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/17#discussion_r357099036
##
File path:
src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleViolationCh
elharo commented on a change in pull request #17: [MCHECKSTYLE-385] rework code
to use a Violation.java class.
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/17#discussion_r357097941
##
File path:
src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleViolationCh
elharo commented on a change in pull request #17: [MCHECKSTYLE-385] rework code
to use a Violation.java class.
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/17#discussion_r357096888
##
File path:
src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleViolationCh
elharo commented on a change in pull request #17: [MCHECKSTYLE-385] rework code
to use a Violation.java class.
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/17#discussion_r357097702
##
File path:
src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleViolationCh
elharo commented on a change in pull request #17: [MCHECKSTYLE-385] rework code
to use a Violation.java class.
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/17#discussion_r357098426
##
File path:
src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleViolationCh
elharo commented on a change in pull request #17: [MCHECKSTYLE-385] rework code
to use a Violation.java class.
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/17#discussion_r357099516
##
File path: src/main/java/org/apache/maven/plugins/checkstyle/Violation.java
##
elharo commented on a change in pull request #17: [MCHECKSTYLE-385] rework code
to use a Violation.java class.
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/17#discussion_r357096831
##
File path:
src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleViolationCh
elharo commented on a change in pull request #17: [MCHECKSTYLE-385] rework code
to use a Violation.java class.
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/17#discussion_r357096184
##
File path:
src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleViolationCh
elharo commented on a change in pull request #17: [MCHECKSTYLE-385] rework code
to use a Violation.java class.
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/17#discussion_r357099966
##
File path: src/main/java/org/apache/maven/plugins/checkstyle/Violation.java
##
elharo commented on a change in pull request #17: [MCHECKSTYLE-385] rework code
to use a Violation.java class.
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/17#discussion_r357100196
##
File path: src/main/java/org/apache/maven/plugins/checkstyle/Violation.java
##
elharo commented on a change in pull request #17: [MCHECKSTYLE-385] rework code
to use a Violation.java class.
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/17#discussion_r357100035
##
File path: src/main/java/org/apache/maven/plugins/checkstyle/Violation.java
##
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben M. updated MCHECKSTYLE-385:
---
Labels: easyfix pull-request-available (was: easyfix)
> Violation should be a value class
> ---
bmhm commented on issue #17: [MCHECKSTYLE-385] rework code to use a
Violation.java class.
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/17#issuecomment-564945721
Things to think of:
- Some javadoc. Especially the difference between `source` and `file` does
not seem c
bmhm opened a new pull request #17: [MCHECKSTYLE-385] rework code to use a
Violation.java class.
URL: https://github.com/apache/maven-checkstyle-plugin/pull/17
rework code to use a Violation.java class. This enables further
optimizations.
- [X] I hereby declare this contribution to
Andy Wilkinson created MPH-162:
--
Summary: Allow EffectiveHelpMojo to be configured to produce
repeatable output
Key: MPH-162
URL: https://issues.apache.org/jira/browse/MPH-162
Project: Maven Help Plugin
[
https://issues.apache.org/jira/browse/MGPG-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Hummel updated MGPG-75:
Summary: Creates a signature with the wrong name if a classifier is defined
(was: If I create a karaf feature
Mike Hummel created MGPG-75:
---
Summary: If I create a karaf feature project the plugin creates a
signature with the wrong name
Key: MGPG-75
URL: https://issues.apache.org/jira/browse/MGPG-75
Project: Maven G
Ben M. created MCHECKSTYLE-385:
--
Summary: Violation should be a value class
Key: MCHECKSTYLE-385
URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-385
Project: Maven Checkstyle Plugin
Issue
[
https://issues.apache.org/jira/browse/SUREFIRE-1732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16994422#comment-16994422
]
Dietrich Schulten commented on SUREFIRE-1732:
-
It turned out I had also th
[
https://issues.apache.org/jira/browse/SUREFIRE-1732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16994374#comment-16994374
]
Dietrich Schulten commented on SUREFIRE-1732:
-
The issue occured for me in
[
https://issues.apache.org/jira/browse/SUREFIRE-1732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16994374#comment-16994374
]
Dietrich Schulten edited comment on SUREFIRE-1732 at 12/12/19 8:28 AM:
-
67 matches
Mail list logo
