[jira] [Commented] (MRELEASE-1034) Remove SCM tag blocks rollback in some situations

2019-12-06 Thread Jira
[ https://issues.apache.org/jira/browse/MRELEASE-1034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16990149#comment-16990149 ] Clemens Quoß commented on MRELEASE-1034: PR: [https://github.com/apache/maven-

[GitHub] [maven-release] cquoss opened a new pull request #31: changed error to warn if tag is not present at rollback; fixed typos

2019-12-06 Thread GitBox
cquoss opened a new pull request #31: changed error to warn if tag is not present at rollback; fixed typos URL: https://github.com/apache/maven-release/pull/31 Hervé, hope this is useful and you pull it in before cutting the release.

[GitHub] [maven] rfscholte commented on a change in pull request #287: [MNG-6065] - Log fail-level option.

2019-12-06 Thread GitBox
rfscholte commented on a change in pull request #287: [MNG-6065] - Log fail-level option. URL: https://github.com/apache/maven/pull/287#discussion_r355007013 ## File path: maven-slf4j-provider/src/main/java/org/slf4j/impl/MavenLoggerFactory.java ## @@ -0,0 +1,82 @@ +packa

[GitHub] [maven] mthmulders commented on a change in pull request #287: [MNG-6065] - Log fail-level option.

2019-12-06 Thread GitBox
mthmulders commented on a change in pull request #287: [MNG-6065] - Log fail-level option. URL: https://github.com/apache/maven/pull/287#discussion_r354972700 ## File path: maven-slf4j-provider/src/main/java/org/slf4j/impl/MavenLoggerFactory.java ## @@ -0,0 +1,82 @@ +pack

[GitHub] [maven] rfscholte commented on issue #287: [MNG-6065] - Log fail-level option.

2019-12-06 Thread GitBox
rfscholte commented on issue #287: [MNG-6065] - Log fail-level option. URL: https://github.com/apache/maven/pull/287#issuecomment-562656230 -fae,--fail-at-end Only fail the build afterwards; allow all non-impacted builds to continue -ff,--fail-fast

[GitHub] [maven] rfscholte commented on a change in pull request #287: [MNG-6065] - Log fail-level option.

2019-12-06 Thread GitBox
rfscholte commented on a change in pull request #287: [MNG-6065] - Log fail-level option. URL: https://github.com/apache/maven/pull/287#discussion_r354934067 ## File path: maven-slf4j-wrapper/src/main/java/org/apache/maven/logwrapper/LogLevelRecorder.java ## @@ -0,0 +1,55

[GitHub] [maven] MartinKanters commented on a change in pull request #287: [MNG-6065] - Log fail-level option.

2019-12-06 Thread GitBox
MartinKanters commented on a change in pull request #287: [MNG-6065] - Log fail-level option. URL: https://github.com/apache/maven/pull/287#discussion_r354928439 ## File path: maven-slf4j-provider/src/main/java/org/slf4j/impl/MavenLoggerFactory.java ## @@ -0,0 +1,82 @@ +p

[GitHub] [maven] MartinKanters commented on a change in pull request #287: [MNG-6065] - Log fail-level option.

2019-12-06 Thread GitBox
MartinKanters commented on a change in pull request #287: [MNG-6065] - Log fail-level option. URL: https://github.com/apache/maven/pull/287#discussion_r354924333 ## File path: maven-slf4j-wrapper/src/main/java/org/apache/maven/logwrapper/LogLevelRecorder.java ## @@ -0,0 +

[GitHub] [maven] MartinKanters commented on issue #287: [MNG-6065] - Log fail-level option.

2019-12-06 Thread GitBox
MartinKanters commented on issue #287: [MNG-6065] - Log fail-level option. URL: https://github.com/apache/maven/pull/287#issuecomment-562645728 > > Talking about `Level` within the context of logging is clear, but we're talking about the context of Maven. > > Suppose we would talk about

[GitHub] [maven] rfscholte commented on a change in pull request #287: [MNG-6065] - Log fail-level option.

2019-12-06 Thread GitBox
rfscholte commented on a change in pull request #287: [MNG-6065] - Log fail-level option. URL: https://github.com/apache/maven/pull/287#discussion_r354913973 ## File path: maven-slf4j-wrapper/src/main/java/org/apache/maven/logwrapper/LogLevelRecorder.java ## @@ -0,0 +1,55

[GitHub] [maven] michael-o commented on a change in pull request #287: [MNG-6065] - Log fail-level option.

2019-12-06 Thread GitBox
michael-o commented on a change in pull request #287: [MNG-6065] - Log fail-level option. URL: https://github.com/apache/maven/pull/287#discussion_r354857868 ## File path: maven-slf4j-wrapper/src/main/java/org/apache/maven/logwrapper/LogLevelRecorder.java ## @@ -0,0 +1,55

[GitHub] [maven] rfscholte commented on a change in pull request #287: [MNG-6065] - Log fail-level option.

2019-12-06 Thread GitBox
rfscholte commented on a change in pull request #287: [MNG-6065] - Log fail-level option. URL: https://github.com/apache/maven/pull/287#discussion_r354852942 ## File path: maven-slf4j-provider/src/main/java/org/slf4j/impl/MavenLoggerFactory.java ## @@ -0,0 +1,82 @@ +packa

[GitHub] [maven] rfscholte commented on a change in pull request #287: [MNG-6065] - Log fail-level option.

2019-12-06 Thread GitBox
rfscholte commented on a change in pull request #287: [MNG-6065] - Log fail-level option. URL: https://github.com/apache/maven/pull/287#discussion_r354839488 ## File path: maven-slf4j-wrapper/src/main/java/org/apache/maven/logwrapper/LogLevelRecorder.java ## @@ -0,0 +1,55

[jira] [Commented] (MCOMPILER-372) Unable to compile modularized test code depending on test-jar

2019-12-06 Thread Jira
[ https://issues.apache.org/jira/browse/MCOMPILER-372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16989678#comment-16989678 ] François Loison commented on MCOMPILER-372: --- I wrote the src/it/MCOMPILER-37

[jira] [Comment Edited] (SUREFIRE-1733) Surefire and Failsafe JPMS additions for JUnit 5.x execution

2019-12-06 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16989624#comment-16989624 ] Tibor Digana edited comment on SUREFIRE-1733 at 12/6/19 10:43 AM: --

[jira] [Commented] (SUREFIRE-1733) Surefire and Failsafe JPMS additions for JUnit 5.x execution

2019-12-06 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16989624#comment-16989624 ] Tibor Digana commented on SUREFIRE-1733: [~rfscholte] Why to distinguish for s

[jira] [Commented] (SUREFIRE-1733) Surefire and Failsafe JPMS additions for JUnit 5.x execution

2019-12-06 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16989620#comment-16989620 ] Tibor Digana commented on SUREFIRE-1733: [~nhoj.patrick] Do not expect test-co

[jira] [Commented] (SUREFIRE-1731) Unable to test Multi Release Jar with surefire or failsafe

2019-12-06 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16989612#comment-16989612 ] Tibor Digana commented on SUREFIRE-1731: Here is the solution in Maven Compile

[jira] [Commented] (SUREFIRE-1733) Surefire and Failsafe JPMS additions for JUnit 5.x execution

2019-12-06 Thread Robert Scholte (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16989596#comment-16989596 ] Robert Scholte commented on SUREFIRE-1733: -- Quoting from https://www.oracle.

[jira] [Commented] (SUREFIRE-1731) Unable to test Multi Release Jar with surefire or failsafe

2019-12-06 Thread John Patrick (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16989595#comment-16989595 ] John Patrick commented on SUREFIRE-1731: [~tibordigana] happy to help, I thoug

[jira] [Commented] (SUREFIRE-1733) Surefire and Failsafe JPMS additions for JUnit 5.x execution

2019-12-06 Thread John Patrick (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16989593#comment-16989593 ] John Patrick commented on SUREFIRE-1733: What about I do a document change add

[jira] [Comment Edited] (SUREFIRE-1733) Surefire and Failsafe JPMS additions for JUnit 5.x execution

2019-12-06 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16989498#comment-16989498 ] Tibor Digana edited comment on SUREFIRE-1733 at 12/6/19 8:17 AM: ---

[jira] [Commented] (SUREFIRE-1733) Surefire and Failsafe JPMS additions for JUnit 5.x execution

2019-12-06 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16989498#comment-16989498 ] Tibor Digana commented on SUREFIRE-1733: [~rfscholte] Pls see my comment prope

[jira] [Comment Edited] (SUREFIRE-1733) Surefire and Failsafe JPMS additions for JUnit 5.x execution

2019-12-06 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16989277#comment-16989277 ] Tibor Digana edited comment on SUREFIRE-1733 at 12/6/19 8:02 AM: ---