[GitHub] [maven-archetype] tony-- commented on issue #28: ARCHETYPE-567: switch to dom4j 2.1.1 (and Java 8)

2019-05-31 Thread GitBox
tony-- commented on issue #28: ARCHETYPE-567: switch to dom4j 2.1.1 (and Java 8) URL: https://github.com/apache/maven-archetype/pull/28#issuecomment-497872171 @Tibor17 I did not mention it in description, but maven-archetype already depends on dom4j. The proposal is to switch the dependenc

[GitHub] [maven-archetype] tony-- commented on issue #28: ARCHETYPE-567: switch to dom4j 2.1.1 (and Java 8)

2019-05-31 Thread GitBox
tony-- commented on issue #28: ARCHETYPE-567: switch to dom4j 2.1.1 (and Java 8) URL: https://github.com/apache/maven-archetype/pull/28#issuecomment-497870211 Thanks @eolivelli. Looks like the non-jdk7 builds all passed (and the jdk7 builds are expected to fail because I bumped compatibili

[jira] [Updated] (MNG-6666) File download to 14KB is blocked

2019-05-31 Thread Michael Osipov (JIRA)
[ https://issues.apache.org/jira/browse/MNG-?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-: Fix Version/s: waiting-for-feedback > File download to 14KB is blocked >

[GitHub] [maven-compiler-plugin] rhowe commented on a change in pull request #21: Cleanup debug log handling

2019-05-31 Thread GitBox
rhowe commented on a change in pull request #21: Cleanup debug log handling URL: https://github.com/apache/maven-compiler-plugin/pull/21#discussion_r289551305 ## File path: src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java ## @@ -960,7 +963,7 @@ els

[GitHub] [maven-archetype] eolivelli commented on issue #28: ARCHETYPE-567: switch to dom4j 2.1.1 (and Java 8)

2019-05-31 Thread GitBox
eolivelli commented on issue #28: ARCHETYPE-567: switch to dom4j 2.1.1 (and Java 8) URL: https://github.com/apache/maven-archetype/pull/28#issuecomment-497855733 https://builds.apache.org/job/maven-box/job/maven-archetype/job/ARCHETYPE-567/

[GitHub] [maven-archetype] Tibor17 commented on issue #28: ARCHETYPE-567: switch to dom4j 2.1.1 (and Java 8)

2019-05-31 Thread GitBox
Tibor17 commented on issue #28: ARCHETYPE-567: switch to dom4j 2.1.1 (and Java 8) URL: https://github.com/apache/maven-archetype/pull/28#issuecomment-497841349 I have bad experiences with DOM library. It is due to the same library is used in JDK according to the JVM spec and it is legal an

[GitHub] [maven-archetype] tony-- opened a new pull request #28: ARCHETYPE-567: switch to dom4j 2.1.1 (and Java 8)

2019-05-31 Thread GitBox
tony-- opened a new pull request #28: ARCHETYPE-567: switch to dom4j 2.1.1 (and Java 8) URL: https://github.com/apache/maven-archetype/pull/28 dom4j 2.1.1 requires Java 8 dom4j 2.0.2 would retain Java 7 but is vulnerable to CVE-2018-1000632 dom4j 2.0.3 fixes CVE-2018-1000632 but has b

[GitHub] [maven-ear-plugin] legopiraat opened a new pull request #3: [MEAR-278] - Remove non included artifacts from working directory

2019-05-31 Thread GitBox
legopiraat opened a new pull request #3: [MEAR-278] - Remove non included artifacts from working directory URL: https://github.com/apache/maven-ear-plugin/pull/3 With this pull request only specified artifacts in the pom.xml will be added to the ear file that is being generated. Ho

[jira] [Created] (ARCHETYPE-567) Update to dom4j 2.1.1

2019-05-31 Thread Tony Homer (JIRA)
Tony Homer created ARCHETYPE-567: Summary: Update to dom4j 2.1.1 Key: ARCHETYPE-567 URL: https://issues.apache.org/jira/browse/ARCHETYPE-567 Project: Maven Archetype Issue Type: Bug Aff

[GitHub] [maven-fluido-skin] mikemol1991 opened a new pull request #8: [MSKINS-104] Remove obsolete meta tags

2019-05-31 Thread GitBox
mikemol1991 opened a new pull request #8: [MSKINS-104] Remove obsolete meta tags URL: https://github.com/apache/maven-fluido-skin/pull/8 Submitted by: Mike Mol **I removed the obsolete Meta tag for ```Content-Language```.** Following this checklist to help us incorporate your

[GitHub] [maven-shade-plugin] mkarg commented on issue #20: [MSHADE-318] - Include transitive dependencies

2019-05-31 Thread GitBox
mkarg commented on issue #20: [MSHADE-318] - Include transitive dependencies URL: https://github.com/apache/maven-shade-plugin/pull/20#issuecomment-497733154 @rfscholte @khmarbaise Ping ;-) This is an automated message from th

[GitHub] [maven] MartinKanters opened a new pull request #251: [MNG-6665] toolchain.xml file should support environment variables

2019-05-31 Thread GitBox
MartinKanters opened a new pull request #251: [MNG-6665] toolchain.xml file should support environment variables URL: https://github.com/apache/maven/pull/251 Submitted by: Mike Mol and Martin Kanters Following this checklist to help us incorporate your contribution quickly and e

[GitHub] [maven-surefire] Tibor17 commented on issue #236: MasterProcessChannelDecoder

2019-05-31 Thread GitBox
Tibor17 commented on issue #236: MasterProcessChannelDecoder URL: https://github.com/apache/maven-surefire/pull/236#issuecomment-497683301 @eolivelli yes, this i am aiming for. The preamble was changed (`-` replaced `:`), so the changes in both directions should be the same and therefor

[GitHub] [maven-surefire] eolivelli commented on issue #236: MasterProcessChannelDecoder

2019-05-31 Thread GitBox
eolivelli commented on issue #236: MasterProcessChannelDecoder URL: https://github.com/apache/maven-surefire/pull/236#issuecomment-497680147 Ok, this is a good way. We have to move away from a raw stream of charactes separated bty newline to a sequence of commands. The stdin/out imple

[jira] [Commented] (MNG-6666) File download to 14KB is blocked

2019-05-31 Thread Michael Osipov (JIRA)
[ https://issues.apache.org/jira/browse/MNG-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16852931#comment-16852931 ] Michael Osipov commented on MNG-: - Provide a full debug log for the http client. >

[GitHub] [maven-surefire] Tibor17 commented on issue #112: Adding support for externally passed random seed and printing used seed on console

2019-05-31 Thread GitBox
Tibor17 commented on issue #112: Adding support for externally passed random seed and printing used seed on console URL: https://github.com/apache/maven-surefire/pull/112#issuecomment-497667464 Try to cover also tests for `AbstractSurefireMojo` and other modified classes. I know it's not e

[GitHub] [maven-surefire] Tibor17 commented on issue #112: Adding support for externally passed random seed and printing used seed on console

2019-05-31 Thread GitBox
Tibor17 commented on issue #112: Adding support for externally passed random seed and printing used seed on console URL: https://github.com/apache/maven-surefire/pull/112#issuecomment-497665525 Is there related issue in ASF Jira for this PR?

[GitHub] [maven-surefire] Tibor17 commented on issue #112: Adding support for externally passed random seed and printing used seed on console

2019-05-31 Thread GitBox
Tibor17 commented on issue #112: Adding support for externally passed random seed and printing used seed on console URL: https://github.com/apache/maven-surefire/pull/112#issuecomment-497665055 Can you create a documentation for your feature? Hint, see `maven-surefire-plugin/src/site`.

[GitHub] [maven-surefire] cardil edited a comment on issue #112: Adding support for externally passed random seed and printing used seed on console

2019-05-31 Thread GitBox
cardil edited a comment on issue #112: Adding support for externally passed random seed and printing used seed on console URL: https://github.com/apache/maven-surefire/pull/112#issuecomment-497644398 > The confusing thing is that if I pass `random:1` it becomes `random:11` > Using va

[GitHub] [maven-surefire] cardil commented on issue #112: Adding support for externally passed random seed and printing used seed on console

2019-05-31 Thread GitBox
cardil commented on issue #112: Adding support for externally passed random seed and printing used seed on console URL: https://github.com/apache/maven-surefire/pull/112#issuecomment-497644398 > The confusing thing is that if I pass `random:1` it becomes `random:11` > Using value `ra

[GitHub] [maven-surefire] seregamorph commented on issue #112: Adding support for externally passed random seed and printing used seed on console

2019-05-31 Thread GitBox
seregamorph commented on issue #112: Adding support for externally passed random seed and printing used seed on console URL: https://github.com/apache/maven-surefire/pull/112#issuecomment-497610117 The confusing thing is that if I pass `random:1` it becomes `random:11` Using value `r