[GitHub] [maven-indexer] carlspring commented on issue #25: [MINDEXER-114] Extend JarFileContentsIndexCreator to support zip files

carlspring commented on issue #25: [MINDEXER-114] Extend JarFileContentsIndexCreator to support zip files URL: https://github.com/apache/maven-indexer/pull/25#issuecomment-482897820 @slachiewicz : It looks like this PR was closed without merging. Was this by accident, or am I missing s

[jira] [Updated] (MPH-160) help:effective-pom -Dverbose: add source location as comments in effective pom.xml

[ https://issues.apache.org/jira/browse/MPH-160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hervé Boutemy updated MPH-160: -- Description: during in-memory effective pom building (by maven-model-builder), the source location of con

[jira] [Updated] (MPH-160) help:effective-pom -Dverbose: add source location as comments in effective pom.xml

[ https://issues.apache.org/jira/browse/MPH-160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hervé Boutemy updated MPH-160: -- Summary: help:effective-pom -Dverbose: add source location as comments in effective pom.xml (was: help:ef

[jira] [Commented] (SUREFIRE-1546) JUnit 5 runner does not honor JUnit 5 display names

[ https://issues.apache.org/jira/browse/SUREFIRE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817083#comment-16817083 ] Tibor Digana commented on SUREFIRE-1546: [~Srdo] [~marcphilipp] I would unders

[jira] [Comment Edited] (MCHECKSTYLE-366) Upgrade checkstyle to a more recent version

[ https://issues.apache.org/jira/browse/MCHECKSTYLE-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817077#comment-16817077 ] Enrico Olivelli edited comment on MCHECKSTYLE-366 at 4/13/19 8:22 PM:

[jira] [Commented] (MCHECKSTYLE-366) Upgrade checkstyle to a more recent version

[ https://issues.apache.org/jira/browse/MCHECKSTYLE-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817077#comment-16817077 ] Enrico Olivelli commented on MCHECKSTYLE-366: - 137 and 193 were subject

[jira] [Commented] (MCHECKSTYLE-366) Upgrade checkstyle to a more recent version

[ https://issues.apache.org/jira/browse/MCHECKSTYLE-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817076#comment-16817076 ] Enrico Olivelli commented on MCHECKSTYLE-366: - I am working on this, I w

[jira] [Closed] (MNGSITE-355) super pom for Maven 3

[ https://issues.apache.org/jira/browse/MNGSITE-355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MNGSITE-355. Resolution: Fixed > super pom for Maven 3 > - > >

[jira] [Commented] (MNGSITE-355) super pom for Maven 3

[ https://issues.apache.org/jira/browse/MNGSITE-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817055#comment-16817055 ] Sylwester Lachiewicz commented on MNGSITE-355: -- Updated to Maven 3.5.4 in

[jira] [Assigned] (MNGSITE-355) super pom for Maven 3

[ https://issues.apache.org/jira/browse/MNGSITE-355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned MNGSITE-355: Assignee: Sylwester Lachiewicz > super pom for Maven 3 >

[GitHub] [maven-javadoc-plugin] rovarga commented on a change in pull request #25: [MJAVADOC-591] consider release for supportModulePath

rovarga commented on a change in pull request #25: [MJAVADOC-591] consider release for supportModulePath URL: https://github.com/apache/maven-javadoc-plugin/pull/25#discussion_r275129185 ## File path: src/it/projects/MJAVADOC-591/pom.xml ## @@ -0,0 +1,67 @@ + + + + +http

[GitHub] [maven-javadoc-plugin] eolivelli commented on a change in pull request #25: [MJAVADOC-591] consider release for supportModulePath

eolivelli commented on a change in pull request #25: [MJAVADOC-591] consider release for supportModulePath URL: https://github.com/apache/maven-javadoc-plugin/pull/25#discussion_r275129162 ## File path: src/it/projects/MJAVADOC-591/pom.xml ## @@ -0,0 +1,67 @@ + + + + +ht

[GitHub] [maven-javadoc-plugin] rfscholte commented on a change in pull request #25: [MJAVADOC-591] consider release for supportModulePath

rfscholte commented on a change in pull request #25: [MJAVADOC-591] consider release for supportModulePath URL: https://github.com/apache/maven-javadoc-plugin/pull/25#discussion_r275128528 ## File path: src/it/projects/MJAVADOC-591/pom.xml ## @@ -0,0 +1,67 @@ + + + + +ht

[GitHub] [maven-javadoc-plugin] rovarga commented on a change in pull request #25: [MJAVADOC-591] source should default to ${maven.compiler.release}

rovarga commented on a change in pull request #25: [MJAVADOC-591] source should default to ${maven.compiler.release} URL: https://github.com/apache/maven-javadoc-plugin/pull/25#discussion_r275126844 ## File path: src/it/projects/MJAVADOC-591/src/main/java/com/example/Foo.java

[GitHub] [maven-javadoc-plugin] rovarga commented on a change in pull request #25: [MJAVADOC-591] source should default to ${maven.compiler.release}

rovarga commented on a change in pull request #25: [MJAVADOC-591] source should default to ${maven.compiler.release} URL: https://github.com/apache/maven-javadoc-plugin/pull/25#discussion_r275126814 ## File path: src/it/projects/MJAVADOC-591/pom.xml ## @@ -0,0 +1,67 @@ +

[GitHub] [maven-javadoc-plugin] rfscholte commented on a change in pull request #25: [MJAVADOC-591] source should default to ${maven.compiler.release}

rfscholte commented on a change in pull request #25: [MJAVADOC-591] source should default to ${maven.compiler.release} URL: https://github.com/apache/maven-javadoc-plugin/pull/25#discussion_r275126729 ## File path: src/it/projects/MJAVADOC-591/src/main/java/com/example/Foo.java ##

[GitHub] [maven-javadoc-plugin] eolivelli commented on a change in pull request #25: [MJAVADOC-591] source should default to ${maven.compiler.release}

eolivelli commented on a change in pull request #25: [MJAVADOC-591] source should default to ${maven.compiler.release} URL: https://github.com/apache/maven-javadoc-plugin/pull/25#discussion_r275126482 ## File path: src/it/projects/MJAVADOC-591/pom.xml ## @@ -0,0 +1,67 @@

[jira] [Commented] (MSHADE-316) Explicit minijar includes

[ https://issues.apache.org/jira/browse/MSHADE-316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816997#comment-16816997 ] Markus Karg commented on MSHADE-316: [~rfscholte] Provided PR that implements exclude

[GitHub] [maven-shade-plugin] mkarg commented on issue #19: [MSHADE-316] - Configuration option

mkarg commented on issue #19: [MSHADE-316] - Configuration option URL: https://github.com/apache/maven-shade-plugin/pull/19#issuecomment-482829387 @rfscholte Review please. :-) This is an automated message from the Apache Gi

[GitHub] [maven-shade-plugin] mkarg opened a new pull request #19: [MSHADE-316] - Configuration option

mkarg opened a new pull request #19: [MSHADE-316] - Configuration option URL: https://github.com/apache/maven-shade-plugin/pull/19 This PR adds a new configuration option `` (default: `true` for backwards compatibility). When set to `false`, providing an `` will *not* automatically

[jira] [Commented] (SUREFIRE-1546) JUnit 5 runner does not honor JUnit 5 display names

[ https://issues.apache.org/jira/browse/SUREFIRE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816969#comment-16816969 ] Stig Rohde Døssing commented on SUREFIRE-1546: -- [~marcphilipp] The examp

[jira] [Commented] (MJAVADOC-591) javadoc fails with maven.compiler.release=8 and Automatic-Module-Name

[ https://issues.apache.org/jira/browse/MJAVADOC-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816965#comment-16816965 ] Robert Scholte commented on MJAVADOC-591: - Yes, that change makes sense. > jav

[jira] [Commented] (MJAVADOC-591) javadoc fails with maven.compiler.release=8 and Automatic-Module-Name

[ https://issues.apache.org/jira/browse/MJAVADOC-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816961#comment-16816961 ] Robert Varga commented on MJAVADOC-591: --- Yes, I noticed that property. I agree, t

[jira] [Commented] (MJAVADOC-591) javadoc fails with maven.compiler.release=8 and Automatic-Module-Name

[ https://issues.apache.org/jira/browse/MJAVADOC-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816948#comment-16816948 ] Robert Scholte commented on MJAVADOC-591: - This shouldn't be required. There's

[jira] [Commented] (MJAVADOC-591) javadoc fails with maven.compiler.release=8 and Automatic-Module-Name

[ https://issues.apache.org/jira/browse/MJAVADOC-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816940#comment-16816940 ] Robert Varga commented on MJAVADOC-591: --- Ah, right, it was just my local repo tha

[GitHub] [maven-javadoc-plugin] rovarga opened a new pull request #25: [MJAVADOC-591] source should default to ${maven.compiler.release}

rovarga opened a new pull request #25: [MJAVADOC-591] source should default to ${maven.compiler.release} URL: https://github.com/apache/maven-javadoc-plugin/pull/25 Since we are setting javadoc -release to whatever is set in maven.compiler.release, we should also propagate the same to our

[jira] [Comment Edited] (SUREFIRE-1546) JUnit 5 runner does not honor JUnit 5 display names

[ https://issues.apache.org/jira/browse/SUREFIRE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816931#comment-16816931 ] Tibor Digana edited comment on SUREFIRE-1546 at 4/13/19 12:46 PM: --

[jira] [Comment Edited] (SUREFIRE-1546) JUnit 5 runner does not honor JUnit 5 display names

[ https://issues.apache.org/jira/browse/SUREFIRE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816931#comment-16816931 ] Tibor Digana edited comment on SUREFIRE-1546 at 4/13/19 12:43 PM: --

[jira] [Commented] (SUREFIRE-1546) JUnit 5 runner does not honor JUnit 5 display names

[ https://issues.apache.org/jira/browse/SUREFIRE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816931#comment-16816931 ] Tibor Digana commented on SUREFIRE-1546: [~marcphilipp] We still do not know w

[jira] [Commented] (MJAVADOC-591) javadoc fails with maven.compiler.release=8 and Automatic-Module-Name

[ https://issues.apache.org/jira/browse/MJAVADOC-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816930#comment-16816930 ] Robert Scholte commented on MJAVADOC-591: - I don't recognize any commits since

[jira] [Updated] (MNG-6598) Maven 3.6.0 and Surefire problem

[ https://issues.apache.org/jira/browse/MNG-6598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MNG-6598: -- Fix Version/s: 3.x / Backlog > Maven 3.6.0 and Surefire problem > ---

[jira] [Commented] (MCOMPILER-360) NPE when calculating modulepath with invalid entries

[ https://issues.apache.org/jira/browse/MCOMPILER-360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816927#comment-16816927 ] Hendrik Schreiber commented on MCOMPILER-360: - I'd like to add: This is a

[jira] [Commented] (MJAVADOC-591) javadoc fails with maven.compiler.release=8 and Automatic-Module-Name

[ https://issues.apache.org/jira/browse/MJAVADOC-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816925#comment-16816925 ] Robert Varga commented on MJAVADOC-591: --- It seems to work with 3.1.1-SNAPSHOT. >

[jira] [Commented] (MSHADE-316) Explicit minijar includes

[ https://issues.apache.org/jira/browse/MSHADE-316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816917#comment-16816917 ] Markus Karg commented on MSHADE-316: [~rfscholte] Fully agree with all you say. But s

[jira] [Commented] (MPH-160) help:effective-pom -Dverbose: add source location in comments to effective pom.xml

[ https://issues.apache.org/jira/browse/MPH-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816901#comment-16816901 ] Hudson commented on MPH-160: Build succeeded in Jenkins: Maven TLP » maven-help-plugin » master

[jira] [Commented] (MPH-160) help:effective-pom -Dverbose: add source location in comments to effective pom.xml

[ https://issues.apache.org/jira/browse/MPH-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816897#comment-16816897 ] Hudson commented on MPH-160: Build succeeded in Jenkins: Maven TLP » maven-help-plugin » master

[GitHub] [maven] olamy commented on issue #225: [MNG-6405] Fix basedir in MavenProject.deepCopy

olamy commented on issue #225: [MNG-6405] Fix basedir in MavenProject.deepCopy URL: https://github.com/apache/maven/pull/225#issuecomment-482798510 IMHO it's a bit nitpicking to require test for such change... This is an autom

[jira] [Commented] (MSHADE-316) Explicit minijar includes

[ https://issues.apache.org/jira/browse/MSHADE-316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816896#comment-16816896 ] Robert Scholte commented on MSHADE-316: --- Well, the more people that ask for my opin

[jira] [Commented] (MPH-161) add color to goal or plugin description

[ https://issues.apache.org/jira/browse/MPH-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816895#comment-16816895 ] Hudson commented on MPH-161: Build succeeded in Jenkins: Maven TLP » maven-help-plugin » master

[jira] [Closed] (MPH-161) add color to goal or plugin description

[ https://issues.apache.org/jira/browse/MPH-161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hervé Boutemy closed MPH-161. - Resolution: Fixed Assignee: Hervé Boutemy Fix Version/s: 3.2.0 merged and reworked in https

[GitHub] [maven-help-plugin] hboutemy edited a comment on issue #3: [MPH-161] - add color to goal or plugin description

hboutemy edited a comment on issue #3: [MPH-161] - add color to goal or plugin description URL: https://github.com/apache/maven-help-plugin/pull/3#issuecomment-482797003 merged and reworked in https://github.com/apache/maven-help-plugin/commit/66ff8957e4650bc99d79fa55bba2aa13ca8d9723

[GitHub] [maven-help-plugin] hboutemy commented on issue #3: [MPH-161] - add color to goal or plugin description

hboutemy commented on issue #3: [MPH-161] - add color to goal or plugin description URL: https://github.com/apache/maven-help-plugin/pull/3#issuecomment-482797003 merged and reworked in e4650bc99d79fa55bba2aa13ca8d9723 thank you --

[GitHub] [maven-help-plugin] hboutemy closed pull request #3: [MPH-161] - add color to goal or plugin description

hboutemy closed pull request #3: [MPH-161] - add color to goal or plugin description URL: https://github.com/apache/maven-help-plugin/pull/3 This is an automated message from the Apache Git Service. To respond to the message

[jira] [Commented] (MSHADE-316) Explicit minijar includes

[ https://issues.apache.org/jira/browse/MSHADE-316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816890#comment-16816890 ] Markus Karg commented on MSHADE-316: [~rfscholte] Ok I will create another PR impleme

[jira] [Created] (MSHADE-317) Source package name parse error

xuzhiyi created MSHADE-317: -- Summary: Source package name parse error Key: MSHADE-317 URL: https://issues.apache.org/jira/browse/MSHADE-317 Project: Maven Shade Plugin Issue Type: Bug Affects Ve

[jira] [Updated] (MPH-152) Enhance console output of "evaluate" goal to indicate result

[ https://issues.apache.org/jira/browse/MPH-152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hervé Boutemy updated MPH-152: -- Fix Version/s: waiting-for-feedback > Enhance console output of "evaluate" goal to indicate result > -

[jira] [Commented] (MPH-152) Enhance console output of "evaluate" goal to indicate result

[ https://issues.apache.org/jira/browse/MPH-152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816889#comment-16816889 ] Hervé Boutemy commented on MPH-152: --- I like MPH-144 approach: {noformat}$ mvn help:evaluat

[jira] [Updated] (MPH-160) help:effective-pom -Dverbose: add source location in comments to effective pom.xml

[ https://issues.apache.org/jira/browse/MPH-160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hervé Boutemy updated MPH-160: -- Summary: help:effective-pom -Dverbose: add source location in comments to effective pom.xml (was: add sou

[jira] [Commented] (MSHADE-316) Explicit minijar includes

[ https://issues.apache.org/jira/browse/MSHADE-316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816885#comment-16816885 ] Robert Scholte commented on MSHADE-316: --- bq. As of version 1.6, minimizeJar will re

[jira] [Commented] (SUREFIRE-1546) JUnit 5 runner does not honor JUnit 5 display names

[ https://issues.apache.org/jira/browse/SUREFIRE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816884#comment-16816884 ] Marc Philipp commented on SUREFIRE-1546: {code:java} @DisplayName("Some tests"

[jira] [Comment Edited] (MNG-6636) NPE on reporting convertion when inheritance of with no reports

[ https://issues.apache.org/jira/browse/MNG-6636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816496#comment-16816496 ] Hervé Boutemy edited comment on MNG-6636 at 4/13/19 7:05 AM: - s

[jira] [Closed] (MPH-160) add source location in comments to effective pom.xml

[ https://issues.apache.org/jira/browse/MPH-160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hervé Boutemy closed MPH-160. - Resolution: Fixed Assignee: Hervé Boutemy Fix Version/s: 3.2.0 > add source location in comm