[GitHub] [maven-shade-plugin] mkarg commented on issue #17: [MSHADE-313] - Keep Services

2019-04-01 Thread GitBox
mkarg commented on issue #17: [MSHADE-313] - Keep Services URL: https://github.com/apache/maven-shade-plugin/pull/17#issuecomment-478856304 @rfscholte Removed extra parameter as you proposed, also fixed several bugs. LGTY? Th

[GitHub] [maven-compiler-plugin] yeroc commented on issue #3: [MCOMPILER-205] fixes incremental compilation

2019-04-01 Thread GitBox
yeroc commented on issue #3: [MCOMPILER-205] fixes incremental compilation URL: https://github.com/apache/maven-compiler-plugin/pull/3#issuecomment-478848699 @rfscholte Thanks for the update. There's quite a bit of conflicting information on the ticket so for an outsider it's difficult to

[jira] [Updated] (MSHARED-810) Support Java 12

2019-04-01 Thread Rune Flobakk (JIRA)
[ https://issues.apache.org/jira/browse/MSHARED-810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rune Flobakk updated MSHARED-810: - Issue Type: Dependency upgrade (was: Bug) > Support Java 12 > --- > >

[GitHub] [maven-resolver] tawek commented on a change in pull request #22: Introduce caching for tracking files.

2019-04-01 Thread GitBox
tawek commented on a change in pull request #22: Introduce caching for tracking files. URL: https://github.com/apache/maven-resolver/pull/22#discussion_r271065809 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java ##

[GitHub] [maven-resolver] tawek commented on a change in pull request #22: Introduce caching for tracking files.

2019-04-01 Thread GitBox
tawek commented on a change in pull request #22: Introduce caching for tracking files. URL: https://github.com/apache/maven-resolver/pull/22#discussion_r271065809 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java ##

[jira] [Commented] (MJAVADOC-594) aggregate-jar fails on attached artifacts created by projects in the reactor build

2019-04-01 Thread Steinar Bang (JIRA)
[ https://issues.apache.org/jira/browse/MJAVADOC-594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16807215#comment-16807215 ] Steinar Bang commented on MJAVADOC-594: --- I've tried changing phases for the featu

[jira] [Commented] (MJAVADOC-594) aggregate-jar fails on attached artifacts created by projects in the reactor build

2019-04-01 Thread Steinar Bang (JIRA)
[ https://issues.apache.org/jira/browse/MJAVADOC-594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16807210#comment-16807210 ] Steinar Bang commented on MJAVADOC-594: --- I've created a branch in a project in a

[jira] [Created] (MJAVADOC-594) aggregate-jar fails on attached artifacts created by projects in the reactor build

2019-04-01 Thread Steinar Bang (JIRA)
Steinar Bang created MJAVADOC-594: - Summary: aggregate-jar fails on attached artifacts created by projects in the reactor build Key: MJAVADOC-594 URL: https://issues.apache.org/jira/browse/MJAVADOC-594

[jira] [Commented] (MRELEASE-1021) release:prepare and release:update-version sets line endings to crlf for all lines except the first and last lines of the pom.xml files

2019-04-01 Thread Michael Osipov (JIRA)
[ https://issues.apache.org/jira/browse/MRELEASE-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16807206#comment-16807206 ] Michael Osipov commented on MRELEASE-1021: -- Can we close this one then? > re

[jira] [Commented] (MSHARED-811) Improve handling of Metadata

2019-04-01 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/MSHARED-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16807198#comment-16807198 ] Hudson commented on MSHARED-811: Build succeeded in Jenkins: Maven TLP » maven-artifact-

[jira] [Commented] (MRELEASE-1021) release:prepare and release:update-version sets line endings to crlf for all lines except the first and last lines of the pom.xml files

2019-04-01 Thread Steinar Bang (JIRA)
[ https://issues.apache.org/jira/browse/MRELEASE-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16807177#comment-16807177 ] Steinar Bang commented on MRELEASE-1021: I have now tried with maven 3.6.0 and

[jira] [Closed] (MSHARED-811) Improve handling of Metadata

2019-04-01 Thread Robert Scholte (JIRA)
[ https://issues.apache.org/jira/browse/MSHARED-811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MSHARED-811. -- Resolution: Fixed Fixed in [46660e4b972066d25d0e1009a6b2b5ada7d55694|https://gitbox.apache.or

[jira] [Commented] (MPMD-280) maven-pmd-plugin does not support targetJdk 12

2019-04-01 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/MPMD-280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16807133#comment-16807133 ] Hudson commented on MPMD-280: - Build succeeded in Jenkins: Maven TLP » maven-pmd-plugin » maste

[jira] [Closed] (MNG-6589) Document property maven.multiModuleProjectDirectory

2019-04-01 Thread Karl Heinz Marbaise (JIRA)
[ https://issues.apache.org/jira/browse/MNG-6589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise closed MNG-6589. Resolution: Won't Fix > Document property maven.multiModuleProjectDirectory > ---

[jira] [Commented] (MPMD-275) Upgrade to PMD 6.13.0

2019-04-01 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/MPMD-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16807132#comment-16807132 ] Hudson commented on MPMD-275: - Build succeeded in Jenkins: Maven TLP » maven-pmd-plugin » maste

[GitHub] [maven-pmd-plugin] adangel commented on a change in pull request #6: [MPMD-275] update to PMD 6.13.0

2019-04-01 Thread GitBox
adangel commented on a change in pull request #6: [MPMD-275] update to PMD 6.13.0 URL: https://github.com/apache/maven-pmd-plugin/pull/6#discussion_r271019278 ## File path: src/it/MPMD-268-deprecated-rules/verify.groovy ## @@ -19,4 +19,6 @@ File buildLog = new File( bas

[jira] [Resolved] (MPMD-280) maven-pmd-plugin does not support targetJdk 12

2019-04-01 Thread Andreas Dangel (JIRA)
[ https://issues.apache.org/jira/browse/MPMD-280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Dangel resolved MPMD-280. - Resolution: Fixed > maven-pmd-plugin does not support targetJdk 12 > --

[GitHub] [maven-pmd-plugin] oss92 commented on a change in pull request #6: [MPMD-275] update to PMD 6.13.0

2019-04-01 Thread GitBox
oss92 commented on a change in pull request #6: [MPMD-275] update to PMD 6.13.0 URL: https://github.com/apache/maven-pmd-plugin/pull/6#discussion_r271018165 ## File path: src/it/MPMD-268-deprecated-rules/verify.groovy ## @@ -19,4 +19,6 @@ File buildLog = new File( basedi

[GitHub] [maven-pmd-plugin] adangel commented on a change in pull request #6: [MPMD-275] update to PMD 6.13.0

2019-04-01 Thread GitBox
adangel commented on a change in pull request #6: [MPMD-275] update to PMD 6.13.0 URL: https://github.com/apache/maven-pmd-plugin/pull/6#discussion_r271016731 ## File path: src/it/MPMD-268-deprecated-rules/verify.groovy ## @@ -19,4 +19,6 @@ File buildLog = new File( bas

[jira] [Commented] (MPMD-275) Upgrade to PMD 6.13.0

2019-04-01 Thread Mohamed Osama (JIRA)
[ https://issues.apache.org/jira/browse/MPMD-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16807060#comment-16807060 ] Mohamed Osama commented on MPMD-275: [https://github.com/apache/maven-pmd-plugin/pull/6

[GitHub] [maven-pmd-plugin] oss92 opened a new pull request #6: update to PMD 6.13.0

2019-04-01 Thread GitBox
oss92 opened a new pull request #6: update to PMD 6.13.0 URL: https://github.com/apache/maven-pmd-plugin/pull/6 - Update to PMD 6.13.0 - Adapt integration-tests as such This is an automated message from the Apache Git Servi

[jira] [Updated] (MPMD-277) plugin tries to download local submodules from repo

2019-04-01 Thread Andreas Dangel (JIRA)
[ https://issues.apache.org/jira/browse/MPMD-277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Dangel updated MPMD-277: Summary: plugin tries to download local submodules from repo (was: plugin tries to download local su

[jira] [Updated] (MPMD-275) Upgrade to PMD 6.13.0

2019-04-01 Thread Andreas Dangel (JIRA)
[ https://issues.apache.org/jira/browse/MPMD-275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Dangel updated MPMD-275: Summary: Upgrade to PMD 6.13.0 (was: Upgrade to PMD 6.9.0) > Upgrade to PMD 6.13.0 > ---

[jira] [Reopened] (MPMD-275) Upgrade to PMD 6.9.0

2019-04-01 Thread Andreas Dangel (JIRA)
[ https://issues.apache.org/jira/browse/MPMD-275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Dangel reopened MPMD-275: - Changing this to upgrade to PMD 6.13.0 This is necessary for MPMD-280 > Upgrade to PMD 6.9.0 > --

[jira] [Updated] (MPMD-280) maven-pmd-plugin does not support targetJdk 12

2019-04-01 Thread Andreas Dangel (JIRA)
[ https://issues.apache.org/jira/browse/MPMD-280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Dangel updated MPMD-280: Fix Version/s: 3.12.0 > maven-pmd-plugin does not support targetJdk 12 >

[GitHub] [maven-shade-plugin] mkarg commented on issue #17: [MSHADE-313] - Keep Services

2019-04-01 Thread GitBox
mkarg commented on issue #17: [MSHADE-313] - Keep Services URL: https://github.com/apache/maven-shade-plugin/pull/17#issuecomment-478675008 @rfscholte Okay so I will remove the extra parameter. This is an automated message fro

[GitHub] [maven-shade-plugin] rfscholte commented on issue #17: [MSHADE-313] - Keep Services

2019-04-01 Thread GitBox
rfscholte commented on issue #17: [MSHADE-313] - Keep Services URL: https://github.com/apache/maven-shade-plugin/pull/17#issuecomment-478672785 I see no reason for an extra parameter. If an implementation of a service is provided, all its depending classes should be added, always. So I'd su

[GitHub] [maven-compiler-plugin] rfscholte commented on issue #3: [MCOMPILER-205] fixes incremental compilation

2019-04-01 Thread GitBox
rfscholte commented on issue #3: [MCOMPILER-205] fixes incremental compilation URL: https://github.com/apache/maven-compiler-plugin/pull/3#issuecomment-478671975 > What needs to be done to move this forward? Did you read the comments of https://issues.apache.org/jira/browse/MCOMPILE

[GitHub] [maven-resolver] rfscholte commented on a change in pull request #22: Introduce caching for tracking files.

2019-04-01 Thread GitBox
rfscholte commented on a change in pull request #22: Introduce caching for tracking files. URL: https://github.com/apache/maven-resolver/pull/22#discussion_r270969267 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java

[GitHub] [maven-javadoc-plugin] rfscholte merged pull request #24: Add missing `@since` tags to sourceFile[Includes|Excludes]

2019-04-01 Thread GitBox
rfscholte merged pull request #24: Add missing `@since` tags to sourceFile[Includes|Excludes] URL: https://github.com/apache/maven-javadoc-plugin/pull/24 This is an automated message from the Apache Git Service. To respond t

[GitHub] [maven-javadoc-plugin] britter opened a new pull request #24: Add missing `@since` tags to sourceFile[Includes|Excludes]

2019-04-01 Thread GitBox
britter opened a new pull request #24: Add missing `@since` tags to sourceFile[Includes|Excludes] URL: https://github.com/apache/maven-javadoc-plugin/pull/24 Simple doc fix. This is an automated message from the Apache Git Se

[jira] [Commented] (SUREFIRE-1427) Surefire-plugin throws NoClassDefFoundError with static initialiser

2019-04-01 Thread Tibor Digana (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16806780#comment-16806780 ] Tibor Digana commented on SUREFIRE-1427: [~mgai...@hotmail.com] This stil does

[jira] [Commented] (SUREFIRE-1570) Maven-fail-safe doesn't put testing JPMS module on module path

2019-04-01 Thread JIRA
[ https://issues.apache.org/jira/browse/SUREFIRE-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16806761#comment-16806761 ] Yoann Rodière commented on SUREFIRE-1570: - I just experienced this bug, and in

[jira] [Commented] (MNG-6618) Maven doesn't export org.slf4j.event.Level

2019-04-01 Thread Viacheslav Yakunin (JIRA)
[ https://issues.apache.org/jira/browse/MNG-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16806741#comment-16806741 ] Viacheslav Yakunin commented on MNG-6618: - [~michael-o], [~slachiewicz], I checked

[jira] [Created] (MNGSITE-369) Improve docs about dependency resolution within Multi module build

2019-04-01 Thread Karl Heinz Marbaise (JIRA)
Karl Heinz Marbaise created MNGSITE-369: --- Summary: Improve docs about dependency resolution within Multi module build Key: MNGSITE-369 URL: https://issues.apache.org/jira/browse/MNGSITE-369 Proj

[jira] [Updated] (MRELEASE-1021) release:prepare and release:update-version sets line endings to crlf for all lines except the first and last lines of the pom.xml files

2019-04-01 Thread Michael Osipov (JIRA)
[ https://issues.apache.org/jira/browse/MRELEASE-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRELEASE-1021: - Fix Version/s: waiting-for-feedback > release:prepare and release:update-version sets

[jira] [Commented] (MRELEASE-1021) release:prepare and release:update-version sets line endings to crlf for all lines except the first and last lines of the pom.xml files

2019-04-01 Thread Michael Osipov (JIRA)
[ https://issues.apache.org/jira/browse/MRELEASE-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16806662#comment-16806662 ] Michael Osipov commented on MRELEASE-1021: -- Did you try with Maven 3.6.0? >

[jira] [Commented] (MNG-6618) Maven doesn't export org.slf4j.event.Level

2019-04-01 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/MNG-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16806640#comment-16806640 ] Hudson commented on MNG-6618: - Build succeeded in Jenkins: Maven TLP » maven » master #189 See

[jira] [Closed] (MNG-6618) Maven doesn't export org.slf4j.event.Level

2019-04-01 Thread Sylwester Lachiewicz (JIRA)
[ https://issues.apache.org/jira/browse/MNG-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MNG-6618. - Resolution: Fixed > Maven doesn't export org.slf4j.event.Level > --

[jira] [Commented] (MNG-6618) Maven doesn't export org.slf4j.event.Level

2019-04-01 Thread Sylwester Lachiewicz (JIRA)
[ https://issues.apache.org/jira/browse/MNG-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16806594#comment-16806594 ] Sylwester Lachiewicz commented on MNG-6618: --- Fixed with  [0ba5753c17a37b96a42df39

[jira] [Updated] (MNG-6618) Maven doesn't export org.slf4j.event.Level

2019-04-01 Thread Sylwester Lachiewicz (JIRA)
[ https://issues.apache.org/jira/browse/MNG-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MNG-6618: -- Priority: Major (was: Blocker) > Maven doesn't export org.slf4j.event.Level > --

[jira] [Updated] (MNG-6618) Maven doesn't export org.slf4j.event.Level

2019-04-01 Thread Sylwester Lachiewicz (JIRA)
[ https://issues.apache.org/jira/browse/MNG-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MNG-6618: -- Fix Version/s: (was: 3.6.x-candidate) (was: waiting-for-feedbac

[jira] [Commented] (MNG-6618) Maven doesn't export org.slf4j.event.Level

2019-04-01 Thread Michael Osipov (JIRA)
[ https://issues.apache.org/jira/browse/MNG-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16806533#comment-16806533 ] Michael Osipov commented on MNG-6618: - [~slachiewicz], let's merge it and see what happ

[jira] [Comment Edited] (MNG-6618) Maven doesn't export org.slf4j.event.Level

2019-04-01 Thread Michael Osipov (JIRA)
[ https://issues.apache.org/jira/browse/MNG-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16805227#comment-16805227 ] Michael Osipov edited comment on MNG-6618 at 4/1/19 8:54 AM: - A

[jira] [Commented] (MNG-6605) Allow to suppress download messages in interactive mode

2019-04-01 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/MNG-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16806525#comment-16806525 ] Hudson commented on MNG-6605: - Build succeeded in Jenkins: Maven TLP » maven » master #188 See

[jira] [Closed] (MNG-6577) pom.xml: Uncaught IllegalArgumentException when parsing unicode entity ref

2019-04-01 Thread Michael Osipov (JIRA)
[ https://issues.apache.org/jira/browse/MNG-6577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNG-6577. --- > pom.xml: Uncaught IllegalArgumentException when parsing unicode entity ref > ---

[GitHub] [maven] asfgit closed pull request #239: MNG-6605 Unable to suppress download messages in interactive mode

2019-04-01 Thread GitBox
asfgit closed pull request #239: MNG-6605 Unable to suppress download messages in interactive mode URL: https://github.com/apache/maven/pull/239 This is an automated message from the Apache Git Service. To respond to the mes

[jira] [Closed] (MNG-6605) Allow to suppress download messages in interactive mode

2019-04-01 Thread Michael Osipov (JIRA)
[ https://issues.apache.org/jira/browse/MNG-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNG-6605. --- Resolution: Fixed Fixed with [95401cf7a606daa0982c3fe5a5928cd466230995|https://gitbox.apache.org/repos