[GitHub] eolivelli commented on issue #5: [MCHECKSTYLE-353] - Don't resolve any dependencies

2018-12-13 Thread GitBox
eolivelli commented on issue #5: [MCHECKSTYLE-353] - Don't resolve any dependencies URL: https://github.com/apache/maven-checkstyle-plugin/pull/5#issuecomment-447241006 Maybe you can try to you a brand new repository. I will load this branch into CI

[GitHub] MaxCCC commented on issue #36: [MENFORCER-142] documentation - add example for checking rules via cli

2018-12-13 Thread GitBox
MaxCCC commented on issue #36: [MENFORCER-142] documentation - add example for checking rules via cli URL: https://github.com/apache/maven-enforcer/pull/36#issuecomment-447238729 @khmarbaise When will a new official release be created? --

[jira] [Closed] (SCM-832) maven-scm-provider-jgit should support SSH public key auth

2018-12-13 Thread *$^¨%`£
[ https://issues.apache.org/jira/browse/SCM-832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) closed SCM-832. -- Resolution: Fixed [~mkutter] thanks for your contribution! > maven-scm-provider-jgit shou

[jira] [Updated] (SCM-832) maven-scm-provider-jgit should support SSH public key auth

2018-12-13 Thread *$^¨%`£
[ https://issues.apache.org/jira/browse/SCM-832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) updated SCM-832: --- Fix Version/s: 1.11.2 > maven-scm-provider-jgit should support SSH public key auth > ---

[jira] [Assigned] (SCM-832) maven-scm-provider-jgit should support SSH public key auth

2018-12-13 Thread *$^¨%`£
[ https://issues.apache.org/jira/browse/SCM-832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) reassigned SCM-832: -- Assignee: Olivier Lamy (*$^¨%`£) > maven-scm-provider-jgit should support SSH pub

[GitHub] olamy closed pull request #50: [SCM-832] maven-scm-provider-jgit should support SSH public key auth

2018-12-13 Thread GitBox
olamy closed pull request #50: [SCM-832] maven-scm-provider-jgit should support SSH public key auth URL: https://github.com/apache/maven-scm/pull/50 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] sormuras commented on issue #209: Surefire 1614

2018-12-13 Thread GitBox
sormuras commented on issue #209: Surefire 1614 URL: https://github.com/apache/maven-surefire/pull/209#issuecomment-447199514 You're welcome. Just work on this branch: https://github.com/apache/maven-surefire/tree/SUREFIRE-1614 --

[GitHub] olamy commented on issue #50: [SCM-832] maven-scm-provider-jgit should support SSH public key auth

2018-12-13 Thread GitBox
olamy commented on issue #50: [SCM-832] maven-scm-provider-jgit should support SSH public key auth URL: https://github.com/apache/maven-scm/pull/50#issuecomment-447195836 nice feature! LGTM except maybe style (not sure if the build pass as checkstyle is now configured to fail the build...

[jira] [Comment Edited] (SUREFIRE-1615) surefire.includesProperty is ignored

2018-12-13 Thread Eddie Webb (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720811#comment-16720811 ] Eddie Webb edited comment on SUREFIRE-1615 at 12/14/18 1:44 AM:

[jira] [Commented] (SUREFIRE-1615) surefire.includesProperty is ignored

2018-12-13 Thread Eddie Webb (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720811#comment-16720811 ] Eddie Webb commented on SUREFIRE-1615: -- I pulled the code and debug a little, it

[jira] [Updated] (SUREFIRE-1615) surefire.includesProperty is ignored

2018-12-13 Thread Eddie Webb (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eddie Webb updated SUREFIRE-1615: - Affects Version/s: 3.0.0-M2 > surefire.includesProperty is ignored > -

[jira] [Commented] (SUREFIRE-1615) surefire.includesProperty is ignored

2018-12-13 Thread Eddie Webb (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720670#comment-16720670 ] Eddie Webb commented on SUREFIRE-1615: -- Seeing this in surefire 3.0.0 candidates

[jira] [Created] (SUREFIRE-1615) surefire.includesProperty is ignored

2018-12-13 Thread Eddie Webb (JIRA)
Eddie Webb created SUREFIRE-1615: Summary: surefire.includesProperty is ignored Key: SUREFIRE-1615 URL: https://issues.apache.org/jira/browse/SUREFIRE-1615 Project: Maven Surefire Issue Type:

[jira] [Closed] (MNGSITE-360) upgrade archetype version to 1.4 to support Java 11

2018-12-13 Thread JIRA
[ https://issues.apache.org/jira/browse/MNGSITE-360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hervé Boutemy closed MNGSITE-360. - Resolution: Fixed Assignee: Hervé Boutemy > upgrade archetype version to 1.4 to support Ja

[jira] [Commented] (MRAR-81) rar artifact is build twice

2018-12-13 Thread zosrothko (JIRA)
[ https://issues.apache.org/jira/browse/MRAR-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720540#comment-16720540 ] zosrothko commented on MRAR-81: --- Here the full [^pom.xml] > rar artifact is build twice > ---

[jira] [Updated] (MRAR-81) rar artifact is build twice

2018-12-13 Thread zosrothko (JIRA)
[ https://issues.apache.org/jira/browse/MRAR-81?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zosrothko updated MRAR-81: -- Attachment: pom.xml > rar artifact is build twice > --- > > Key: MRAR-81 >

[GitHub] Tibor17 commented on issue #209: Surefire 1614

2018-12-13 Thread GitBox
Tibor17 commented on issue #209: Surefire 1614 URL: https://github.com/apache/maven-surefire/pull/209#issuecomment-447089793 @sormuras Pls make me committer in your PR and I will finish the code style and squash it. Thx.

[GitHub] zregvart commented on issue #5: [MCHECKSTYLE-353] - Don't resolve any dependencies

2018-12-13 Thread GitBox
zregvart commented on issue #5: [MCHECKSTYLE-353] - Don't resolve any dependencies URL: https://github.com/apache/maven-checkstyle-plugin/pull/5#issuecomment-447088395 Here are some details: ``` cat /etc/fedora-release Fedora release 29 (Twenty Nine) ``` ``` $ mvn

[jira] [Commented] (MDEPLOY-244) maven deploy plugin 3.0.0-M1 breaks deploys when alt*DeploymentRepository properties are used

2018-12-13 Thread JIRA
[ https://issues.apache.org/jira/browse/MDEPLOY-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720477#comment-16720477 ] Leonard Brünings commented on MDEPLOY-244: -- There also seems to be a problem wh

[GitHub] Tibor17 commented on issue #208: [SUREFIRE-1615] Sort in the surefire-report/Test-*.xml file

2018-12-13 Thread GitBox
Tibor17 commented on issue #208: [SUREFIRE-1615] Sort in the surefire-report/Test-*.xml file URL: https://github.com/apache/maven-surefire/pull/208#issuecomment-447076134 @lanlingxueyu Thx and now pls write an IT. As a hint see any `*IT.java` in `surefire-its/src/test/java`. Each IT

[GitHub] Tibor17 commented on a change in pull request #208: [SUREFIRE-1615] Sort in the surefire-report/Test-*.xml file

2018-12-13 Thread GitBox
Tibor17 commented on a change in pull request #208: [SUREFIRE-1615] Sort in the surefire-report/Test-*.xml file URL: https://github.com/apache/maven-surefire/pull/208#discussion_r241515424 ## File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/St

[GitHub] Tibor17 commented on a change in pull request #208: [SUREFIRE-1615] Sort in the surefire-report/Test-*.xml file

2018-12-13 Thread GitBox
Tibor17 commented on a change in pull request #208: [SUREFIRE-1615] Sort in the surefire-report/Test-*.xml file URL: https://github.com/apache/maven-surefire/pull/208#discussion_r241514634 ## File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/St

[GitHub] eolivelli commented on issue #5: [MCHECKSTYLE-353] - Don't resolve any dependencies

2018-12-13 Thread GitBox
eolivelli commented on issue #5: [MCHECKSTYLE-353] - Don't resolve any dependencies URL: https://github.com/apache/maven-checkstyle-plugin/pull/5#issuecomment-447052139 mvn version ? Jdk? Os? This is an automated message fro

[GitHub] zregvart commented on issue #5: [MCHECKSTYLE-353] - Don't resolve any dependencies

2018-12-13 Thread GitBox
zregvart commented on issue #5: [MCHECKSTYLE-353] - Don't resolve any dependencies URL: https://github.com/apache/maven-checkstyle-plugin/pull/5#issuecomment-447044139 Both on the master and on the pull request branch. This

[GitHub] eolivelli edited a comment on issue #5: [MCHECKSTYLE-353] - Don't resolve any dependencies

2018-12-13 Thread GitBox
eolivelli edited a comment on issue #5: [MCHECKSTYLE-353] - Don't resolve any dependencies URL: https://github.com/apache/maven-checkstyle-plugin/pull/5#issuecomment-447040047 Sorry, just to understand. If you run mvn clean verify -Prun-its On current master you see failures?

[GitHub] eolivelli commented on issue #5: [MCHECKSTYLE-353] - Don't resolve any dependencies

2018-12-13 Thread GitBox
eolivelli commented on issue #5: [MCHECKSTYLE-353] - Don't resolve any dependencies URL: https://github.com/apache/maven-checkstyle-plugin/pull/5#issuecomment-447040047 Sorry, just to understand. If you run mvn clean install -Prun-its On current master you see failures? Or

[jira] [Commented] (MRAR-81) rar artifact is build twice

2018-12-13 Thread Karl Heinz Marbaise (JIRA)
[ https://issues.apache.org/jira/browse/MRAR-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720332#comment-16720332 ] Karl Heinz Marbaise commented on MRAR-81: - Looks like you have define packaging: rar

[GitHub] zregvart commented on issue #5: [MCHECKSTYLE-353] - Don't resolve any dependencies

2018-12-13 Thread GitBox
zregvart commented on issue #5: [MCHECKSTYLE-353] - Don't resolve any dependencies URL: https://github.com/apache/maven-checkstyle-plugin/pull/5#issuecomment-447019374 > On my laptop current master does not fail I've found that if I change the site plugin version to 3.7.1 (the lates

[GitHub] eolivelli commented on issue #5: [MCHECKSTYLE-353] - Don't resolve any dependencies

2018-12-13 Thread GitBox
eolivelli commented on issue #5: [MCHECKSTYLE-353] - Don't resolve any dependencies URL: https://github.com/apache/maven-checkstyle-plugin/pull/5#issuecomment-446994581 On my laptop current master does not fail This is an au

[GitHub] zregvart commented on issue #5: [MCHECKSTYLE-353] - Don't resolve any dependencies

2018-12-13 Thread GitBox
zregvart commented on issue #5: [MCHECKSTYLE-353] - Don't resolve any dependencies URL: https://github.com/apache/maven-checkstyle-plugin/pull/5#issuecomment-446988674 @eolivelli the build fails with this in the exact same way it fails for me on master: ``` [INFO] --

[jira] [Created] (MRAR-81) rar artifact is build twice

2018-12-13 Thread zosrothko (JIRA)
zosrothko created MRAR-81: - Summary: rar artifact is build twice Key: MRAR-81 URL: https://issues.apache.org/jira/browse/MRAR-81 Project: Maven Rar Plugin Issue Type: Bug Affects Versions: 2.4

[GitHub] eolivelli commented on issue #7: [MCHECKSTYLE-357] - Allow inline configuration for reporting

2018-12-13 Thread GitBox
eolivelli commented on issue #7: [MCHECKSTYLE-357] - Allow inline configuration for reporting URL: https://github.com/apache/maven-checkstyle-plugin/pull/7#issuecomment-446968801 Yes This is an automated message from the Apa

[GitHub] eolivelli commented on issue #5: Don't resolve any dependencies

2018-12-13 Thread GitBox
eolivelli commented on issue #5: Don't resolve any dependencies URL: https://github.com/apache/maven-checkstyle-plugin/pull/5#issuecomment-446964595 Hi, Can you please change the PR title and commit message so that they start with [JIRAISSUE] ? I will run integration tests on CI.

[GitHub] rnveach commented on a change in pull request #7: [MCHECKSTYLE-357] - Allow inline configuration for reporting

2018-12-13 Thread GitBox
rnveach commented on a change in pull request #7: [MCHECKSTYLE-357] - Allow inline configuration for reporting URL: https://github.com/apache/maven-checkstyle-plugin/pull/7#discussion_r241374703 ## File path: src/main/java/org/apache/maven/plugins/checkstyle/AbstractCheckstyleRepo

[GitHub] Serranya commented on a change in pull request #7: [MCHECKSTYLE-357] - Allow inline configuration for reporting

2018-12-13 Thread GitBox
Serranya commented on a change in pull request #7: [MCHECKSTYLE-357] - Allow inline configuration for reporting URL: https://github.com/apache/maven-checkstyle-plugin/pull/7#discussion_r241376965 ## File path: src/main/java/org/apache/maven/plugins/checkstyle/AbstractCheckstyleRep

[GitHub] rnveach commented on a change in pull request #7: [MCHECKSTYLE-357] - Allow inline configuration for reporting

2018-12-13 Thread GitBox
rnveach commented on a change in pull request #7: [MCHECKSTYLE-357] - Allow inline configuration for reporting URL: https://github.com/apache/maven-checkstyle-plugin/pull/7#discussion_r241374703 ## File path: src/main/java/org/apache/maven/plugins/checkstyle/AbstractCheckstyleRepo

[GitHub] lanlingxueyu commented on issue #208: [SUREFIRE-1615] Sort in the surefire-report/Test-*.xml file

2018-12-13 Thread GitBox
lanlingxueyu commented on issue #208: [SUREFIRE-1615] Sort in the surefire-report/Test-*.xml file URL: https://github.com/apache/maven-surefire/pull/208#issuecomment-446933146 ok,already edited This is an automated message f

[jira] [Commented] (MRESOLVER-64) restore setLoggerFactory(...) API deleted from version 1.3.0

2018-12-13 Thread Sylwester Lachiewicz (JIRA)
[ https://issues.apache.org/jira/browse/MRESOLVER-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720032#comment-16720032 ] Sylwester Lachiewicz commented on MRESOLVER-64: --- Please verify if You can

[GitHub] ppalaga commented on issue #5: Don't resolve any dependencies

2018-12-13 Thread GitBox
ppalaga commented on issue #5: Don't resolve any dependencies URL: https://github.com/apache/maven-checkstyle-plugin/pull/5#issuecomment-446898006 @hboutemy, @rfscholte, @khmarbaise could please somebody of you review this one? Citing the Jira report by @zregvart: > For Apach

[GitHub] Serranya commented on issue #7: [MCHECKSTYLE-357] - Allow inline configuration for reporting

2018-12-13 Thread GitBox
Serranya commented on issue #7: [MCHECKSTYLE-357] - Allow inline configuration for reporting URL: https://github.com/apache/maven-checkstyle-plugin/pull/7#issuecomment-446891636 @khmarbaise So just to be safe . What you are saying is that I shouldn't commit the `src/it/MCHECKSTYLE-357/LIC

[GitHub] Tibor17 commented on a change in pull request #209: Surefire 1614

2018-12-13 Thread GitBox
Tibor17 commented on a change in pull request #209: Surefire 1614 URL: https://github.com/apache/maven-surefire/pull/209#discussion_r241306982 ## File path: surefire-its/src/test/resources/surefire-1614-stream-corruption/src/test/java/com/example/demo/CustomRunner.java ##

[GitHub] sormuras commented on a change in pull request #209: Surefire 1614

2018-12-13 Thread GitBox
sormuras commented on a change in pull request #209: Surefire 1614 URL: https://github.com/apache/maven-surefire/pull/209#discussion_r241303900 ## File path: surefire-its/src/test/resources/surefire-1614-stream-corruption/src/test/java/com/example/demo/CustomRunner.java ##