[jira] [Commented] (MJAR-260) Warn about invalid 'Automatic-Module-Name' in MANIFEST

2018-11-16 Thread Christian Stein (JIRA)
[ https://issues.apache.org/jira/browse/MJAR-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690431#comment-16690431 ] Christian Stein commented on MJAR-260: -- Created Maven ArchiverĀ  [https://issues.apache

[jira] [Created] (MSHARED-773) Fail on invalid 'Automatic-Module-Name' in MANIFEST

2018-11-16 Thread Christian Stein (JIRA)
Christian Stein created MSHARED-773: --- Summary: Fail on invalid 'Automatic-Module-Name' in MANIFEST Key: MSHARED-773 URL: https://issues.apache.org/jira/browse/MSHARED-773 Project: Maven Shared Compon

[jira] [Commented] (SUREFIRE-1593) 3.0.0-M1 produces invalid code sources on Windows

2018-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690398#comment-16690398 ] ASF GitHub Bot commented on SUREFIRE-1593: -- Tibor17 commented on issue #198:

[GitHub] Tibor17 commented on issue #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows

2018-11-16 Thread GitBox
Tibor17 commented on issue #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows URL: https://github.com/apache/maven-surefire/pull/198#issuecomment-439592262 @jglick Pls close your PR, the fix has been pushed. Thx for your work! ---

[GitHub] Tibor17 closed pull request #199: Surefire 1593

2018-11-16 Thread GitBox
Tibor17 closed pull request #199: Surefire 1593 URL: https://github.com/apache/maven-surefire/pull/199 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork

[jira] [Closed] (SUREFIRE-1593) 3.0.0-M1 produces invalid code sources on Windows

2018-11-16 Thread Tibor Digana (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana closed SUREFIRE-1593. -- Resolution: Fixed https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=f5cca5

[jira] [Updated] (SUREFIRE-1593) 3.0.0-M1 produces invalid code sources on Windows

2018-11-16 Thread Tibor Digana (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1593: --- Fix Version/s: 3.0.0-M2 > 3.0.0-M1 produces invalid code sources on Windows >

[jira] [Assigned] (SUREFIRE-1593) 3.0.0-M1 produces invalid code sources on Windows

2018-11-16 Thread Tibor Digana (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana reassigned SUREFIRE-1593: -- Assignee: Tibor Digana > 3.0.0-M1 produces invalid code sources on Windows > --

[jira] [Comment Edited] (MRRESOURCES-102) Filtering of non-.vm files

2018-11-16 Thread Jurrie Overgoor (JIRA)
[ https://issues.apache.org/jira/browse/MRRESOURCES-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689922#comment-16689922 ] Jurrie Overgoor edited comment on MRRESOURCES-102 at 11/16/18 9:02 PM: ---

[GitHub] Jurrie opened a new pull request #2: Implement MRRESOURCES-102

2018-11-16 Thread GitBox
Jurrie opened a new pull request #2: Implement MRRESOURCES-102 URL: https://github.com/apache/maven-remote-resources-plugin/pull/2 This implements [MRRESOURCES-102](https://issues.apache.org/jira/browse/MRRESOURCES-102) by using [Maven resource filtering](https://maven.apache.org/shared/m

[GitHub] Jurrie commented on issue #1: Feature/mrresources 102

2018-11-16 Thread GitBox
Jurrie commented on issue #1: Feature/mrresources 102 URL: https://github.com/apache/maven-remote-resources-plugin/pull/1#issuecomment-439525137 My formatter was too eager - [let me try that again](https://github.com/apache/maven-remote-resources-plugin/pull/2) ;)

[jira] [Commented] (MRRESOURCES-102) Filtering of non-.vm files

2018-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MRRESOURCES-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1669#comment-1669 ] ASF GitHub Bot commented on MRRESOURCES-102: Jurrie opened a new pull re

[GitHub] Jurrie closed pull request #1: Feature/mrresources 102

2018-11-16 Thread GitBox
Jurrie closed pull request #1: Feature/mrresources 102 URL: https://github.com/apache/maven-remote-resources-plugin/pull/1 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] Jurrie opened a new pull request #1: Feature/mrresources 102

2018-11-16 Thread GitBox
Jurrie opened a new pull request #1: Feature/mrresources 102 URL: https://github.com/apache/maven-remote-resources-plugin/pull/1 This implements [MRRESOURCES-102](https://issues.apache.org/jira/browse/MRRESOURCES-102) by using [Maven resource filtering](https://maven.apache.org/shared/mav

[GitHub] Tibor17 commented on issue #199: Surefire 1593

2018-11-16 Thread GitBox
Tibor17 commented on issue #199: Surefire 1593 URL: https://github.com/apache/maven-surefire/pull/199#issuecomment-439521913 @jglick Yes I am but we are here for you users, and the fix would not be possible without your efforts. Thank you for your work. I will continue with squashing

[jira] [Commented] (MRESOLVER-63) FileTransformer#transformData(File) should also throw TransformException

2018-11-16 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/MRESOLVER-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689948#comment-16689948 ] Hudson commented on MRESOLVER-63: - Build succeeded in Jenkins: Maven TLP Ā» maven-resolv

[jira] [Closed] (MRESOLVER-63) FileTransformer#transformData(File) should also throw TransformException

2018-11-16 Thread Robert Scholte (JIRA)
[ https://issues.apache.org/jira/browse/MRESOLVER-63?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MRESOLVER-63. --- Resolution: Fixed Assignee: Robert Scholte Fixed in [2e57238c88085ad0d685b3672e61caa

[jira] [Commented] (MRESOLVER-63) FileTransformer#transformData(File) should also throw TransformException

2018-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MRESOLVER-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689943#comment-16689943 ] ASF GitHub Bot commented on MRESOLVER-63: - rfscholte closed pull request #23: [

[GitHub] rfscholte closed pull request #23: [MRESOLVER-63] FileTransformer#transformData(File) should also throw TransformException

2018-11-16 Thread GitBox
rfscholte closed pull request #23: [MRESOLVER-63] FileTransformer#transformData(File) should also throw TransformException URL: https://github.com/apache/maven-resolver/pull/23 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below

[jira] [Closed] (MRRESOURCES-93) release:perform fails due to integration tests.

2018-11-16 Thread Karl Heinz Marbaise (JIRA)
[ https://issues.apache.org/jira/browse/MRRESOURCES-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise closed MRRESOURCES-93. -- Resolution: Cannot Reproduce > release:perform fails due to integration tes

[jira] [Commented] (MRRESOURCES-102) Filtering of non-.vm files

2018-11-16 Thread Jurrie Overgoor (JIRA)
[ https://issues.apache.org/jira/browse/MRRESOURCES-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689922#comment-16689922 ] Jurrie Overgoor commented on MRRESOURCES-102: - I agree on this; I'm in a

[jira] [Commented] (MJAR-260) Warn about invalid 'Automatic-Module-Name' in MANIFEST

2018-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MJAR-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689869#comment-16689869 ] ASF GitHub Bot commented on MJAR-260: - khmarbaise commented on a change in pull request

[jira] [Commented] (MJAR-260) Warn about invalid 'Automatic-Module-Name' in MANIFEST

2018-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MJAR-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689877#comment-16689877 ] ASF GitHub Bot commented on MJAR-260: - sormuras commented on a change in pull request #

[jira] [Commented] (MJAR-260) Warn about invalid 'Automatic-Module-Name' in MANIFEST

2018-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MJAR-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689876#comment-16689876 ] ASF GitHub Bot commented on MJAR-260: - sormuras commented on a change in pull request #

[GitHub] sormuras commented on a change in pull request #3: [MJAR-260] Fail on invalid automatic module name

2018-11-16 Thread GitBox
sormuras commented on a change in pull request #3: [MJAR-260] Fail on invalid automatic module name URL: https://github.com/apache/maven-jar-plugin/pull/3#discussion_r234313690 ## File path: src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java ## @@ -223,6 +226,

[GitHub] sormuras commented on a change in pull request #3: [MJAR-260] Fail on invalid automatic module name

2018-11-16 Thread GitBox
sormuras commented on a change in pull request #3: [MJAR-260] Fail on invalid automatic module name URL: https://github.com/apache/maven-jar-plugin/pull/3#discussion_r234313690 ## File path: src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java ## @@ -223,6 +226,

[GitHub] khmarbaise commented on a change in pull request #3: [MJAR-260] Fail on invalid automatic module name

2018-11-16 Thread GitBox
khmarbaise commented on a change in pull request #3: [MJAR-260] Fail on invalid automatic module name URL: https://github.com/apache/maven-jar-plugin/pull/3#discussion_r234312461 ## File path: src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java ## @@ -223,6 +22

[jira] [Commented] (MJAR-260) Warn about invalid 'Automatic-Module-Name' in MANIFEST

2018-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MJAR-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689785#comment-16689785 ] ASF GitHub Bot commented on MJAR-260: - sormuras commented on issue #3: [MJAR-260] Fail

[GitHub] sormuras commented on issue #3: [MJAR-260] Fail on invalid automatic module name

2018-11-16 Thread GitBox
sormuras commented on issue #3: [MJAR-260] Fail on invalid automatic module name URL: https://github.com/apache/maven-jar-plugin/pull/3#issuecomment-439480364 Build No 4 is green (read: blue). Waiting for @khmarbaise or @rfscholte to chime in. https://builds.apache.org/job/maven-box

[jira] [Commented] (MJAR-260) Warn about invalid 'Automatic-Module-Name' in MANIFEST

2018-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MJAR-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689749#comment-16689749 ] ASF GitHub Bot commented on MJAR-260: - sormuras commented on issue #3: [MJAR-260] Fail

[GitHub] sormuras commented on issue #3: [MJAR-260] Fail on invalid automatic module name

2018-11-16 Thread GitBox
sormuras commented on issue #3: [MJAR-260] Fail on invalid automatic module name URL: https://github.com/apache/maven-jar-plugin/pull/3#issuecomment-439471640 > > Seems there is a failure https://builds.apache.org/job/maven-box/job/maven-jar-plugin/job/MJAR-260-Automatic-Module-Name/2/

[jira] [Commented] (MJAR-260) Warn about invalid 'Automatic-Module-Name' in MANIFEST

2018-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MJAR-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689727#comment-16689727 ] ASF GitHub Bot commented on MJAR-260: - sormuras edited a comment on issue #3: [MJAR-260

[GitHub] sormuras edited a comment on issue #3: [MJAR-260] Fail on invalid automatic module name

2018-11-16 Thread GitBox
sormuras edited a comment on issue #3: [MJAR-260] Fail on invalid automatic module name URL: https://github.com/apache/maven-jar-plugin/pull/3#issuecomment-439468318 > Seems there is a failure https://builds.apache.org/job/maven-box/job/maven-jar-plugin/job/MJAR-260-Automatic-Module-Nam

[jira] [Commented] (MJAR-260) Warn about invalid 'Automatic-Module-Name' in MANIFEST

2018-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MJAR-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689726#comment-16689726 ] ASF GitHub Bot commented on MJAR-260: - sormuras edited a comment on issue #3: [MJAR-260

[GitHub] sormuras edited a comment on issue #3: [MJAR-260] Fail on invalid automatic module name

2018-11-16 Thread GitBox
sormuras edited a comment on issue #3: [MJAR-260] Fail on invalid automatic module name URL: https://github.com/apache/maven-jar-plugin/pull/3#issuecomment-439468318 > Seems there is a failure https://builds.apache.org/job/maven-box/job/maven-jar-plugin/job/MJAR-260-Automatic-Module-Nam

[GitHub] sormuras commented on issue #3: [MJAR-260] Fail on invalid automatic module name

2018-11-16 Thread GitBox
sormuras commented on issue #3: [MJAR-260] Fail on invalid automatic module name URL: https://github.com/apache/maven-jar-plugin/pull/3#issuecomment-439468318 > Seems there is a failure https://builds.apache.org/job/maven-box/job/maven-jar-plugin/job/MJAR-260-Automatic-Module-Name/2/

[jira] [Commented] (MJAR-260) Warn about invalid 'Automatic-Module-Name' in MANIFEST

2018-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MJAR-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689721#comment-16689721 ] ASF GitHub Bot commented on MJAR-260: - sormuras commented on issue #3: [MJAR-260] Fail

[jira] [Commented] (MJAR-260) Warn about invalid 'Automatic-Module-Name' in MANIFEST

2018-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MJAR-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689653#comment-16689653 ] ASF GitHub Bot commented on MJAR-260: - eolivelli commented on issue #3: [MJAR-260] Fail

[GitHub] eolivelli commented on issue #3: [MJAR-260] Fail on invalid automatic module name

2018-11-16 Thread GitBox
eolivelli commented on issue #3: [MJAR-260] Fail on invalid automatic module name URL: https://github.com/apache/maven-jar-plugin/pull/3#issuecomment-439454108 I wonder if we should fix other plugins, namely the shade plugin

[jira] [Commented] (MJAR-260) Warn about invalid 'Automatic-Module-Name' in MANIFEST

2018-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MJAR-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689648#comment-16689648 ] ASF GitHub Bot commented on MJAR-260: - eolivelli commented on issue #3: [MJAR-260] Fail

[GitHub] eolivelli commented on issue #3: [MJAR-260] Fail on invalid automatic module name

2018-11-16 Thread GitBox
eolivelli commented on issue #3: [MJAR-260] Fail on invalid automatic module name URL: https://github.com/apache/maven-jar-plugin/pull/3#issuecomment-439452167 Seems there is a failure https://builds.apache.org/job/maven-box/job/maven-jar-plugin/job/MJAR-260-Automatic-Module-Name/2/ --

[jira] [Commented] (MJAR-260) Warn about invalid 'Automatic-Module-Name' in MANIFEST

2018-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MJAR-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689550#comment-16689550 ] ASF GitHub Bot commented on MJAR-260: - sormuras commented on a change in pull request #

[GitHub] sormuras commented on a change in pull request #3: [MJAR-260] Fail on invalid automatic module name

2018-11-16 Thread GitBox
sormuras commented on a change in pull request #3: [MJAR-260] Fail on invalid automatic module name URL: https://github.com/apache/maven-jar-plugin/pull/3#discussion_r234243253 ## File path: src/test/java/org/apache/maven/plugins/jar/AbstractJarMojoTest.java ## @@ -0,0 +1,

[jira] [Commented] (MJAR-260) Warn about invalid 'Automatic-Module-Name' in MANIFEST

2018-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MJAR-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689462#comment-16689462 ] ASF GitHub Bot commented on MJAR-260: - sormuras commented on a change in pull request #

[GitHub] sormuras commented on a change in pull request #3: [MJAR-260] Fail on invalid automatic module name

2018-11-16 Thread GitBox
sormuras commented on a change in pull request #3: [MJAR-260] Fail on invalid automatic module name URL: https://github.com/apache/maven-jar-plugin/pull/3#discussion_r234218920 ## File path: src/test/java/org/apache/maven/plugins/jar/AbstractJarMojoTest.java ## @@ -0,0 +1,

[jira] [Commented] (MJAR-260) Warn about invalid 'Automatic-Module-Name' in MANIFEST

2018-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MJAR-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689412#comment-16689412 ] ASF GitHub Bot commented on MJAR-260: - eolivelli commented on a change in pull request

[GitHub] eolivelli commented on a change in pull request #3: [MJAR-260] Fail on invalid automatic module name

2018-11-16 Thread GitBox
eolivelli commented on a change in pull request #3: [MJAR-260] Fail on invalid automatic module name URL: https://github.com/apache/maven-jar-plugin/pull/3#discussion_r234201172 ## File path: src/test/java/org/apache/maven/plugins/jar/AbstractJarMojoTest.java ## @@ -0,0 +1

[jira] [Commented] (MJAR-260) Warn about invalid 'Automatic-Module-Name' in MANIFEST

2018-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MJAR-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689336#comment-16689336 ] ASF GitHub Bot commented on MJAR-260: - sormuras opened a new pull request #3: [MJAR-260

[GitHub] sormuras opened a new pull request #3: [MJAR-260] Fail on invalid automatic module name

2018-11-16 Thread GitBox
sormuras opened a new pull request #3: [MJAR-260] Fail on invalid automatic module name URL: https://github.com/apache/maven-jar-plugin/pull/3 Addresses https://issues.apache.org/jira/browse/MJAR-260 This is an automated

[jira] [Created] (MJAR-260) Warn about invalid 'Automatic-Module-Name' in MANIFEST

2018-11-16 Thread Christian Stein (JIRA)
Christian Stein created MJAR-260: Summary: Warn about invalid 'Automatic-Module-Name' in MANIFEST Key: MJAR-260 URL: https://issues.apache.org/jira/browse/MJAR-260 Project: Maven JAR Plugin I