[GitHub] [lucene-solr] juanka588 commented on a change in pull request #1320: LUCENE-9257: Always keep FST off-heap. Remove FSTLoadMode and Reader attributes.

juanka588 commented on a change in pull request #1320: LUCENE-9257: Always keep FST off-heap. Remove FSTLoadMode and Reader attributes. URL: https://github.com/apache/lucene-solr/pull/1320#discussion_r388274441 ## File path: lucene/core/src/java/org/apache/lucene/codecs/blocktree/F

[GitHub] [lucene-solr] ctargett commented on a change in pull request #1292: SOLR-14284 add expressible support to list, and add example of removing a component

ctargett commented on a change in pull request #1292: SOLR-14284 add expressible support to list, and add example of removing a component URL: https://github.com/apache/lucene-solr/pull/1292#discussion_r388300341 ## File path: solr/solr-ref-guide/src/stream-api.adoc ## @@

[GitHub] [lucene-solr] ctargett commented on issue #1292: SOLR-14284 add expressible support to list, and add example of removing a component

ctargett commented on issue #1292: SOLR-14284 add expressible support to list, and add example of removing a component URL: https://github.com/apache/lucene-solr/pull/1292#issuecomment-595237017 The changes here are slightly confusing because the descriptions of the Jira and the PR refer t

[GitHub] [lucene-solr] ctargett commented on a change in pull request #1292: SOLR-14284 add expressible support to list, and add example of removing a component

ctargett commented on a change in pull request #1292: SOLR-14284 add expressible support to list, and add example of removing a component URL: https://github.com/apache/lucene-solr/pull/1292#discussion_r388311699 ## File path: solr/solr-ref-guide/src/stream-api.adoc ## @@

[GitHub] [lucene-solr] epugh commented on issue #1292: SOLR-14284 add expressible support to list, and add example of removing a component

epugh commented on issue #1292: SOLR-14284 add expressible support to list, and add example of removing a component URL: https://github.com/apache/lucene-solr/pull/1292#issuecomment-595269969 Thanks @ctargett for the review. Do you want me to pull that `delete-requesthandler` into another

[GitHub] [lucene-solr] ctargett commented on a change in pull request #1291: LUCENE-9016: RefGuide meta doc for how to publish website

ctargett commented on a change in pull request #1291: LUCENE-9016: RefGuide meta doc for how to publish website URL: https://github.com/apache/lucene-solr/pull/1291#discussion_r388348872 ## File path: solr/solr-ref-guide/src/meta-docs/publish.adoc ## @@ -47,61 +47,26 @@ To

[GitHub] [lucene-solr] ctargett commented on issue #1291: LUCENE-9016: RefGuide meta doc for how to publish website

ctargett commented on issue #1291: LUCENE-9016: RefGuide meta doc for how to publish website URL: https://github.com/apache/lucene-solr/pull/1291#issuecomment-595274181 Sorry, I approved this and then looked at why precommit failed and there is still 1 page reference that is incorrect (sin

[GitHub] [lucene-solr] ctargett commented on issue #1292: SOLR-14284 add expressible support to list, and add example of removing a component

ctargett commented on issue #1292: SOLR-14284 add expressible support to list, and add example of removing a component URL: https://github.com/apache/lucene-solr/pull/1292#issuecomment-595275870 It's fine to keep it here, it just was a disconnect at first. -

[GitHub] [lucene-solr] epugh commented on a change in pull request #1292: SOLR-14284 add expressible support to list, and add example of removing a component

epugh commented on a change in pull request #1292: SOLR-14284 add expressible support to list, and add example of removing a component URL: https://github.com/apache/lucene-solr/pull/1292#discussion_r388354635 ## File path: solr/solr-ref-guide/src/stream-api.adoc ## @@ -0,

[GitHub] [lucene-solr] epugh commented on issue #1292: SOLR-14284 add expressible support to list, and add example of removing a component

epugh commented on issue #1292: SOLR-14284 add expressible support to list, and add example of removing a component URL: https://github.com/apache/lucene-solr/pull/1292#issuecomment-595290097 I think I have responded and pushed up all changes. Thank you for reviewing, and let me know if a

[GitHub] [lucene-solr] janhoy merged pull request #1291: LUCENE-9016: RefGuide meta doc for how to publish website

janhoy merged pull request #1291: LUCENE-9016: RefGuide meta doc for how to publish website URL: https://github.com/apache/lucene-solr/pull/1291 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [lucene-solr] jtibshirani edited a comment on issue #1314: LUCENE-9136: Coarse quantization that reuses existing formats.

jtibshirani edited a comment on issue #1314: LUCENE-9136: Coarse quantization that reuses existing formats. URL: https://github.com/apache/lucene-solr/pull/1314#issuecomment-594242054 **Benchmarks** sift-128-euclidean: a dataset of 1 million SIFT descriptors with 128 dims. ```

[GitHub] [lucene-solr] jtibshirani edited a comment on issue #1314: LUCENE-9136: Coarse quantization that reuses existing formats.

jtibshirani edited a comment on issue #1314: LUCENE-9136: Coarse quantization that reuses existing formats. URL: https://github.com/apache/lucene-solr/pull/1314#issuecomment-594242054 **Benchmarks** sift-128-euclidean: a dataset of 1 million SIFT descriptors with 128 dims. ```

[GitHub] [lucene-solr] jtibshirani edited a comment on issue #1314: LUCENE-9136: Coarse quantization that reuses existing formats.

jtibshirani edited a comment on issue #1314: LUCENE-9136: Coarse quantization that reuses existing formats. URL: https://github.com/apache/lucene-solr/pull/1314#issuecomment-594242054 **Benchmarks** In these benchmarks, we find the nearest k=10 vectors and record the recall and queries

[GitHub] [lucene-solr] jtibshirani edited a comment on issue #1314: LUCENE-9136: Coarse quantization that reuses existing formats.

jtibshirani edited a comment on issue #1314: LUCENE-9136: Coarse quantization that reuses existing formats. URL: https://github.com/apache/lucene-solr/pull/1314#issuecomment-594242054 **Benchmarks** In these benchmarks, we find the nearest k=10 vectors and record the recall and queries

[GitHub] [lucene-solr] mikemccand commented on issue #1319: LUCENE-9164: process all events before closing gracefully

mikemccand commented on issue #1319: LUCENE-9164: process all events before closing gracefully URL: https://github.com/apache/lucene-solr/pull/1319#issuecomment-595367820 I'll try to review this one soon! This is an automated

[GitHub] [lucene-solr] jpountz commented on issue #1320: LUCENE-9257: Always keep FST off-heap. Remove FSTLoadMode and Reader attributes.

jpountz commented on issue #1320: LUCENE-9257: Always keep FST off-heap. Remove FSTLoadMode and Reader attributes. URL: https://github.com/apache/lucene-solr/pull/1320#issuecomment-595382926 In the spirit of @dsmiley 's recent email, let's add a CHANGES entry? -

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

jpountz commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1294#discussion_r388498188 ## File path: lucene/core/src/java/org/apache/lucene/search/SliceExecutionControlPlane

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

jpountz commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1294#discussion_r388497511 ## File path: lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java ###

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

jpountz commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1294#discussion_r388493819 ## File path: lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java ###

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

jpountz commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1294#discussion_r388497042 ## File path: lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java ###

[GitHub] [lucene-solr] andyvuong commented on issue #1293: SOLR-14044: Delete collection bug fix by changing sharedShardName to use the same blob delimiter

andyvuong commented on issue #1293: SOLR-14044: Delete collection bug fix by changing sharedShardName to use the same blob delimiter URL: https://github.com/apache/lucene-solr/pull/1293#issuecomment-595431605 cc @yonik can you merge. Thanks -

[GitHub] [lucene-solr] msokolov commented on issue #1313: LUCENE-8962: Split test case

msokolov commented on issue #1313: LUCENE-8962: Split test case URL: https://github.com/apache/lucene-solr/pull/1313#issuecomment-595436417 I verified this fixes the `TestIndexWriterExceptions2.testBasics` reported by @jpountz and also beasted that test 1000x just in case. I think we need t

[GitHub] [lucene-solr] msokolov merged pull request #1313: LUCENE-8962: Split test case

msokolov merged pull request #1313: LUCENE-8962: Split test case URL: https://github.com/apache/lucene-solr/pull/1313 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [lucene-solr] jtibshirani edited a comment on issue #1314: LUCENE-9136: Coarse quantization that reuses existing formats.

jtibshirani edited a comment on issue #1314: LUCENE-9136: Coarse quantization that reuses existing formats. URL: https://github.com/apache/lucene-solr/pull/1314#issuecomment-594242054 **Benchmarks** In these benchmarks, we find the nearest k=10 vectors and record the recall and queries

[GitHub] [lucene-solr] yonik merged pull request #1293: SOLR-14044: Delete collection bug fix by changing sharedShardName to use the same blob delimiter

yonik merged pull request #1293: SOLR-14044: Delete collection bug fix by changing sharedShardName to use the same blob delimiter URL: https://github.com/apache/lucene-solr/pull/1293 This is an automated message from the Apa

[GitHub] [lucene-solr] bruno-roustant commented on issue #1320: LUCENE-9257: Always keep FST off-heap. Remove FSTLoadMode and Reader attributes.

bruno-roustant commented on issue #1320: LUCENE-9257: Always keep FST off-heap. Remove FSTLoadMode and Reader attributes. URL: https://github.com/apache/lucene-solr/pull/1320#issuecomment-595474374 Good point. I added it and classified as 'Other'. --

[GitHub] [lucene-solr] dnhatn commented on issue #1313: LUCENE-8962: Split test case

dnhatn commented on issue #1313: LUCENE-8962: Split test case URL: https://github.com/apache/lucene-solr/pull/1313#issuecomment-595503029 @msfroh @msokolov Thank you for working on the fix. Unfortunately, this is still an issue. Many Elasticsearch tests are [failing](https://github.com/ela

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit

dnhatn commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit URL: https://github.com/apache/lucene-solr/pull/1155#discussion_r388704872 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -3147,6

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit

dnhatn commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit URL: https://github.com/apache/lucene-solr/pull/1155#discussion_r388705514 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -3147,6

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit

dnhatn commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit URL: https://github.com/apache/lucene-solr/pull/1155#discussion_r388705156 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -3252,6

[GitHub] [lucene-solr] dnhatn commented on issue #1313: LUCENE-8962: Split test case

dnhatn commented on issue #1313: LUCENE-8962: Split test case URL: https://github.com/apache/lucene-solr/pull/1313#issuecomment-595597021 I've left some comments in https://github.com/apache/lucene-solr/pull/1155. This is an a

[GitHub] [lucene-solr] dnhatn commented on issue #1319: LUCENE-9164: process all events before closing gracefully

dnhatn commented on issue #1319: LUCENE-9164: process all events before closing gracefully URL: https://github.com/apache/lucene-solr/pull/1319#issuecomment-595598568 Thanks, Simon. I will take a look at this tomorrow. This i

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit

dnhatn commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit URL: https://github.com/apache/lucene-solr/pull/1155#discussion_r388705156 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -3252,6

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit

dnhatn commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit URL: https://github.com/apache/lucene-solr/pull/1155#discussion_r388717615 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -3252,6

[GitHub] [lucene-solr] dnhatn commented on issue #1155: LUCENE-8962: Add ability to selectively merge on commit

dnhatn commented on issue #1155: LUCENE-8962: Add ability to selectively merge on commit URL: https://github.com/apache/lucene-solr/pull/1155#issuecomment-595607002 Hmm, I missed the fact that `mergeFinished` is executed under IndexWriter lock. I will dig into this again. Please ignore my

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit

dnhatn commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit URL: https://github.com/apache/lucene-solr/pull/1155#discussion_r388705514 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -3147,6

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit

dnhatn commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit URL: https://github.com/apache/lucene-solr/pull/1155#discussion_r388704872 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -3147,6

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit

dnhatn commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit URL: https://github.com/apache/lucene-solr/pull/1155#discussion_r388704872 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -3147,6

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit

dnhatn commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit URL: https://github.com/apache/lucene-solr/pull/1155#discussion_r388717615 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -3252,6

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit

dnhatn commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit URL: https://github.com/apache/lucene-solr/pull/1155#discussion_r388705514 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -3147,6

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit

dnhatn commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit URL: https://github.com/apache/lucene-solr/pull/1155#discussion_r388705156 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -3252,6

[GitHub] [lucene-solr] s1monw commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit

s1monw commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit URL: https://github.com/apache/lucene-solr/pull/1155#discussion_r388786805 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriterEvents.java ## @@ -0

[GitHub] [lucene-solr] ywelsch opened a new pull request #1321: LUCENE-9264: Remove SimpleFSDirectory in favor of NIOFSDirectory

ywelsch opened a new pull request #1321: LUCENE-9264: Remove SimpleFSDirectory in favor of NIOFSDirectory URL: https://github.com/apache/lucene-solr/pull/1321 This is an automated message from the Apache Git Service. To resp

[GitHub] [lucene-solr] janhoy opened a new pull request #1322: Remove some unused lines from addBackcompatIndexes.py related to svn

janhoy opened a new pull request #1322: Remove some unused lines from addBackcompatIndexes.py related to svn URL: https://github.com/apache/lucene-solr/pull/1322 This is dead code in a python script. We don't use svn anymore. I did not add corresponding git commands since the releaseWizard

[GitHub] [lucene-solr] janhoy opened a new pull request #1324: LUCENE-9033 Update ReleaseWizard for new website instructions

janhoy opened a new pull request #1324: LUCENE-9033 Update ReleaseWizard for new website instructions URL: https://github.com/apache/lucene-solr/pull/1324 See https://issues.apache.org/jira/browse/LUCENE-9033 This is still work in progress ---

[GitHub] [lucene-solr] ywelsch opened a new pull request #1323: LUCENE-9265: Deprecate SimpleFSDirectory in favor of NIOFSDirectory

ywelsch opened a new pull request #1323: LUCENE-9265: Deprecate SimpleFSDirectory in favor of NIOFSDirectory URL: https://github.com/apache/lucene-solr/pull/1323 This is an automated message from the Apache Git Service. To r

[GitHub] [lucene-solr] rmuir commented on issue #1321: LUCENE-9264: Remove SimpleFSDirectory in favor of NIOFSDirectory

rmuir commented on issue #1321: LUCENE-9264: Remove SimpleFSDirectory in favor of NIOFSDirectory URL: https://github.com/apache/lucene-solr/pull/1321#issuecomment-595695483 Looks great! Thanks for doing this cleanup. will merge it shortly...

[GitHub] [lucene-solr] s1monw opened a new pull request #1325: Consolidated process event logic after CRUD action

s1monw opened a new pull request #1325: Consolidated process event logic after CRUD action URL: https://github.com/apache/lucene-solr/pull/1325 Today we have duplicated logic on how to convert a seqNo into a real seqNo and process events based on this. This change consolidated the logic

[GitHub] [lucene-solr] janhoy opened a new pull request #1326: Remove unused scripts in dev-tools folder

janhoy opened a new pull request #1326: Remove unused scripts in dev-tools folder URL: https://github.com/apache/lucene-solr/pull/1326 Cleanup of unused scripts. Please validate my assumption that this is not in use :) This

[GitHub] [lucene-solr] asfgit closed pull request #1320: LUCENE-9257: Always keep FST off-heap. Remove FSTLoadMode and Reader attributes.

asfgit closed pull request #1320: LUCENE-9257: Always keep FST off-heap. Remove FSTLoadMode and Reader attributes. URL: https://github.com/apache/lucene-solr/pull/1320 This is an automated message from the Apache Git Service

[GitHub] [lucene-solr] asfgit closed pull request #1321: LUCENE-9264: Remove SimpleFSDirectory in favor of NIOFSDirectory

asfgit closed pull request #1321: LUCENE-9264: Remove SimpleFSDirectory in favor of NIOFSDirectory URL: https://github.com/apache/lucene-solr/pull/1321 This is an automated message from the Apache Git Service. To respond to

[GitHub] [lucene-solr] rmuir merged pull request #1323: LUCENE-9265: Deprecate SimpleFSDirectory in favor of NIOFSDirectory

rmuir merged pull request #1323: LUCENE-9265: Deprecate SimpleFSDirectory in favor of NIOFSDirectory URL: https://github.com/apache/lucene-solr/pull/1323 This is an automated message from the Apache Git Service. To respond t

[GitHub] [lucene-solr] janhoy closed pull request #880: Tweak header format.

janhoy closed pull request #880: Tweak header format. URL: https://github.com/apache/lucene-solr/pull/880 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [lucene-solr] janhoy commented on issue #404: Comment to explain how to use URLClassifyProcessorFactory

janhoy commented on issue #404: Comment to explain how to use URLClassifyProcessorFactory URL: https://github.com/apache/lucene-solr/pull/404#issuecomment-595723278 @ohtwadi Do you want to address the review comment so we can merge this?

[GitHub] [lucene-solr] noblepaul opened a new pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data

noblepaul opened a new pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [lucene-solr] bruno-roustant opened a new pull request #1328: LUCENE-9257: Always keep FST off-heap. Remove SegmentReadState.openedFromWriter.

bruno-roustant opened a new pull request #1328: LUCENE-9257: Always keep FST off-heap. Remove SegmentReadState.openedFromWriter. URL: https://github.com/apache/lucene-solr/pull/1328 This is an automated message from the Apac

[GitHub] [lucene-solr] bruno-roustant closed pull request #1305: LUCENE-9257: Make FSTLoadMode enum not BlockTree specific.

bruno-roustant closed pull request #1305: LUCENE-9257: Make FSTLoadMode enum not BlockTree specific. URL: https://github.com/apache/lucene-solr/pull/1305 This is an automated message from the Apache Git Service. To respond t

[GitHub] [lucene-solr] bruno-roustant commented on issue #1305: LUCENE-9257: Make FSTLoadMode enum not BlockTree specific.

bruno-roustant commented on issue #1305: LUCENE-9257: Make FSTLoadMode enum not BlockTree specific. URL: https://github.com/apache/lucene-solr/pull/1305#issuecomment-595761243 Replaced by https://github.com/apache/lucene-solr/pull/1320 to always keep FST off-heap.

[GitHub] [lucene-solr] sigram opened a new pull request #1329: SOLR-14275: Policy calculations are very slow for large clusters and large operations

sigram opened a new pull request #1329: SOLR-14275: Policy calculations are very slow for large clusters and large operations URL: https://github.com/apache/lucene-solr/pull/1329 # Description See JIRA for the explanation of the problem. # Solution Try and r

[GitHub] [lucene-solr] dnhatn edited a comment on issue #1155: LUCENE-8962: Add ability to selectively merge on commit

dnhatn edited a comment on issue #1155: LUCENE-8962: Add ability to selectively merge on commit URL: https://github.com/apache/lucene-solr/pull/1155#issuecomment-595607002 I missed the fact that `mergeFinished` is executed under IndexWriter lock. I will dig into this again. Please ignore m

[GitHub] [lucene-solr] bruno-roustant closed pull request #1328: LUCENE-9257: Always keep FST off-heap. Remove SegmentReadState.openedFromWriter.

bruno-roustant closed pull request #1328: LUCENE-9257: Always keep FST off-heap. Remove SegmentReadState.openedFromWriter. URL: https://github.com/apache/lucene-solr/pull/1328 This is an automated message from the Apache Git

[GitHub] [lucene-solr] bruno-roustant commented on issue #1301: LUCENE-9254: UniformSplit supports FST off-heap.

bruno-roustant commented on issue #1301: LUCENE-9254: UniformSplit supports FST off-heap. URL: https://github.com/apache/lucene-solr/pull/1301#issuecomment-595856255 Updated after LUCENE-9257 removed FSTLoadMode. Now FST is off-heap by default. It is possible to force it with a boolean in

[GitHub] [lucene-solr] atris commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

atris commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1294#discussion_r389038791 ## File path: lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java #

[GitHub] [lucene-solr] atris commented on issue #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

atris commented on issue #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1294#issuecomment-595884480 @jpountz Raised another iteration, please let me know your thoughts and comments. ---

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1319: LUCENE-9164: process all events before closing gracefully

dnhatn commented on a change in pull request #1319: LUCENE-9164: process all events before closing gracefully URL: https://github.com/apache/lucene-solr/pull/1319#discussion_r389028879 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -299,7

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1319: LUCENE-9164: process all events before closing gracefully

dnhatn commented on a change in pull request #1319: LUCENE-9164: process all events before closing gracefully URL: https://github.com/apache/lucene-solr/pull/1319#discussion_r389028289 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -299,7

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1319: LUCENE-9164: process all events before closing gracefully

dnhatn commented on a change in pull request #1319: LUCENE-9164: process all events before closing gracefully URL: https://github.com/apache/lucene-solr/pull/1319#discussion_r389028473 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -299,7

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1319: LUCENE-9164: process all events before closing gracefully

dnhatn commented on a change in pull request #1319: LUCENE-9164: process all events before closing gracefully URL: https://github.com/apache/lucene-solr/pull/1319#discussion_r389029514 ## File path: lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java ## @@ -3

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1319: LUCENE-9164: process all events before closing gracefully

dnhatn commented on a change in pull request #1319: LUCENE-9164: process all events before closing gracefully URL: https://github.com/apache/lucene-solr/pull/1319#discussion_r389028879 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -299,7

[GitHub] [lucene-solr] dnhatn commented on issue #1215: LUCENE-9164: Ignore ACE on tragic event if IW is closed

dnhatn commented on issue #1215: LUCENE-9164: Ignore ACE on tragic event if IW is closed URL: https://github.com/apache/lucene-solr/pull/1215#issuecomment-595913520 Closes in favor of https://github.com/apache/lucene-solr/pull/1319. -

[GitHub] [lucene-solr] dnhatn closed pull request #1215: LUCENE-9164: Ignore ACE on tragic event if IW is closed

dnhatn closed pull request #1215: LUCENE-9164: Ignore ACE on tragic event if IW is closed URL: https://github.com/apache/lucene-solr/pull/1215 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [lucene-solr] beettlle commented on a change in pull request #1297: SOLR-14253 Replace various sleep calls with ZK waits

beettlle commented on a change in pull request #1297: SOLR-14253 Replace various sleep calls with ZK waits URL: https://github.com/apache/lucene-solr/pull/1297#discussion_r389132693 ## File path: solr/core/src/java/org/apache/solr/cloud/ZkController.java ## @@ -1684,58 +16

[GitHub] [lucene-solr] madrob commented on a change in pull request #1297: SOLR-14253 Replace various sleep calls with ZK waits

madrob commented on a change in pull request #1297: SOLR-14253 Replace various sleep calls with ZK waits URL: https://github.com/apache/lucene-solr/pull/1297#discussion_r389193738 ## File path: solr/core/src/java/org/apache/solr/cloud/ZkController.java ## @@ -1684,58 +1685

[GitHub] [lucene-solr] beettlle commented on a change in pull request #1297: SOLR-14253 Replace various sleep calls with ZK waits

beettlle commented on a change in pull request #1297: SOLR-14253 Replace various sleep calls with ZK waits URL: https://github.com/apache/lucene-solr/pull/1297#discussion_r389208349 ## File path: solr/core/src/java/org/apache/solr/cloud/ZkController.java ## @@ -1684,58 +16

[GitHub] [lucene-solr] chatman commented on issue #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data

chatman commented on issue #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#issuecomment-596057142 This must have the reference guide changes too. This is an autom

[GitHub] [lucene-solr] iverase commented on issue #1318: LUCENE-9263: Fix wrong transformation of distance in meters to radians in Geo3DPoint

iverase commented on issue #1318: LUCENE-9263: Fix wrong transformation of distance in meters to radians in Geo3DPoint URL: https://github.com/apache/lucene-solr/pull/1318#issuecomment-596068243 @nknize, I had another iteration and decided to go back to one constructor that defines the sem

[GitHub] [lucene-solr] plperron opened a new pull request #1330: LUCENE-9267 Replace getQueryBuildTime time unit from ms to ns

plperron opened a new pull request #1330: LUCENE-9267 Replace getQueryBuildTime time unit from ms to ns URL: https://github.com/apache/lucene-solr/pull/1330 # Description Change the documentation of getQueryBuildTime to report nanoseconds instead of milliseconds. # Solution

[GitHub] [lucene-solr] dnhatn opened a new pull request #1331: LUCENE-9268: Add some random tests to IndexWriter

dnhatn opened a new pull request #1331: LUCENE-9268: Add some random tests to IndexWriter URL: https://github.com/apache/lucene-solr/pull/1331 Add some tests that perform a set of operations randomly and concurrently on IndexWriter.

[GitHub] [lucene-solr] msokolov commented on a change in pull request #1331: LUCENE-9268: Add some random tests to IndexWriter

msokolov commented on a change in pull request #1331: LUCENE-9268: Add some random tests to IndexWriter URL: https://github.com/apache/lucene-solr/pull/1331#discussion_r389304104 ## File path: lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java ## @@ -3775,4

[GitHub] [lucene-solr] msokolov commented on a change in pull request #1331: LUCENE-9268: Add some random tests to IndexWriter

msokolov commented on a change in pull request #1331: LUCENE-9268: Add some random tests to IndexWriter URL: https://github.com/apache/lucene-solr/pull/1331#discussion_r389304196 ## File path: lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java ## @@ -3775,4

[GitHub] [lucene-solr] dnhatn commented on issue #1331: LUCENE-9268: Add some random tests to IndexWriter

dnhatn commented on issue #1331: LUCENE-9268: Add some random tests to IndexWriter URL: https://github.com/apache/lucene-solr/pull/1331#issuecomment-596128237 @msokolov Thanks for looking. I pushed https://github.com/apache/lucene-solr/pull/1331/commits/9e9b53271372d6a884b8de019c4aec7fed7d

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data

tflobbe commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r389306880 ## File path: solr/core/src/test/org/apache/solr/handler/admin/ZookeeperStatusHandlerTest.java ###

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data

tflobbe commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r389306592 ## File path: solr/core/src/java/org/apache/solr/handler/admin/ZkRead.java ## @@ -0,0 +1,117 @

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data

tflobbe commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r389306574 ## File path: solr/core/src/java/org/apache/solr/handler/admin/ZkRead.java ## @@ -0,0 +1,117 @

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data

tflobbe commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r389307304 ## File path: solr/core/src/test/org/apache/solr/handler/admin/ZookeeperStatusHandlerTest.java ###

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data

tflobbe commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r389306716 ## File path: solr/core/src/java/org/apache/solr/handler/admin/ZkRead.java ## @@ -0,0 +1,117 @

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data

tflobbe commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r389306787 ## File path: solr/core/src/java/org/apache/solr/handler/admin/ZkRead.java ## @@ -0,0 +1,117 @

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data

tflobbe commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r389306764 ## File path: solr/core/src/java/org/apache/solr/handler/admin/ZkRead.java ## @@ -0,0 +1,117 @

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data

tflobbe commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r389306852 ## File path: solr/core/src/test/org/apache/solr/handler/admin/ZookeeperStatusHandlerTest.java ###

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data

tflobbe commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r389306671 ## File path: solr/core/src/java/org/apache/solr/handler/admin/ZkRead.java ## @@ -0,0 +1,117 @

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data

tflobbe commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r389307090 ## File path: solr/core/src/java/org/apache/solr/handler/admin/ZkRead.java ## @@ -0,0 +1,117 @

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #1304: LUCENE-9242: generate javadocs by calling Ant javadoc task

mocobeta commented on a change in pull request #1304: LUCENE-9242: generate javadocs by calling Ant javadoc task URL: https://github.com/apache/lucene-solr/pull/1304#discussion_r389316120 ## File path: gradle/invoke-javadoc.gradle ## @@ -0,0 +1,335 @@ +/* + * Licensed to t

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #1304: LUCENE-9242: generate javadocs by calling Ant javadoc task

mocobeta commented on a change in pull request #1304: LUCENE-9242: generate javadocs by calling Ant javadoc task URL: https://github.com/apache/lucene-solr/pull/1304#discussion_r389316224 ## File path: gradle/invoke-javadoc.gradle ## @@ -0,0 +1,335 @@ +/* + * Licensed to t

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #1304: LUCENE-9242: generate javadocs by calling Ant javadoc task

mocobeta commented on a change in pull request #1304: LUCENE-9242: generate javadocs by calling Ant javadoc task URL: https://github.com/apache/lucene-solr/pull/1304#discussion_r389316429 ## File path: gradle/invoke-javadoc.gradle ## @@ -0,0 +1,335 @@ +/* + * Licensed to t

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #1304: LUCENE-9242: generate javadocs by calling Ant javadoc task

mocobeta commented on a change in pull request #1304: LUCENE-9242: generate javadocs by calling Ant javadoc task URL: https://github.com/apache/lucene-solr/pull/1304#discussion_r389316645 ## File path: gradle/invoke-javadoc.gradle ## @@ -0,0 +1,335 @@ +/* + * Licensed to t

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #1304: LUCENE-9242: generate javadocs by calling Ant javadoc task

mocobeta commented on a change in pull request #1304: LUCENE-9242: generate javadocs by calling Ant javadoc task URL: https://github.com/apache/lucene-solr/pull/1304#discussion_r389316672 ## File path: gradle/invoke-javadoc.gradle ## @@ -0,0 +1,335 @@ +/* + * Licensed to t

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #1304: LUCENE-9242: generate javadocs by calling Ant javadoc task

mocobeta commented on a change in pull request #1304: LUCENE-9242: generate javadocs by calling Ant javadoc task URL: https://github.com/apache/lucene-solr/pull/1304#discussion_r389317438 ## File path: gradle/invoke-javadoc.gradle ## @@ -0,0 +1,335 @@ +/* + * Licensed to t

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #1304: LUCENE-9242: generate javadocs by calling Ant javadoc task

mocobeta commented on a change in pull request #1304: LUCENE-9242: generate javadocs by calling Ant javadoc task URL: https://github.com/apache/lucene-solr/pull/1304#discussion_r389318421 ## File path: gradle/invoke-javadoc.gradle ## @@ -0,0 +1,335 @@ +/* + * Licensed to t

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #1304: LUCENE-9242: generate javadocs by calling Ant javadoc task

mocobeta commented on a change in pull request #1304: LUCENE-9242: generate javadocs by calling Ant javadoc task URL: https://github.com/apache/lucene-solr/pull/1304#discussion_r389318980 ## File path: gradle/invoke-javadoc.gradle ## @@ -0,0 +1,335 @@ +/* + * Licensed to t

<    3   4   5   6   7   8   9   10   11   12   >