[GitHub] [lucene-solr] morissm commented on a change in pull request #417: Fixes SOLR-12550: ConcurrentUpdateSolrClient doesn't respect timeouts for commits and optimize

morissm commented on a change in pull request #417: Fixes SOLR-12550: ConcurrentUpdateSolrClient doesn't respect timeouts for commits and optimize URL: https://github.com/apache/lucene-solr/pull/417#discussion_r380969820 ## File path: solr/solrj/src/java/org/apache/solr/client/solr

[GitHub] [lucene-solr] morissm commented on a change in pull request #417: Fixes SOLR-12550: ConcurrentUpdateSolrClient doesn't respect timeouts for commits and optimize

morissm commented on a change in pull request #417: Fixes SOLR-12550: ConcurrentUpdateSolrClient doesn't respect timeouts for commits and optimize URL: https://github.com/apache/lucene-solr/pull/417#discussion_r380970071 ## File path: solr/solrj/src/test/org/apache/solr/client/solr

[GitHub] [lucene-solr] morissm commented on issue #417: Fixes SOLR-12550: ConcurrentUpdateSolrClient doesn't respect timeouts for commits and optimize

morissm commented on issue #417: Fixes SOLR-12550: ConcurrentUpdateSolrClient doesn't respect timeouts for commits and optimize URL: https://github.com/apache/lucene-solr/pull/417#issuecomment-587937426 > So I think this is built off of a really old master. We should probably make sure the

[GitHub] [lucene-solr] CaoManhDat commented on a change in pull request #1167: SOLR-13845: DELETEREPLICA API by count and type

CaoManhDat commented on a change in pull request #1167: SOLR-13845: DELETEREPLICA API by count and type URL: https://github.com/apache/lucene-solr/pull/1167#discussion_r380999083 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/request/CollectionAdminRequest.java ###

[GitHub] [lucene-solr] CaoManhDat commented on a change in pull request #1167: SOLR-13845: DELETEREPLICA API by count and type

CaoManhDat commented on a change in pull request #1167: SOLR-13845: DELETEREPLICA API by count and type URL: https://github.com/apache/lucene-solr/pull/1167#discussion_r380999083 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/request/CollectionAdminRequest.java ###

[GitHub] [lucene-solr] CaoManhDat commented on a change in pull request #1167: SOLR-13845: DELETEREPLICA API by count and type

CaoManhDat commented on a change in pull request #1167: SOLR-13845: DELETEREPLICA API by count and type URL: https://github.com/apache/lucene-solr/pull/1167#discussion_r380999227 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/request/CollectionAdminRequest.java ###

[GitHub] [lucene-solr] CaoManhDat commented on a change in pull request #1167: SOLR-13845: DELETEREPLICA API by count and type

CaoManhDat commented on a change in pull request #1167: SOLR-13845: DELETEREPLICA API by count and type URL: https://github.com/apache/lucene-solr/pull/1167#discussion_r380999461 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/request/CollectionAdminRequest.java ###

[GitHub] [lucene-solr] CaoManhDat commented on a change in pull request #1167: SOLR-13845: DELETEREPLICA API by count and type

CaoManhDat commented on a change in pull request #1167: SOLR-13845: DELETEREPLICA API by count and type URL: https://github.com/apache/lucene-solr/pull/1167#discussion_r381002805 ## File path: solr/solr-ref-guide/src/replica-management.adoc ## @@ -212,6 +212,11 @@ The numb

[GitHub] [lucene-solr] CaoManhDat commented on a change in pull request #1167: SOLR-13845: DELETEREPLICA API by count and type

CaoManhDat commented on a change in pull request #1167: SOLR-13845: DELETEREPLICA API by count and type URL: https://github.com/apache/lucene-solr/pull/1167#discussion_r381000486 ## File path: solr/solr-ref-guide/src/replica-management.adoc ## @@ -212,6 +212,11 @@ The numb

[GitHub] [lucene-solr] CaoManhDat commented on a change in pull request #1167: SOLR-13845: DELETEREPLICA API by count and type

CaoManhDat commented on a change in pull request #1167: SOLR-13845: DELETEREPLICA API by count and type URL: https://github.com/apache/lucene-solr/pull/1167#discussion_r381003552 ## File path: solr/core/src/java/org/apache/solr/cloud/api/collections/DeleteReplicaCmd.java #

[GitHub] [lucene-solr] CaoManhDat commented on a change in pull request #1167: SOLR-13845: DELETEREPLICA API by count and type

CaoManhDat commented on a change in pull request #1167: SOLR-13845: DELETEREPLICA API by count and type URL: https://github.com/apache/lucene-solr/pull/1167#discussion_r381007584 ## File path: solr/core/src/test/org/apache/solr/cloud/DeleteReplicaTest.java ## @@ -170,6 +17

[GitHub] [lucene-solr] CaoManhDat commented on a change in pull request #1167: SOLR-13845: DELETEREPLICA API by count and type

CaoManhDat commented on a change in pull request #1167: SOLR-13845: DELETEREPLICA API by count and type URL: https://github.com/apache/lucene-solr/pull/1167#discussion_r381005466 ## File path: solr/core/src/test/org/apache/solr/cloud/DeleteReplicaTest.java ## @@ -170,6 +17

[GitHub] [lucene-solr] CaoManhDat commented on a change in pull request #1167: SOLR-13845: DELETEREPLICA API by count and type

CaoManhDat commented on a change in pull request #1167: SOLR-13845: DELETEREPLICA API by count and type URL: https://github.com/apache/lucene-solr/pull/1167#discussion_r380999141 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/request/CollectionAdminRequest.java ###

[GitHub] [lucene-solr] CaoManhDat commented on a change in pull request #1167: SOLR-13845: DELETEREPLICA API by count and type

CaoManhDat commented on a change in pull request #1167: SOLR-13845: DELETEREPLICA API by count and type URL: https://github.com/apache/lucene-solr/pull/1167#discussion_r381005728 ## File path: solr/core/src/test/org/apache/solr/cloud/DeleteReplicaTest.java ## @@ -170,6 +17

[GitHub] [lucene-solr] CaoManhDat commented on a change in pull request #1167: SOLR-13845: DELETEREPLICA API by count and type

CaoManhDat commented on a change in pull request #1167: SOLR-13845: DELETEREPLICA API by count and type URL: https://github.com/apache/lucene-solr/pull/1167#discussion_r380999688 ## File path: solr/core/src/java/org/apache/solr/cloud/api/collections/DeleteReplicaCmd.java #

[GitHub] [lucene-solr] CaoManhDat commented on a change in pull request #1167: SOLR-13845: DELETEREPLICA API by count and type

CaoManhDat commented on a change in pull request #1167: SOLR-13845: DELETEREPLICA API by count and type URL: https://github.com/apache/lucene-solr/pull/1167#discussion_r381005608 ## File path: solr/core/src/test/org/apache/solr/cloud/DeleteReplicaTest.java ## @@ -170,6 +17

[GitHub] [lucene-solr] dnhatn commented on issue #1263: LUCENE-9228: Sort dv updates by terms by applying

dnhatn commented on issue #1263: LUCENE-9228: Sort dv updates by terms by applying URL: https://github.com/apache/lucene-solr/pull/1263#issuecomment-588001843 I ran a few benchmarks with the nyc_taxis dataset. The refresh performance in the latest patch is decreased around 2% comparing to

[GitHub] [lucene-site] uschindler commented on issue #13: Prevent caching surprises for CSS, JS

uschindler commented on issue #13: Prevent caching surprises for CSS, JS URL: https://github.com/apache/lucene-site/pull/13#issuecomment-588080295 Looks good. In the future we may simply add some additional python that creates a hash out of the static folder. For now it's good. You just hav

[GitHub] [lucene-site] uschindler edited a comment on issue #13: Prevent caching surprises for CSS, JS

uschindler edited a comment on issue #13: Prevent caching surprises for CSS, JS URL: https://github.com/apache/lucene-site/pull/13#issuecomment-588080295 Looks good. In the future we may simply add some additional python that creates a hash out of the static folder. For now it's good. You j

[GitHub] [lucene-site] uschindler edited a comment on issue #13: Prevent caching surprises for CSS, JS

uschindler edited a comment on issue #13: Prevent caching surprises for CSS, JS URL: https://github.com/apache/lucene-site/pull/13#issuecomment-588080295 Looks good. In the future we may simply add some additional python that creates a hash out of the static folder. For now it's good. You j

[GitHub] [lucene-site] janhoy commented on issue #13: Prevent caching surprises for CSS, JS

janhoy commented on issue #13: Prevent caching surprises for CSS, JS URL: https://github.com/apache/lucene-site/pull/13#issuecomment-588105140 > Hashing of directories as pypi: https://pypi.org/project/checksumdir/ This was a nice solution and easy to implement. Now it is automatic. B

[GitHub] [lucene-site] janhoy merged pull request #13: Prevent caching surprises for CSS, JS

janhoy merged pull request #13: Prevent caching surprises for CSS, JS URL: https://github.com/apache/lucene-site/pull/13 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [lucene-solr] shuson closed pull request #1036: SOLR-13967: Update query.css to make query form sticky on the top while scrolling page

shuson closed pull request #1036: SOLR-13967: Update query.css to make query form sticky on the top while scrolling page URL: https://github.com/apache/lucene-solr/pull/1036 This is an automated message from the Apache Git S

[GitHub] [lucene-solr] s1monw commented on issue #1263: LUCENE-9228: Sort dv updates by terms by applying

s1monw commented on issue #1263: LUCENE-9228: Sort dv updates by terms by applying URL: https://github.com/apache/lucene-solr/pull/1263#issuecomment-588194409 This is an interesting improvement. I had a similar [change](https://github.com/s1monw/lucene-solr/commit/f886d0cee9cbda13845b96776

[GitHub] [lucene-solr] iverase merged pull request #587: LUCENE-8707: Add LatLonShape and XYShape distance query

iverase merged pull request #587: LUCENE-8707: Add LatLonShape and XYShape distance query URL: https://github.com/apache/lucene-solr/pull/587 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [lucene-solr] dnhatn commented on issue #1263: LUCENE-9228: Sort dv updates by terms by applying

dnhatn commented on issue #1263: LUCENE-9228: Sort dv updates by terms by applying URL: https://github.com/apache/lucene-solr/pull/1263#issuecomment-588405996 @s1monw Thanks for looking. Your patch is very similar to this PR :). I like the SortState class in your change and use it in this

[GitHub] [lucene-solr] mbwaheed commented on a change in pull request #1223: SOLR-14213: Configuring Solr Cloud to use Shared Storage

mbwaheed commented on a change in pull request #1223: SOLR-14213: Configuring Solr Cloud to use Shared Storage URL: https://github.com/apache/lucene-solr/pull/1223#discussion_r381679795 ## File path: solr/core/src/test/org/apache/solr/cloud/api/collections/SimpleSharedStorageCollec

[GitHub] [lucene-solr] mbwaheed commented on a change in pull request #1223: SOLR-14213: Configuring Solr Cloud to use Shared Storage

mbwaheed commented on a change in pull request #1223: SOLR-14213: Configuring Solr Cloud to use Shared Storage URL: https://github.com/apache/lucene-solr/pull/1223#discussion_r381674933 ## File path: solr/core/src/java/org/apache/solr/store/shared/SharedStoreManager.java #

[GitHub] [lucene-solr] mbwaheed commented on a change in pull request #1223: SOLR-14213: Configuring Solr Cloud to use Shared Storage

mbwaheed commented on a change in pull request #1223: SOLR-14213: Configuring Solr Cloud to use Shared Storage URL: https://github.com/apache/lucene-solr/pull/1223#discussion_r381679795 ## File path: solr/core/src/test/org/apache/solr/cloud/api/collections/SimpleSharedStorageCollec

[GitHub] [lucene-solr] shalinmangar merged pull request #417: Fixes SOLR-12550: ConcurrentUpdateSolrClient doesn't respect timeouts for commits and optimize

shalinmangar merged pull request #417: Fixes SOLR-12550: ConcurrentUpdateSolrClient doesn't respect timeouts for commits and optimize URL: https://github.com/apache/lucene-solr/pull/417 This is an automated message from the

[GitHub] [lucene-solr] noblepaul opened a new pull request #1266: SOLR-14270 export command to have an option to write to a zip file

noblepaul opened a new pull request #1266: SOLR-14270 export command to have an option to write to a zip file URL: https://github.com/apache/lucene-solr/pull/1266 This is an automated message from the Apache Git Service. To

[GitHub] [lucene-solr] mocobeta opened a new pull request #1267: LUCENE-9201: Add missing javadocs check task

mocobeta opened a new pull request #1267: LUCENE-9201: Add missing javadocs check task URL: https://github.com/apache/lucene-solr/pull/1267 # Description This PR adds missing Javadocs check to gradle build (i.e., an equivalent to Ant build's "check-missing-javadocs" macro). #

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1267: LUCENE-9201: Add missing javadocs check task

dweiss commented on a change in pull request #1267: LUCENE-9201: Add missing javadocs check task URL: https://github.com/apache/lucene-solr/pull/1267#discussion_r382173351 ## File path: gradle/validation/missing-docs-check.gradle ## @@ -0,0 +1,124 @@ +/* + * Licensed to th

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1267: LUCENE-9201: Add missing javadocs check task

dweiss commented on a change in pull request #1267: LUCENE-9201: Add missing javadocs check task URL: https://github.com/apache/lucene-solr/pull/1267#discussion_r382174006 ## File path: gradle/validation/missing-docs-check.gradle ## @@ -0,0 +1,124 @@ +/* + * Licensed to th

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1267: LUCENE-9201: Add missing javadocs check task

dweiss commented on a change in pull request #1267: LUCENE-9201: Add missing javadocs check task URL: https://github.com/apache/lucene-solr/pull/1267#discussion_r382173652 ## File path: gradle/validation/missing-docs-check.gradle ## @@ -0,0 +1,124 @@ +/* + * Licensed to th

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1267: LUCENE-9201: Add missing javadocs check task

dweiss commented on a change in pull request #1267: LUCENE-9201: Add missing javadocs check task URL: https://github.com/apache/lucene-solr/pull/1267#discussion_r382174718 ## File path: gradle/validation/missing-docs-check.gradle ## @@ -0,0 +1,124 @@ +/* + * Licensed to th

[GitHub] [lucene-solr] dnhatn commented on issue #1263: LUCENE-9228: Sort dv updates by terms by applying

dnhatn commented on issue #1263: LUCENE-9228: Sort dv updates by terms by applying URL: https://github.com/apache/lucene-solr/pull/1263#issuecomment-589238374 @jpountz @s1monw @juanka588 Thank you for reviewing :). This is an

[GitHub] [lucene-solr] dnhatn closed pull request #1263: LUCENE-9228: Sort dv updates by terms by applying

dnhatn closed pull request #1263: LUCENE-9228: Sort dv updates by terms by applying URL: https://github.com/apache/lucene-solr/pull/1263 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [lucene-site] janhoy merged pull request #14: LUCENE-9223 License headers

janhoy merged pull request #14: LUCENE-9223 License headers URL: https://github.com/apache/lucene-site/pull/14 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [lucene-solr] anshumg opened a new pull request #1268: SOLR-14271: Remove duplicate async id check meant for pre Solr 8 versions

anshumg opened a new pull request #1268: SOLR-14271: Remove duplicate async id check meant for pre Solr 8 versions URL: https://github.com/apache/lucene-solr/pull/1268 This is an automated message from the Apache Git Service

[GitHub] [lucene-solr] anshumg opened a new pull request #1269: Remove autoReplicaFailoverBadNodeExpiration and autoReplicaFailoverWorkLoopDelay for 9.0 as it was deprecated in 7.1

anshumg opened a new pull request #1269: Remove autoReplicaFailoverBadNodeExpiration and autoReplicaFailoverWorkLoopDelay for 9.0 as it was deprecated in 7.1 URL: https://github.com/apache/lucene-solr/pull/1269 This is an a

[GitHub] [lucene-solr] anshumg commented on a change in pull request #1266: SOLR-14270 export command to have an option to write to a zip file

anshumg commented on a change in pull request #1266: SOLR-14270 export command to have an option to write to a zip file URL: https://github.com/apache/lucene-solr/pull/1266#discussion_r382283413 ## File path: solr/core/src/java/org/apache/solr/util/ExportTool.java ## @@ -3

[GitHub] [lucene-solr] bruno-roustant opened a new pull request #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader.

bruno-roustant opened a new pull request #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader. URL: https://github.com/apache/lucene-solr/pull/1270 New version of TermsEnum intersect for UniformSplit. It is 70% more efficient than the previous version for FuzzyQuery. Compare

[GitHub] [lucene-solr] anshumg opened a new pull request #1271: LUCENE-9155: Add Apache License header to the Kuromoji dictionary compilation

anshumg opened a new pull request #1271: LUCENE-9155: Add Apache License header to the Kuromoji dictionary compilation URL: https://github.com/apache/lucene-solr/pull/1271 This is an automated message from the Apache Git Ser

[GitHub] [lucene-solr] anshumg merged pull request #1271: LUCENE-9155: Add Apache License header to the Kuromoji dictionary compilation

anshumg merged pull request #1271: LUCENE-9155: Add Apache License header to the Kuromoji dictionary compilation URL: https://github.com/apache/lucene-solr/pull/1271 This is an automated message from the Apache Git Service.

[GitHub] [lucene-solr] madrob commented on issue #1268: SOLR-14271: Remove duplicate async id check meant for pre Solr 8 versions

madrob commented on issue #1268: SOLR-14271: Remove duplicate async id check meant for pre Solr 8 versions URL: https://github.com/apache/lucene-solr/pull/1268#issuecomment-589397814 LGTM This is an automated message from the

[GitHub] [lucene-solr] anshumg commented on issue #1268: SOLR-14271: Remove duplicate async id check meant for pre Solr 8 versions

anshumg commented on issue #1268: SOLR-14271: Remove duplicate async id check meant for pre Solr 8 versions URL: https://github.com/apache/lucene-solr/pull/1268#issuecomment-589401448 Fixed the precommit issue that was introduced by another commit on master. The failure here shouldn't be a

[GitHub] [lucene-solr] anshumg merged pull request #1268: SOLR-14271: Remove duplicate async id check meant for pre Solr 8 versions

anshumg merged pull request #1268: SOLR-14271: Remove duplicate async id check meant for pre Solr 8 versions URL: https://github.com/apache/lucene-solr/pull/1268 This is an automated message from the Apache Git Service. To r

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1266: SOLR-14270 export command to have an option to write to a zip file

noblepaul commented on a change in pull request #1266: SOLR-14270 export command to have an option to write to a zip file URL: https://github.com/apache/lucene-solr/pull/1266#discussion_r382324127 ## File path: solr/core/src/java/org/apache/solr/util/ExportTool.java ## @@

[GitHub] [lucene-solr] noblepaul merged pull request #1266: SOLR-14270 export command to have an option to write to a zip file

noblepaul merged pull request #1266: SOLR-14270 export command to have an option to write to a zip file URL: https://github.com/apache/lucene-solr/pull/1266 This is an automated message from the Apache Git Service. To respon

[GitHub] [lucene-solr] noblepaul commented on issue #1266: SOLR-14270 export command to have an option to write to a zip file

noblepaul commented on issue #1266: SOLR-14270 export command to have an option to write to a zip file URL: https://github.com/apache/lucene-solr/pull/1266#issuecomment-589471256 SOLR-14270 export command to have an option to write to a zip file

[GitHub] [lucene-solr] dweiss commented on issue #1271: LUCENE-9155: Add Apache License header to the Kuromoji dictionary compilation

dweiss commented on issue #1271: LUCENE-9155: Add Apache License header to the Kuromoji dictionary compilation URL: https://github.com/apache/lucene-solr/pull/1271#issuecomment-589524095 Hmmm... I swear I've ran precommit before committing... but I reverted to that commit locally and see i

[GitHub] [lucene-solr] dweiss edited a comment on issue #1271: LUCENE-9155: Add Apache License header to the Kuromoji dictionary compilation

dweiss edited a comment on issue #1271: LUCENE-9155: Add Apache License header to the Kuromoji dictionary compilation URL: https://github.com/apache/lucene-solr/pull/1271#issuecomment-589524095 Hmmm... I swear I ran precommit before committing... but I reverted to that commit locally and s

[GitHub] [lucene-solr] iverase opened a new pull request #1272: LUCENE-9238: Add new XYPointField, queries ansd sorting capabilities

iverase opened a new pull request #1272: LUCENE-9238: Add new XYPointField, queries ansd sorting capabilities URL: https://github.com/apache/lucene-solr/pull/1272 Adaptation of LatLonPoint to generic cartesian space. This is

[GitHub] [lucene-solr] alessandrobenedetti commented on issue #357: [SOLR-12238] Synonym Queries boost

alessandrobenedetti commented on issue #357: [SOLR-12238] Synonym Queries boost URL: https://github.com/apache/lucene-solr/pull/357#issuecomment-589548183 Anything else I can do my side to close this pull request? This is an a

[GitHub] [lucene-solr] janhoy opened a new pull request #1273: SOLR-14114: Add WARN to Solr log that embedded ZK is not supported in prod

janhoy opened a new pull request #1273: SOLR-14114: Add WARN to Solr log that embedded ZK is not supported in prod URL: https://github.com/apache/lucene-solr/pull/1273 See https://issues.apache.org/jira/browse/SOLR-14114 This

[GitHub] [lucene-solr] jpountz commented on issue #1272: LUCENE-9238: Add new XYPointField, queries and sorting capabilities

jpountz commented on issue #1272: LUCENE-9238: Add new XYPointField, queries and sorting capabilities URL: https://github.com/apache/lucene-solr/pull/1272#issuecomment-589565033 Make sure to add a CHANGES entry too. This is a

[GitHub] [lucene-solr] janhoy merged pull request #1250: SOLR-14250 Fix error logging on Expect: 100-continue

janhoy merged pull request #1250: SOLR-14250 Fix error logging on Expect: 100-continue URL: https://github.com/apache/lucene-solr/pull/1250 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [lucene-solr] iverase merged pull request #1272: LUCENE-9238: Add new XYPointField, queries and sorting capabilities

iverase merged pull request #1272: LUCENE-9238: Add new XYPointField, queries and sorting capabilities URL: https://github.com/apache/lucene-solr/pull/1272 This is an automated message from the Apache Git Service. To respond

[GitHub] [lucene-solr] s1monw opened a new pull request #1274: LUCENE-9164: Prevent IW from closing gracefully if threads are still modifying

s1monw opened a new pull request #1274: LUCENE-9164: Prevent IW from closing gracefully if threads are still modifying URL: https://github.com/apache/lucene-solr/pull/1274 This is an alternative approach to https://github.com/apache/lucene-solr/pull/1215 It's still a rough cut and more up

[GitHub] [lucene-site] janhoy merged pull request #4: SOLR-13910 Add security pages news feeds for solr, core, and tlp

janhoy merged pull request #4: SOLR-13910 Add security pages news feeds for solr, core, and tlp URL: https://github.com/apache/lucene-site/pull/4 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [lucene-solr] dnhatn commented on issue #1274: LUCENE-9164: Prevent IW from closing gracefully if threads are still modifying

dnhatn commented on issue #1274: LUCENE-9164: Prevent IW from closing gracefully if threads are still modifying URL: https://github.com/apache/lucene-solr/pull/1274#issuecomment-589706428 @s1monw There are two related test failures: testHangDuringRollback and testCloseWithThreads. We might

[GitHub] [lucene-solr] mocobeta commented on issue #1267: LUCENE-9201: Add missing javadocs check task

mocobeta commented on issue #1267: LUCENE-9201: Add missing javadocs check task URL: https://github.com/apache/lucene-solr/pull/1267#issuecomment-589722060 Hi @dweiss I updated the task definitions. I defined one default task and the entry task for all projects, then tweaked the ":lucene

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader.

bruno-roustant commented on a change in pull request #1270: LUCENE-9237: Faster UniformSplit IntersectBlockReader. URL: https://github.com/apache/lucene-solr/pull/1270#discussion_r382682649 ## File path: lucene/core/src/java/org/apache/lucene/util/automaton/Operations.java ###

[GitHub] [lucene-solr] anshumg opened a new pull request #1275: SOLR-14271: Delete CollectionsAPIAsyncDistributedZkTest.testAsyncIdBackCompat as that is no longer required

anshumg opened a new pull request #1275: SOLR-14271: Delete CollectionsAPIAsyncDistributedZkTest.testAsyncIdBackCompat as that is no longer required URL: https://github.com/apache/lucene-solr/pull/1275 This is an automated

[GitHub] [lucene-solr] anshumg merged pull request #1275: SOLR-14271: Delete CollectionsAPIAsyncDistributedZkTest.testAsyncIdBackCompat as that is no longer required

anshumg merged pull request #1275: SOLR-14271: Delete CollectionsAPIAsyncDistributedZkTest.testAsyncIdBackCompat as that is no longer required URL: https://github.com/apache/lucene-solr/pull/1275 This is an automated messag

[GitHub] [lucene-solr] dweiss commented on issue #1267: LUCENE-9201: Add missing javadocs check task

dweiss commented on issue #1267: LUCENE-9201: Add missing javadocs check task URL: https://github.com/apache/lucene-solr/pull/1267#issuecomment-589769041 I'll take a look, @mocobeta You always seem to catch me just before I have to leave (time zones...). I'll try to review and clean up the

[GitHub] [lucene-solr] danmuzi opened a new pull request #1276: LUCENE-8954: refactor Nori analyzer

danmuzi opened a new pull request #1276: LUCENE-8954: refactor Nori analyzer URL: https://github.com/apache/lucene-solr/pull/1276 LUCENE-8954 is an issue created in August last year. (https://issues.apache.org/jira/browse/LUCENE-8954) The patch is already pushed in master branch. (htt

[GitHub] [lucene-solr] s1monw commented on issue #1274: LUCENE-9164: Prevent IW from closing gracefully if threads are still modifying

s1monw commented on issue #1274: LUCENE-9164: Prevent IW from closing gracefully if threads are still modifying URL: https://github.com/apache/lucene-solr/pull/1274#issuecomment-589987566 @dnhatn I did change some parts slightly to wait for threads after all resources are closed like merge

[GitHub] [lucene-solr] dnhatn edited a comment on issue #1274: LUCENE-9164: Prevent IW from closing gracefully if threads are still modifying

dnhatn edited a comment on issue #1274: LUCENE-9164: Prevent IW from closing gracefully if threads are still modifying URL: https://github.com/apache/lucene-solr/pull/1274#issuecomment-589706428 @s1monw There are two related test failures: testHangDuringRollback and testCloseWithThreads. W

[GitHub] [lucene-solr] yonik opened a new pull request #1277: SOLR-14278: draft test for data loss when leader dies during live split

yonik opened a new pull request #1277: SOLR-14278: draft test for data loss when leader dies during live split URL: https://github.com/apache/lucene-solr/pull/1277 Draft patch of the simplest test to show an issue (not for committing yet). See SOLR-14278 for details.

[GitHub] [lucene-solr] dweiss commented on issue #1267: LUCENE-9201: Add missing javadocs check task

dweiss commented on issue #1267: LUCENE-9201: Add missing javadocs check task URL: https://github.com/apache/lucene-solr/pull/1267#issuecomment-590050376 Hi Tomoko. I uploaded a cleaned up patch to jira - please take a look. I'll also add some comments on this pull request so that you know

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1267: LUCENE-9201: Add missing javadocs check task

dweiss commented on a change in pull request #1267: LUCENE-9201: Add missing javadocs check task URL: https://github.com/apache/lucene-solr/pull/1267#discussion_r382988664 ## File path: gradle/validation/missing-docs-check.gradle ## @@ -0,0 +1,118 @@ +/* + * Licensed to th

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1267: LUCENE-9201: Add missing javadocs check task

dweiss commented on a change in pull request #1267: LUCENE-9201: Add missing javadocs check task URL: https://github.com/apache/lucene-solr/pull/1267#discussion_r382988443 ## File path: gradle/validation/missing-docs-check.gradle ## @@ -0,0 +1,118 @@ +/* + * Licensed to th

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1267: LUCENE-9201: Add missing javadocs check task

dweiss commented on a change in pull request #1267: LUCENE-9201: Add missing javadocs check task URL: https://github.com/apache/lucene-solr/pull/1267#discussion_r382988576 ## File path: gradle/validation/missing-docs-check.gradle ## @@ -0,0 +1,118 @@ +/* + * Licensed to th

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1267: LUCENE-9201: Add missing javadocs check task

dweiss commented on a change in pull request #1267: LUCENE-9201: Add missing javadocs check task URL: https://github.com/apache/lucene-solr/pull/1267#discussion_r382988638 ## File path: gradle/validation/missing-docs-check.gradle ## @@ -0,0 +1,118 @@ +/* + * Licensed to th

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1267: LUCENE-9201: Add missing javadocs check task

dweiss commented on a change in pull request #1267: LUCENE-9201: Add missing javadocs check task URL: https://github.com/apache/lucene-solr/pull/1267#discussion_r382988460 ## File path: gradle/validation/missing-docs-check.gradle ## @@ -0,0 +1,118 @@ +/* + * Licensed to th

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1267: LUCENE-9201: Add missing javadocs check task

dweiss commented on a change in pull request #1267: LUCENE-9201: Add missing javadocs check task URL: https://github.com/apache/lucene-solr/pull/1267#discussion_r382988556 ## File path: gradle/validation/missing-docs-check.gradle ## @@ -0,0 +1,118 @@ +/* + * Licensed to th

[GitHub] [lucene-solr] mocobeta commented on issue #1267: LUCENE-9201: Add missing javadocs check task

mocobeta commented on issue #1267: LUCENE-9201: Add missing javadocs check task URL: https://github.com/apache/lucene-solr/pull/1267#issuecomment-590057882 @dweiss thanks for your comments and the refined patch. I did some tests with the patch and added a comment to JIRA. Maybe we should cl

[GitHub] [lucene-solr] mocobeta closed pull request #1267: LUCENE-9201: Add missing javadocs check task

mocobeta closed pull request #1267: LUCENE-9201: Add missing javadocs check task URL: https://github.com/apache/lucene-solr/pull/1267 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [lucene-solr] mocobeta commented on issue #1267: LUCENE-9201: Add missing javadocs check task

mocobeta commented on issue #1267: LUCENE-9201: Add missing javadocs check task URL: https://github.com/apache/lucene-solr/pull/1267#issuecomment-590154751 I will close this. Thank you @dweiss for your review comments here! Th

[GitHub] [lucene-solr] iverase opened a new pull request #1278: LUCENE-9243: Add fudge factor when creating a bounding box of a xycircle

iverase opened a new pull request #1278: LUCENE-9243: Add fudge factor when creating a bounding box of a xycircle URL: https://github.com/apache/lucene-solr/pull/1278 We need increase slightly the bounding box of a `XYCircle` to prevent points at the provided distance to be outside of the

[GitHub] [lucene-solr] iverase opened a new pull request #1279: LUCENE-9244: In 2D, a point can be shred by four leaves

iverase opened a new pull request #1279: LUCENE-9244: In 2D, a point can be shred by four leaves URL: https://github.com/apache/lucene-solr/pull/1279 Adjust test not to fail when point is shared by multiple leaves. This is an

[GitHub] [lucene-solr] janhoy merged pull request #1256: SOLR-10306: Document in Reference Guide how to disable or reduce swapping

janhoy merged pull request #1256: SOLR-10306: Document in Reference Guide how to disable or reduce swapping URL: https://github.com/apache/lucene-solr/pull/1256 This is an automated message from the Apache Git Service. To re

[GitHub] [lucene-solr] janhoy merged pull request #1273: SOLR-14114: Add WARN to Solr log that embedded ZK is not supported in prod

janhoy merged pull request #1273: SOLR-14114: Add WARN to Solr log that embedded ZK is not supported in prod URL: https://github.com/apache/lucene-solr/pull/1273 This is an automated message from the Apache Git Service. To r

[GitHub] [lucene-solr] romseygeek commented on issue #357: [SOLR-12238] Synonym Queries boost

romseygeek commented on issue #357: [SOLR-12238] Synonym Queries boost URL: https://github.com/apache/lucene-solr/pull/357#issuecomment-590225053 Sorry, have been away and/or busy - I'm running tests now and will merge once everything passes. Thanks for all your work @alessandrobenedetti!

[GitHub] [lucene-solr] iverase opened a new pull request #1280: LUCENE-9239: Change withinTriangle logic for Circles

iverase opened a new pull request #1280: LUCENE-9239: Change withinTriangle logic for Circles URL: https://github.com/apache/lucene-solr/pull/1280 see https://issues.apache.org/jira/browse/LUCENE-9239 for an explanation. The idea of the new logic is to exploit the fact that for Circl

[GitHub] [lucene-solr] bruno-roustant opened a new pull request #1281: LUCENE-9245: Optimize AutomatonTermsEnum memory and automaton Operations.getCommonPrefixBytesRef.

bruno-roustant opened a new pull request #1281: LUCENE-9245: Optimize AutomatonTermsEnum memory and automaton Operations.getCommonPrefixBytesRef. URL: https://github.com/apache/lucene-solr/pull/1281 This is an automated mess

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1281: LUCENE-9245: Optimize AutomatonTermsEnum memory and automaton Operations.getCommonPrefixBytesRef.

bruno-roustant commented on a change in pull request #1281: LUCENE-9245: Optimize AutomatonTermsEnum memory and automaton Operations.getCommonPrefixBytesRef. URL: https://github.com/apache/lucene-solr/pull/1281#discussion_r383154138 ## File path: lucene/core/src/java/org/apache/lu

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1281: LUCENE-9245: Optimize AutomatonTermsEnum memory and automaton Operations.getCommonPrefixBytesRef.

bruno-roustant commented on a change in pull request #1281: LUCENE-9245: Optimize AutomatonTermsEnum memory and automaton Operations.getCommonPrefixBytesRef. URL: https://github.com/apache/lucene-solr/pull/1281#discussion_r383154930 ## File path: lucene/core/src/java/org/apache/luc

[GitHub] [lucene-solr] juanka588 opened a new pull request #1282: Lucene 9236

juanka588 opened a new pull request #1282: Lucene 9236 URL: https://github.com/apache/lucene-solr/pull/1282 # Description Please provide a short description of the changes you're making with this pull request. # Solution Please provide a short description of

[GitHub] [lucene-solr] juanka588 commented on a change in pull request #1282: Lucene 9236

juanka588 commented on a change in pull request #1282: Lucene 9236 URL: https://github.com/apache/lucene-solr/pull/1282#discussion_r383184671 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesProducer.java ## @@ -121,1445 +116,80 @@ priv

[GitHub] [lucene-solr] juanka588 commented on a change in pull request #1282: Lucene 9236

juanka588 commented on a change in pull request #1282: Lucene 9236 URL: https://github.com/apache/lucene-solr/pull/1282#discussion_r383184968 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80NumericConsumer.java ## @@ -0,0 +1,319 @@ +/* + * Lice

[GitHub] [lucene-solr] romseygeek merged pull request #357: [SOLR-12238] Synonym Queries boost

romseygeek merged pull request #357: [SOLR-12238] Synonym Queries boost URL: https://github.com/apache/lucene-solr/pull/357 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [lucene-solr] juanka588 commented on a change in pull request #1282: Lucene 9236

juanka588 commented on a change in pull request #1282: Lucene 9236 URL: https://github.com/apache/lucene-solr/pull/1282#discussion_r383185344 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80NumericProducer.java ## @@ -0,0 +1,541 @@ +/* + * Lice

[GitHub] [lucene-solr] juanka588 commented on a change in pull request #1282: Lucene 9236

juanka588 commented on a change in pull request #1282: Lucene 9236 URL: https://github.com/apache/lucene-solr/pull/1282#discussion_r383186292 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80BinaryConsumer.java ## @@ -48,6 +53,16 @@ public Lucen

[GitHub] [lucene-solr] juanka588 commented on issue #1282: Lucene 9236

juanka588 commented on issue #1282: Lucene 9236 URL: https://github.com/apache/lucene-solr/pull/1282#issuecomment-590257020 Please review each commit apart. This is an automated message from the Apache Git Service. To respond

[GitHub] [lucene-solr] romseygeek commented on issue #1243: LUCENE-9212: Intervals.multiterm() should take CompiledAutomaton

romseygeek commented on issue #1243: LUCENE-9212: Intervals.multiterm() should take CompiledAutomaton URL: https://github.com/apache/lucene-solr/pull/1243#issuecomment-590270502 Merged as ffb7cafe9351cd6cd5181bc06dd053d586f6d63f -

[GitHub] [lucene-solr] romseygeek closed pull request #1243: LUCENE-9212: Intervals.multiterm() should take CompiledAutomaton

romseygeek closed pull request #1243: LUCENE-9212: Intervals.multiterm() should take CompiledAutomaton URL: https://github.com/apache/lucene-solr/pull/1243 This is an automated message from the Apache Git Service. To respond

[GitHub] [lucene-solr] rmuir commented on a change in pull request #1281: LUCENE-9245: Optimize AutomatonTermsEnum memory and automaton Operations.getCommonPrefixBytesRef.

rmuir commented on a change in pull request #1281: LUCENE-9245: Optimize AutomatonTermsEnum memory and automaton Operations.getCommonPrefixBytesRef. URL: https://github.com/apache/lucene-solr/pull/1281#discussion_r383259436 ## File path: lucene/core/src/java/org/apache/lucene/index/

<    1   2   3   4   5   6   7   8   9   10   >