Re: [I] Remove -XX:ActiveProcessorCount=1 from template.gradle.properties [lucene]

2025-06-22 Thread via GitHub
dweiss commented on issue #14829: URL: https://github.com/apache/lucene/issues/14829#issuecomment-2994005520 I've applied this on main and branch_10x. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] build: replace six simple error prone checks [lucene]

2025-06-22 Thread via GitHub
dweiss commented on code in PR #14831: URL: https://github.com/apache/lucene/pull/14831#discussion_r2160248134 ## lucene/test-framework/src/test/org/apache/lucene/tests/util/TestBeforeAfterOverrides.java: ## @@ -30,7 +30,9 @@ public TestBeforeAfterOverrides() { public stati

Re: [PR] Custom google java format tasks to replace spotless [lucene]

2025-06-22 Thread via GitHub
github-actions[bot] commented on PR #14824: URL: https://github.com/apache/lucene/pull/14824#issuecomment-2994008065 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop

Re: [I] Remove -XX:ActiveProcessorCount=1 from template.gradle.properties [lucene]

2025-06-22 Thread via GitHub
dweiss closed issue #14829: Remove -XX:ActiveProcessorCount=1 from template.gradle.properties URL: https://github.com/apache/lucene/issues/14829 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Custom google java format tasks to replace spotless [lucene]

2025-06-22 Thread via GitHub
dweiss merged PR #14824: URL: https://github.com/apache/lucene/pull/14824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

[I] add generated files lists/patterns to .gitattributes [lucene]

2025-06-22 Thread via GitHub
rmuir opened a new issue, #14833: URL: https://github.com/apache/lucene/issues/14833 ### Description generated files can be specified in `.gitattributes` as generated for a couple bonuses in github: * doesn't mess up source code analysis (counts etc) * changes are folded/hidden

Re: [PR] style: fix indents inconsistent with editorconfig and validate in CI [lucene]

2025-06-22 Thread via GitHub
rmuir commented on PR #14832: URL: https://github.com/apache/lucene/pull/14832#issuecomment-2994425325 will also push a commit adding this one to `.git-blame-ignore-revs`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] build: replace six simple error prone checks [lucene]

2025-06-22 Thread via GitHub
github-actions[bot] commented on PR #14831: URL: https://github.com/apache/lucene/pull/14831#issuecomment-2994427294 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop

Re: [PR] style: fix indents inconsistent with editorconfig and validate in CI [lucene]

2025-06-22 Thread via GitHub
rmuir commented on PR #14832: URL: https://github.com/apache/lucene/pull/14832#issuecomment-2994386376 The validation does make `eclint` run slower, but it still burns relative to other tasks in the build: ``` $ time eclint real 0m5.289s user 0m7.823s sys 0m0.601s ```

Re: [I] Remove -XX:ActiveProcessorCount=1 from template.gradle.properties [lucene]

2025-06-22 Thread via GitHub
dsmiley commented on issue #14829: URL: https://github.com/apache/lucene/issues/14829#issuecomment-2994866377 I imagine you'd recommend the same for Solr? It's not clear if Spotless vs. the direct GoogleJavaFormat aspect changes the answer. -- This is an automated message from the Apache

Re: [PR] style: fix indents inconsistent with editorconfig and validate in CI [lucene]

2025-06-22 Thread via GitHub
rmuir merged PR #14832: URL: https://github.com/apache/lucene/pull/14832 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apach

[PR] Optimize `CombinedFieldQuery` by `nextDocsAndScores` [lucene]

2025-06-22 Thread via GitHub
HUSTERGS opened a new pull request, #14834: URL: https://github.com/apache/lucene/pull/14834 ### Description This PR propose to implement `nextDocsAndScores` in order to help the auto-vectorize of score calculation, I'v seen similar code under `TermScorer`. Basically this pr add a ne

[PR] style: fix indents inconsistent with editorconfig and validate in CI [lucene]

2025-06-22 Thread via GitHub
rmuir opened a new pull request, #14832: URL: https://github.com/apache/lucene/pull/14832 editorconfig indents were set across the board for all files, but nothing was done with existing files. For example, yaml was set to have a 2-space indent, yet it is the wild-west out there: 1-space in

Re: [PR] Optimize `CombinedFieldQuery` by `nextDocsAndScores` [lucene]

2025-06-22 Thread via GitHub
github-actions[bot] commented on PR #14834: URL: https://github.com/apache/lucene/pull/14834#issuecomment-2994705537 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop

Re: [PR] build: add eclint to verify editorconfig in CI [lucene]

2025-06-22 Thread via GitHub
rmuir merged PR #14825: URL: https://github.com/apache/lucene/pull/14825 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apach

Re: [PR] style: fix indents inconsistent with editorconfig and validate in CI [lucene]

2025-06-22 Thread via GitHub
github-actions[bot] commented on PR #14832: URL: https://github.com/apache/lucene/pull/14832#issuecomment-2994383872 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop