xcx1r3 opened a new pull request, #14727:
URL: https://github.com/apache/lucene/pull/14727
### Description
Use try-with-resources to auto-close DataInputStream
```
try (DataInputStream dctFile = new
DataInputStream(Files.newInputStream(Paths.get(dctFilePath {
...
}
github-actions[bot] commented on PR #14727:
URL: https://github.com/apache/lucene/pull/14727#issuecomment-2915210212
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog-check
label to it and you wil
vigyasharma commented on PR #14708:
URL: https://github.com/apache/lucene/pull/14708#issuecomment-2917306575
Thanks for the review folks! I like the idea of a separate class and a
custom vector comparator, will make these changes.
--
This is an automated message from the Apache Git Servic
vigyasharma commented on PR #14708:
URL: https://github.com/apache/lucene/pull/14708#issuecomment-2917325435
I'm not sure about the byte vector case myself. Do we see a viable need for
it in FullPrecisionVectorSimilaritySource ?
--
This is an automated message from the Apache Git Service
benwtrent commented on PR #14708:
URL: https://github.com/apache/lucene/pull/14708#issuecomment-2917328559
> I'm not sure about the byte vector case myself. Do we see a viable need
for it in FullPrecisionVectorSimilaritySource ?
I am not sure. As of right now, none of the quantization
jpountz commented on PR #14727:
URL: https://github.com/apache/lucene/pull/14727#issuecomment-2916354220
Looks good! Can you add an entry in lucene/CHANGES.txt under version 10.3?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
dweiss commented on PR #14721:
URL: https://github.com/apache/lucene/pull/14721#issuecomment-2916470586
@pseudo-nymous - if you can shed some light on this before I merge, it'd be
great. I'll wait a bit for your feedback.
--
This is an automated message from the Apache Git Service.
To res
dweiss commented on PR #14721:
URL: https://github.com/apache/lucene/pull/14721#issuecomment-2916469412
I've no idea. All I know is I get failures when I work on a self-fork PR,
see here -
https://github.com/dweiss/lucene/actions/workflows/label-pull-request.yml
these recent "skipp
dweiss merged PR #14722:
URL: https://github.com/apache/lucene/pull/14722
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
dweiss merged PR #14723:
URL: https://github.com/apache/lucene/pull/14723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
msokolov commented on PR #14708:
URL: https://github.com/apache/lucene/pull/14708#issuecomment-2916875650
+1 to add support for full precision re-ranking. Have you considered writing
a FullPrecisionVectorSimilaritySource as a separate class? We like to avoid
conditional logic on boolean pa
benwtrent commented on PR #14708:
URL: https://github.com/apache/lucene/pull/14708#issuecomment-2916888768
> Have you considered writing a FullPrecisionVectorSimilaritySource as a
separate class?
A separate class would allow users to provide a custom vector comparator,
which might be
Jinny-Wang opened a new pull request, #14728:
URL: https://github.com/apache/lucene/pull/14728
#14565
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
github-actions[bot] commented on PR #14728:
URL: https://github.com/apache/lucene/pull/14728#issuecomment-2917468073
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog-check
label to it and you wil
Jinny-Wang closed pull request #14728: [BlockJoin] Add
ParentsChildrenBlockJoinQuery to support parent and c…
URL: https://github.com/apache/lucene/pull/14728
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
github-actions[bot] commented on PR #14728:
URL: https://github.com/apache/lucene/pull/14728#issuecomment-2917477162
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog-check
label to it and you wil
jainankitk commented on PR #14527:
URL: https://github.com/apache/lucene/pull/14527#issuecomment-2917542707
Thanks @benwtrent and @weizijun for seeing this through!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
msokolov merged PR #14712:
URL: https://github.com/apache/lucene/pull/14712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.ap
msokolov commented on code in PR #14674:
URL: https://github.com/apache/lucene/pull/14674#discussion_r2112296471
##
lucene/core/src/java/org/apache/lucene/search/AbstractKnnVectorQuery.java:
##
@@ -226,15 +227,25 @@ private BitSet createBitSet(DocIdSetIterator iterator,
Bits li
msokolov commented on code in PR #14674:
URL: https://github.com/apache/lucene/pull/14674#discussion_r2112296471
##
lucene/core/src/java/org/apache/lucene/search/AbstractKnnVectorQuery.java:
##
@@ -226,15 +227,25 @@ private BitSet createBitSet(DocIdSetIterator iterator,
Bits li
jpountz commented on code in PR #14714:
URL: https://github.com/apache/lucene/pull/14714#discussion_r2111945886
##
lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java:
##
@@ -73,23 +65,22 @@ public ScoreMode scoreMode() {
public LeafCollector getLeafCollec
dweiss merged PR #14721:
URL: https://github.com/apache/lucene/pull/14721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
pseudo-nymous commented on PR #14721:
URL: https://github.com/apache/lucene/pull/14721#issuecomment-2916739701
I'm also not sure about the permission issue. There have been past
successful runs in forks.
[Documentation](https://docs.github.com/en/rest/issues/labels?apiVersion=2022-11
msfroh commented on code in PR #14728:
URL: https://github.com/apache/lucene/pull/14728#discussion_r2112783861
##
lucene/join/src/test/org/apache/lucene/search/join/TestParentsChildrenBlockJoinQuery.java:
##
@@ -0,0 +1,186 @@
+/*
+ * Licensed to the Apache Software Foundation (A
jainankitk merged PR #14626:
URL: https://github.com/apache/lucene/pull/14626
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
vigyasharma opened a new pull request, #14729:
URL: https://github.com/apache/lucene/pull/14729
Late Interaction models, like [ColBERT](https://arxiv.org/abs/2004.12832)
and [ColPali](https://arxiv.org/html/2407.01449v2), capture rich semantic
interaction between documents and queries, and
github-actions[bot] commented on PR #14729:
URL: https://github.com/apache/lucene/pull/14729#issuecomment-2917887297
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog-check
label to it and you wil
vigyasharma commented on PR #14729:
URL: https://github.com/apache/lucene/pull/14729#issuecomment-2917890456
This change builds on the work shared
[here](https://github.com/apache/lucene/pull/13525#issuecomment-2445295372) by
@jimczi, thanks Jim!
--
This is an automated message from the
github-actions[bot] commented on PR #14667:
URL: https://github.com/apache/lucene/pull/14667#issuecomment-2917902454
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
github-actions[bot] commented on PR #14661:
URL: https://github.com/apache/lucene/pull/14661#issuecomment-2917902497
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
github-actions[bot] commented on PR #14725:
URL: https://github.com/apache/lucene/pull/14725#issuecomment-2917935696
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog-check
label to it and you wil
viliam-durina commented on PR #14667:
URL: https://github.com/apache/lucene/pull/14667#issuecomment-2918487383
@jainankitk Do you really want changelogs for this kind of changes?
Nevertheless, I added it.
--
This is an automated message from the Apache Git Service.
To respond to the messa
xcx1r3 commented on PR #14727:
URL: https://github.com/apache/lucene/pull/14727#issuecomment-2918148345
It seems there were a couple more areas got same problem and I've added a
few more commits to this PR which are
```
1、org.apache.lucene.analysis.cn.smart.hhmm.BigramDictionary#loadF
33 matches
Mail list logo
