pseudo-nymous commented on PR #14369:
URL: https://github.com/apache/lucene/pull/14369#issuecomment-2888492537
Sorry, I didn't get a chance to pick this up.
Thanks for making the changes. It looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to th
pseudo-nymous closed pull request #14369: Fix for changelog verifier and
milestone setter automation
URL: https://github.com/apache/lucene/pull/14369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pseudo-nymous commented on issue #13898:
URL: https://github.com/apache/lucene/issues/13898#issuecomment-2888494102
Github does not allow adding labels by non owners of a repo. Ref:
[link](https://github.com/isaacs/github/issues/875)
--
This is an automated message from the Apache Git Ser
pseudo-nymous commented on PR #14369:
URL: https://github.com/apache/lucene/pull/14369#issuecomment-2888492954
My changes are not required now. Thus, closing this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
schlosna commented on PR #14678:
URL: https://github.com/apache/lucene/pull/14678#issuecomment-2888508407
> There's intentionally not a `BytesRef(String)` constructor, as there have
been issues before.
@rmuir Do you happen to recall what issues a `BytesRef(String)` constructor
create
rmuir commented on PR #14678:
URL: https://github.com/apache/lucene/pull/14678#issuecomment-2888555604
> In #12071 these is mention [#12071
(comment)](https://github.com/apache/lucene/issues/12071#issuecomment-1379313710)
of using the vector APIs to speed up UnicodeUtil conversions. Has any
rmuir commented on PR #14678:
URL: https://github.com/apache/lucene/pull/14678#issuecomment-2888550852
git log tells the story. A quick summary:
* conflicting use cases such as usages as a reference vs
stringbuilder/string type uses
* ownership issues and API problems resulting fro
dweiss commented on code in PR #14676:
URL: https://github.com/apache/lucene/pull/14676#discussion_r2094060457
##
lucene/core/src/java/org/apache/lucene/util/BytesRefBuilder.java:
##
@@ -171,4 +171,9 @@ public boolean equals(Object obj) {
public int hashCode() {
throw ne
rmuir commented on PR #14678:
URL: https://github.com/apache/lucene/pull/14678#issuecomment-2888326775
There's intentionally not a `BytesRef(String)` constructor, as there have
been issues before.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
github-actions[bot] commented on PR #14682:
URL: https://github.com/apache/lucene/pull/14682#issuecomment-2888681850
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog-check
label to it and you wil
github-actions[bot] commented on PR #14682:
URL: https://github.com/apache/lucene/pull/14682#issuecomment-2888656024
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog-check
label to it and you wil
pseudo-nymous opened a new pull request, #14682:
URL: https://github.com/apache/lucene/pull/14682
### Description
Adds a fix for Luke Analysis tab where user weren't able to add char or
token filters.
Root Cause:
We have a util method which returns JList's model underlying
12 matches
Mail list logo
