Re: [I] Nightly benchmark regression on 2025.05.01 [lucene]

2025-05-16 Thread via GitHub
uschindler commented on issue #14630: URL: https://github.com/apache/lucene/issues/14630#issuecomment-2886130445 > I'm also not liking these unrelated hardware errors!! But they are pre-existing for a long time now... This happens on modern hardware more often. You often get PCIe chec

Re: [I] Nightly benchmark regression on 2025.05.01 [lucene]

2025-05-16 Thread via GitHub
uschindler commented on issue #14630: URL: https://github.com/apache/lucene/issues/14630#issuecomment-2886118006 > Hmm downgrading to Java 23 is not so simple ... I got it installed, cutover benchy's N places to use Java 23, but then Lucene's `main` insists in at least two places that I'm r

[I] TestStressNRTReplication may never terminate (exceed suite timeout) [lucene]

2025-05-16 Thread via GitHub
dweiss opened a new issue, #14664: URL: https://github.com/apache/lucene/issues/14664 ### Description It hangs in the 'restarter' thread on this condition: ``` while (startupThreads.size() > 0) { Thread.sleep(10); } ``` the main thread just j

Re: [PR] Fix termination condition in TestStressNRTReplication. [lucene]

2025-05-16 Thread via GitHub
github-actions[bot] commented on PR #14665: URL: https://github.com/apache/lucene/pull/14665#issuecomment-2879192882 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you wil

Re: [PR] Fix termination condition in TestStressNRTReplication. [lucene]

2025-05-16 Thread via GitHub
dweiss commented on code in PR #14665: URL: https://github.com/apache/lucene/pull/14665#discussion_r2088329682 ## lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestStressNRTReplication.java: ## @@ -994,26 +998,26 @@ public void run() { } fi

Re: [I] Nightly benchmark regression on 2025.05.01 [lucene]

2025-05-16 Thread via GitHub
mikemccand commented on issue #14630: URL: https://github.com/apache/lucene/issues/14630#issuecomment-2887249181 Thanks @uschindler! I was able to get @jpountz idea to work -- it ran in last night's run (2025-05-15) and it looks to me like Java 23 -> 24 was not responsible for the slowdown

Re: [PR] [Bug] Fix for stored fields force merge regression [lucene]

2025-05-16 Thread via GitHub
github-actions[bot] commented on PR #14512: URL: https://github.com/apache/lucene/pull/14512#issuecomment-2887885025 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Speed up exhaustive evaluation. [lucene]

2025-05-16 Thread via GitHub
gf2121 commented on code in PR #14679: URL: https://github.com/apache/lucene/pull/14679#discussion_r2093432298 ## lucene/core/src/java/org/apache/lucene/search/similarities/Similarity.java: ## @@ -208,6 +208,25 @@ protected SimScorer() {} */ public abstract float scor

Re: [PR] Speed up exhaustive evaluation. [lucene]

2025-05-16 Thread via GitHub
jpountz commented on code in PR #14679: URL: https://github.com/apache/lucene/pull/14679#discussion_r2093664788 ## lucene/core/src/java/org/apache/lucene/search/similarities/Similarity.java: ## @@ -208,6 +208,25 @@ protected SimScorer() {} */ public abstract float sco

Re: [PR] Use per-segment K in filtered KNN fallback logic (fixes 14671) [lucene]

2025-05-16 Thread via GitHub
msokolov merged PR #14680: URL: https://github.com/apache/lucene/pull/14680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.ap

Re: [I] Nightly benchark regression on pre-filtered vector search [lucene]

2025-05-16 Thread via GitHub
msokolov closed issue #14671: Nightly benchark regression on pre-filtered vector search URL: https://github.com/apache/lucene/issues/14671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [I] Should we explore DiskANN for aKNN vector search? [lucene]

2025-05-16 Thread via GitHub
RKSPD commented on issue #12615: URL: https://github.com/apache/lucene/issues/12615#issuecomment-2887741322 > I am actually in the process of extending Lucene Codec for JVector DiskANN integration. Note this work is part of [opensearch-project/k-NN#2386](https://github.com/opensearch-projec

Re: [I] Should we explore DiskANN for aKNN vector search? [lucene]

2025-05-16 Thread via GitHub
RKSPD commented on issue #12615: URL: https://github.com/apache/lucene/issues/12615#issuecomment-2887805413 > > I am actually in the process of extending Lucene Codec for JVector DiskANN integration. Note this work is part of [opensearch-project/k-NN#2386](https://github.com/opensearch-proj

Re: [PR] Improve BytesRef creation from String [lucene]

2025-05-16 Thread via GitHub
github-actions[bot] commented on PR #14678: URL: https://github.com/apache/lucene/pull/14678#issuecomment-2887286703 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you wil

Re: [PR] Improve BytesRef creation from String [lucene]

2025-05-16 Thread via GitHub
github-actions[bot] commented on PR #14678: URL: https://github.com/apache/lucene/pull/14678#issuecomment-2887298479 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you wil

Re: [I] Nightly benchmark regression on 2025.05.01 [lucene]

2025-05-16 Thread via GitHub
rmuir commented on issue #14630: URL: https://github.com/apache/lucene/issues/14630#issuecomment-2887482208 Prime suspect: https://gitlab.archlinux.org/archlinux/packaging/packages/linux/-/commit/027f29fb4104bac71151c47ce637fb18579a4a36 You may look at other changes to flags and such

Re: [PR] Improve BytesRef creation from String [lucene]

2025-05-16 Thread via GitHub
schlosna commented on PR #14678: URL: https://github.com/apache/lucene/pull/14678#issuecomment-2887624646 Added `BytesRefBenchmark` demonstrating existing `new BytesRef(CharSequence)` vs. `new BytesRef(String)` demonstrating 2x to 6x throughput improvement on AMD EPYC 7R13 Processor:

Re: [PR] Use per-segment K in filtered KNN fallback logic (fixes 14671) [lucene]

2025-05-16 Thread via GitHub
github-actions[bot] commented on PR #14680: URL: https://github.com/apache/lucene/pull/14680#issuecomment-2887632883 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you wil

[PR] Use per-segment K in filtered KNN fallback logic (fixes 14671) [lucene]

2025-05-16 Thread via GitHub
msokolov opened a new pull request, #14680: URL: https://github.com/apache/lucene/pull/14680 Originally (before optimistic KNN query): ``` recall latency(ms) nDoc topK fanout maxConn beamWidth quantized visited selectivity filterType vec_disk(MB) vec_RAM(MB) indexT

Re: [PR] Override ValueSource.FromDoubleValuesSource.getSortField [lucene]

2025-05-16 Thread via GitHub
dsmiley merged PR #14654: URL: https://github.com/apache/lucene/pull/14654 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Improve BytesRef creation from String [lucene]

2025-05-16 Thread via GitHub
vigyasharma commented on code in PR #14678: URL: https://github.com/apache/lucene/pull/14678#discussion_r2093976930 ## lucene/CHANGES.txt: ## @@ -41,6 +41,7 @@ Optimizations - * GITHUB#14011: Reduce allocation rate in HNSW concurrent merge. (Viliam Durina)

Re: [PR] Added toString() method to BytesRefBuilder [lucene]

2025-05-16 Thread via GitHub
vigyasharma commented on code in PR #14676: URL: https://github.com/apache/lucene/pull/14676#discussion_r2093986452 ## lucene/CHANGES.txt: ## @@ -49,6 +49,9 @@ Bug Fixes * GITHUB#14075: Remove duplicate and add missing entry on brazilian portuguese stopwords list. (Arthur Ca