Re: [I] gradle-wrapper.jar will not be updated when its sha/version changes [lucene]

2025-05-04 Thread via GitHub
dweiss commented on issue #14598: URL: https://github.com/apache/lucene/issues/14598#issuecomment-2849301978 https://github.com/apache/lucene/pull/14608 This adds sha256 check on Windows and Linux. The Linux part is a redesigned version of what chatgpt came up with. I believe even cha

Re: [PR] Always check gradle wrapper sha checksum and download if necessary [lucene]

2025-05-04 Thread via GitHub
dweiss commented on PR #14608: URL: https://github.com/apache/lucene/pull/14608#issuecomment-2849304533 I've verified this works on Windows, Linux (ubuntu) and Mac. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Update created version major [lucene]

2025-05-04 Thread via GitHub
rahulgoswami commented on PR #14607: URL: https://github.com/apache/lucene/pull/14607#issuecomment-2849305608 > As states on the dev list, I don't think we should do this. Can you please elaborate why? I have tried to address the concern you brought up on the mailing list via the impl

Re: [PR] Always check gradle wrapper sha checksum and download if necessary [lucene]

2025-05-04 Thread via GitHub
dweiss commented on code in PR #14608: URL: https://github.com/apache/lucene/pull/14608#discussion_r2072657950 ## gradlew.bat: ## @@ -81,10 +81,22 @@ SET DEFAULT_JVM_OPTS=%DEFAULT_JVM_OPTS% "-Djava.io.tmpdir=%GRADLE_TEMPDIR%" @rem LUCENE-9266: verify and download the gradle

Re: [PR] Add Query for reranking KnnFloatVectorQuery with full-precision vectors [lucene]

2025-05-04 Thread via GitHub
dungba88 commented on PR #14009: URL: https://github.com/apache/lucene/pull/14009#issuecomment-2849835324 > I'm curious about https://github.com/apache/lucene/pull/14009#issuecomment-2502665806 -- why is recall better for 1bit and 4bit than 7bit, when reranking? If we compare the rec

Re: [I] gradle-wrapper.jar will not be updated when its sha/version changes [lucene]

2025-05-04 Thread via GitHub
dweiss closed issue #14598: gradle-wrapper.jar will not be updated when its sha/version changes URL: https://github.com/apache/lucene/issues/14598 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Always check gradle wrapper sha checksum and download if necessary [lucene]

2025-05-04 Thread via GitHub
dweiss merged PR #14608: URL: https://github.com/apache/lucene/pull/14608 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

Re: [PR] Always check gradle wrapper sha checksum and download if necessary [lucene]

2025-05-04 Thread via GitHub
dweiss commented on PR #14608: URL: https://github.com/apache/lucene/pull/14608#issuecomment-2849376294 Interesting. I've got no idea, to be honest. Here is a list of shas for all releases - https://gradle.org/release-checksums/ v8.14 is there and consistent with what we have. --

Re: [I] gradle-wrapper.jar will not be updated when its sha/version changes [lucene]

2025-05-04 Thread via GitHub
dweiss commented on issue #14598: URL: https://github.com/apache/lucene/issues/14598#issuecomment-2849293690 This is actually a sort-of regression introduced in #13404 (90e07f666422). Previously, we'd always check the checksum of the wrapper file. After this change - to speed up startup ti

[PR] Overrides rewrite in PointRangeQuery to optimize AllDocs/NoDocs cases [lucene]

2025-05-04 Thread via GitHub
ebradshaw opened a new pull request, #14609: URL: https://github.com/apache/lucene/pull/14609 Overrides rewrite in PointRangeQuery range to handle cases where the query either fully contains or fully excludes all documents within the shard. Often, particularly when using time based pa

Re: [PR] Always check gradle wrapper sha checksum and download if necessary [lucene]

2025-05-04 Thread via GitHub
vigyasharma commented on PR #14608: URL: https://github.com/apache/lucene/pull/14608#issuecomment-2849497626 Thanks for fixing this! I ran into the same problem. My old `gradle-wrapper.jar` was not getting updated and I kept hitting: ```bash % ./gradlew clean no main manifes

[PR] Update jdk requirements in README to OpenJDK 24 [lucene]

2025-05-04 Thread via GitHub
vigyasharma opened a new pull request, #14610: URL: https://github.com/apache/lucene/pull/14610 Lucene now depends on Java 24. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] Support adaptive refresh in Searcher Managers. [lucene]

2025-05-04 Thread via GitHub
vigyasharma commented on code in PR #14443: URL: https://github.com/apache/lucene/pull/14443#discussion_r2072749702 ## lucene/core/src/java/org/apache/lucene/search/SearcherManager.java: ## @@ -131,17 +133,32 @@ public SearcherManager(DirectoryReader reader, SearcherFactory sea

Re: [PR] Update jdk requirements in README to OpenJDK 24 [lucene]

2025-05-04 Thread via GitHub
dweiss merged PR #14610: URL: https://github.com/apache/lucene/pull/14610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

Re: [PR] Update jdk requirements in README to OpenJDK 24 [lucene]

2025-05-04 Thread via GitHub
dweiss commented on PR #14610: URL: https://github.com/apache/lucene/pull/14610#issuecomment-2849993132 Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] Update created version major [lucene]

2025-05-04 Thread via GitHub
rmuir commented on PR #14607: URL: https://github.com/apache/lucene/pull/14607#issuecomment-2849142575 As states on the dev list, I don't think we should do this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL