gf2121 commented on PR #14552:
URL: https://github.com/apache/lucene/pull/14552#issuecomment-2834065647
I made some effort to simplify the change, this is ready for review now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
mikemccand commented on PR #14178:
URL: https://github.com/apache/lucene/pull/14178#issuecomment-2833388608
Hmm, there have been [other packages missing versions (e.g. 0.2.2 of
torchvision)](https://github.com/pytorch/vision/issues/7456) (~ 2 years ago)
(in the pytorch channel) and the resu
ChrisHegarty commented on issue #14561:
URL: https://github.com/apache/lucene/issues/14561#issuecomment-2833417210
//cc @jpountz @gf2121 @expani
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
jainankitk commented on PR #13923:
URL: https://github.com/apache/lucene/pull/13923#issuecomment-2833704578
> Hello @jainankitk , Can you merge this change?
@vsop-479 - I don't have the permissions to merge, but I can see that Mike
is involved now. He should be able to help get this c
mikemccand commented on PR #14178:
URL: https://github.com/apache/lucene/pull/14178#issuecomment-2833441480
OK I think [this](https://github.com/conda-forge/staged-recipes/pull/11337)
is the original issue that imported Faiss into the `conda-forge` community
driven channel...
[This
ChrisHegarty opened a new issue, #14561:
URL: https://github.com/apache/lucene/issues/14561
The changes in https://github.com/apache/lucene/pull/14511 result in a
change in behaviour. This should be analysed since #14511 has been backported
in the 10.2.1 bugfix release.
I've not yet
ChrisHegarty commented on issue #14561:
URL: https://github.com/apache/lucene/issues/14561#issuecomment-2833419981
Maybe this change in behaviour is expected, but it's little concerning,
unless the test doesn't make sense? Tho, I think that this behaviour has been
this way for quite a while
mikemccand commented on PR #14178:
URL: https://github.com/apache/lucene/pull/14178#issuecomment-2833443335
Aha, here is the feedstock for Faiss (which provides the actual artifacts to
ship through `conda-forge` channel:
https://github.com/conda-forge/faiss-split-feedstock
And there
mikemccand commented on PR #14178:
URL: https://github.com/apache/lucene/pull/14178#issuecomment-2833444503
Here is the root cause for one of those build failures ([full log
here](https://dev.azure.com/conda-forge/84710dde-1620-425b-80d0-4cf5baca359d/_apis/build/builds/1233252/logs/105)):
mikemccand commented on code in PR #13923:
URL: https://github.com/apache/lucene/pull/13923#discussion_r2062650201
##
lucene/core/src/java/org/apache/lucene/util/fst/FSTCompiler.java:
##
@@ -819,17 +819,11 @@ private void freezeTail(int prefixLenPlus1) throws
IOException {
mikemccand commented on PR #14178:
URL: https://github.com/apache/lucene/pull/14178#issuecomment-2833381916
> > but it's currently at 1.9.0 -- maybe the developers who build Faiss here
might push 1.11.0 (just released) soon?
>
> I see a PR for this:
[conda-forge/faiss-split-feedstock
mikemccand commented on PR #14178:
URL: https://github.com/apache/lucene/pull/14178#issuecomment-2833392738
> > Do commercial fees apply to conda-forge?
> > No. Our commercial fees do not apply to the user-uploaded packages at
[anaconda.org](http://anaconda.org/), which includes conda-for
vsop-479 commented on code in PR #13923:
URL: https://github.com/apache/lucene/pull/13923#discussion_r2062803592
##
lucene/core/src/java/org/apache/lucene/util/fst/FSTCompiler.java:
##
@@ -819,17 +819,11 @@ private void freezeTail(int prefixLenPlus1) throws
IOException {
vsop-479 commented on code in PR #13923:
URL: https://github.com/apache/lucene/pull/13923#discussion_r2062805026
##
lucene/core/src/java/org/apache/lucene/util/fst/FSTCompiler.java:
##
@@ -819,17 +819,11 @@ private void freezeTail(int prefixLenPlus1) throws
IOException {
14 matches
Mail list logo
