atris commented on PR #14525:
URL: https://github.com/apache/lucene/pull/14525#issuecomment-2817323978
@jpountz This PR is now ready for review. I will post luceneutil benchmarks
tomorrow. Please let me know if anything else is needed from me.
--
This is an automated message from the Apac
jainankitk commented on PR #14516:
URL: https://github.com/apache/lucene/pull/14516#issuecomment-2817661402
JMH benchmark comparison for just the FromPointDistanceSloppySin /
FromPointDistanceStandardSin comparison:
```
JMH Benchmark Results Comparison
=
jainankitk commented on PR #14516:
URL: https://github.com/apache/lucene/pull/14516#issuecomment-2817660626
JMH benchmark comparison for just the sloppySin / standardSin comparison:
```
JMH Benchmark Results Comparison
jainankitk commented on code in PR #14516:
URL: https://github.com/apache/lucene/pull/14516#discussion_r2051979569
##
lucene/core/src/java/org/apache/lucene/geo/Rectangle.java:
##
@@ -28,9 +25,6 @@
import static org.apache.lucene.geo.GeoUtils.MIN_LON_RADIANS;
import static org
jainankitk commented on PR #14516:
URL: https://github.com/apache/lucene/pull/14516#issuecomment-2817678029
> But the benchmark is not useful, as it was written as a test. Tests don't
run normally, in particular without java C2 compiler, so trying to make
benchmark via test is not useful an
mkhludnev commented on PR #14404:
URL: https://github.com/apache/lucene/pull/14404#issuecomment-2817735129
ok. If there's no concerns, I'll merge it this week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
jpountz commented on code in PR #14523:
URL: https://github.com/apache/lucene/pull/14523#discussion_r2051810126
##
lucene/core/src/java/org/apache/lucene/search/comparators/TermOrdValComparator.java:
##
@@ -524,17 +524,21 @@ public int advance(int target) throws IOException {
atris commented on PR #14409:
URL: https://github.com/apache/lucene/pull/14409#issuecomment-2817096299
@jpountz opened a new PR with the discussed approach:
https://github.com/apache/lucene/pull/14525
--
This is an automated message from the Apache Git Service.
To respond to the mes
gf2121 commented on code in PR #14523:
URL: https://github.com/apache/lucene/pull/14523#discussion_r2051668144
##
lucene/core/src/java/org/apache/lucene/search/comparators/TermOrdValComparator.java:
##
@@ -524,17 +524,21 @@ public int advance(int target) throws IOException {
jpountz commented on code in PR #14523:
URL: https://github.com/apache/lucene/pull/14523#discussion_r2051658845
##
lucene/core/src/java/org/apache/lucene/search/comparators/TermOrdValComparator.java:
##
@@ -524,17 +524,21 @@ public int advance(int target) throws IOException {
10 matches
Mail list logo
