guojialiang92 commented on code in PR #14417:
URL: https://github.com/apache/lucene/pull/14417#discussion_r2032735699
##
lucene/test-framework/src/java/org/apache/lucene/tests/index/ThreadedIndexingAndSearchingTestCase.java:
##
@@ -189,6 +190,19 @@ public void run() {
vigyasharma commented on code in PR #14417:
URL: https://github.com/apache/lucene/pull/14417#discussion_r2032521908
##
lucene/core/src/java/org/apache/lucene/index/IndexWriter.java:
##
@@ -1427,6 +1427,25 @@ public synchronized void advanceSegmentInfosVersion(long
newVersion) {
msokolov commented on PR #14178:
URL: https://github.com/apache/lucene/pull/14178#issuecomment-2787265466
It's great that you were able to get the FAISS changes merged. I think to
reproduce your benchmark results it is no longer necessary to follow all the
steps documented above (to build
dsmiley commented on code in PR #14448:
URL: https://github.com/apache/lucene/pull/14448#discussion_r2033180408
##
lucene/queries/src/test/org/apache/lucene/queries/function/TestLongNormValueSource.java:
##
@@ -16,99 +16,70 @@
*/
package org.apache.lucene.queries.function;
dsmiley commented on code in PR #14448:
URL: https://github.com/apache/lucene/pull/14448#discussion_r2033181531
##
lucene/test-framework/src/java/org/apache/lucene/tests/search/AssertingScorable.java:
##
@@ -44,7 +44,7 @@ public void setMinCompetitiveScore(float minScore) throws
benwtrent commented on issue #14429:
URL: https://github.com/apache/lucene/issues/14429#issuecomment-2786821619
@mikemccand OK, I gathered more info:
- Modern OpenJDK (22.0.1)
- Modern Linux
So other system stuff doesn't seem very exotic.
However, the data being ing
rmuir opened a new issue, #14454:
URL: https://github.com/apache/lucene/issues/14454
### Description
Example found by @uschindler during release vote:
https://jenkins.thetaphi.de/job/Lucene-10.x-Release-Tester/5/consoleFull
Maybe the test should be marked AwaitFix until it is d
guojialiang92 commented on PR #14417:
URL: https://github.com/apache/lucene/pull/14417#issuecomment-2788140261
Thanks, @vigyasharma
I have made the modifications as suggested, please reivew the code again.
--
This is an automated message from the Apache Git Service.
To respond to the m
rmuir commented on code in PR #14433:
URL: https://github.com/apache/lucene/pull/14433#discussion_r2034195959
##
lucene/core/src/java/org/apache/lucene/search/similarities/Similarity.java:
##
@@ -161,6 +162,17 @@ public long computeNorm(FieldInvertState state) {
return Smal
kaivalnp commented on PR #14178:
URL: https://github.com/apache/lucene/pull/14178#issuecomment-2787367839
Thanks @msokolov!
> no longer necessary to follow all the steps documented above (to build
libfaiss_c.so) right?
Yes, we no longer need to build the C API of Faiss (it is p
github-actions[bot] commented on PR #14395:
URL: https://github.com/apache/lucene/pull/14395#issuecomment-2787928763
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
dsmiley commented on PR #14433:
URL: https://github.com/apache/lucene/pull/14433#issuecomment-2787942020
What name would you suggest then, Rob?
There's something to be said for choosing a name that's correct for the vast
majority of cases, even if hypothetically a Similarity might do some
rmuir commented on code in PR #14433:
URL: https://github.com/apache/lucene/pull/14433#discussion_r2034192030
##
lucene/core/src/java/org/apache/lucene/search/similarities/Similarity.java:
##
@@ -161,6 +162,17 @@ public long computeNorm(FieldInvertState state) {
return Smal
dsmiley commented on code in PR #14433:
URL: https://github.com/apache/lucene/pull/14433#discussion_r2034358885
##
lucene/core/src/java/org/apache/lucene/search/similarities/Similarity.java:
##
@@ -161,6 +162,17 @@ public long computeNorm(FieldInvertState state) {
return Sm
vigyasharma merged PR #14417:
URL: https://github.com/apache/lucene/pull/14417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene
rmuir commented on code in PR #14433:
URL: https://github.com/apache/lucene/pull/14433#discussion_r2034196400
##
lucene/queries/src/java/org/apache/lucene/queries/function/IndexReaderFunctions.java:
##
@@ -301,6 +304,17 @@ public static DoubleValuesSource docCount(String field)
rmuir commented on PR #14433:
URL: https://github.com/apache/lucene/pull/14433#issuecomment-2787922548
I think there is a high-level problem here, as i stated originally, that
norm is not any position length. For example it may be based on
`FieldInvertState.getMaxTermFrequency()` or
`Field
17 matches
Mail list logo
