Re: [PR] Fix HistogramCollector to not create zero-count buckets. [lucene]

2025-03-31 Thread via GitHub
jpountz merged PR #14421: URL: https://github.com/apache/lucene/pull/14421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Fix HistogramCollector to not create zero-count buckets. [lucene]

2025-03-31 Thread via GitHub
jpountz commented on PR #14421: URL: https://github.com/apache/lucene/pull/14421#issuecomment-2766465560 I backported to branch_10_2 since this is a bugfix cc @iverase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] quick exit on filter query matching no docs when rewriting knn query [lucene]

2025-03-31 Thread via GitHub
jpountz merged PR #14418: URL: https://github.com/apache/lucene/pull/14418 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

[I] Add more information to IOContext [lucene]

2025-03-31 Thread via GitHub
thecoop opened a new issue, #14422: URL: https://github.com/apache/lucene/issues/14422 ### Description Currently Lucene tends to use `ReadAdvice.RANDOM` quite liberally, in various hard-coded locations. We have seen that this causes some problems with recent kernel versions, such as

Re: [PR] quick exit on filter query matching no docs when rewriting knn query [lucene]

2025-03-31 Thread via GitHub
bugmakerr commented on PR #14418: URL: https://github.com/apache/lucene/pull/14418#issuecomment-2766274186 > So in the case when the filter rewrites to MatchNoDocsQuery, `IndexSearcher#search` would now return immediately, while it may currently need to wait for tasks to be submitted (i

Re: [PR] Enable collectors to take advantage of pre-aggregated data. [lucene]

2025-03-31 Thread via GitHub
gf2121 commented on PR #14401: URL: https://github.com/apache/lucene/pull/14401#issuecomment-2765918007 The change of https://github.com/apache/lucene/pull/14421 is also included, which seems not expected? -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] Disable the query cache by default. [lucene]

2025-03-31 Thread via GitHub
msfroh commented on code in PR #14187: URL: https://github.com/apache/lucene/pull/14187#discussion_r2021571472 ## lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java: ## @@ -77,7 +77,8 @@ public class IndexSearcher { static int maxClauseCount = 1024; - privat

Re: [PR] add Automaton.toMermaid() for emitting mermaid state charts [lucene]

2025-03-31 Thread via GitHub
github-actions[bot] commented on PR #14360: URL: https://github.com/apache/lucene/pull/14360#issuecomment-2767713257 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Enable collectors to take advantage of pre-aggregated data. [lucene]

2025-03-31 Thread via GitHub
jpountz merged PR #14401: URL: https://github.com/apache/lucene/pull/14401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Adding profiling support for concurrent segment search [lucene]

2025-03-31 Thread via GitHub
jainankitk commented on PR #14413: URL: https://github.com/apache/lucene/pull/14413#issuecomment-2767417910 @jpountz - Can you provide your thoughts on above? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] PointInSetQuery clips segments by lower and upper [lucene]

2025-03-31 Thread via GitHub
gsmiller commented on code in PR #14268: URL: https://github.com/apache/lucene/pull/14268#discussion_r2021381006 ## lucene/CHANGES.txt: ## @@ -186,6 +186,8 @@ Optimizations * GITHUB#14272: Use DocIdSetIterator#range for continuous-id BKD leaves. (Guo Feng) +* GITHUB#14268:

Re: [PR] Optimize commit retention policy to maintain only the last 5 commits [lucene]

2025-03-31 Thread via GitHub
github-actions[bot] commented on PR #14325: URL: https://github.com/apache/lucene/pull/14325#issuecomment-2767713463 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [I] Add more information to IOContext [lucene]

2025-03-31 Thread via GitHub
jpountz commented on issue #14422: URL: https://github.com/apache/lucene/issues/14422#issuecomment-2767398441 @rmuir I'm curious if you can expand a bit more on what you have in mind, what you are describing sounds to me like how things are today where `ReadAdvice.RANDOM` is the context and

Re: [PR] Reduce the number of comparisons when lowerPoint is equal to upperPoint [lucene]

2025-03-31 Thread via GitHub
jainankitk commented on code in PR #14267: URL: https://github.com/apache/lucene/pull/14267#discussion_r2021794022 ## lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java: ## @@ -129,6 +141,16 @@ public final Weight createWeight(IndexSearcher searcher, ScoreMode s

Re: [PR] PointInSetQuery early exit on non-matching segments [lucene]

2025-03-31 Thread via GitHub
hanbj commented on code in PR #14268: URL: https://github.com/apache/lucene/pull/14268#discussion_r2022087763 ## lucene/CHANGES.txt: ## @@ -186,6 +186,8 @@ Optimizations * GITHUB#14272: Use DocIdSetIterator#range for continuous-id BKD leaves. (Guo Feng) +* GITHUB#14268: Po

Re: [PR] cache preset dict for LZ4WithPresetDictDecompressor [lucene]

2025-03-31 Thread via GitHub
jainankitk commented on code in PR #14397: URL: https://github.com/apache/lucene/pull/14397#discussion_r2021750116 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/LZ4WithPresetDictCompressionMode.java: ## @@ -98,12 +98,17 @@ public void decompress(DataInput in, int ori

Re: [PR] cache preset dict for LZ4WithPresetDictDecompressor [lucene]

2025-03-31 Thread via GitHub
jainankitk commented on code in PR #14397: URL: https://github.com/apache/lucene/pull/14397#discussion_r2021748068 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/LZ4WithPresetDictCompressionMode.java: ## @@ -144,10 +148,85 @@ public void decompress(DataInput in, int o