Re: [I] `mergeThreadCount` is both a variable and a method in the `ConcurrentMergeScheduler` [lucene]

2025-03-30 Thread via GitHub
vigyasharma closed issue #13114: `mergeThreadCount` is both a variable and a method in the `ConcurrentMergeScheduler` URL: https://github.com/apache/lucene/issues/13114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Rename `mergeThreadCount` in ConcurrentMergeScheduler to avoid clashing with method of the same name [lucene]

2025-03-30 Thread via GitHub
vigyasharma merged PR #14171: URL: https://github.com/apache/lucene/pull/14171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene

Re: [PR] Support modifying segmentInfos.counter in IndexWriter [lucene]

2025-03-30 Thread via GitHub
vigyasharma commented on PR #14417: URL: https://github.com/apache/lucene/pull/14417#issuecomment-2764422079 Also, IIUC `IndexWriter#advanceSegmentInfosVersion()` was added to handle similar scenarios for NRT replication (Lucene's native segment replication implementation). I'm curious why

Re: [PR] Allow skip cache factor to be updated dynamically [lucene]

2025-03-30 Thread via GitHub
kkewwei commented on PR #14412: URL: https://github.com/apache/lucene/pull/14412#issuecomment-2764949091 Thank you for your reply. I understand your perspective. You aim to optimize execution efficiency rather than focus on cache optimization. In certain rare scenarios, the querycache

Re: [PR] PointInSetQuery clips segments by lower and upper [lucene]

2025-03-30 Thread via GitHub
hanbj commented on code in PR #14268: URL: https://github.com/apache/lucene/pull/14268#discussion_r2020443439 ## lucene/core/src/java/org/apache/lucene/search/PointInSetQuery.java: ## @@ -108,6 +110,8 @@ protected PointInSetQuery(String field, int numDims, int bytesPerDim, Stre

Re: [PR] PointInSetQuery clips segments by lower and upper [lucene]

2025-03-30 Thread via GitHub
hanbj commented on code in PR #14268: URL: https://github.com/apache/lucene/pull/14268#discussion_r2020445557 ## lucene/core/src/java/org/apache/lucene/search/PointInSetQuery.java: ## @@ -153,6 +162,21 @@ public ScorerSupplier scorerSupplier(LeafReaderContext context) throws IO

Re: [PR] PointInSetQuery clips segments by lower and upper [lucene]

2025-03-30 Thread via GitHub
hanbj commented on code in PR #14268: URL: https://github.com/apache/lucene/pull/14268#discussion_r2020445151 ## lucene/core/src/java/org/apache/lucene/search/PointInSetQuery.java: ## @@ -153,6 +162,21 @@ public ScorerSupplier scorerSupplier(LeafReaderContext context) throws IO

Re: [PR] quick exit on filter query matching no docs when rewriting knn query [lucene]

2025-03-30 Thread via GitHub
jpountz commented on PR #14418: URL: https://github.com/apache/lucene/pull/14418#issuecomment-2764554455 Thank you, that makes sense. So in the case when the filter rewrites to MatchNoDocsQuery, `IndexSearcher#search` would now return immediately, while it may currently need to wait for tas

Re: [PR] A specialized Trie for Block Tree Index [lucene]

2025-03-30 Thread via GitHub
gf2121 commented on code in PR #14333: URL: https://github.com/apache/lucene/pull/14333#discussion_r2006853334 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/TrieBuilder.java: ## @@ -0,0 +1,552 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] Allow skip cache factor to be updated dynamically [lucene]

2025-03-30 Thread via GitHub
jpountz commented on PR #14412: URL: https://github.com/apache/lucene/pull/14412#issuecomment-2764454882 > I am wondering if we should also make maxRamBytesUsed dynamic as well. What is your use-case for tuning it? Related to my comment on the issue linked to this PR, I worry a bit ab

Re: [PR] Allow skip cache factor to be updated dynamically [lucene]

2025-03-30 Thread via GitHub
jpountz merged PR #14412: URL: https://github.com/apache/lucene/pull/14412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa