Re: [PR] Allow skip cache factor to be updated dynamically [lucene]

jpountz commented on code in PR #14412: URL: https://github.com/apache/lucene/pull/14412#discussion_r2019755560 ## lucene/CHANGES.txt: ## @@ -47,6 +47,7 @@ Other - * GITHUB#14229: Bump minimum required Java version to 25 +* GITHUB#14412: Allow skip cache

Re: [PR] Allow skip cache factor to be updated dynamically [lucene]

kkewwei commented on PR #14412: URL: https://github.com/apache/lucene/pull/14412#issuecomment-2763254947 I am wondering if we should also make `maxRamBytesUsed` dynamic as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] cache preset dict for LZ4WithPresetDictDecompressor [lucene]

kkewwei commented on code in PR #14397: URL: https://github.com/apache/lucene/pull/14397#discussion_r2019766795 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingStoredFieldsReader.java: ## @@ -512,6 +512,7 @@ private void doReset(int docID

Re: [PR] quick exit on filter query matching no docs when rewriting knn query [lucene]

bugmakerr commented on PR #14418: URL: https://github.com/apache/lucene/pull/14418#issuecomment-2763256416 > Can you help me understand what work this change helps save? Thanks for your reply. I think if the filter query matches no docs, the knn query must also match no docs. Befo

Re: [PR] Allow skip cache factor to be updated dynamically [lucene]

sgup432 commented on code in PR #14412: URL: https://github.com/apache/lucene/pull/14412#discussion_r2019868684 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -142,6 +142,20 @@ public LRUQueryCache( missCount = new LongAdder(); } + public f

Re: [PR] Fix HistogramCollector to not create zero-count buckets. [lucene]

jpountz commented on code in PR #14421: URL: https://github.com/apache/lucene/pull/14421#discussion_r2019755410 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/plain/histograms/HistogramCollector.java: ## @@ -279,7 +279,9 @@ public void collect(DocIdStream stream) thr

Re: [PR] Allow skip cache factor to be updated dynamically [lucene]

sgup432 commented on code in PR #14412: URL: https://github.com/apache/lucene/pull/14412#discussion_r2019868684 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -142,6 +142,20 @@ public LRUQueryCache( missCount = new LongAdder(); } + public f

Re: [PR] Allow skip cache factor to be updated dynamically [lucene]

sgup432 commented on code in PR #14412: URL: https://github.com/apache/lucene/pull/14412#discussion_r2019870708 ## lucene/CHANGES.txt: ## @@ -47,6 +47,7 @@ Other - * GITHUB#14229: Bump minimum required Java version to 25 +* GITHUB#14412: Allow skip cache