Re: [PR] [Draft] Support Multi-Vector HNSW Search via Flat Vector Storage [lucene]

2025-03-23 Thread via GitHub
alessandrobenedetti commented on PR #14173: URL: https://github.com/apache/lucene/pull/14173#issuecomment-2743201362 @vigyasharma, from a first superficial pass, I see that this PR touches similar points of my original outdated one: https://github.com/apache/lucene/pull/12314, but it see

Re: [PR] bump antlr 4.11.1 -> 4.13.2 [lucene]

2025-03-23 Thread via GitHub
rmuir merged PR #14388: URL: https://github.com/apache/lucene/pull/14388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apach

Re: [PR] Optimize ParallelLeafReader to improve term vector fetching efficienc [lucene]

2025-03-23 Thread via GitHub
DivyanshIITB commented on code in PR #14373: URL: https://github.com/apache/lucene/pull/14373#discussion_r2009127681 ## lucene/CHANGES.txt: ## @@ -35,6 +35,10 @@ Optimizations - * GITHUB#14011: Reduce allocation rate in HNSW concurrent merge. (Viliam Durin

Re: [PR] Optimize ParallelLeafReader to improve term vector fetching efficienc [lucene]

2025-03-23 Thread via GitHub
DivyanshIITB commented on PR #14373: URL: https://github.com/apache/lucene/pull/14373#issuecomment-2746245859 > > I successfully ran `./gradlew tidy` and the built was successful. > > Github build is still failing on spotless (formatting). `tidy` will change and reformat offending fil

Re: [PR] Speed up advancing within a sparse block in IndexedDISI. [lucene]

2025-03-23 Thread via GitHub
vsop-479 commented on PR #14371: URL: https://github.com/apache/lucene/pull/14371#issuecomment-2747056694 @gf2121 For what it's worth, I implemented this patch, and measured with luceneutil on `wikimedium10m`. TaskQPS baseline StdDevQPS my_modified_version

Re: [I] Exploring GPU based kNN vector search [lucene]

2025-03-23 Thread via GitHub
alessandrobenedetti commented on issue #13003: URL: https://github.com/apache/lucene/issues/13003#issuecomment-2743054765 Does https://github.com/apache/lucene/issues/14243 supersede this one? should we close it? -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Optimize ParallelLeafReader to improve term vector fetching efficienc [lucene]

2025-03-23 Thread via GitHub
vigyasharma commented on PR #14373: URL: https://github.com/apache/lucene/pull/14373#issuecomment-2747063076 Changes merged. Thanks @DivyanshIITB ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Fix comment typo [lucene]

2025-03-23 Thread via GitHub
gf2121 merged PR #14392: URL: https://github.com/apache/lucene/pull/14392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

Re: [PR] Fix comment typo [lucene]

2025-03-23 Thread via GitHub
gf2121 commented on PR #14392: URL: https://github.com/apache/lucene/pull/14392#issuecomment-2747016784 Thanks @flat35hd99 ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] Fix comment typo [lucene]

2025-03-23 Thread via GitHub
flat35hd99 opened a new pull request, #14392: URL: https://github.com/apache/lucene/pull/14392 ### Description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[PR] Pack file pointers when merging BKD trees [lucene]

2025-03-23 Thread via GitHub
iverase opened a new pull request, #14393: URL: https://github.com/apache/lucene/pull/14393 We are currently using long arrays to hold file pointers. These arrays can get pretty big if the number of points is big which seems wasteful, moreover when those file pointers are monotonically incr

Re: [PR] Speed up advancing within a sparse block in IndexedDISI. [lucene]

2025-03-23 Thread via GitHub
vsop-479 commented on PR #14371: URL: https://github.com/apache/lucene/pull/14371#issuecomment-2747066080 Maybe I should measure it with `DVBench` in luceneutil, or add a bench in jmh. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Optimize ParallelLeafReader to improve term vector fetching efficienc [lucene]

2025-03-23 Thread via GitHub
vigyasharma merged PR #14373: URL: https://github.com/apache/lucene/pull/14373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene

Re: [PR] Optimize ParallelLeafReader to improve term vector fetching efficienc [lucene]

2025-03-23 Thread via GitHub
vigyasharma commented on PR #14373: URL: https://github.com/apache/lucene/pull/14373#issuecomment-2745914617 > I successfully ran `./gradlew tidy` and the built was successful. Github build is still failing on spotless (formatting). `tidy` will change and reformat offending files for