Re: [PR] OptimisticKnnVectorQuery [lucene]

2025-03-02 Thread via GitHub
msokolov commented on PR #14226: URL: https://github.com/apache/lucene/pull/14226#issuecomment-2692803205 Sorry, it took me a while to get back to this. My local setup got messed up and somehow I was exhaustively searching entire segments! Anyway I finally got this working again, including

Re: [PR] python scripts: fix enough so that undefined variable analysis works [lucene]

2025-03-02 Thread via GitHub
rmuir merged PR #14319: URL: https://github.com/apache/lucene/pull/14319 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apach

[I] TestKnnGraph.testMultiThreadedSearch random test failure [lucene]

2025-03-02 Thread via GitHub
rmuir opened a new issue, #14327: URL: https://github.com/apache/lucene/issues/14327 ### Description ``` > java.lang.AssertionError: [doc=0 score=0.990099 shardIndex=-1, doc=3 score=0.49751243 shardIndex=-1, doc=5 score=0.21691975 shardIndex=-1, doc=6 score=0.19960079 shard

Re: [PR] Fix DirectIOIndexInput seek to not read when position is within buffer [lucene]

2025-03-02 Thread via GitHub
rmuir commented on code in PR #14320: URL: https://github.com/apache/lucene/pull/14320#discussion_r1976613907 ## lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java: ## @@ -373,7 +373,13 @@ public long getFilePointer() { @Override public void seek(

Re: [PR] Fix DirectIOIndexInput seek to not read when position is within buffer [lucene]

2025-03-02 Thread via GitHub
ChrisHegarty commented on PR #14320: URL: https://github.com/apache/lucene/pull/14320#issuecomment-2692699601 I’m going to see if I can write a few small unit tests for this particular scenario. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] python scripts: enable standard type checking [lucene]

2025-03-02 Thread via GitHub
rmuir commented on PR #14321: URL: https://github.com/apache/lucene/pull/14321#issuecomment-2692800932 After this PR, i'd like to run `make reformat` and create PR with the result. The mix of 2-space and 4-space indentation is killing me :) -- This is an automated message from the Apache

[PR] python scripts: enable standard type checking [lucene]

2025-03-02 Thread via GitHub
rmuir opened a new pull request, #14321: URL: https://github.com/apache/lucene/pull/14321 Fix all the type issues, enable checking so that no more creep in. A couple third-party libraries have some issues (such as totally wrong typing), I just disabled in that case. Fixes are m

Re: [PR] SortedSet DV Multi Range query [lucene]

2025-03-02 Thread via GitHub
mkhludnev commented on PR #13974: URL: https://github.com/apache/lucene/pull/13974#issuecomment-2692875765 >.. ranges aiming IP/masks Turns out there are many varieties in range fields: single vs multiple values, number of dimensions and range search operations. Let's postpone it til

Re: [I] TestDirectIODirectory is slow on Ubuntu/Linux systems [lucene]

2025-03-02 Thread via GitHub
ChrisHegarty commented on issue #14315: URL: https://github.com/apache/lucene/issues/14315#issuecomment-2692698948 > Sorry, couldn't find the time to do this yesterday. No problem at all. You and Robert did the heavy lifting here! The fix is trivial. -- This is an automated

Re: [I] TestDirectIODirectory is slow on Ubuntu/Linux systems [lucene]

2025-03-02 Thread via GitHub
dweiss closed issue #14315: TestDirectIODirectory is slow on Ubuntu/Linux systems URL: https://github.com/apache/lucene/issues/14315 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [I] TestDirectIODirectory is slow on Ubuntu/Linux systems [lucene]

2025-03-02 Thread via GitHub
dweiss commented on issue #14315: URL: https://github.com/apache/lucene/issues/14315#issuecomment-2692836935 Fix in #14320. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] python scripts: enable standard type checking [lucene]

2025-03-02 Thread via GitHub
rmuir merged PR #14321: URL: https://github.com/apache/lucene/pull/14321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apach

[PR] reformat the python code with 'make reformat' and enable format in CI check [lucene]

2025-03-02 Thread via GitHub
rmuir opened a new pull request, #14322: URL: https://github.com/apache/lucene/pull/14322 currently the python code has a mix of indentation, styles, imports ordering, etc. for example, it is very difficult to work with mixed indentation levels: the language is sensitive to indentation.

Re: [PR] Add changelog verifier [lucene]

2025-03-02 Thread via GitHub
stefanvodita closed pull request #13909: Add changelog verifier URL: https://github.com/apache/lucene/pull/13909 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [I] TestDirectIODirectory is slow on Ubuntu/Linux systems [lucene]

2025-03-02 Thread via GitHub
dweiss commented on issue #14315: URL: https://github.com/apache/lucene/issues/14315#issuecomment-2692694414 Sorry, couldn't find the time to do this yesterday. Thanks for finding the root of the problem, @ChrisHegarty ! -- This is an automated message from the Apache Git Service. To resp

Re: [PR] Fix DirectIOIndexInput seek to not read when position is within buffer [lucene]

2025-03-02 Thread via GitHub
dweiss commented on PR #14320: URL: https://github.com/apache/lucene/pull/14320#issuecomment-2692695298 Good find! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[PR] python: enable all linting checks and type-hint the code [lucene]

2025-03-02 Thread via GitHub
rmuir opened a new pull request, #14326: URL: https://github.com/apache/lucene/pull/14326 Review https://github.com/apache/lucene/pull/14322 separate as it is included here to prevent merge conflicts. So look at the 2nd commit if you want to see what has changed: * enable all type

Re: [PR] OptimisticKnnVectorQuery [lucene]

2025-03-02 Thread via GitHub
msokolov commented on PR #14226: URL: https://github.com/apache/lucene/pull/14226#issuecomment-2692810655 Also, I forgot about this comment: > Would it make sense to cap perLeafTopK by the original k? I think k is double on every iteration, and perLeafTopK can theoretically go over th

Re: [PR] Optimize commit retention policy to maintain only the last 5 commits [lucene]

2025-03-02 Thread via GitHub
DivyanshIITB closed pull request #14323: Optimize commit retention policy to maintain only the last 5 commits URL: https://github.com/apache/lucene/pull/14323 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] Add PR number to output of changelog action [lucene]

2025-03-02 Thread via GitHub
stefanvodita opened a new pull request, #14324: URL: https://github.com/apache/lucene/pull/14324 Make it easier to understand the output by having the PR number referenced in the logs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [I] Create a bot to check if there is a CHANGES entry for new PRs [lucene]

2025-03-02 Thread via GitHub
stefanvodita commented on issue #13898: URL: https://github.com/apache/lucene/issues/13898#issuecomment-2692956304 I was looking at the workflow that @pseudo-nymous wrote. The [logs](https://github.com/apache/lucene/actions/runs/13597403773/job/38017259510) for #14276 say there is no CHANGE

Re: [PR] Add changelog verifier [lucene]

2025-03-02 Thread via GitHub
stefanvodita commented on PR #13909: URL: https://github.com/apache/lucene/pull/13909#issuecomment-2692955030 This was done better in #14279. Plus, I've accidentally overwritten the branch here. Closing. -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] Add PR number to output of changelog action [lucene]

2025-03-02 Thread via GitHub
stefanvodita merged PR #14324: URL: https://github.com/apache/lucene/pull/14324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucen

Re: [PR] Make Lucene better at skipping long runs of matches. [lucene]

2025-03-02 Thread via GitHub
gf2121 commented on code in PR #14312: URL: https://github.com/apache/lucene/pull/14312#discussion_r1976945729 ## lucene/core/src/java/org/apache/lucene/search/DenseConjunctionBulkScorer.java: ## @@ -128,6 +128,16 @@ private void scoreWindowUsingBitSet( assert windowMatches

Re: [PR] Make Lucene better at skipping long runs of matches. [lucene]

2025-03-02 Thread via GitHub
gf2121 commented on code in PR #14312: URL: https://github.com/apache/lucene/pull/14312#discussion_r1976952412 ## lucene/core/src/java/org/apache/lucene/search/DenseConjunctionBulkScorer.java: ## @@ -128,6 +128,16 @@ private void scoreWindowUsingBitSet( assert windowMatches

Re: [PR] Fix DirectIOIndexInput seek to not read when position is within buffer [lucene]

2025-03-02 Thread via GitHub
rmuir commented on code in PR #14320: URL: https://github.com/apache/lucene/pull/14320#discussion_r1976613907 ## lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java: ## @@ -373,7 +373,13 @@ public long getFilePointer() { @Override public void seek(