[PR] SlowCompositeCodecReaderWrapper copies sub-vector values for thread-safety [lucene]

2024-12-31 Thread via GitHub
msokolov opened a new pull request, #14092: URL: https://github.com/apache/lucene/pull/14092 This was a bug introduced with #13779. I'm guessing it has been of no consequence because `SlowCompositeCodecReaderWrapper` is normally only used by a single merge thread. However I came across test

[PR] Cover all DataType [lucene]

2024-12-31 Thread via GitHub
LuXugang opened a new pull request, #14091: URL: https://github.com/apache/lucene/pull/14091 A change made ten years ago—did you forget to change `DataType.PACKED` back to `DataType.values()`? 😊 @jpountz -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] Add some basic HNSW graph checks to CheckIndex [lucene]

2024-12-31 Thread via GitHub
benchaplin commented on PR #13984: URL: https://github.com/apache/lucene/pull/13984#issuecomment-2566774509 I've added @msokolov's node-in-range check + neighbor-on-same-level check, and @tteofili's connectivity check. I chose not to throw an exception for disconnectedness, as I've found th

[I] VirtualMachineError: Out of space in CodeCache for adapters in gradle [lucene]

2024-12-31 Thread via GitHub
dweiss opened a new issue, #14090: URL: https://github.com/apache/lucene/issues/14090 ### Description I've seen this a few times in jenkins and now github [1]: [smoke-tester-logs-jdk-21.zip](https://github.com/user-attachments/files/18280106/smoke-tester-logs-jdk-21.zip) Per

Re: [PR] Use read advice consistently in the knn vector formats [lucene]

2024-12-31 Thread via GitHub
shatejas commented on PR #14076: URL: https://github.com/apache/lucene/pull/14076#issuecomment-2566719988 > I may have overstated my point, I didn’t test it directly. My main concern is that the advice applies for the entire duration of the merge. Since the vector copy occurs at the start a

Re: [PR] SlowCompositeCodecReaderWrapper copies sub-vector values for thread-safety [lucene]

2024-12-31 Thread via GitHub
msokolov merged PR #14092: URL: https://github.com/apache/lucene/pull/14092 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.ap