Re: [PR] Add a Better Binary Quantizer (RaBitQ) format for dense vectors [lucene]

2024-11-05 Thread via GitHub
ShashwatShivam commented on PR #13651: URL: https://github.com/apache/lucene/pull/13651#issuecomment-2456984008 Hi Ben, I'm trying to get a benchmark run for RaBitQ using luceneutil (https://github.com/mikemccand/luceneutil), but I'm facing some missing files issue - java.lang.NoClassDefFou

Re: [PR] Add a Better Binary Quantizer (RaBitQ) format for dense vectors [lucene]

2024-11-05 Thread via GitHub
benwtrent commented on PR #13651: URL: https://github.com/apache/lucene/pull/13651#issuecomment-2457031733 Hey @ShashwatShivam https://github.com/mikemccand/luceneutil/compare/main...benwtrent:luceneutil:bbq that is the testing script I use. But if Lucene has since been update

Re: [PR] Remove `supportsConcurrency` flag from top-docs collector managers. [lucene]

2024-11-05 Thread via GitHub
jpountz merged PR #13977: URL: https://github.com/apache/lucene/pull/13977 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [I] Should we auto-adjust top score doc and top field collector manager based on slices? [lucene]

2024-11-05 Thread via GitHub
jpountz commented on issue #13791: URL: https://github.com/apache/lucene/issues/13791#issuecomment-2457351174 Partially addressed via #13977. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Revert "Disjunction as CompetitiveIterator for numeric dynamic pruning (#13221)" [lucene]

2024-11-05 Thread via GitHub
javanna merged PR #13971: URL: https://github.com/apache/lucene/pull/13971 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [I] Significant performance regression with search after [lucene]

2024-11-05 Thread via GitHub
javanna closed issue #13856: Significant performance regression with search after URL: https://github.com/apache/lucene/issues/13856 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] PR 13757 follow-up: add missing with-discountOverlaps Similarity constructor variants, CHANGES.txt entries (#13845) [lucene]

2024-11-05 Thread via GitHub
javanna commented on PR #13891: URL: https://github.com/apache/lucene/pull/13891#issuecomment-2457943937 @cpoerschke would you mind getting this in, but backing out the changes to 9.12.0 section of the change log? -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] [WIP] Multi-Vector support for HNSW search [lucene]

2024-11-05 Thread via GitHub
benwtrent commented on PR #13525: URL: https://github.com/apache/lucene/pull/13525#issuecomment-2457990323 > One use-case for multi-vectors is indexing product aspects as separate embeddings for e-commerce search. At Amazon Product Search (where I work), we'd like to experiment with separat

Re: [PR] Optimize slice calculation in IndexSearcher a little [lucene]

2024-11-05 Thread via GitHub
javanna commented on code in PR #13860: URL: https://github.com/apache/lucene/pull/13860#discussion_r1829869859 ## lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java: ## @@ -540,7 +523,43 @@ public int count(Query query) throws IOException { * @lucene.experimen

Re: [I] TestPostingsUtil > testIntegerOverflow [lucene]

2024-11-05 Thread via GitHub
benwtrent commented on issue #13978: URL: https://github.com/apache/lucene/issues/13978#issuecomment-2458176189 OK, git bisect says: cfdd20f5bc8387ba24653ca2ba15aa5be10d0ae0 That bisect seems correct. //CC @jpountz -- This is an automated message from the Apache Git Service.

Re: [I] TestPostingsUtil > testIntegerOverflow [lucene]

2024-11-05 Thread via GitHub
jpountz commented on issue #13978: URL: https://github.com/apache/lucene/issues/13978#issuecomment-2458232736 Woops, I'll look, thanks for bisecting! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[I] TestPostingsUtil > testIntegerOverflow [lucene]

2024-11-05 Thread via GitHub
benwtrent opened a new issue, #13978: URL: https://github.com/apache/lucene/issues/13978 ### Description Fails repeatably on current main. Didn't try other branches yet. ``` TestPostingsUtil > testIntegerOverflow FAILED java.lang.ArithmeticException: integer overflow

[PR] Fix TestPostingsUtil#testIntegerOverflow failure. [lucene]

2024-11-05 Thread via GitHub
jpountz opened a new pull request, #13979: URL: https://github.com/apache/lucene/pull/13979 The group vint logic is mistakenly using the long->int conversion logic for the case when integers are being written rather than longs. Closes #13978 -- This is an automated message from the

Re: [I] Move vector search from IndexInput to RandomAccessInput [lucene]

2024-11-05 Thread via GitHub
dungba88 commented on issue #13938: URL: https://github.com/apache/lucene/issues/13938#issuecomment-2458667635 I looked at some implementation of RandomAccessInput, such as BufferedIndexInput. This particular class holds a single buffer for all reads, thus it cannot be shared. If we use tem