Re: [PR] New JMH benchmark method - vdot8s that implement int8 dotProduct in C… [lucene]

2024-10-28 Thread via GitHub
goankur commented on code in PR #13572: URL: https://github.com/apache/lucene/pull/13572#discussion_r1819887022 ## lucene/core/src/java21/org/apache/lucene/internal/vectorization/Lucene99MemorySegmentScalarQuantizedVectorScorer.java: ## @@ -0,0 +1,407 @@ +/* + * Licensed to the

Re: [PR] New JMH benchmark method - vdot8s that implement int8 dotProduct in C… [lucene]

2024-10-28 Thread via GitHub
goankur commented on code in PR #13572: URL: https://github.com/apache/lucene/pull/13572#discussion_r1819967252 ## lucene/native/src/c/dotProduct.c: ## @@ -0,0 +1,209 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements

Re: [PR] PR 13757 follow-up: add missing with-discountOverlaps Similarity constructor variants, CHANGES.txt entries (#13845) [lucene]

2024-10-28 Thread via GitHub
github-actions[bot] commented on PR #13891: URL: https://github.com/apache/lucene/pull/13891#issuecomment-2442918959 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] New JMH benchmark method - vdot8s that implement int8 dotProduct in C… [lucene]

2024-10-28 Thread via GitHub
goankur commented on code in PR #13572: URL: https://github.com/apache/lucene/pull/13572#discussion_r1819967252 ## lucene/native/src/c/dotProduct.c: ## @@ -0,0 +1,209 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements

Re: [PR] New JMH benchmark method - vdot8s that implement int8 dotProduct in C… [lucene]

2024-10-28 Thread via GitHub
goankur commented on code in PR #13572: URL: https://github.com/apache/lucene/pull/13572#discussion_r1819967252 ## lucene/native/src/c/dotProduct.c: ## @@ -0,0 +1,209 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements

Re: [PR] New JMH benchmark method - vdot8s that implement int8 dotProduct in C… [lucene]

2024-10-28 Thread via GitHub
goankur commented on code in PR #13572: URL: https://github.com/apache/lucene/pull/13572#discussion_r1819967252 ## lucene/native/src/c/dotProduct.c: ## @@ -0,0 +1,209 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements

Re: [PR] Support multi-tenant RAM buffers for IndexWriter [lucene]

2024-10-28 Thread via GitHub
vigyasharma commented on code in PR #13951: URL: https://github.com/apache/lucene/pull/13951#discussion_r1820167245 ## lucene/core/src/java/org/apache/lucene/index/IndexWriterRAMManager.java: ## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [I] Java is not supported real? [lucene]

2024-10-28 Thread via GitHub
dabao1990 commented on issue #13960: URL: https://github.com/apache/lucene/issues/13960#issuecomment-2442972571 > Java 21 is the required minimum for Lucene 10. > > You mentioned additional failures after installing java 22, could you provide that information? After cleaning up

Re: [PR] Support multi-tenant RAM buffers for IndexWriter [lucene]

2024-10-28 Thread via GitHub
vigyasharma commented on code in PR #13951: URL: https://github.com/apache/lucene/pull/13951#discussion_r1820159346 ## lucene/core/src/java/org/apache/lucene/index/IndexWriterRAMManager.java: ## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Support multi-tenant RAM buffers for IndexWriter [lucene]

2024-10-28 Thread via GitHub
vigyasharma commented on code in PR #13951: URL: https://github.com/apache/lucene/pull/13951#discussion_r1820163993 ## lucene/core/src/java/org/apache/lucene/index/IndexWriterRAMManager.java: ## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Support multi-tenant RAM buffers for IndexWriter [lucene]

2024-10-28 Thread via GitHub
vigyasharma commented on code in PR #13951: URL: https://github.com/apache/lucene/pull/13951#discussion_r1820163993 ## lucene/core/src/java/org/apache/lucene/index/IndexWriterRAMManager.java: ## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Speed up advancing within a block, take 2. [lucene]

2024-10-28 Thread via GitHub
jpountz commented on PR #13958: URL: https://github.com/apache/lucene/pull/13958#issuecomment-2442236520 Here's wikimediumall on a c7i.2xlarge instance that supports AVX512: ``` TaskQPS baseline StdDevQPS my_modified_version StdDev

[PR] replace Map with IntObjectHashMap for DV producer [lucene]

2024-10-28 Thread via GitHub
bugmakerr opened a new pull request, #13961: URL: https://github.com/apache/lucene/pull/13961 ### Description Add back #13686, which is reverted previously due to #13805. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] DocValuesSkipper implementation in IndexSortSorted [lucene]

2024-10-28 Thread via GitHub
BrianWoolfolk commented on code in PR #13886: URL: https://github.com/apache/lucene/pull/13886#discussion_r1819467637 ## lucene/core/src/java/org/apache/lucene/search/IndexSortSortedNumericDocValuesRangeQuery.java: ## @@ -397,106 +413,80 @@ private boolean matchAll(PointValues p

Re: [PR] DocValuesSkipper implementation in IndexSortSorted [lucene]

2024-10-28 Thread via GitHub
BrianWoolfolk commented on code in PR #13886: URL: https://github.com/apache/lucene/pull/13886#discussion_r1819458522 ## lucene/core/src/java/org/apache/lucene/search/IndexSortSortedNumericDocValuesRangeQuery.java: ## @@ -20,9 +20,11 @@ import java.util.ArrayDeque; import java

Re: [I] Java is not supported real? [lucene]

2024-10-28 Thread via GitHub
benwtrent commented on issue #13960: URL: https://github.com/apache/lucene/issues/13960#issuecomment-2441405534 Java 21 is the required minimum for Lucene 10. You mentioned additional failures after installing java 22, could you provide that information? -- This is an automated me

Re: [PR] [WIP] Multi-Vector support for HNSW search [lucene]

2024-10-28 Thread via GitHub
jimczi commented on PR #13525: URL: https://github.com/apache/lucene/pull/13525#issuecomment-2441247130 > it seems like single vector is a special form of multi-vector The solution really depends on the semantics. In its current form, the way multi-vectors are incorporated in this PR

Re: [PR] Remove HitsThresholdChecker. [lucene]

2024-10-28 Thread via GitHub
jpountz merged PR #13943: URL: https://github.com/apache/lucene/pull/13943 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Speed up advancing within a block, take 2. [lucene]

2024-10-28 Thread via GitHub
jpountz commented on PR #13958: URL: https://github.com/apache/lucene/pull/13958#issuecomment-2441837295 Here's a `luceneutil`/`wikibigall` run on the latest version of the code on my Linux desktop: ``` TaskQPS baseline StdDevQPS my_modified_versio

Re: [PR] New JMH benchmark method - vdot8s that implement int8 dotProduct in C… [lucene]

2024-10-28 Thread via GitHub
goankur commented on code in PR #13572: URL: https://github.com/apache/lucene/pull/13572#discussion_r1819694503 ## lucene/core/src/java21/org/apache/lucene/internal/vectorization/Lucene99MemorySegmentByteVectorScorer.java: ## @@ -34,6 +37,8 @@ abstract sealed class Lucene99Memor

Re: [PR] New JMH benchmark method - vdot8s that implement int8 dotProduct in C… [lucene]

2024-10-28 Thread via GitHub
goankur commented on code in PR #13572: URL: https://github.com/apache/lucene/pull/13572#discussion_r1819694503 ## lucene/core/src/java21/org/apache/lucene/internal/vectorization/Lucene99MemorySegmentByteVectorScorer.java: ## @@ -34,6 +37,8 @@ abstract sealed class Lucene99Memor

Re: [PR] New JMH benchmark method - vdot8s that implement int8 dotProduct in C… [lucene]

2024-10-28 Thread via GitHub
goankur commented on code in PR #13572: URL: https://github.com/apache/lucene/pull/13572#discussion_r1819699896 ## lucene/core/src/java21/org/apache/lucene/internal/vectorization/Lucene99MemorySegmentByteVectorScorer.java: ## @@ -103,6 +125,27 @@ public float score(int node) thr

Re: [PR] New JMH benchmark method - vdot8s that implement int8 dotProduct in C… [lucene]

2024-10-28 Thread via GitHub
goankur commented on code in PR #13572: URL: https://github.com/apache/lucene/pull/13572#discussion_r1819696009 ## lucene/core/src/java21/org/apache/lucene/internal/vectorization/Lucene99MemorySegmentScalarQuantizedVectorScorer.java: ## @@ -0,0 +1,407 @@ +/* Review Comment:

Re: [PR] New JMH benchmark method - vdot8s that implement int8 dotProduct in C… [lucene]

2024-10-28 Thread via GitHub
goankur commented on code in PR #13572: URL: https://github.com/apache/lucene/pull/13572#discussion_r1817385236 ## lucene/benchmark-jmh/src/java/org/apache/lucene/benchmark/jmh/VectorUtilBenchmark.java: ## @@ -84,6 +91,76 @@ public void init() { floatsA[i] = random.nextFl