Re: [PR] Use growNoCopy when copying bytes in BytesRefBuilder [lucene]

2024-10-20 Thread via GitHub
iverase merged PR #13930: URL: https://github.com/apache/lucene/pull/13930 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Speedup PriorityQueue a little [lucene]

2024-10-20 Thread via GitHub
dweiss commented on code in PR #13936: URL: https://github.com/apache/lucene/pull/13936#discussion_r1808146179 ## lucene/core/src/java/org/apache/lucene/util/PriorityQueue.java: ## @@ -270,7 +280,7 @@ public final boolean remove(T element) { return false; } - private

Re: [PR] Speedup OrderIntervalsSource some more [lucene]

2024-10-20 Thread via GitHub
jpountz commented on code in PR #13937: URL: https://github.com/apache/lucene/pull/13937#discussion_r1808166752 ## lucene/queries/src/java/org/apache/lucene/queries/intervals/OrderedIntervalsSource.java: ## @@ -161,8 +163,8 @@ public int nextInterval() throws IOException {

Re: [PR] Speedup PriorityQueue a little [lucene]

2024-10-20 Thread via GitHub
original-brownbear commented on code in PR #13936: URL: https://github.com/apache/lucene/pull/13936#discussion_r1807955670 ## lucene/core/src/java/org/apache/lucene/util/PriorityQueue.java: ## @@ -270,7 +280,7 @@ public final boolean remove(T element) { return false; }

Re: [PR] Speedup PriorityQueue a little [lucene]

2024-10-20 Thread via GitHub
original-brownbear commented on code in PR #13936: URL: https://github.com/apache/lucene/pull/13936#discussion_r1807873638 ## lucene/core/src/java/org/apache/lucene/util/PriorityQueue.java: ## @@ -270,7 +280,7 @@ public final boolean remove(T element) { return false; }

Re: [PR] Speedup PriorityQueue a little [lucene]

2024-10-20 Thread via GitHub
original-brownbear commented on code in PR #13936: URL: https://github.com/apache/lucene/pull/13936#discussion_r1807876659 ## lucene/core/src/java/org/apache/lucene/util/PriorityQueue.java: ## @@ -270,7 +280,7 @@ public final boolean remove(T element) { return false; }

Re: [PR] Speedup PriorityQueue a little [lucene]

2024-10-20 Thread via GitHub
original-brownbear commented on code in PR #13936: URL: https://github.com/apache/lucene/pull/13936#discussion_r1807876827 ## lucene/core/src/java/org/apache/lucene/util/PriorityQueue.java: ## @@ -117,26 +117,29 @@ public PriorityQueue(int maxSize, Supplier sentinelObjectSuppli

Re: [PR] Speedup PriorityQueue a little [lucene]

2024-10-20 Thread via GitHub
rmuir commented on PR #13936: URL: https://github.com/apache/lucene/pull/13936#issuecomment-2424867914 This results in a lot more code complexity, which makes maintenance difficult. Maybe the version of java you are testing with has a bug in its register allocator or something? seri

Re: [PR] Speedup PriorityQueue a little [lucene]

2024-10-20 Thread via GitHub
original-brownbear commented on PR #13936: URL: https://github.com/apache/lucene/pull/13936#issuecomment-2425018683 I think the queue methods changed here in isolation get a far bigger improvement than 1% in many cases. Plus making methods like the ones adjusted here smaller and easier on

Re: [PR] Speedup PriorityQueue a little [lucene]

2024-10-20 Thread via GitHub
dweiss commented on code in PR #13936: URL: https://github.com/apache/lucene/pull/13936#discussion_r1807927256 ## lucene/core/src/java/org/apache/lucene/util/PriorityQueue.java: ## @@ -270,7 +280,7 @@ public final boolean remove(T element) { return false; } - private

Re: [PR] Speedup PriorityQueue a little [lucene]

2024-10-20 Thread via GitHub
dweiss commented on code in PR #13936: URL: https://github.com/apache/lucene/pull/13936#discussion_r1807867567 ## lucene/core/src/java/org/apache/lucene/util/PriorityQueue.java: ## @@ -270,7 +280,7 @@ public final boolean remove(T element) { return false; } - private