Re: [PR] Have value and count in LabelAndValue only for TaxonomyFacets [lucene]

2024-09-23 Thread via GitHub
stefanvodita commented on PR #13740: URL: https://github.com/apache/lucene/pull/13740#issuecomment-2367820490 > Given the timing of 9.12/10.0, I'm not sure we should rush this in? Can we aim for 10.1.0? Are these @lucene.experimental APIs so we are free to break in the 10.x series? `

Re: [PR] Use Arrays.compareUnsigned in IDVersionSegmentTermsEnum and OrdsSegmentTermsEnum. [lucene]

2024-09-23 Thread via GitHub
vsop-479 commented on PR #13782: URL: https://github.com/apache/lucene/pull/13782#issuecomment-2367959929 > I replaced loop compare suffixe with Arrays#compareUnsigned in IDVersionSegmentTermsEnumFrame and OrdsSegmentTermsEnumFrame. @jpountz It seems you implemented the same thing in

Re: [PR] Fix lucene SDK issues [lucene]

2024-09-23 Thread via GitHub
Noah-ney closed pull request #13817: Fix lucene SDK issues URL: https://github.com/apache/lucene/pull/13817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[I] TestTieredMergePolicy.testSimulateAppendOnly fails with AssertionError [lucene]

2024-09-23 Thread via GitHub
ChrisHegarty opened a new issue, #13818: URL: https://github.com/apache/lucene/issues/13818 This failure has been reproduced on both the `main` and `branch_9_12` branches. Does not fail on `branch_9_11`. ``` ERROR: The following test(s) have failed: - org.apache.lucene.index.T

Re: [I] Backout changes messing around with fieldinfos on merge [lucene]

2024-09-23 Thread via GitHub
ChrisHegarty closed issue #13809: Backout changes messing around with fieldinfos on merge URL: https://github.com/apache/lucene/issues/13809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [I] TestTieredMergePolicy.testSimulateAppendOnly fails with AssertionError [lucene]

2024-09-23 Thread via GitHub
ChrisHegarty commented on issue #13818: URL: https://github.com/apache/lucene/issues/13818#issuecomment-2369304051 ``` 3ee37695af18246a4e05f8a6c7ee1ab7a2f8118f is the first bad commit commit 3ee37695af18246a4e05f8a6c7ee1ab7a2f8118f Author: Carlos Delgado <6339205+carlosdel...@users.n

Re: [I] TestTieredMergePolicy.testSimulateAppendOnly fails with AssertionError [lucene]

2024-09-23 Thread via GitHub
ChrisHegarty commented on issue #13818: URL: https://github.com/apache/lucene/issues/13818#issuecomment-2369348982 `numSegments=43 allowed=41.` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] Allow MultiLeafKnnCollector.greediness to be configurable [lucene]

2024-09-23 Thread via GitHub
dungba88 commented on issue #13699: URL: https://github.com/apache/lucene/issues/13699#issuecomment-2370059452 > FWIW I'd be less concerned about exposing a higher-level configuration option on the query, such as a "desired recall" or something along these lines and then make decisions for