javanna commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1749750973
##
lucene/core/src/java/org/apache/lucene/search/BulkScorer.java:
##
@@ -27,18 +27,6 @@
*/
public abstract class BulkScorer {
- /**
- * Scores and collects all
javanna commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1749979372
##
lucene/core/src/test/org/apache/lucene/index/TestForTooMuchCloning.java:
##
@@ -80,7 +80,7 @@ public void test() throws Exception {
// System.out.println("quer
rmuir merged PR #13739:
URL: https://github.com/apache/lucene/pull/13739
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
Mikep86 commented on code in PR #13697:
URL: https://github.com/apache/lucene/pull/13697#discussion_r1750179324
##
lucene/join/src/test/org/apache/lucene/search/join/TestBlockJoinBulkScorer.java:
##
@@ -0,0 +1,454 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
mikemccand commented on PR #13723:
URL: https://github.com/apache/lucene/pull/13723#issuecomment-2338279298
> Should we add the "double" variant, too?
+1, maybe as follow-on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
javanna commented on code in PR #13735:
URL: https://github.com/apache/lucene/pull/13735#discussion_r1750433222
##
lucene/core/src/java/org/apache/lucene/search/CollectorManager.java:
##
@@ -46,4 +48,28 @@ public interface CollectorManager {
* called after collection is fini
romseygeek commented on code in PR #13735:
URL: https://github.com/apache/lucene/pull/13735#discussion_r1750455113
##
lucene/monitor/src/java/org/apache/lucene/monitor/CollectingMatcher.java:
##
@@ -37,7 +38,7 @@ abstract class CollectingMatcher
extends CandidateMatcher<
@Ov
mikemccand commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1750413448
##
lucene/MIGRATE.md:
##
@@ -802,5 +802,35 @@ both `TopDocs` as well as facets results included in a
reduced `FacetsCollector`
### `SearchWithCollectorTask` no
javanna commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1750500023
##
lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java:
##
@@ -363,7 +374,88 @@ public static LeafSlice[] slices(
LeafSlice[] slices = new LeafSlice[
javanna commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1750502348
##
lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java:
##
@@ -363,7 +374,88 @@ public static LeafSlice[] slices(
LeafSlice[] slices = new LeafSlice[
shubhamvishu commented on PR #13742:
URL: https://github.com/apache/lucene/pull/13742#issuecomment-2338468843
@jpountz Added a CHANGES entry now. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
romseygeek commented on code in PR #13735:
URL: https://github.com/apache/lucene/pull/13735#discussion_r1750548459
##
lucene/monitor/src/java/org/apache/lucene/monitor/CollectingMatcher.java:
##
@@ -37,7 +38,7 @@ abstract class CollectingMatcher
extends CandidateMatcher<
@Ov
jpountz commented on code in PR #13697:
URL: https://github.com/apache/lucene/pull/13697#discussion_r1750571840
##
lucene/join/src/test/org/apache/lucene/search/join/TestBlockJoinBulkScorer.java:
##
@@ -0,0 +1,454 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
javanna commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1750711025
##
lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java:
##
@@ -363,7 +374,88 @@ public static LeafSlice[] slices(
LeafSlice[] slices = new LeafSlice[
javanna commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1750743766
##
lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java:
##
@@ -363,7 +374,88 @@ public static LeafSlice[] slices(
LeafSlice[] slices = new LeafSlice[
ChrisHegarty merged PR #13732:
URL: https://github.com/apache/lucene/pull/13732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucen
gsmiller commented on code in PR #13735:
URL: https://github.com/apache/lucene/pull/13735#discussion_r1750877300
##
lucene/core/src/java/org/apache/lucene/search/CollectorManager.java:
##
@@ -46,4 +48,28 @@ public interface CollectorManager {
* called after collection is fin
gsmiller commented on code in PR #13735:
URL: https://github.com/apache/lucene/pull/13735#discussion_r1750884436
##
lucene/core/src/java/org/apache/lucene/search/CollectorManager.java:
##
@@ -46,4 +48,28 @@ public interface CollectorManager {
* called after collection is fin
gsmiller commented on code in PR #13697:
URL: https://github.com/apache/lucene/pull/13697#discussion_r1750898154
##
lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinQuery.java:
##
@@ -348,34 +410,23 @@ public void setMinCompetitiveScore(float minScore) throws
msfroh commented on code in PR #13735:
URL: https://github.com/apache/lucene/pull/13735#discussion_r1750940757
##
lucene/core/src/java/org/apache/lucene/search/CollectorManager.java:
##
@@ -46,4 +48,28 @@ public interface CollectorManager {
* called after collection is finis
msfroh opened a new pull request, #13747:
URL: https://github.com/apache/lucene/pull/13747
### Description
Relates to https://github.com/apache/lucene/issues/12892
For global ordinal-based join, we can support concurrent search. For numeric
and term-based joins, we fail if we're ca
github-actions[bot] commented on PR #13657:
URL: https://github.com/apache/lucene/pull/13657#issuecomment-2339375272
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
msfroh commented on code in PR #13748:
URL: https://github.com/apache/lucene/pull/13748#discussion_r1751112687
##
lucene/test-framework/src/java/org/apache/lucene/tests/search/QueryUtils.java:
##
@@ -345,175 +348,199 @@ public static void checkSkipTo(final Query q, final
IndexS
msfroh commented on PR #13748:
URL: https://github.com/apache/lucene/pull/13748#issuecomment-2339574918
I had another thought while walking home. Both of the anonymous
CollectorManagers are the same (but produce slightly different collectors).
What if you split it out into an inner class th
24 matches
Mail list logo
