[PR] Optimize binary search call [lucene]

2024-07-21 Thread via GitHub
dungba88 opened a new pull request, #13595: URL: https://github.com/apache/lucene/pull/13595 ### Description I think `advance` is usually not called in backward, so we can run the binary search from the current position +1 instead of 0. Also cap the fromIndex to scoreDocs.length to a

[PR] [WIP] Add reopen method in PerThreadPKLookup [lucene]

2024-07-21 Thread via GitHub
vsop-479 opened a new pull request, #13596: URL: https://github.com/apache/lucene/pull/13596 ### Description Try to reuse old segments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] Significant drop in recall for 8 bit Scalar Quantizer [lucene]

2024-07-21 Thread via GitHub
naveentatikonda commented on issue #13519: URL: https://github.com/apache/lucene/issues/13519#issuecomment-2241850768 > @naveentatikonda could you test my branch as well? I want to make sure my numbers were not flukes on my end. > @benwtrent Apologies for my late response. I wasn'

Re: [I] Examine performance of individual data accessor methods of MemorySegmentIndexInput when IndexInputs are closed in other threads (deoptimizations,...) [lucene]

2024-07-21 Thread via GitHub
dsmiley commented on issue #13325: URL: https://github.com/apache/lucene/issues/13325#issuecomment-2241852198 I set a breakpoint in a debugger on IndexInput.close while running a Solr test and it's called in **lots** of places separately from closing an IndexReader. Lucene FieldsIndexWrite

Re: [I] Examine performance of individual data accessor methods of MemorySegmentIndexInput when IndexInputs are closed in other threads (deoptimizations,...) [lucene]

2024-07-21 Thread via GitHub
uschindler commented on issue #13325: URL: https://github.com/apache/lucene/issues/13325#issuecomment-2242174153 All ChecksumIndexInput are automatically opened using READONCE in main branch as those cannot get consumed by multiple threads. In the backport it's manually done; if we missed o